)]}'
{"manifests/osds.pp":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"b28dae995f009f22dae4a2f875aa59f077cc07c3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*defaults*] A config hash"},{"line_number":28,"context_line":"#   Optional. Defaults to a empty hash"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*manage_pid_max*] Whether or not to manage the sysctl setting"},{"line_number":31,"context_line":"#   for kernel.pid_max. Optional. Defaults to false, however"},{"line_number":32,"context_line":"#   for OSD nodes it is recommend that you raise pid_max above the"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a8bc5a2_87e365d8","line":29,"updated":"2016-09-26 22:14:29.000000000","message":"Should this parameter not go in ceph::osd rather than ceph::osds which is a wrapper class around ceph::osd ?","commit_id":"03559d942c332fe2d0ae6a66ea59b2891570b168"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"b28dae995f009f22dae4a2f875aa59f077cc07c3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*manage_pid_max*] Whether or not to manage the sysctl setting"},{"line_number":31,"context_line":"#   for kernel.pid_max. Optional. Defaults to false, however"},{"line_number":32,"context_line":"#   for OSD nodes it is recommend that you raise pid_max above the"},{"line_number":33,"context_line":"#   default value because you may hit the system max during"},{"line_number":34,"context_line":"#   recovery."},{"line_number":35,"context_line":"#   See: http://docs.ceph.com/docs/jewel/rados/troubleshooting/troubleshooting-osd/"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a8bc5a2_07a2f598","line":32,"range":{"start_line":32,"start_character":24,"end_line":32,"end_character":33},"updated":"2016-09-26 22:14:29.000000000","message":"nit: recommended","commit_id":"03559d942c332fe2d0ae6a66ea59b2891570b168"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"cafe9bace5075a69b7ac95535bc216a48604e97d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"class ceph::osds("},{"line_number":41,"context_line":"  $args \u003d {},"},{"line_number":42,"context_line":"  $defaults \u003d {},"},{"line_number":43,"context_line":"  $manage_pid_max \u003d false,"},{"line_number":44,"context_line":"  $pid_max \u003d 4194303,"},{"line_number":45,"context_line":")"},{"line_number":46,"context_line":"{"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5a8bc5a2_5d720e12","line":43,"range":{"start_line":43,"start_character":3,"end_line":43,"end_character":25},"updated":"2016-09-26 23:34:04.000000000","message":"do we need to check for false? we could have pid_max default to false/undef and set the value when it\u0027s an integer","commit_id":"215a87db281130d840a6a5fa1df30cf9cb6bf3d0"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"c1e27583313dce8c9d2bd71b0c6e877cee5317cb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class ceph::osds("},{"line_number":37,"context_line":"  $args \u003d {},"},{"line_number":38,"context_line":"  $defaults \u003d {},"},{"line_number":39,"context_line":"  $pid_max \u003d undef,"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":"{"},{"line_number":42,"context_line":"  create_resources(ceph::osd, $args, $defaults)"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5a8bc5a2_5f73a6e7","line":39,"range":{"start_line":39,"start_character":13,"end_line":39,"end_character":18},"updated":"2016-09-27 21:46:08.000000000","message":"please add the parameter to and get the default of \u0027undef\u0027 from ceph::profile:parms","commit_id":"a4188b8896d637ea7c25401209f0f99a16d35da7"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"c1e27583313dce8c9d2bd71b0c6e877cee5317cb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"{"},{"line_number":42,"context_line":"  create_resources(ceph::osd, $args, $defaults)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  if $pid_max !\u003d undef {"},{"line_number":45,"context_line":"    $sysctl_settings \u003d {"},{"line_number":46,"context_line":"      \u0027kernel.pid_max\u0027 \u003d\u003e { value \u003d\u003e $pid_max },"},{"line_number":47,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5a8bc5a2_ff9d520b","line":44,"range":{"start_line":44,"start_character":17,"end_line":44,"end_character":22},"updated":"2016-09-27 21:46:08.000000000","message":"nit: we don\u0027t have to !\u003d undef, its implicitly false (if $pid_max {...) is fine.","commit_id":"a4188b8896d637ea7c25401209f0f99a16d35da7"}],"metadata.json":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"be83c6b48d95a30eb90c22bc76ff523deab8a0ee","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  ],"},{"line_number":48,"context_line":"  \"description\": \"Installs and configures Ceph.\","},{"line_number":49,"context_line":"  \"dependencies\": ["},{"line_number":50,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":51,"context_line":"    {"},{"line_number":52,"context_line":"      \"name\": \"puppetlabs/apt\","},{"line_number":53,"context_line":"      \"version_requirement\": \"\u003e\u003d2.0.0 \u003c3.0.0\""}],"source_content_type":"application/json","patch_set":5,"id":"5a8bc5a2_67b9f9cb","line":50,"updated":"2016-09-26 22:14:47.000000000","message":"rebase artifact","commit_id":"03559d942c332fe2d0ae6a66ea59b2891570b168"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"be83c6b48d95a30eb90c22bc76ff523deab8a0ee","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    },"},{"line_number":71,"context_line":"    {"},{"line_number":72,"context_line":"      \"name\": \"duritong/sysctl\","},{"line_number":73,"context_line":"      \"version_requirement\": \"\u003e\u003d0.0.1 \u003c1.0.0\" "},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"  ]"},{"line_number":76,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"5a8bc5a2_07c91559","line":73,"updated":"2016-09-26 22:14:47.000000000","message":"whitespace","commit_id":"03559d942c332fe2d0ae6a66ea59b2891570b168"}]}