)]}'
{"manifests/mds.pp":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"eb19045936374cb0fe2d2a0915352d46b4fb3d0b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  $keyring      \u003d \u0027/var/lib/ceph/mds/$cluster-$id/keyring\u0027,"},{"line_number":36,"context_line":") {"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  ensure_packages($::ceph::params::pkg_mds, {\u0027tag\u0027 \u003d\u003e \u0027ceph\u0027})"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  # [mds]"},{"line_number":41,"context_line":"  if $mds_activate {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a98d1f4_c0be1064","line":38,"range":{"start_line":38,"start_character":2,"end_line":38,"end_character":42},"updated":"2016-10-04 05:34:53.000000000","message":"This change and similar seems to have produced the following error in unit tests:\n\nNo title provided and \"package[]\" is not a valid resource reference\n\nOR \n\nDuplicate declaration: Package[] is already declared; cannot redeclare ..\n\nI would expect the duplicate declaration error to state Package[\u0027ceph-mds\u0027] if it were really a duplicate so perhaps an eval is occurring in cases where $::ceph::params::pkg_mds is undef. To rule this out I wrapped the above in an \"if $::ceph::params::pkg_mds {\" and similar in patch set 8.","commit_id":"f74561656bf890f8c12f1da82a677a1930928a7a"}],"manifests/params.pp":[{"author":{"_account_id":16211,"name":"Ken Dreyer (Red Hat)","email":"kdreyer@redhat.com","username":"kdreyer"},"change_message_id":"1efb45de46909328a696f8ce1240d715043af355","unresolved":false,"context_lines":[{"line_number":49,"context_line":") {"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  case $::osfamily {"},{"line_number":52,"context_line":"    \u0027Debian\u0027: {"},{"line_number":53,"context_line":"      $pkg_base            \u003d \u0027ceph\u0027"},{"line_number":54,"context_line":"      $pkg_mon             \u003d \u0027ceph\u0027"},{"line_number":55,"context_line":"      $pkg_osd             \u003d \u0027ceph\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a98d1f4_a23d9dc5","line":52,"updated":"2016-10-03 17:00:34.000000000","message":"Debian package names are the same for these servers, so it\u0027s:\n\n$pkg_base            \u003d \u0027ceph-base\u0027\n$pkg_mon             \u003d \u0027ceph-mon\u0027\n$pkg_osd             \u003d \u0027ceph-osd\u0027\n$pkg_mds             \u003d \u0027ceph-mds\u0027","commit_id":"f74f825f1bc78cb7c918f1b9ce6d0f611d08dd87"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"193e6e12980c6dbd727cd86b958c11d65bc1f967","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  case $::osfamily {"},{"line_number":52,"context_line":"    \u0027Debian\u0027: {"},{"line_number":53,"context_line":"      $pkg_base            \u003d \u0027ceph-base\u0027"},{"line_number":54,"context_line":"      $pkg_mon             \u003d \u0027ceph-mon\u0027"},{"line_number":55,"context_line":"      $pkg_osd             \u003d \u0027ceph-osd\u0027"},{"line_number":56,"context_line":"      $pkg_mds             \u003d \u0027ceph-mds\u0027"},{"line_number":57,"context_line":"      $pkg_radosgw         \u003d \u0027radosgw\u0027"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_da58b48c","line":54,"range":{"start_line":54,"start_character":30,"end_line":54,"end_character":38},"updated":"2016-10-04 09:55:06.000000000","message":"i cannot find this ceph-mon package, does it exist? I am not sure we should initialize these values with in-existent ones, because it cause failures, maybe better to use undef?","commit_id":"f114a7d660f93048a2cb09e72691aa496a2aeae2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"718a697d90b4f366612c65d7304dcadb80ea5bc0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  case $::osfamily {"},{"line_number":52,"context_line":"    \u0027Debian\u0027: {"},{"line_number":53,"context_line":"      $pkg_base            \u003d \u0027ceph-base\u0027"},{"line_number":54,"context_line":"      $pkg_mon             \u003d \u0027ceph-mon\u0027"},{"line_number":55,"context_line":"      $pkg_osd             \u003d \u0027ceph-osd\u0027"},{"line_number":56,"context_line":"      $pkg_mds             \u003d \u0027ceph-mds\u0027"},{"line_number":57,"context_line":"      $pkg_radosgw         \u003d \u0027radosgw\u0027"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_b52bf980","line":54,"range":{"start_line":54,"start_character":30,"end_line":54,"end_character":38},"in_reply_to":"3a98d1f4_da58b48c","updated":"2016-10-04 09:59:21.000000000","message":"it\u0027s in the ceph repos https://download.ceph.com/debian-jewel/pool/main/c/ceph/","commit_id":"f114a7d660f93048a2cb09e72691aa496a2aeae2"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"b6b95382d493914d130450e7fe1c4aef238136d0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  case $::osfamily {"},{"line_number":52,"context_line":"    \u0027Debian\u0027: {"},{"line_number":53,"context_line":"      $pkg_base            \u003d \u0027ceph-base\u0027"},{"line_number":54,"context_line":"      $pkg_mon             \u003d \u0027ceph-mon\u0027"},{"line_number":55,"context_line":"      $pkg_osd             \u003d \u0027ceph-osd\u0027"},{"line_number":56,"context_line":"      $pkg_mds             \u003d \u0027ceph-mds\u0027"},{"line_number":57,"context_line":"      $pkg_radosgw         \u003d \u0027radosgw\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a98d1f4_90a36bb1","line":54,"range":{"start_line":54,"start_character":30,"end_line":54,"end_character":38},"updated":"2016-10-04 10:33:21.000000000","message":"Nikita\u0027s K. comment to the previous patch is perfectly valid. And as Maksym Y. mentioned in comment to this patch it is not in Debian repository.\nPlease do not do that. Even package (0.94.5-1.1) in Experimental repository doesn\u0027t contain it: https://packages.debian.org/source/experimental/ceph\nPlease add it once it available. We should follow Debian upstream rules. If you do not agree, please file a bug: https://www.debian.org/Bugs/Reporting","commit_id":"8269fa5a75eddc2710e42733d62985455c88eea9"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"f2b1f43cabaab35344b8e72a412ce907d95f26cb","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  case $::osfamily {"},{"line_number":52,"context_line":"    \u0027Debian\u0027: {"},{"line_number":53,"context_line":"      $pkg_base            \u003d \u0027ceph-base\u0027"},{"line_number":54,"context_line":"      $pkg_mon             \u003d \u0027ceph-mon\u0027"},{"line_number":55,"context_line":"      $pkg_osd             \u003d \u0027ceph-osd\u0027"},{"line_number":56,"context_line":"      $pkg_mds             \u003d \u0027ceph-mds\u0027"},{"line_number":57,"context_line":"      $pkg_radosgw         \u003d \u0027radosgw\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a98d1f4_f05bcf83","line":54,"range":{"start_line":54,"start_character":30,"end_line":54,"end_character":38},"in_reply_to":"3a98d1f4_90a36bb1","updated":"2016-10-04 10:39:14.000000000","message":"the comment is valid, though this was broken for those using ceph.com repos though; the ceph.com repos eventually added by ceph::repos do *not* provide any \u0027ceph\u0027 package\n\nlooks like best thing to do would be to make those values user-customizable and default to \u0027ceph\u0027 in Debian to stay compatible with the current behaviour, sounds good?","commit_id":"8269fa5a75eddc2710e42733d62985455c88eea9"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"8fa7eddfccb8aff73ae7750b60044d791492ef30","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  case $::osfamily {"},{"line_number":52,"context_line":"    \u0027Debian\u0027: {"},{"line_number":53,"context_line":"      $pkg_base            \u003d \u0027ceph-base\u0027"},{"line_number":54,"context_line":"      $pkg_mon             \u003d \u0027ceph-mon\u0027"},{"line_number":55,"context_line":"      $pkg_osd             \u003d \u0027ceph-osd\u0027"},{"line_number":56,"context_line":"      $pkg_mds             \u003d \u0027ceph-mds\u0027"},{"line_number":57,"context_line":"      $pkg_radosgw         \u003d \u0027radosgw\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a98d1f4_cb1e285e","line":54,"range":{"start_line":54,"start_character":30,"end_line":54,"end_character":38},"in_reply_to":"3a98d1f4_f05bcf83","updated":"2016-10-04 10:42:57.000000000","message":"Sounds reasonable, let\u0027s make it so.\nThank you!","commit_id":"8269fa5a75eddc2710e42733d62985455c88eea9"}],"manifests/repo.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8fd2e187a097a53f0680a9b17e2ec69fbe869790","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        }"},{"line_number":128,"context_line":"        yumrepo { \u0027ceph-jewel-sig\u0027:"},{"line_number":129,"context_line":"          enabled    \u003d\u003e \u00271\u0027,"},{"line_number":130,"context_line":"          baseurl    \u003d\u003e \u0027http://mirror.centos.org/centos/7/storage/x86_64/ceph-jewel/\u0027,"},{"line_number":131,"context_line":"          descr      \u003d\u003e \u0027Ceph Jewel SIG\u0027,"},{"line_number":132,"context_line":"          mirrorlist \u003d\u003e \u0027absent\u0027,"},{"line_number":133,"context_line":"          gpgcheck   \u003d\u003e \u00270\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3a98d1f4_0e3d9b8e","line":130,"updated":"2016-10-03 18:13:38.000000000","message":"that is out of context, right?","commit_id":"3c4d269e59c9c58d0f5c33c2a60931d71f0ddce3"}],"manifests/rgw/keystone.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e63272a1536f28a4532027137317d1d0044745ad","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    }"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    Package[$pkg_nsstools]"},{"line_number":175,"context_line":"    -\u003e Package[$::ceph::params::pkg_base]"},{"line_number":176,"context_line":"    -\u003e File[$nss_db_path]"},{"line_number":177,"context_line":"    -\u003e Exec[\"${name}-nssdb-ca\"]"},{"line_number":178,"context_line":"    -\u003e Exec[\"${name}-nssdb-signing\"]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a98d1f4_c8c2cb52","line":175,"updated":"2016-10-03 17:29:20.000000000","message":"we probably want pkg_radosgw here instead?","commit_id":"99fe2642eeac673e3879cca2b4510d17ed682b4e"}]}