)]}'
{"manifests/key.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b59aa8c3866254de854719812b5c9e853e0cf9af","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      group                   \u003d\u003e $group,"},{"line_number":110,"context_line":"      mode                    \u003d\u003e $mode,"},{"line_number":111,"context_line":"      selinux_ignore_defaults \u003d\u003e true,"},{"line_number":112,"context_line":"      require                 \u003d\u003e Class[\u0027ceph\u0027],"},{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":"  }"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a95cdbc_7475c0f7","line":112,"updated":"2016-10-05 12:12:53.000000000","message":"your commit message doesn\u0027t explain this change in this file. Please do commit message more than one line, to explain what happens, etc.","commit_id":"9f2de4dfb688362f7dc81b66473d254190e6f4b9"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c4607619aa3cf02c80a12351d8087bf2dffdbb8f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      group                   \u003d\u003e $group,"},{"line_number":110,"context_line":"      mode                    \u003d\u003e $mode,"},{"line_number":111,"context_line":"      selinux_ignore_defaults \u003d\u003e true,"},{"line_number":112,"context_line":"      require                 \u003d\u003e Class[\u0027ceph\u0027],"},{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":"  }"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a95cdbc_a51714a2","line":112,"in_reply_to":"1a95cdbc_7475c0f7","updated":"2016-10-05 13:02:12.000000000","message":"ack, was described in the bug only","commit_id":"9f2de4dfb688362f7dc81b66473d254190e6f4b9"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"7705c7c63280eec781d6cb8944be2e3bd9ab3cce","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      group                   \u003d\u003e $group,"},{"line_number":110,"context_line":"      mode                    \u003d\u003e $mode,"},{"line_number":111,"context_line":"      selinux_ignore_defaults \u003d\u003e true,"},{"line_number":112,"context_line":"      require                 \u003d\u003e Class[\u0027ceph\u0027],"},{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":"  }"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a95cdbc_884a11ab","line":112,"range":{"start_line":112,"start_character":33,"end_line":112,"end_character":38},"updated":"2016-10-05 22:20:22.000000000","message":"Can you elaborate on why we are switching from what I would expect to be Package[$::ceph::params::packages] to Class[\u0027ceph\u0027] (init)?\n\nIt was in rev 3, but not anymore","commit_id":"f97516ceac7eb6c3e5dee31d92c8f533390fa739"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9bb954a6cd9a26cfd7e68c6a194c889148935069","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      group                   \u003d\u003e $group,"},{"line_number":110,"context_line":"      mode                    \u003d\u003e $mode,"},{"line_number":111,"context_line":"      selinux_ignore_defaults \u003d\u003e true,"},{"line_number":112,"context_line":"      require                 \u003d\u003e Class[\u0027ceph\u0027],"},{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":"  }"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a95cdbc_9d19647c","line":112,"range":{"start_line":112,"start_character":33,"end_line":112,"end_character":38},"in_reply_to":"1a95cdbc_884a11ab","updated":"2016-10-06 08:33:10.000000000","message":"ack, this can probably just be Package[$::ceph::params::packages]","commit_id":"f97516ceac7eb6c3e5dee31d92c8f533390fa739"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9bb954a6cd9a26cfd7e68c6a194c889148935069","unresolved":false,"context_lines":[{"line_number":124,"context_line":"ceph-authtool \\$NEW_KEYRING --name \u0027${name}\u0027 --add-key \u0027${secret}\u0027 ${caps}"},{"line_number":125,"context_line":"diff -N \\$NEW_KEYRING ${keyring_path} | grep \u0027\u003c\u0027"},{"line_number":126,"context_line":"rm \\$NEW_KEYRING\","},{"line_number":127,"context_line":"    require   \u003d\u003e [ Class[\u0027ceph\u0027], File[$keyring_path], ],"},{"line_number":128,"context_line":"    logoutput \u003d\u003e true,"},{"line_number":129,"context_line":"  }"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a95cdbc_bd82a050","line":127,"updated":"2016-10-06 08:33:10.000000000","message":"seems like this could depend on File only","commit_id":"f97516ceac7eb6c3e5dee31d92c8f533390fa739"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9bb954a6cd9a26cfd7e68c6a194c889148935069","unresolved":false,"context_lines":[{"line_number":151,"context_line":"ceph ${cluster_option} ${inject_id_option} ${inject_keyring_option} auth get ${name} -o \\$OLD_KEYRING || true"},{"line_number":152,"context_line":"diff -N \\$OLD_KEYRING ${keyring_path} | grep \u0027\u003e\u0027"},{"line_number":153,"context_line":"rm \\$OLD_KEYRING\","},{"line_number":154,"context_line":"      require   \u003d\u003e [ Class[\u0027ceph\u0027], Exec[\"ceph-key-${name}\"], ],"},{"line_number":155,"context_line":"      logoutput \u003d\u003e true,"},{"line_number":156,"context_line":"    }"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a95cdbc_dd85ac59","line":154,"updated":"2016-10-06 08:33:10.000000000","message":"this depends on ceph being actually configured, so I think Class[\u0027ceph\u0027] is best here","commit_id":"f97516ceac7eb6c3e5dee31d92c8f533390fa739"}],"manifests/params.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b59aa8c3866254de854719812b5c9e853e0cf9af","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# [*exec_timeout*] The default exec resource timeout, in seconds"},{"line_number":26,"context_line":"#   Optional. Defaults to 600"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*packages*] The ceph packages name"},{"line_number":29,"context_line":"#   Optional. Defaults to [\u0027ceph\u0027]"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*rgw_socket_path*] The socket path of the rados gateway"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a95cdbc_741ea0bb","line":28,"updated":"2016-10-05 12:12:53.000000000","message":"names?","commit_id":"9f2de4dfb688362f7dc81b66473d254190e6f4b9"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c4607619aa3cf02c80a12351d8087bf2dffdbb8f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# [*exec_timeout*] The default exec resource timeout, in seconds"},{"line_number":26,"context_line":"#   Optional. Defaults to 600"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*packages*] The ceph packages name"},{"line_number":29,"context_line":"#   Optional. Defaults to [\u0027ceph\u0027]"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*rgw_socket_path*] The socket path of the rados gateway"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a95cdbc_45301002","line":28,"in_reply_to":"1a95cdbc_741ea0bb","updated":"2016-10-05 13:02:12.000000000","message":"yeah we can make this \u0027package names\u0027 as well","commit_id":"9f2de4dfb688362f7dc81b66473d254190e6f4b9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1439f8455a66aa22f93eb983b1f54174e2967fd","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class ceph::params ("},{"line_number":44,"context_line":"  $exec_timeout    \u003d 600,"},{"line_number":45,"context_line":"  $packages        \u003d [\u0027ceph\u0027], # just provide the minimum per default"},{"line_number":46,"context_line":"  $rgw_socket_path \u003d \u0027/tmp/radosgw.sock\u0027,"},{"line_number":47,"context_line":"  $enable_sig      \u003d false,"},{"line_number":48,"context_line":"  $release         \u003d \u0027jewel\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a95cdbc_b382f5fe","line":45,"updated":"2016-10-05 14:43:04.000000000","message":"you don\u0027t expain it in the commit message either.","commit_id":"83bdf028899178d21003fa2d22e6dc91ee8ffcac"}]}