)]}'
{"manifests/mirror.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"df685f5f1590a185c2ebb53687aa501c3d7b1f94","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (C) 2014 Catalyst IT Limited."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"#   you may not use this file except in compliance with the License."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a74a57a_908fc022","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":40},"updated":"2016-11-23 21:11:04.000000000","message":"2016, your affiliation","commit_id":"ccb900f162e73a7b836c8733bcd2e461b4f0637f"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8157cdc19ffd978643e6f7f724830e983f1f213f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# [*rbd_mirror_enable*] Enable the RBD mirror service on boot"},{"line_number":31,"context_line":"#   Optional. Default is true"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"define ceph::mirror ("},{"line_number":34,"context_line":"  $pkg_mirror        \u003d \u0027rbd_mirror\u0027,"},{"line_number":35,"context_line":"  $rbd_mirror_ensure \u003d \u0027running\u0027,"},{"line_number":36,"context_line":"  $rbd_mirror_enable \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"3a71b18c_4f14c7f4","line":33,"updated":"2016-12-01 14:31:02.000000000","message":"is it possible to run more than a single instance of rbd_mirror on a single node?","commit_id":"85afdcaedb3c3565f193ccc030014b8bbd44aa20"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"8e376903625c284b07e9b060788de918c24b7bc3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# [*rbd_mirror_enable*] Enable the RBD mirror service on boot"},{"line_number":31,"context_line":"#   Optional. Default is true"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"define ceph::mirror ("},{"line_number":34,"context_line":"  $pkg_mirror        \u003d \u0027rbd_mirror\u0027,"},{"line_number":35,"context_line":"  $rbd_mirror_ensure \u003d \u0027running\u0027,"},{"line_number":36,"context_line":"  $rbd_mirror_enable \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"3a71b18c_5e8d4930","line":33,"in_reply_to":"3a71b18c_4f14c7f4","updated":"2016-12-01 17:27:22.000000000","message":"At this time: No. Only one RBD mirror process per cluster with two-way replication.","commit_id":"85afdcaedb3c3565f193ccc030014b8bbd44aa20"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"2cfff0e6aa9e7adedc957e12be1c72d4df126543","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#   Optional. Default is true"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"define ceph::mirror ("},{"line_number":34,"context_line":"  $pkg_mirror        \u003d \u0027rbd_mirror\u0027,"},{"line_number":35,"context_line":"  $rbd_mirror_ensure \u003d \u0027running\u0027,"},{"line_number":36,"context_line":"  $rbd_mirror_enable \u003d true,"},{"line_number":37,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"3a71b18c_2b2ad82c","line":34,"range":{"start_line":34,"start_character":24,"end_line":34,"end_character":34},"updated":"2016-12-02 15:35:01.000000000","message":"s/rbd_mirror/rbd-mirror/","commit_id":"5adb1edb5c31707d5a0080bd9328ba7ebf868394"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"4077dc4386039ebe0d09cb15eab3c86953a21067","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    tag    \u003d\u003e \u0027ceph\u0027,"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  $service_name \u003d \"ceph-rbd-mirror@${name}\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  if ( $::operatingsystemrelease \u003d\u003d \u002716.04\u0027 )"},{"line_number":49,"context_line":"    or"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"3a71b18c_7a5654d3","line":46,"updated":"2016-12-02 16:59:21.000000000","message":"What is ${name} here?\n\nTo start a rbd-mirror daemon on systemd we need to do:\n\nsystemctl start ceph-brd-mirror@\u003cceph user\u003e\n\nwhere ceph-user is normally \"admin\" which results in the ceph-rbd-mirror connecting to the cluster with the admin user.\n\nWhich ultimately means that the ceph.client.admin.keyring must be present in /etc/ceph","commit_id":"ed7f4afcb10293c8107c46d4db5f7b90e321813e"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"6efc8bd152570bf6949fdb49a25687dc1f75fc83","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    tag    \u003d\u003e \u0027ceph\u0027,"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  $service_name \u003d \"ceph-rbd-mirror@${name}\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  if ( $::operatingsystemrelease \u003d\u003d \u002716.04\u0027 )"},{"line_number":49,"context_line":"    or"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"3a71b18c_036a5cb3","line":46,"in_reply_to":"3a71b18c_00433243","updated":"2016-12-02 17:30:39.000000000","message":"I\u0027m not 100% sure it terms of permission, I suspect we need a user capable of connecting to the cluster and that has proper permissions on the replicated pools. So in this case the \"openstack\" user is fine. So does ${name} points to the \"openstack\" user somehow?","commit_id":"ed7f4afcb10293c8107c46d4db5f7b90e321813e"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"032dc455866ef813e3cf5ffc080cc454d10e265a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    tag    \u003d\u003e \u0027ceph\u0027,"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  $service_name \u003d \"ceph-rbd-mirror@${name}\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  if ( $::operatingsystemrelease \u003d\u003d \u002716.04\u0027 )"},{"line_number":49,"context_line":"    or"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"3a71b18c_23791830","line":46,"in_reply_to":"3a71b18c_036a5cb3","updated":"2016-12-02 17:39:32.000000000","message":"my local test script does a ::ceph::mirror{ \u0027openstack\u0027: }. When tripleo consumes this i assume mirror_ensure and mirro_enable will be false. Pacemaker will be configured to ensure one mirror process is running per ceph cluster. that will be a separate set of patches.","commit_id":"ed7f4afcb10293c8107c46d4db5f7b90e321813e"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"4daab953fce87332534a0d6e388f3f167a6a6f8c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    tag    \u003d\u003e \u0027ceph\u0027,"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  $service_name \u003d \"ceph-rbd-mirror@${name}\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  if ( $::operatingsystemrelease \u003d\u003d \u002716.04\u0027 )"},{"line_number":49,"context_line":"    or"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"3a71b18c_00433243","line":46,"in_reply_to":"3a71b18c_7a5654d3","updated":"2016-12-02 17:13:53.000000000","message":"in my local testing I  used \"systemctl start ceph-brd-mirror@openstack\" to start the mirror process. \n\nThe openstack client would have sufficient rights to mirror the needed data and pools. \nWouldn\u0027t the admin user have too many rights?","commit_id":"ed7f4afcb10293c8107c46d4db5f7b90e321813e"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8ef2a34a877070247c398c7221d59fd889988631","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  if ( $::operatingsystemrelease \u003d\u003d \u002716.04\u0027 )"},{"line_number":49,"context_line":"    or"},{"line_number":50,"context_line":"    ( $::operatingsystemmajrelease \u003d\u003d \u00277\u0027 and ( $::operatingsystem \u003d\u003d \u0027RedHat\u0027 or $::operatingsystem \u003d\u003d \u0027CentOS\u0027) )"},{"line_number":51,"context_line":"  {"},{"line_number":52,"context_line":"    Service{"},{"line_number":53,"context_line":"      name   \u003d\u003e $service_name,"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"3a71b18c_f96dfa98","line":50,"updated":"2016-12-03 21:29:03.000000000","message":"I think this might not catch fedore but more in general sounds like we can default to systemd as we are not meant to support old versions of ubuntu with this version of the module\n\nAlso see https://review.openstack.org/#/c/402385/7/manifests/mds.pp","commit_id":"ed7f4afcb10293c8107c46d4db5f7b90e321813e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"354a4f7ec0fd5fd8b52f61fbbc655b2e481e52ea","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":"  else {"},{"line_number":59,"context_line":"    fail(\"Unsupported operating system. Ubuntu 16.04 and RedHat/CentOS 7 are supported\")"},{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  service { $service_name:"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"3a71b18c_b158d58b","line":59,"updated":"2016-12-05 15:06:45.000000000","message":"use single quotes for lint","commit_id":"adb79d26bfcb73534c249f7bbf538654de5f45b4"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4d14b9ab37c192e95863b7047796e121ed0f7a3c","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  service { $service_name:"},{"line_number":63,"context_line":"    ensure \u003d\u003e $rbd_mirror_ensure,"},{"line_number":64,"context_line":"    tag    \u003d\u003e [\u0027ceph-rbd-mirror\u0027]"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  Ceph_config\u003c||\u003e ~\u003e Service\u003c| tag \u003d\u003d \u0027ceph-rbd-mirror\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"3a71b18c_b0f616f7","line":64,"updated":"2016-12-05 15:10:19.000000000","message":"I think we need to pass \"enable\" here too","commit_id":"adb79d26bfcb73534c249f7bbf538654de5f45b4"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"59b61d0b38af21512a7326c946d60b6637f8d35e","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  service { $service_name:"},{"line_number":63,"context_line":"    ensure \u003d\u003e $rbd_mirror_ensure,"},{"line_number":64,"context_line":"    tag    \u003d\u003e [\u0027ceph-rbd-mirror\u0027]"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  Ceph_config\u003c||\u003e ~\u003e Service\u003c| tag \u003d\u003d \u0027ceph-rbd-mirror\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"3a71b18c_b110d55a","line":64,"in_reply_to":"3a71b18c_b0f616f7","updated":"2016-12-05 15:13:09.000000000","message":"Isn\u0027t that provided by line 53? \nWith the current supported OSs, should 53 and 62 be combined?","commit_id":"adb79d26bfcb73534c249f7bbf538654de5f45b4"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"3fd67d6577e94b0af7744aae4b1fbb9ed7c86e48","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  service { $service_name:"},{"line_number":63,"context_line":"    ensure \u003d\u003e $rbd_mirror_ensure,"},{"line_number":64,"context_line":"    tag    \u003d\u003e [\u0027ceph-rbd-mirror\u0027]"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  Ceph_config\u003c||\u003e ~\u003e Service\u003c| tag \u003d\u003d \u0027ceph-rbd-mirror\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"3a71b18c_ecb27693","line":64,"in_reply_to":"3a71b18c_b110d55a","updated":"2016-12-05 15:28:13.000000000","message":"yep sorry","commit_id":"adb79d26bfcb73534c249f7bbf538654de5f45b4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"103d8625286b2771daae1230d3647f5bdc6b35e9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# [*rbd_mirror_enable*] Enable the RBD mirror service on boot"},{"line_number":31,"context_line":"#   Optional. Default is true"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"define ceph::mirror ("},{"line_number":34,"context_line":"  $pkg_mirror        \u003d \u0027rbd-mirror\u0027,"},{"line_number":35,"context_line":"  $rbd_mirror_ensure \u003d \u0027running\u0027,"},{"line_number":36,"context_line":"  $rbd_mirror_enable \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"3a71b18c_0881228f","line":33,"updated":"2016-12-06 17:19:25.000000000","message":"shouldn\u0027t this be a class rather than a resource? It\u0027ll fail because of duplicate package declaration","commit_id":"e61ab9a125835c6b3a08b628bc6fb0e6dd3c017a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a96b8cd57244a1a632b374a00073b0625c4dd057","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  include ::stdlib"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  ensure_packages( $pkg_mirror,"},{"line_number":42,"context_line":"    {"},{"line_number":43,"context_line":"      ensure \u003d\u003e present,"},{"line_number":44,"context_line":"      tag    \u003d\u003e [ \u0027ceph\u0027 ],"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"3a71b18c_7f84a3b0","line":41,"updated":"2016-12-08 15:30:30.000000000","message":"Should use ensure_resource(\u0027package\u0027, ...) as we\u0027ve seen issues with ensure_packages and being able to handle when people switch to ensure \u003d\u003e \u0027latest\u0027 with the spaceship operator","commit_id":"716bb89157527523f5e623e5673e3222dcecca31"}],"manifests/profile/mirror.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8dac6d16b62e5fa9fd9524b76351f425277a2f68","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class ceph::profile::mirror {"},{"line_number":23,"context_line":"  require ::ceph::profile::base"},{"line_number":24,"context_line":"  $rbd_name \u003d $::ceph::profile::params::rbd_mirror_client_name ? {"},{"line_number":25,"context_line":"    undef   \u003d\u003e \u0027openstack\u0027,"},{"line_number":26,"context_line":"    default \u003d\u003e $::ceph::profile::params::rbd_mirror_client_name,"},{"line_number":27,"context_line":"  }"},{"line_number":28,"context_line":"  ceph::mirror { $rbd_name:"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a71b18c_5a4fd8bd","line":25,"updated":"2016-12-09 07:15:01.000000000","message":"why do you try to install a packaged called openstack?","commit_id":"f95aa995f6e7b7ee2ad2f2124004cfedbc9ca61f"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"d8d38f977331b61d484ff3d4c80e5ad021288337","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class ceph::profile::mirror {"},{"line_number":23,"context_line":"  require ::ceph::profile::base"},{"line_number":24,"context_line":"  $rbd_name \u003d $::ceph::profile::params::rbd_mirror_client_name ? {"},{"line_number":25,"context_line":"    undef   \u003d\u003e \u0027openstack\u0027,"},{"line_number":26,"context_line":"    default \u003d\u003e $::ceph::profile::params::rbd_mirror_client_name,"},{"line_number":27,"context_line":"  }"},{"line_number":28,"context_line":"  ceph::mirror { $rbd_name:"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a71b18c_72bd8ad6","line":25,"in_reply_to":"3a71b18c_55fde238","updated":"2016-12-09 13:48:03.000000000","message":"This is the name of the cephx client used to authenticate to the Ceph cluster and has rights to sync data. In the tripleo OSP case, this name is openstack. The name is used at (1) to create and manage the service. \n\nThis client name convention is used elsewhere in puppet-ceph (mon and rgw). \n\n1: https://review.openstack.org/gitweb?p\u003dopenstack/puppet-ceph.git;a\u003dblob;f\u003dmanifests/mirror.pp;h\u003d084a367187f88927844f64a48318f822e7d0427e;hb\u003df95aa995f6e7b7ee2ad2f2124004cfedbc9ca61f#l49","commit_id":"f95aa995f6e7b7ee2ad2f2124004cfedbc9ca61f"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c704be5f170279e0c3b42af8501dfed91602a723","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class ceph::profile::mirror {"},{"line_number":23,"context_line":"  require ::ceph::profile::base"},{"line_number":24,"context_line":"  $rbd_name \u003d $::ceph::profile::params::rbd_mirror_client_name ? {"},{"line_number":25,"context_line":"    undef   \u003d\u003e \u0027openstack\u0027,"},{"line_number":26,"context_line":"    default \u003d\u003e $::ceph::profile::params::rbd_mirror_client_name,"},{"line_number":27,"context_line":"  }"},{"line_number":28,"context_line":"  ceph::mirror { $rbd_name:"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a71b18c_55fde238","line":25,"in_reply_to":"3a71b18c_5a4fd8bd","updated":"2016-12-09 10:19:57.000000000","message":"I don\u0027t think this has to do with the package being installed, that comes from $pkg_mirror","commit_id":"f95aa995f6e7b7ee2ad2f2124004cfedbc9ca61f"}],"releasenotes/notes/rbd-mirror-e8c13699bb0e71d8.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ae9a4de001ddff625bca91ffc820b1213d8caadb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  - Includes"},{"line_number":5,"context_line":"    - package installation"},{"line_number":6,"context_line":"    - service start"},{"line_number":7,"context_line":"    - service enable"},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - Client key is not generated by this module. ceph::key "},{"line_number":10,"context_line":"    or other process creates this key"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3a71b18c_da497390","line":7,"updated":"2016-12-01 14:01:22.000000000","message":"The format is not correct here. Each point is a feature, so make it something lile:\n\n- Add support for ..., which includes package and service management, but not client key management.\n\nor something similar.","commit_id":"85afdcaedb3c3565f193ccc030014b8bbd44aa20"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"8e376903625c284b07e9b060788de918c24b7bc3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  - Includes"},{"line_number":5,"context_line":"    - package installation"},{"line_number":6,"context_line":"    - service start"},{"line_number":7,"context_line":"    - service enable"},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - Client key is not generated by this module. ceph::key "},{"line_number":10,"context_line":"    or other process creates this key"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3a71b18c_9ee28102","line":7,"in_reply_to":"3a71b18c_da497390","updated":"2016-12-01 17:27:22.000000000","message":"Done","commit_id":"85afdcaedb3c3565f193ccc030014b8bbd44aa20"}]}