)]}'
{"manifests/mds.pp":[{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"345ae26ed483f35c9713658abe3ceec3c86cb291","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# [*keyring*] The location of the keyring used by MDSs"},{"line_number":39,"context_line":"#   Optional. Defaults to /var/lib/ceph/mds/$cluster-$id/keyring."},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"class ceph::mds ("},{"line_number":42,"context_line":"  $public_addr  \u003d undef,"},{"line_number":43,"context_line":"  $mds_activate \u003d true,"},{"line_number":44,"context_line":"  $mds_data     \u003d \u0027/var/lib/ceph/mds/$cluster-$id\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a74a57a_4847c6bb","line":41,"updated":"2016-11-28 07:43:33.000000000","message":"s/class/define/ worked for me","commit_id":"7c3fdcd7c3c81ea9dbd2fa4f0b93d242895857ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2ece8a1860059c2780c76b9498e8d974c805b9cf","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# [*keyring*] The location of the keyring used by MDSs"},{"line_number":39,"context_line":"#   Optional. Defaults to /var/lib/ceph/mds/$cluster-$id/keyring."},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"class ceph::mds ("},{"line_number":42,"context_line":"  $public_addr  \u003d undef,"},{"line_number":43,"context_line":"  $mds_activate \u003d true,"},{"line_number":44,"context_line":"  $mds_data     \u003d \u0027/var/lib/ceph/mds/$cluster-$id\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a74a57a_d796133d","line":41,"in_reply_to":"5a74a57a_4847c6bb","updated":"2016-11-28 09:39:39.000000000","message":"I didn\u0027t want to change this to not break backward compatibility, yet mon and osd use define, not sure if others have opinions","commit_id":"7c3fdcd7c3c81ea9dbd2fa4f0b93d242895857ba"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"345ae26ed483f35c9713658abe3ceec3c86cb291","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  # NOTE(aschultz): this is the service title for the mon service. It may be"},{"line_number":59,"context_line":"  # different than the actual service name."},{"line_number":60,"context_line":"  $mds_service \u003d \"ceph-mds-${id}\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  # For Ubuntu Trusty system"},{"line_number":63,"context_line":"  if $::service_provider \u003d\u003d \u0027upstart\u0027 {"},{"line_number":64,"context_line":"    $init \u003d \u0027upstart\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a74a57a_68f72259","line":61,"updated":"2016-11-28 07:43:33.000000000","message":"ceph-mds service fails to start because of 2 issues:\n1) overcloud-controller-0.localdomain os-collect-config[2486]: ESC[1;31mError: Could not set \u0027file\u0027 on ensure: No such file or directory - /var/lib/ceph/mds/ceph-overcloud-controller-0/keyring at 113:/etc/puppet/modules/ceph/manifests/key.pp\n\nAdding this worked for me:\n  file { [\u0027/var/lib/ceph/mds\u0027, \u0027\u0027/var/lib/ceph/mds/ceph-overcloud-controller-0\u0027]: # missing in redhat pkg\n    ensure                  \u003d\u003e directory,\n    mode                    \u003d\u003e \u00270755\u0027,\n    selinux_ignore_defaults \u003d\u003e true,\n  }\n\n2) missing ceph-mds package","commit_id":"7c3fdcd7c3c81ea9dbd2fa4f0b93d242895857ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2ece8a1860059c2780c76b9498e8d974c805b9cf","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  # NOTE(aschultz): this is the service title for the mon service. It may be"},{"line_number":59,"context_line":"  # different than the actual service name."},{"line_number":60,"context_line":"  $mds_service \u003d \"ceph-mds-${id}\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  # For Ubuntu Trusty system"},{"line_number":63,"context_line":"  if $::service_provider \u003d\u003d \u0027upstart\u0027 {"},{"line_number":64,"context_line":"    $init \u003d \u0027upstart\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a74a57a_d732935d","line":61,"in_reply_to":"5a74a57a_68f72259","updated":"2016-11-28 09:39:39.000000000","message":"1) should this be taken care of in line 87?\n2) yeah by default ceph-mds is not pulled in as dependency so it needs to be explicitly installed, will fix it","commit_id":"7c3fdcd7c3c81ea9dbd2fa4f0b93d242895857ba"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3cc45701f20d9630fba10fa5be443b78de31300c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  if $cluster {"},{"line_number":63,"context_line":"    $cluster_real \u003d $cluster"},{"line_number":64,"context_line":"  } else {"},{"line_number":65,"context_line":"    $cluster_real \u003d \u0027ceph\u0027"},{"line_number":66,"context_line":"  }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  if $mds_data {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_b3ce8b81","line":65,"updated":"2016-12-01 20:58:34.000000000","message":"Why not make this the default parameter?","commit_id":"9237f1328e7dcf110e857707efc571950c530c70"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2a0a2406faa2da15f1bbc183faeaa64c8df7d0a3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  if $cluster {"},{"line_number":63,"context_line":"    $cluster_real \u003d $cluster"},{"line_number":64,"context_line":"  } else {"},{"line_number":65,"context_line":"    $cluster_real \u003d \u0027ceph\u0027"},{"line_number":66,"context_line":"  }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  if $mds_data {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_395f72e6","line":65,"in_reply_to":"3a71b18c_b3ce8b81","updated":"2016-12-03 21:27:03.000000000","message":"I think I\u0027ve seen it defaulting to undef in MON and thought it\u0027d have been good to keep some consistency; though the behavior we want here is the same it would have if we defaulted it to \u0027ceph\u0027 so I think I\u0027ll do it anyway.","commit_id":"9237f1328e7dcf110e857707efc571950c530c70"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3cc45701f20d9630fba10fa5be443b78de31300c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  # different than the actual service name."},{"line_number":87,"context_line":"  $mds_service \u003d \"ceph-mds-${mds_id}\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  # For Ubuntu Trusty system"},{"line_number":90,"context_line":"  if $::service_provider \u003d\u003d \u0027upstart\u0027 {"},{"line_number":91,"context_line":"    $init \u003d \u0027upstart\u0027"},{"line_number":92,"context_line":"    Service {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_d3cb0771","line":89,"updated":"2016-12-01 20:58:34.000000000","message":"We don\u0027t support trusty with the latest version of this module, so unless you\u0027re planning on backporting this I don\u0027t think this is necessary","commit_id":"9237f1328e7dcf110e857707efc571950c530c70"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2a0a2406faa2da15f1bbc183faeaa64c8df7d0a3","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  # different than the actual service name."},{"line_number":87,"context_line":"  $mds_service \u003d \"ceph-mds-${mds_id}\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  # For Ubuntu Trusty system"},{"line_number":90,"context_line":"  if $::service_provider \u003d\u003d \u0027upstart\u0027 {"},{"line_number":91,"context_line":"    $init \u003d \u0027upstart\u0027"},{"line_number":92,"context_line":"    Service {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_59626eae","line":89,"in_reply_to":"3a71b18c_d3cb0771","updated":"2016-12-03 21:27:03.000000000","message":"ack, so I guess we can cleanup this from other bits too","commit_id":"9237f1328e7dcf110e857707efc571950c530c70"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"756d02c7453a2aa40927440d3e3329ec7c15e862","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  package { $pkg_mds:"},{"line_number":88,"context_line":"    ensure \u003d\u003e installed,"},{"line_number":89,"context_line":"    tag    \u003d\u003e \u0027ceph\u0027,"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"ba5201f7_48165c56","line":88,"updated":"2017-01-03 16:04:42.000000000","message":"maybe we could have a param for the package status, like we have for other package resources in the modules.","commit_id":"2075473b2f3d79a1f273e782f1a3f099c2b1c29e"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"528d3d2f0c5b34739f94a45dae323690bc25e771","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  package { $pkg_mds:"},{"line_number":88,"context_line":"    ensure \u003d\u003e installed,"},{"line_number":89,"context_line":"    tag    \u003d\u003e \u0027ceph\u0027,"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"ba5201f7_5ef7f2f4","line":88,"in_reply_to":"ba5201f7_48165c56","updated":"2017-01-03 16:38:11.000000000","message":"we actually don\u0027t make this customizable for the osd or the rgw resources, but I can add it here as a start","commit_id":"2075473b2f3d79a1f273e782f1a3f099c2b1c29e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a1b58f719e963f0ad3d451e7116f56fe7530aadc","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  package { $pkg_mds:"},{"line_number":88,"context_line":"    ensure \u003d\u003e installed,"},{"line_number":89,"context_line":"    tag    \u003d\u003e \u0027ceph\u0027,"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"ba5201f7_79421040","line":88,"in_reply_to":"ba5201f7_5ef7f2f4","updated":"2017-01-03 16:47:23.000000000","message":"we should have the package name in params.pp in case they are OS specific.  It can still be a parameter on this class, but it should default to like $ceph::params::mds_packages or something","commit_id":"2075473b2f3d79a1f273e782f1a3f099c2b1c29e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"756d02c7453a2aa40927440d3e3329ec7c15e862","unresolved":false,"context_lines":[{"line_number":102,"context_line":"      \u0027mds/mds_data\u0027: value \u003d\u003e $mds_data_real;"},{"line_number":103,"context_line":"      \u0027mds/keyring\u0027:  value \u003d\u003e $keyring_real;"},{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":"    if $public_addr {"},{"line_number":106,"context_line":"      ceph_config {"},{"line_number":107,"context_line":"        \"mds.${mds_id}/public_addr\": value \u003d\u003e $public_addr;"},{"line_number":108,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"ba5201f7_083534f6","line":105,"updated":"2017-01-03 16:04:42.000000000","message":"you wouldn\u0027t need this conditional if you would set $public_addr to $::os_service_default.","commit_id":"2075473b2f3d79a1f273e782f1a3f099c2b1c29e"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"528d3d2f0c5b34739f94a45dae323690bc25e771","unresolved":false,"context_lines":[{"line_number":102,"context_line":"      \u0027mds/mds_data\u0027: value \u003d\u003e $mds_data_real;"},{"line_number":103,"context_line":"      \u0027mds/keyring\u0027:  value \u003d\u003e $keyring_real;"},{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":"    if $public_addr {"},{"line_number":106,"context_line":"      ceph_config {"},{"line_number":107,"context_line":"        \"mds.${mds_id}/public_addr\": value \u003d\u003e $public_addr;"},{"line_number":108,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"ba5201f7_fe2b46e9","line":105,"in_reply_to":"ba5201f7_083534f6","updated":"2017-01-03 16:38:11.000000000","message":"though it would add openstacklib to the requirements, I am not against it but we never added that as dep for puppet-ceph","commit_id":"2075473b2f3d79a1f273e782f1a3f099c2b1c29e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a1b58f719e963f0ad3d451e7116f56fe7530aadc","unresolved":false,"context_lines":[{"line_number":102,"context_line":"      \u0027mds/mds_data\u0027: value \u003d\u003e $mds_data_real;"},{"line_number":103,"context_line":"      \u0027mds/keyring\u0027:  value \u003d\u003e $keyring_real;"},{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":"    if $public_addr {"},{"line_number":106,"context_line":"      ceph_config {"},{"line_number":107,"context_line":"        \"mds.${mds_id}/public_addr\": value \u003d\u003e $public_addr;"},{"line_number":108,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"ba5201f7_be07fe1a","line":105,"in_reply_to":"ba5201f7_fe2b46e9","updated":"2017-01-03 16:47:23.000000000","message":"ceph_config doesn\u0027t support os_service_default and if i recall it\u0027s a big batch of work to get it working. It might be nice in the long term as something to work on but I don\u0027t think the puppet-ceph module should have a direct dependency on puppet-openstacklib at this time. I think that\u0027s outside the scope of this change.","commit_id":"2075473b2f3d79a1f273e782f1a3f099c2b1c29e"}],"manifests/params.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1431957ee7b0d58623133da58178be5405254556","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  $rgw_socket_path \u003d \u0027/tmp/radosgw.sock\u0027,"},{"line_number":50,"context_line":"  $enable_sig      \u003d false,"},{"line_number":51,"context_line":"  $release         \u003d \u0027jewel\u0027,"},{"line_number":52,"context_line":"  $pkg_mds         \u003d \u0027ceph-mds\u0027,"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  case $::osfamily {"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"ba5201f7_0969afbe","line":52,"updated":"2017-01-03 20:23:15.000000000","message":"So this should just be defined in the class like the other $pkg_* variables here. It shouldn\u0027t be a parameter of this class.","commit_id":"7bd4a3152cba66b0c3269f4ea9950a3140eaacf2"}],"manifests/profile/mds.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"ef04dba5f78c42918b394733edd8fc9f319f4021","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# Profile for a Ceph mds"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"class ceph::profile::mds {"},{"line_number":23,"context_line":"  require ::ceph::profile::base"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  ceph::mds { $::hostname:"},{"line_number":26,"context_line":"    public_addr \u003d\u003e $ceph::profile::params::public_addr,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a74a57a_1c56f05b","line":23,"updated":"2016-11-28 09:16:06.000000000","message":"you need \u0027include\u0027 instead of \u0027require\u0027 maybe?","commit_id":"7c3fdcd7c3c81ea9dbd2fa4f0b93d242895857ba"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"ef04dba5f78c42918b394733edd8fc9f319f4021","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class ceph::profile::mds {"},{"line_number":23,"context_line":"  require ::ceph::profile::base"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  ceph::mds { $::hostname:"},{"line_number":26,"context_line":"    public_addr \u003d\u003e $ceph::profile::params::public_addr,"},{"line_number":27,"context_line":"  }"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a74a57a_9c7a00f0","line":25,"updated":"2016-11-28 09:16:06.000000000","message":"you defined ceph::mds as a class, so this type of declaration won\u0027t work.","commit_id":"7c3fdcd7c3c81ea9dbd2fa4f0b93d242895857ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2ece8a1860059c2780c76b9498e8d974c805b9cf","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class ceph::profile::mds {"},{"line_number":23,"context_line":"  require ::ceph::profile::base"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  ceph::mds { $::hostname:"},{"line_number":26,"context_line":"    public_addr \u003d\u003e $ceph::profile::params::public_addr,"},{"line_number":27,"context_line":"  }"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a74a57a_3753c76c","line":25,"in_reply_to":"5a74a57a_9c7a00f0","updated":"2016-11-28 09:39:39.000000000","message":"yeah I am tempted to change it into a define as mon, osd or key are already","commit_id":"7c3fdcd7c3c81ea9dbd2fa4f0b93d242895857ba"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"345ae26ed483f35c9713658abe3ceec3c86cb291","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      cap_mds      \u003d\u003e \u0027allow \u0027,"},{"line_number":34,"context_line":"      inject       \u003d\u003e true,"},{"line_number":35,"context_line":"      keyring_path \u003d\u003e \"/var/lib/ceph/mds/ceph-${::hostname}/keyring\""},{"line_number":36,"context_line":"      secret       \u003d\u003e $ceph::profile::params::mds_key,"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a74a57a_e846d279","line":36,"updated":"2016-11-28 07:43:33.000000000","message":"the comma at the end of line should be moved on the previous line to avoid a syntax error","commit_id":"7c3fdcd7c3c81ea9dbd2fa4f0b93d242895857ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2ece8a1860059c2780c76b9498e8d974c805b9cf","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      cap_mds      \u003d\u003e \u0027allow \u0027,"},{"line_number":34,"context_line":"      inject       \u003d\u003e true,"},{"line_number":35,"context_line":"      keyring_path \u003d\u003e \"/var/lib/ceph/mds/ceph-${::hostname}/keyring\""},{"line_number":36,"context_line":"      secret       \u003d\u003e $ceph::profile::params::mds_key,"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a74a57a_176fab2b","line":36,"in_reply_to":"5a74a57a_e846d279","updated":"2016-11-28 09:39:39.000000000","message":"ack thanks","commit_id":"7c3fdcd7c3c81ea9dbd2fa4f0b93d242895857ba"},{"author":{"_account_id":14270,"name":"Dimitri Savineau","email":"dsavinea@redhat.com","username":"dsavineau"},"change_message_id":"8f1a18f68dcbebde20d73e9da10ce7bc4abd1d4d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    ceph::key { \"mds.${::hostname}\":"},{"line_number":31,"context_line":"      cap_mon      \u003d\u003e \u0027allow rwx\u0027,"},{"line_number":32,"context_line":"      cap_osd      \u003d\u003e \u0027allow *\u0027,"},{"line_number":33,"context_line":"      cap_mds      \u003d\u003e \u0027allow \u0027,"},{"line_number":34,"context_line":"      inject       \u003d\u003e true,"},{"line_number":35,"context_line":"      keyring_path \u003d\u003e \"/var/lib/ceph/mds/ceph-${::hostname}/keyring\","},{"line_number":36,"context_line":"      secret       \u003d\u003e $ceph::profile::params::mds_key"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a74a57a_3c49d5b7","line":33,"range":{"start_line":33,"start_character":28,"end_line":33,"end_character":29},"updated":"2016-11-28 15:45:55.000000000","message":"Unnecessary whitespace","commit_id":"70eb8637924e1ce1ce4feee71c793b9828de582e"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"468549e47ffb5123bbd9ddaaf11b4103becf6221","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      cap_osd      \u003d\u003e \u0027allow *\u0027,"},{"line_number":33,"context_line":"      cap_mds      \u003d\u003e \u0027allow \u0027,"},{"line_number":34,"context_line":"      inject       \u003d\u003e true,"},{"line_number":35,"context_line":"      keyring_path \u003d\u003e \"/var/lib/ceph/mds/ceph-${::hostname}/keyring\","},{"line_number":36,"context_line":"      secret       \u003d\u003e $ceph::profile::params::mds_key"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a74a57a_9e3d73c6","line":35,"updated":"2016-11-28 19:38:31.000000000","message":"keyring file needs ceph owner/group ownership, otherwise ceph-mds service fails to start:\nauth: unable to find a keyring on /var/lib/ceph/mds/ceph-overcloud-controller-0/keyring: (13) Permission denied\n\n\n[root@overcloud-controller-0 system]# ls -l /var/lib/ceph/mds/ceph-overcloud-controller-0/keyring\n-rw-------. 1 root root 144 Nov 28 16:56 /var/lib/ceph/mds/ceph-overcloud-controller-0/keyring","commit_id":"c3905cc34a4953b56e0e2c30d357d8a3d472a0fa"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9de8b26d1015f33b271df2886b44211ce48dc525","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      cap_osd      \u003d\u003e \u0027allow *\u0027,"},{"line_number":33,"context_line":"      cap_mds      \u003d\u003e \u0027allow \u0027,"},{"line_number":34,"context_line":"      inject       \u003d\u003e true,"},{"line_number":35,"context_line":"      keyring_path \u003d\u003e \"/var/lib/ceph/mds/ceph-${::hostname}/keyring\","},{"line_number":36,"context_line":"      secret       \u003d\u003e $ceph::profile::params::mds_key"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a74a57a_e11fa8b4","line":35,"in_reply_to":"5a74a57a_9e3d73c6","updated":"2016-11-28 20:24:14.000000000","message":"great, thanks!","commit_id":"c3905cc34a4953b56e0e2c30d357d8a3d472a0fa"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"140c63f829d9445dd98696ede523d6d12b84dbc0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  require ::ceph::profile::base"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  class { \u0027::ceph::mds\u0027:"},{"line_number":26,"context_line":"    public_addr \u003d\u003e $ceph::profile::params::public_addr,"},{"line_number":27,"context_line":"  }"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  if !empty($ceph::profile::params::mds_key) {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5a74a57a_d8f16897","line":26,"updated":"2016-11-30 11:11:17.000000000","message":"Wouldn\u0027t it be better to just use this as a default in the ceph::mds class?","commit_id":"9237f1328e7dcf110e857707efc571950c530c70"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ccf638d1d6afcf5c1a07f14f081dca0ffa0eb4be","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  require ::ceph::profile::base"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  class { \u0027::ceph::mds\u0027:"},{"line_number":26,"context_line":"    public_addr \u003d\u003e $ceph::profile::params::public_addr,"},{"line_number":27,"context_line":"  }"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  if !empty($ceph::profile::params::mds_key) {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_e094c0e9","line":26,"in_reply_to":"5a74a57a_d8f16897","updated":"2016-12-01 14:33:17.000000000","message":"I think the idea is that the base classes do not consume the params given to ::profile::params which should be used instead by the ::profile::$role","commit_id":"9237f1328e7dcf110e857707efc571950c530c70"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"6b81e2af57cff1f7a20ee32baf18a9bbf6565c84","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  if !empty($ceph::profile::params::mds_key) {"},{"line_number":30,"context_line":"    ceph::key { \"mds.${::hostname}\":"},{"line_number":31,"context_line":"      cap_mon      \u003d\u003e \u0027allow rwx\u0027,"},{"line_number":32,"context_line":"      cap_osd      \u003d\u003e \u0027allow *\u0027,"},{"line_number":33,"context_line":"      cap_mds      \u003d\u003e \u0027allow\u0027,"},{"line_number":34,"context_line":"      inject       \u003d\u003e true,"},{"line_number":35,"context_line":"      keyring_path \u003d\u003e \"/var/lib/ceph/mds/ceph-${::hostname}/keyring\","}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a71b18c_35c3aa58","line":32,"updated":"2016-12-06 09:31:17.000000000","message":"should we make a cephfs pool instead of granting rights to all ceph pools? See here for pool reference: http://docs.ceph.com/docs/master/cephfs/createfs/\nhttp://docs.ceph.com/docs/master/cephfs/client-auth/","commit_id":"05a780b3c3de44db0b9e264abdf5003208c16017"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"56e599056f313ca8329cbdbdbdc4fd76440c81c0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  if !empty($ceph::profile::params::mds_key) {"},{"line_number":30,"context_line":"    ceph::key { \"mds.${::hostname}\":"},{"line_number":31,"context_line":"      cap_mon      \u003d\u003e \u0027allow rwx\u0027,"},{"line_number":32,"context_line":"      cap_osd      \u003d\u003e \u0027allow *\u0027,"},{"line_number":33,"context_line":"      cap_mds      \u003d\u003e \u0027allow\u0027,"},{"line_number":34,"context_line":"      inject       \u003d\u003e true,"},{"line_number":35,"context_line":"      keyring_path \u003d\u003e \"/var/lib/ceph/mds/ceph-${::hostname}/keyring\","}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a71b18c_9b810ffe","line":32,"in_reply_to":"3a71b18c_35c3aa58","updated":"2016-12-06 10:05:43.000000000","message":"yeah sounds like a good idea, thanks","commit_id":"05a780b3c3de44db0b9e264abdf5003208c16017"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"2e2c6aa1a01a30360b30a212888a59de5d4aebec","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  if !empty($ceph::profile::params::mds_key) {"},{"line_number":30,"context_line":"    ceph::key { \"mds.${::hostname}\":"},{"line_number":31,"context_line":"      cap_mon      \u003d\u003e \u0027allow profile mds\u0027,"},{"line_number":32,"context_line":"      cap_osd      \u003d\u003e \"allow rwx pool\u003d${ceph::profile::params::mds_data_pool} rwx pool\u003d${ceph::profile::params::mds_metadata_pool}\","},{"line_number":33,"context_line":"      cap_mds      \u003d\u003e \u0027allow\u0027,"},{"line_number":34,"context_line":"      inject       \u003d\u003e true,"},{"line_number":35,"context_line":"      keyring_path \u003d\u003e \"/var/lib/ceph/mds/ceph-${::hostname}/keyring\","}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a6eadb0_ef9f385d","line":32,"updated":"2016-12-13 11:26:38.000000000","message":"As you pointed out on IRC, it needs to be:\n      cap_osd      \u003d\u003e \"allow rwx pool\u003d${ceph::profile::params::mds_data_pool}, allow rwx pool\u003d${ceph::profile::params::mds_metadata_pool}\",","commit_id":"be6e5630f78ea0cefbec9f61b8f8e3236bfea013"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ad7a04268f67266a283d86f65d16fc91f30f039d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  if !empty($ceph::profile::params::mds_key) {"},{"line_number":30,"context_line":"    ceph::key { \"mds.${::hostname}\":"},{"line_number":31,"context_line":"      cap_mon      \u003d\u003e \u0027allow profile mds\u0027,"},{"line_number":32,"context_line":"      cap_osd      \u003d\u003e \"allow rwx pool\u003d${ceph::profile::params::mds_data_pool} rwx pool\u003d${ceph::profile::params::mds_metadata_pool}\","},{"line_number":33,"context_line":"      cap_mds      \u003d\u003e \u0027allow\u0027,"},{"line_number":34,"context_line":"      inject       \u003d\u003e true,"},{"line_number":35,"context_line":"      keyring_path \u003d\u003e \"/var/lib/ceph/mds/ceph-${::hostname}/keyring\","}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a6eadb0_fd5e0944","line":32,"in_reply_to":"1a6eadb0_ef9f385d","updated":"2016-12-13 14:00:52.000000000","message":"ack, updating","commit_id":"be6e5630f78ea0cefbec9f61b8f8e3236bfea013"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"f9f6a3936fd8e88485d5a2f3c76d9b62cae7d2aa","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  if !empty($ceph::profile::params::mds_key) {"},{"line_number":30,"context_line":"    ceph::key { \"mds.${::hostname}\":"},{"line_number":31,"context_line":"      cap_mon      \u003d\u003e \u0027allow profile mds\u0027,"},{"line_number":32,"context_line":"      cap_osd      \u003d\u003e \"allow rwx pool\u003d${ceph::profile::params::mds_data_pool}, allow rwx pool\u003d${ceph::profile::params::mds_metadata_pool}\","},{"line_number":33,"context_line":"      cap_mds      \u003d\u003e \u0027allow\u0027,"},{"line_number":34,"context_line":"      inject       \u003d\u003e true,"},{"line_number":35,"context_line":"      keyring_path \u003d\u003e \"/var/lib/ceph/mds/ceph-${::hostname}/keyring\","}],"source_content_type":"text/x-puppet","patch_set":12,"id":"1a6eadb0_ee5e2375","line":32,"updated":"2016-12-14 10:55:49.000000000","message":"mds service fails to start with these perms for me, what works for me:\n   if !empty($ceph::profile::params::mds_key) {\n     ceph::key { \"mds.${::hostname}\":\n       cap_mon      \u003d\u003e \u0027allow profile mds\u0027,\n       cap_osd      \u003d\u003e \"allow rwx\",\n       cap_mds      \u003d\u003e \u0027allow\u0027,\n       inject       \u003d\u003e true,\n       keyring_path \u003d\u003e \"/var/lib/ceph/mds/ceph-${::hostname}/keyring\",","commit_id":"8699f38a4e84849366ee036a38536fa102eecae5"}],"manifests/profile/params.pp":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"5dc51774dabcafe867f4b7c80eabc654395bc881","unresolved":false,"context_lines":[{"line_number":94,"context_line":"# [*mds_key*] The mds secret key."},{"line_number":95,"context_line":"#   Optional but required when using cephx."},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"# [*mds_data_pool*] The data pool for which MDS is given permissions"},{"line_number":98,"context_line":"#   Optional. Defaults to \u0027cephfs\u0027."},{"line_number":99,"context_line":"#"},{"line_number":100,"context_line":"# [*mds_metadata_pool*] The metadata pool for which MDS is given permissions"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da4df55a_a427bcc8","line":97,"updated":"2016-12-26 10:50:44.000000000","message":"Why do you need this option? What\u0027s this option used for currently? I don\u0027t see MDS user key\u0027s permissions restricted to a pool. Currently the permissions/caps are set as\n\n      :cap_mon      \u003d\u003e \u0027allow profile mds\u0027,\n      :cap_osd      \u003d\u003e \u0027allow rwx\u0027,\n      :cap_mds      \u003d\u003e \u0027allow\u0027,","commit_id":"611cc72b0b0b2e4fe5e8e178356bd7ebff1fab2a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"98075f3c8dff70d6cc3bf75aff09b85785185ae3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"# [*mds_key*] The mds secret key."},{"line_number":95,"context_line":"#   Optional but required when using cephx."},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"# [*mds_data_pool*] The data pool for which MDS is given permissions"},{"line_number":98,"context_line":"#   Optional. Defaults to \u0027cephfs\u0027."},{"line_number":99,"context_line":"#"},{"line_number":100,"context_line":"# [*mds_metadata_pool*] The metadata pool for which MDS is given permissions"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"ba5201f7_f1a462ba","line":97,"in_reply_to":"ba5201f7_f1d62226","updated":"2017-01-03 11:59:14.000000000","message":"these were actually created by mds.pp but we don\u0027t use them by default anymore","commit_id":"611cc72b0b0b2e4fe5e8e178356bd7ebff1fab2a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"dc7b1a2114de99b9dd667abd2be95971b88be178","unresolved":false,"context_lines":[{"line_number":94,"context_line":"# [*mds_key*] The mds secret key."},{"line_number":95,"context_line":"#   Optional but required when using cephx."},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"# [*mds_data_pool*] The data pool for which MDS is given permissions"},{"line_number":98,"context_line":"#   Optional. Defaults to \u0027cephfs\u0027."},{"line_number":99,"context_line":"#"},{"line_number":100,"context_line":"# [*mds_metadata_pool*] The metadata pool for which MDS is given permissions"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"ba5201f7_f1d62226","line":97,"in_reply_to":"da4df55a_a427bcc8","updated":"2017-01-03 11:56:38.000000000","message":"ack, I was previously consuming it, not anymore, will remove them","commit_id":"611cc72b0b0b2e4fe5e8e178356bd7ebff1fab2a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"5dc51774dabcafe867f4b7c80eabc654395bc881","unresolved":false,"context_lines":[{"line_number":97,"context_line":"# [*mds_data_pool*] The data pool for which MDS is given permissions"},{"line_number":98,"context_line":"#   Optional. Defaults to \u0027cephfs\u0027."},{"line_number":99,"context_line":"#"},{"line_number":100,"context_line":"# [*mds_metadata_pool*] The metadata pool for which MDS is given permissions"},{"line_number":101,"context_line":"#   Optional. Defaults to \u0027cephfs_metadata\u0027."},{"line_number":102,"context_line":"#"},{"line_number":103,"context_line":"# [*mon_key*] The mon secret key."}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da4df55a_c424c0c6","line":100,"updated":"2016-12-26 10:50:44.000000000","message":"Why do you need this option? What\u0027s this option used for currently? I don\u0027t see MDS user key\u0027s permissions restricted to a pool. Currently the permissions/caps are set as\n\n      :cap_mon      \u003d\u003e \u0027allow profile mds\u0027,\n      :cap_osd      \u003d\u003e \u0027allow rwx\u0027,\n      :cap_mds      \u003d\u003e \u0027allow\u0027,","commit_id":"611cc72b0b0b2e4fe5e8e178356bd7ebff1fab2a"}],"spec/classes/ceph_mds_spec.rb":[{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"6b81e2af57cff1f7a20ee32baf18a9bbf6565c84","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        }"},{"line_number":60,"context_line":"      end"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027mds/mds_data\u0027).with_value(\u0027/var/lib/ceph/mds/ceph-myhostname\u0027) }"},{"line_number":63,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027mds/keyring\u0027).with_value(\u0027/var/lib/ceph/mds/ceph-myhostname/keyring\u0027) }"},{"line_number":64,"context_line":"      it { is_expected.to contain_ceph_config(\u0027mds/mds_data\u0027).with_ensure(\u0027absent\u0027) }"},{"line_number":65,"context_line":"      it { is_expected.to contain_ceph_config(\u0027mds/keyring\u0027).with_ensure(\u0027absent\u0027) }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    end"},{"line_number":68,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3a71b18c_75efe21d","line":65,"range":{"start_line":62,"start_character":2,"end_line":65,"end_character":84},"updated":"2016-12-06 09:31:17.000000000","message":"Does the second two lines make the first redundant? If the keys are absent, then they cannot contain a value.","commit_id":"05a780b3c3de44db0b9e264abdf5003208c16017"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"56e599056f313ca8329cbdbdbdc4fd76440c81c0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        }"},{"line_number":60,"context_line":"      end"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027mds/mds_data\u0027).with_value(\u0027/var/lib/ceph/mds/ceph-myhostname\u0027) }"},{"line_number":63,"context_line":"      it { is_expected.to_not contain_ceph_config(\u0027mds/keyring\u0027).with_value(\u0027/var/lib/ceph/mds/ceph-myhostname/keyring\u0027) }"},{"line_number":64,"context_line":"      it { is_expected.to contain_ceph_config(\u0027mds/mds_data\u0027).with_ensure(\u0027absent\u0027) }"},{"line_number":65,"context_line":"      it { is_expected.to contain_ceph_config(\u0027mds/keyring\u0027).with_ensure(\u0027absent\u0027) }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    end"},{"line_number":68,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3a71b18c_80699efb","line":65,"range":{"start_line":62,"start_character":2,"end_line":65,"end_character":84},"in_reply_to":"3a71b18c_75efe21d","updated":"2016-12-06 10:05:43.000000000","message":"yeah I think we can just remove lines 49 and 50","commit_id":"05a780b3c3de44db0b9e264abdf5003208c16017"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ac3f72e4baf4c6be8d41490b8befeb073a463d07","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  }).each do |os,facts|"},{"line_number":71,"context_line":"    context \"on #{os}\" do"},{"line_number":72,"context_line":"      let (:facts) do"},{"line_number":73,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":74,"context_line":"        facts.merge!(:hostname \u003d\u003e \u0027myhostname\u0027)"},{"line_number":75,"context_line":"      end"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":10,"id":"3a71b18c_fd434911","line":73,"updated":"2016-12-08 23:01:28.000000000","message":"OSDefaults.get_facts({:hostname \u003d\u003e \u0027myhostname\u0027})","commit_id":"753219c4ec533e1a97a83b732bd8ff8e90717944"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"289e663d5c4fb93269d0f808153fdf62138a9819","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  }).each do |os,facts|"},{"line_number":71,"context_line":"    context \"on #{os}\" do"},{"line_number":72,"context_line":"      let (:facts) do"},{"line_number":73,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":74,"context_line":"        facts.merge!(:hostname \u003d\u003e \u0027myhostname\u0027)"},{"line_number":75,"context_line":"      end"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":10,"id":"3a71b18c_9db5f5d1","line":73,"in_reply_to":"3a71b18c_fd434911","updated":"2016-12-08 23:07:53.000000000","message":"yeah you commented this on previous patchsets too, I must have missed it","commit_id":"753219c4ec533e1a97a83b732bd8ff8e90717944"}],"spec/classes/ceph_profile_mds_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3cc45701f20d9630fba10fa5be443b78de31300c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  }).each do |os,facts|"},{"line_number":42,"context_line":"    context \"on #{os}\" do"},{"line_number":43,"context_line":"      let (:facts) do"},{"line_number":44,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":45,"context_line":"        facts.merge!(:hostname \u003d\u003e \u0027myhostname\u0027)"},{"line_number":46,"context_line":"      end"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3a71b18c_f3c80377","line":44,"updated":"2016-12-01 20:58:34.000000000","message":"get_facts takes a hash as a parameter so you don\u0027t have to do this. facts.merge!(OSDefaults.get_facts({:hostname \u003d\u003e \u0027myhostname\u0027}))","commit_id":"9237f1328e7dcf110e857707efc571950c530c70"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2a0a2406faa2da15f1bbc183faeaa64c8df7d0a3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  }).each do |os,facts|"},{"line_number":42,"context_line":"    context \"on #{os}\" do"},{"line_number":43,"context_line":"      let (:facts) do"},{"line_number":44,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":45,"context_line":"        facts.merge!(:hostname \u003d\u003e \u0027myhostname\u0027)"},{"line_number":46,"context_line":"      end"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3a71b18c_1952b6dd","line":44,"in_reply_to":"3a71b18c_f3c80377","updated":"2016-12-03 21:27:03.000000000","message":"ack, will update thanks","commit_id":"9237f1328e7dcf110e857707efc571950c530c70"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ac3f72e4baf4c6be8d41490b8befeb073a463d07","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  }).each do |os,facts|"},{"line_number":44,"context_line":"    context \"on #{os}\" do"},{"line_number":45,"context_line":"      let (:facts) do"},{"line_number":46,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":47,"context_line":"        facts.merge!(:hostname \u003d\u003e \u0027myhostname\u0027)"},{"line_number":48,"context_line":"      end"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":10,"id":"3a71b18c_1d4ba52c","line":46,"updated":"2016-12-08 23:01:28.000000000","message":"get_facts({:hostname \u003d\u003e \u0027myhostname\u0027})","commit_id":"753219c4ec533e1a97a83b732bd8ff8e90717944"}],"spec/fixtures/hieradata/common.yaml":[{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"59d0299dd5b5d524a4491721a03f42626e9151a7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"ceph::profile::params::cluster_network: \u002710.12.13.0/24\u0027"},{"line_number":18,"context_line":"ceph::profile::params::public_network: \u002710.11.12.0/24\u0027"},{"line_number":19,"context_line":"ceph::profile::params::public_addr: \u002710.11.12.2\u0027"},{"line_number":20,"context_line":"ceph::profile::params::mds_key: \u0027supersecret\u0027"},{"line_number":21,"context_line":"ceph::profile::params::osd_max_backfills: \u00271\u0027"},{"line_number":22,"context_line":"ceph::profile::params::osd_recovery_max_active: \u00271\u0027"},{"line_number":23,"context_line":"ceph::profile::params::osd_recovery_op_priority: \u00271\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a74a57a_bb008135","line":20,"updated":"2016-11-28 19:31:54.000000000","message":"A minor pick but this is not a usual type of cephx key. See line 29. Also, can you move it to below with the rest of the keys?","commit_id":"c3905cc34a4953b56e0e2c30d357d8a3d472a0fa"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9de8b26d1015f33b271df2886b44211ce48dc525","unresolved":false,"context_lines":[{"line_number":17,"context_line":"ceph::profile::params::cluster_network: \u002710.12.13.0/24\u0027"},{"line_number":18,"context_line":"ceph::profile::params::public_network: \u002710.11.12.0/24\u0027"},{"line_number":19,"context_line":"ceph::profile::params::public_addr: \u002710.11.12.2\u0027"},{"line_number":20,"context_line":"ceph::profile::params::mds_key: \u0027supersecret\u0027"},{"line_number":21,"context_line":"ceph::profile::params::osd_max_backfills: \u00271\u0027"},{"line_number":22,"context_line":"ceph::profile::params::osd_recovery_max_active: \u00271\u0027"},{"line_number":23,"context_line":"ceph::profile::params::osd_recovery_op_priority: \u00271\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a74a57a_0172e410","line":20,"in_reply_to":"5a74a57a_bb008135","updated":"2016-11-28 20:24:14.000000000","message":"yes, thanks","commit_id":"c3905cc34a4953b56e0e2c30d357d8a3d472a0fa"}]}