)]}'
{"manifests/repo.pp":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"60e016604f5e51cc36a718b5cbbd4617a0fefe36","unresolved":false,"context_lines":[{"line_number":125,"context_line":"          ensure \u003d\u003e $ensure,"},{"line_number":126,"context_line":"          path   \u003d\u003e \u0027/etc/yum.repos.d/CentOS-Ceph-Hammer.repo\u0027,"},{"line_number":127,"context_line":"          after  \u003d\u003e \u0027^\\[centos-ceph-hammer\\]$\u0027,"},{"line_number":128,"context_line":"          line   \u003d\u003e \u0027priority\u003d1\u0027,"},{"line_number":129,"context_line":"        }"},{"line_number":130,"context_line":"        # Make sure we install the repo and configure priorities before install ceph"},{"line_number":131,"context_line":"        File_line[\u0027priority ceph\u0027] -\u003e Package\u003c| tag \u003d\u003d \u0027ceph\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_83b1ee49","line":128,"updated":"2016-12-14 18:45:58.000000000","message":"For this to work, you need to ensure yum-plugin-priorities RPM is installed.","commit_id":"6877014ca65324189f3f044ec49868a8aed573c2"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"5cf0d3dfb99b4758bf223f05ba08d48a5fa83594","unresolved":false,"context_lines":[{"line_number":125,"context_line":"          ensure \u003d\u003e $ensure,"},{"line_number":126,"context_line":"          path   \u003d\u003e \u0027/etc/yum.repos.d/CentOS-Ceph-Hammer.repo\u0027,"},{"line_number":127,"context_line":"          after  \u003d\u003e \u0027^\\[centos-ceph-hammer\\]$\u0027,"},{"line_number":128,"context_line":"          line   \u003d\u003e \u0027priority\u003d1\u0027,"},{"line_number":129,"context_line":"        }"},{"line_number":130,"context_line":"        # Make sure we install the repo and configure priorities before install ceph"},{"line_number":131,"context_line":"        File_line[\u0027priority ceph\u0027] -\u003e Package\u003c| tag \u003d\u003d \u0027ceph\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_c3f04694","line":128,"in_reply_to":"1a6eadb0_83b1ee49","updated":"2016-12-14 18:54:08.000000000","message":"It\u0027s installed by default in p-o-i, but yes make sense to enforce it here. I\u0027ll add it to the patch.","commit_id":"6877014ca65324189f3f044ec49868a8aed573c2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7ade71bf623e8c777d237f3a12c8a0007cc3fd00","unresolved":false,"context_lines":[{"line_number":122,"context_line":"          unless    \u003d\u003e \u0027/usr/bin/rpm -qa | /usr/bin/grep -q centos-release-ceph-hammer\u0027,"},{"line_number":123,"context_line":"        } -\u003e"},{"line_number":124,"context_line":"        package { \u0027yum-plugin-priorities\u0027:"},{"line_number":125,"context_line":"          ensure \u003d\u003e present,"},{"line_number":126,"context_line":"        } -\u003e"},{"line_number":127,"context_line":"        file_line { \u0027priority ceph\u0027:"},{"line_number":128,"context_line":"          ensure \u003d\u003e $ensure,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a6eadb0_66a860dc","line":125,"updated":"2016-12-14 19:16:07.000000000","message":"this could be \u0027ensure \u003d\u003e $ensure\u0027","commit_id":"295a0912e07712483babec2a6d0d3313d14ed538"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7ade71bf623e8c777d237f3a12c8a0007cc3fd00","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        package { \u0027yum-plugin-priorities\u0027:"},{"line_number":125,"context_line":"          ensure \u003d\u003e present,"},{"line_number":126,"context_line":"        } -\u003e"},{"line_number":127,"context_line":"        file_line { \u0027priority ceph\u0027:"},{"line_number":128,"context_line":"          ensure \u003d\u003e $ensure,"},{"line_number":129,"context_line":"          path   \u003d\u003e \u0027/etc/yum.repos.d/CentOS-Ceph-Hammer.repo\u0027,"},{"line_number":130,"context_line":"          after  \u003d\u003e \u0027^\\[centos-ceph-hammer\\]$\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a6eadb0_068a4c1b","line":127,"updated":"2016-12-14 19:16:07.000000000","message":"given we have inifile in metadata.json already, I think it\u0027d be cool to use it here, see an example at https://forge.puppet.com/puppetlabs/inifile","commit_id":"295a0912e07712483babec2a6d0d3313d14ed538"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"1b4988ca0c736efe1411825361dfcc3e0d991bf1","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        package { \u0027yum-plugin-priorities\u0027:"},{"line_number":125,"context_line":"          ensure \u003d\u003e present,"},{"line_number":126,"context_line":"        } -\u003e"},{"line_number":127,"context_line":"        file_line { \u0027priority ceph\u0027:"},{"line_number":128,"context_line":"          ensure \u003d\u003e $ensure,"},{"line_number":129,"context_line":"          path   \u003d\u003e \u0027/etc/yum.repos.d/CentOS-Ceph-Hammer.repo\u0027,"},{"line_number":130,"context_line":"          after  \u003d\u003e \u0027^\\[centos-ceph-hammer\\]$\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a6eadb0_6f33cc62","line":127,"in_reply_to":"1a6eadb0_068a4c1b","updated":"2016-12-14 22:49:19.000000000","message":"or could we exec yum-config-manager although that would require install yum-utils...","commit_id":"295a0912e07712483babec2a6d0d3313d14ed538"}]}