)]}'
{"manifests/osd.pp":[{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"2221aa3942c4246c40ab46240c0cea8766e4bde3","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":119,"context_line":"set -ex"},{"line_number":120,"context_line":"if [ -b ${journal} ]; then"},{"line_number":121,"context_line":"  sgdisk -Z ${journal} "},{"line_number":122,"context_line":"  sgdisk -g ${journal} "},{"line_number":123,"context_line":"  partprobe"},{"line_number":124,"context_line":"fi"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a3c09a3_56076c81","line":121,"range":{"start_line":121,"start_character":22,"end_line":121,"end_character":23},"updated":"2017-01-17 19:49:53.000000000","message":"white space at and of line","commit_id":"73bffe65e99ebfe3527856a33651b7b189a8f763"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"2221aa3942c4246c40ab46240c0cea8766e4bde3","unresolved":false,"context_lines":[{"line_number":119,"context_line":"set -ex"},{"line_number":120,"context_line":"if [ -b ${journal} ]; then"},{"line_number":121,"context_line":"  sgdisk -Z ${journal} "},{"line_number":122,"context_line":"  sgdisk -g ${journal} "},{"line_number":123,"context_line":"  partprobe"},{"line_number":124,"context_line":"fi"},{"line_number":125,"context_line":"\","}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a3c09a3_96fd5470","line":122,"range":{"start_line":122,"start_character":22,"end_line":122,"end_character":23},"updated":"2017-01-17 19:49:53.000000000","message":"white space at and of line.","commit_id":"73bffe65e99ebfe3527856a33651b7b189a8f763"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d2f7617885701805f60ff6185b4344b2f6d9bd17","unresolved":false,"context_lines":[{"line_number":127,"context_line":"set -ex"},{"line_number":128,"context_line":"# do not zap journal if there are still old journal partitions in the process of"},{"line_number":129,"context_line":"# being cleaned up or if the disk is already clean to prevent a race condition"},{"line_number":130,"context_line":"ceph-disk list | egrep \u0027 *${journal}.*(other, unknown|ceph journal,)\u0027"},{"line_number":131,"context_line":"\","},{"line_number":132,"context_line":"            logoutput \u003d\u003e true,"},{"line_number":133,"context_line":"            timeout   \u003d\u003e $exec_timeout,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a3c09a3_c20acb89","line":130,"updated":"2017-01-17 14:41:45.000000000","message":"shouldn\u0027t we avoid zapping also when the cluster fsid is the same we\u0027re about to provision to diminish risk of zapping good disks on puppet update?","commit_id":"73bffe65e99ebfe3527856a33651b7b189a8f763"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"2221aa3942c4246c40ab46240c0cea8766e4bde3","unresolved":false,"context_lines":[{"line_number":138,"context_line":"          command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":139,"context_line":"set -ex"},{"line_number":140,"context_line":"if [ -b ${data} ]; then"},{"line_number":141,"context_line":"  sgdisk -Z ${data} "},{"line_number":142,"context_line":"  sgdisk -g ${data} "},{"line_number":143,"context_line":"  partprobe"},{"line_number":144,"context_line":"fi"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a3c09a3_b637b04b","line":141,"range":{"start_line":141,"start_character":19,"end_line":141,"end_character":20},"updated":"2017-01-17 19:49:53.000000000","message":"white space at end of line.","commit_id":"73bffe65e99ebfe3527856a33651b7b189a8f763"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"2221aa3942c4246c40ab46240c0cea8766e4bde3","unresolved":false,"context_lines":[{"line_number":139,"context_line":"set -ex"},{"line_number":140,"context_line":"if [ -b ${data} ]; then"},{"line_number":141,"context_line":"  sgdisk -Z ${data} "},{"line_number":142,"context_line":"  sgdisk -g ${data} "},{"line_number":143,"context_line":"  partprobe"},{"line_number":144,"context_line":"fi"},{"line_number":145,"context_line":"\","}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a3c09a3_f63db82b","line":142,"range":{"start_line":142,"start_character":19,"end_line":142,"end_character":20},"updated":"2017-01-17 19:49:53.000000000","message":"white space at end of line.","commit_id":"73bffe65e99ebfe3527856a33651b7b189a8f763"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ccd1c1f3f24114ad6a20be900433e2f0014df479","unresolved":false,"context_lines":[{"line_number":143,"context_line":"\","},{"line_number":144,"context_line":"          unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":145,"context_line":"set -ex"},{"line_number":146,"context_line":"ceph-disk list | egrep \u0027 *${data}1? .*ceph data, active\u0027"},{"line_number":147,"context_line":"\","},{"line_number":148,"context_line":"          logoutput \u003d\u003e true,"},{"line_number":149,"context_line":"          timeout   \u003d\u003e $exec_timeout,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a3c09a3_021f285b","line":146,"updated":"2017-01-18 15:59:29.000000000","message":"I think one can pass actual partitions as osd, should this be appending \u00271\u0027 to the ${data} var?","commit_id":"8970903e57f67732b156b35e3bbca8078ade00e4"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"564764cd42e378436c71d235d7ba705ddbd17628","unresolved":false,"context_lines":[{"line_number":126,"context_line":"set -ex"},{"line_number":127,"context_line":"# do not zap journal if there are still old journal partitions in the process of"},{"line_number":128,"context_line":"# being cleaned up or if the disk is already clean to prevent a race condition"},{"line_number":129,"context_line":"ceph-disk list | egrep \u0027 *${journal}.*(other, unknown|ceph journal,)\u0027"},{"line_number":130,"context_line":"\","},{"line_number":131,"context_line":"            logoutput \u003d\u003e true,"},{"line_number":132,"context_line":"            timeout   \u003d\u003e $exec_timeout,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a3c09a3_9cb8c72c","line":129,"updated":"2017-01-18 22:30:43.000000000","message":"I think we want to make sure this is safe to run if we launch puppet multiple times adding or removing osds, did we test this?","commit_id":"97feceb0bf98640bb23cf753e1990e7dabe42ae6"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"564764cd42e378436c71d235d7ba705ddbd17628","unresolved":false,"context_lines":[{"line_number":129,"context_line":"ceph-disk list | egrep \u0027 *${journal}.*(other, unknown|ceph journal,)\u0027"},{"line_number":130,"context_line":"\","},{"line_number":131,"context_line":"            logoutput \u003d\u003e true,"},{"line_number":132,"context_line":"            timeout   \u003d\u003e $exec_timeout,"},{"line_number":133,"context_line":"          }"},{"line_number":134,"context_line":"        }"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a3c09a3_5c39ffd7","line":132,"updated":"2017-01-18 22:30:43.000000000","message":"how about using\n\nbefore  \u003d\u003e Exec[$ceph_prepare]\n\nto remove the -\u003e on L104\u003eL107 and L112-L115","commit_id":"97feceb0bf98640bb23cf753e1990e7dabe42ae6"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"3f2563417bd6965e41ff6148e03ac444415b4cde","unresolved":false,"context_lines":[{"line_number":129,"context_line":"ceph-disk list | egrep \u0027 *${journal}.*(other, unknown|ceph journal,)\u0027"},{"line_number":130,"context_line":"\","},{"line_number":131,"context_line":"            logoutput \u003d\u003e true,"},{"line_number":132,"context_line":"            timeout   \u003d\u003e $exec_timeout,"},{"line_number":133,"context_line":"          }"},{"line_number":134,"context_line":"        }"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a3c09a3_7fe30d06","line":132,"in_reply_to":"7a3c09a3_5c39ffd7","updated":"2017-01-18 22:52:26.000000000","message":"this should also have\n\n after \u003d Exec[$ceph_zap_osd]","commit_id":"97feceb0bf98640bb23cf753e1990e7dabe42ae6"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"564764cd42e378436c71d235d7ba705ddbd17628","unresolved":false,"context_lines":[{"line_number":143,"context_line":"\","},{"line_number":144,"context_line":"          unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":145,"context_line":"set -ex"},{"line_number":146,"context_line":"ceph-disk list | egrep \u0027 *${data}.*ceph data, active\u0027"},{"line_number":147,"context_line":"\","},{"line_number":148,"context_line":"          logoutput \u003d\u003e true,"},{"line_number":149,"context_line":"          timeout   \u003d\u003e $exec_timeout,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a3c09a3_7c923ba1","line":146,"updated":"2017-01-18 22:30:43.000000000","message":"same as per L129","commit_id":"97feceb0bf98640bb23cf753e1990e7dabe42ae6"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"564764cd42e378436c71d235d7ba705ddbd17628","unresolved":false,"context_lines":[{"line_number":146,"context_line":"ceph-disk list | egrep \u0027 *${data}.*ceph data, active\u0027"},{"line_number":147,"context_line":"\","},{"line_number":148,"context_line":"          logoutput \u003d\u003e true,"},{"line_number":149,"context_line":"          timeout   \u003d\u003e $exec_timeout,"},{"line_number":150,"context_line":"        }"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a3c09a3_bc3023ea","line":149,"updated":"2017-01-18 22:30:43.000000000","message":"before \u003d\u003e Exec[$ceph_zap_osd]","commit_id":"97feceb0bf98640bb23cf753e1990e7dabe42ae6"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"3f2563417bd6965e41ff6148e03ac444415b4cde","unresolved":false,"context_lines":[{"line_number":146,"context_line":"ceph-disk list | egrep \u0027 *${data}.*ceph data, active\u0027"},{"line_number":147,"context_line":"\","},{"line_number":148,"context_line":"          logoutput \u003d\u003e true,"},{"line_number":149,"context_line":"          timeout   \u003d\u003e $exec_timeout,"},{"line_number":150,"context_line":"        }"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a3c09a3_1f0e89e5","line":149,"in_reply_to":"7a3c09a3_bc3023ea","updated":"2017-01-18 22:52:26.000000000","message":"actually this should be\n\n  before \u003d\u003e Exec[$ceph_prepare]","commit_id":"97feceb0bf98640bb23cf753e1990e7dabe42ae6"},{"author":{"_account_id":14270,"name":"Dimitri Savineau","email":"dsavinea@redhat.com","username":"dsavineau"},"change_message_id":"fe1c56cabae1a537c3c078a3eaa1a256f0574923","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":119,"context_line":"set -ex"},{"line_number":120,"context_line":"if [ -b ${journal} ]; then"},{"line_number":121,"context_line":"  sgdisk -Z ${journal}"},{"line_number":122,"context_line":"  sgdisk -g ${journal}"},{"line_number":123,"context_line":"  partprobe"},{"line_number":124,"context_line":"fi"},{"line_number":125,"context_line":"\","},{"line_number":126,"context_line":"            unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5a3905b3_5f4c71c7","line":123,"range":{"start_line":121,"start_character":0,"end_line":123,"end_character":11},"updated":"2017-01-19 19:45:05.000000000","message":"all disk operations in this module are using ceph-disk command (which calls sgdisk and partprobe btw) so you should probably use \u0027ceph-disk zap {device}\u0027 instead","commit_id":"38f596aa98e5343cfc674305c13352e01e43179b"},{"author":{"_account_id":14270,"name":"Dimitri Savineau","email":"dsavinea@redhat.com","username":"dsavineau"},"change_message_id":"fe1c56cabae1a537c3c078a3eaa1a256f0574923","unresolved":false,"context_lines":[{"line_number":123,"context_line":"  partprobe"},{"line_number":124,"context_line":"fi"},{"line_number":125,"context_line":"\","},{"line_number":126,"context_line":"            unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":127,"context_line":"set -ex"},{"line_number":128,"context_line":"# do not zap journal if there are still old journal partitions in the process of"},{"line_number":129,"context_line":"# being cleaned up or if the disk is already clean to prevent a race condition"},{"line_number":130,"context_line":"ceph-disk list | egrep \u0027 *${journal}.*(other, unknown|ceph journal,)\u0027"},{"line_number":131,"context_line":"\","},{"line_number":132,"context_line":"            logoutput \u003d\u003e true,"},{"line_number":133,"context_line":"            timeout   \u003d\u003e $exec_timeout,"},{"line_number":134,"context_line":"          }"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5a3905b3_0269aebe","line":131,"range":{"start_line":126,"start_character":12,"end_line":131,"end_character":1},"updated":"2017-01-19 19:45:05.000000000","message":"Not sure to understand the logic behind this but if you have multiple journals on the same disk then they will never be erased.","commit_id":"38f596aa98e5343cfc674305c13352e01e43179b"},{"author":{"_account_id":14270,"name":"Dimitri Savineau","email":"dsavinea@redhat.com","username":"dsavineau"},"change_message_id":"fe1c56cabae1a537c3c078a3eaa1a256f0574923","unresolved":false,"context_lines":[{"line_number":138,"context_line":"          command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":139,"context_line":"set -ex"},{"line_number":140,"context_line":"if [ -b ${data} ]; then"},{"line_number":141,"context_line":"  sgdisk -Z ${data}"},{"line_number":142,"context_line":"  sgdisk -g ${data}"},{"line_number":143,"context_line":"  partprobe"},{"line_number":144,"context_line":"fi"},{"line_number":145,"context_line":"\","},{"line_number":146,"context_line":"          unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5a3905b3_7fee8d8c","line":143,"range":{"start_line":141,"start_character":0,"end_line":143,"end_character":11},"updated":"2017-01-19 19:45:05.000000000","message":"same as the first comment above","commit_id":"38f596aa98e5343cfc674305c13352e01e43179b"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"c04e3f448861e0319422f1505db47bc7e11205c9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"# [*fsid*] The ceph cluster FSID"},{"line_number":49,"context_line":"#   Optional. Defaults to $::ceph::profile::params::fsid"},{"line_number":50,"context_line":"#"},{"line_number":51,"context_line":"# [*zap_disks*] Whether ceph OSD and journal disks should be zapped"},{"line_number":52,"context_line":"#   Optional. Defaults to $::ceph::profile::params::zap_disks"},{"line_number":53,"context_line":"#"},{"line_number":54,"context_line":"define ceph::osd ("}],"source_content_type":"text/x-puppet","patch_set":10,"id":"5a3905b3_8df3020a","line":51,"updated":"2017-01-20 00:03:06.000000000","message":"The param isn\u0027t added to this class","commit_id":"4575aeac3c73e4eff33f1f2ca91d302706d4d1f1"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"d6a720531371c82188773deaae78507956844445","unresolved":false,"context_lines":[{"line_number":48,"context_line":"# [*fsid*] The ceph cluster FSID"},{"line_number":49,"context_line":"#   Optional. Defaults to $::ceph::profile::params::fsid"},{"line_number":50,"context_line":"#"},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"define ceph::osd ("},{"line_number":53,"context_line":"  $ensure \u003d present,"},{"line_number":54,"context_line":"  $journal \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"5a3905b3_52e35f05","line":51,"updated":"2017-01-20 11:42:30.000000000","message":"You might as well delete this line so that no change to osd.pp is part of this patch.","commit_id":"d4e679d7b9ab2ed4c5b8a7de14bd7bcb422cef37"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"ca9a0d55457ea8bf9838d7383254f0b028315918","unresolved":false,"context_lines":[{"line_number":93,"context_line":"\","},{"line_number":94,"context_line":"          unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":95,"context_line":"set -ex"},{"line_number":96,"context_line":"test $(parted -ms ${journal} p 2\u003e\u00261 | egrep -c \u0027Error.*unrecognised disk label\u0027) -eq 0 ||"},{"line_number":97,"context_line":"! test -b ${data}"},{"line_number":98,"context_line":"\","},{"line_number":99,"context_line":"          logoutput \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":27,"id":"3a461143_a5163053","line":96,"updated":"2017-02-02 10:33:41.000000000","message":"I still think it\u0027s easier to simply test like this:\n\ntest $(parted -ms /dev/vdb p | grep -sq \u0027Error.*unrecognised disk label\u0027)\n\ngrep -sq does the redirect for you and we test only the return code of the command with \u0027test\u0027.\n\nSee:\n\ntest $(parted -ms /dev/vdb p | grep -sq \u0027Error.*unrecognised disk label\u0027) ; echo $?\nError: /dev/vdb: unrecognised disk label\n1\n\nWhat do you think?","commit_id":"e4bece302a8486ae3f5b9daefbf5717df7a973f4"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"3840acd22e8342a205294779f5da3e3770adfa53","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      Ceph::Mon\u003c||\u003e -\u003e Exec[$ceph_prepare]"},{"line_number":82,"context_line":"      Ceph::Key\u003c||\u003e -\u003e Exec[$ceph_prepare]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"      if $journal {"},{"line_number":85,"context_line":"        $ceph_zap_journal \u003d \"ceph-osd-zap-${name}-${journal}\""},{"line_number":86,"context_line":"        Exec[$ceph_zap_osd] -\u003e Exec[$ceph_zap_journal]"},{"line_number":87,"context_line":"        Exec[$ceph_zap_journal] -\u003e Exec[$ceph_check_udev]"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"fa31d9ce_754e7397","line":84,"updated":"2017-02-13 12:31:36.000000000","message":"also I am not sure how this behaves if partitions are given to $journal and/or $data","commit_id":"108f5500adb38f5e8c2ddf271937ef184f57067a"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"421916f7b0a833698de2a016023a4181f4188339","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      Ceph::Mon\u003c||\u003e -\u003e Exec[$ceph_prepare]"},{"line_number":82,"context_line":"      Ceph::Key\u003c||\u003e -\u003e Exec[$ceph_prepare]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"      if $journal {"},{"line_number":85,"context_line":"        $ceph_zap_journal \u003d \"ceph-osd-zap-${name}-${journal}\""},{"line_number":86,"context_line":"        Exec[$ceph_zap_osd] -\u003e Exec[$ceph_zap_journal]"},{"line_number":87,"context_line":"        Exec[$ceph_zap_journal] -\u003e Exec[$ceph_check_udev]"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"fa31d9ce_5fed0524","line":84,"in_reply_to":"fa31d9ce_754e7397","updated":"2017-02-13 14:48:27.000000000","message":"If it is passed a partition instead of a full disk, then it will not zap.","commit_id":"108f5500adb38f5e8c2ddf271937ef184f57067a"}],"manifests/osds.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"38e45f19a3a692c6b78e9d1cdace16914cf09dc1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#   recovery. The recommended value is the absolute max for pid_max: 4194303"},{"line_number":34,"context_line":"#   http://docs.ceph.com/docs/jewel/rados/troubleshooting/troubleshooting-osd/"},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*zap_disks*] Whether ceph OSD and journal disks should be zapped"},{"line_number":37,"context_line":"#   Optional. Defaults to $::ceph::profile::params::zap_disks"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"class ceph::osds("}],"source_content_type":"text/x-puppet","patch_set":14,"id":"5a3905b3_ad727ee3","line":36,"range":{"start_line":36,"start_character":15,"end_line":36,"end_character":16},"updated":"2017-01-20 00:12:59.000000000","message":"missing \"Boolean,\"","commit_id":"d39fd6a39e6d03a3d7197927864b321e9e007bde"}],"manifests/profile/params.pp":[{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"2221aa3942c4246c40ab46240c0cea8766e4bde3","unresolved":false,"context_lines":[{"line_number":187,"context_line":"#"},{"line_number":188,"context_line":"# [*rbd_default_features*] Set RBD features configuration."},{"line_number":189,"context_line":"#   Optional. String. Defaults to undef."},{"line_number":190,"context_line":"# "},{"line_number":191,"context_line":"# [*zap_disks*] Boolean to direct puppet to zap disks and journals"},{"line_number":192,"context_line":"#   Optional. Default is undef"},{"line_number":193,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a3c09a3_162084f6","line":190,"range":{"start_line":190,"start_character":0,"end_line":190,"end_character":2},"updated":"2017-01-17 19:49:53.000000000","message":"white space.","commit_id":"73bffe65e99ebfe3527856a33651b7b189a8f763"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"90bc86d419f5859bfc8de082df3802b7ce0ca0ef","unresolved":false,"context_lines":[{"line_number":187,"context_line":"#"},{"line_number":188,"context_line":"# [*rbd_default_features*] Set RBD features configuration."},{"line_number":189,"context_line":"#   Optional. String. Defaults to undef."},{"line_number":190,"context_line":"#"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"class ceph::profile::params ("},{"line_number":193,"context_line":"  $fsid \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"1a430d35_a5e07697","line":190,"updated":"2017-02-07 18:25:28.000000000","message":"might as well put it back to not have this file included in the change","commit_id":"995b50bad7eea8531c190302dc4d8d57dffb1909"}],"manifests/zap.pp":[{"author":{"_account_id":14270,"name":"Dimitri Savineau","email":"dsavinea@redhat.com","username":"dsavineau"},"change_message_id":"841dfe2db67c6837a256c6677da7546f21a010b5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"          command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":49,"context_line":"set -ex"},{"line_number":50,"context_line":"if [ -b ${journal} ]; then"},{"line_number":51,"context_line":"  ceph-disk zap ${journal} "},{"line_number":52,"context_line":"fi"},{"line_number":53,"context_line":"\","},{"line_number":54,"context_line":"          unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"5a3905b3_5eb62add","line":51,"updated":"2017-01-19 22:05:10.000000000","message":"empty char at the end of the line","commit_id":"4575aeac3c73e4eff33f1f2ca91d302706d4d1f1"},{"author":{"_account_id":14270,"name":"Dimitri Savineau","email":"dsavinea@redhat.com","username":"dsavineau"},"change_message_id":"841dfe2db67c6837a256c6677da7546f21a010b5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":65,"context_line":"set -ex"},{"line_number":66,"context_line":"if [ -b ${data} ]; then"},{"line_number":67,"context_line":"  ceph-disk zap ${data} "},{"line_number":68,"context_line":"fi"},{"line_number":69,"context_line":"\","},{"line_number":70,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"5a3905b3_7ebbe6c4","line":67,"updated":"2017-01-19 22:05:10.000000000","message":"empty char at the end of the line","commit_id":"4575aeac3c73e4eff33f1f2ca91d302706d4d1f1"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"d6a720531371c82188773deaae78507956844445","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":66,"context_line":"set -ex"},{"line_number":67,"context_line":"if [ -b ${data} ]; then"},{"line_number":68,"context_line":"  ceph-disk zap ${data}"},{"line_number":69,"context_line":"fi"},{"line_number":70,"context_line":"\","},{"line_number":71,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"5a3905b3_72e69bb5","line":68,"updated":"2017-01-20 11:42:30.000000000","message":"I see you moved to \u0027ceph-disk zap\u0027 from the variations of sgdisk. Just wanted to report that with this change, that the test I ran earlier (which lead to patch set 9) still passes. To clarify: I can pass different FSIDs but if the zap param is passed, then I do not fail by the fsid-mismatch check.","commit_id":"d4e679d7b9ab2ed4c5b8a7de14bd7bcb422cef37"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"4395c34b7830079203d7740e485b826313cc7965","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#   Copyright (C) 2014 Cloudwatt \u003clibre.licensing@cloudwatt.com\u003e"},{"line_number":3,"context_line":"#   Copyright (C) 2014 Nine Internet Solutions AG"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":"#   you may not use this file except in compliance with the License."}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a3905b3_8be1f700","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":49},"updated":"2017-01-20 19:54:39.000000000","message":"copyright is 2017 Your Company\n\nSince its net new content, you can drop the other companies","commit_id":"722ce8e374c8c1071113d3d56ff1610724acd581"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b8ab1a4256333150cde8d93e4323eca2473f1ef6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"          command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":55,"context_line":"set -ex"},{"line_number":56,"context_line":"if [ -b ${journal} ]; then"},{"line_number":57,"context_line":"  ceph-disk zap ${journal}"},{"line_number":58,"context_line":"fi"},{"line_number":59,"context_line":"\","},{"line_number":60,"context_line":"          unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3a461143_b503e20c","line":57,"updated":"2017-01-25 13:58:57.000000000","message":"what happens if user gave a partition as journal device (or data device for line73), will the zap return error or just silently exit?","commit_id":"4e9a43aa070c76ea0c627e44ec29916d3f37da42"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b8ab1a4256333150cde8d93e4323eca2473f1ef6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\","},{"line_number":60,"context_line":"          unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":61,"context_line":"set -ex"},{"line_number":62,"context_line":"ceph-disk list | egrep \u0027 *${journal}.*(other, unknown|ceph journal,)\u0027"},{"line_number":63,"context_line":"\","},{"line_number":64,"context_line":"          logoutput \u003d\u003e true,"},{"line_number":65,"context_line":"          timeout   \u003d\u003e $exec_timeout,"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3a461143_55347edd","line":62,"updated":"2017-01-25 13:58:57.000000000","message":"can you explain me again what is the scenario in which we get a \"other, unknown\" result?","commit_id":"4e9a43aa070c76ea0c627e44ec29916d3f37da42"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"4f72519a005721de65f2239350ddd4c24b2a3fe1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\","},{"line_number":60,"context_line":"          unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":61,"context_line":"set -ex"},{"line_number":62,"context_line":"ceph-disk list | egrep \u0027 *${journal}.*(other, unknown|ceph journal,)\u0027"},{"line_number":63,"context_line":"\","},{"line_number":64,"context_line":"          logoutput \u003d\u003e true,"},{"line_number":65,"context_line":"          timeout   \u003d\u003e $exec_timeout,"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3a461143_7a5f5e41","line":62,"in_reply_to":"3a461143_01a8d11e","updated":"2017-01-26 22:09:05.000000000","message":"ceph-disk list is used in other parts of puppet-ceph but parted is not, so using ceph-disk list here is consistent with the rest of puppet-ceph. \n\nIf we\u0027re going to switch from ceph-disk list to parted, and I believe you that it\u0027s faster, then I think we should do so under a separate bug.","commit_id":"4e9a43aa070c76ea0c627e44ec29916d3f37da42"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"e547589b0764a068ee68002212590828c49c16e1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\","},{"line_number":60,"context_line":"          unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":61,"context_line":"set -ex"},{"line_number":62,"context_line":"ceph-disk list | egrep \u0027 *${journal}.*(other, unknown|ceph journal,)\u0027"},{"line_number":63,"context_line":"\","},{"line_number":64,"context_line":"          logoutput \u003d\u003e true,"},{"line_number":65,"context_line":"          timeout   \u003d\u003e $exec_timeout,"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3a461143_01a8d11e","line":62,"in_reply_to":"3a461143_55347edd","updated":"2017-01-26 09:43:28.000000000","message":"using ceph-disk list is usually really slow, I\u0027d rather use \u0027parted\u0027 for this simple task.","commit_id":"4e9a43aa070c76ea0c627e44ec29916d3f37da42"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"02537f25d05d6d143c71803c56ecd7639a744564","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\","},{"line_number":60,"context_line":"          unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":61,"context_line":"set -ex"},{"line_number":62,"context_line":"ceph-disk list | egrep \u0027 *${journal}.*(other, unknown|ceph journal,)\u0027"},{"line_number":63,"context_line":"\","},{"line_number":64,"context_line":"          logoutput \u003d\u003e true,"},{"line_number":65,"context_line":"          timeout   \u003d\u003e $exec_timeout,"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3a461143_d13f42d4","line":62,"in_reply_to":"3a461143_7a5f5e41","updated":"2017-01-27 10:42:27.000000000","message":"Alright, for consistency sake it makes sense to keep it that way.\nJust to give you an insight of the gain:\n\nroot@ceph-osd-01:/# time ceph-disk list | egrep \u0027 */dev/vdb2.*(other, unknown|ceph journal,)\u0027\n /dev/vdb2 ceph journal, for /dev/vdb1\n\nreal    0m1.145s\nuser    0m0.336s\nsys     0m0.754s\nroot@ceph-osd-01:/# time parted /dev/vdb print | egrep \u0027^ 2.*ceph journal\u0027\n 2      1049kB  106MB   105MB                ceph journal\n\nreal    0m0.025s\nuser    0m0.004s\nsys     0m0.006s","commit_id":"4e9a43aa070c76ea0c627e44ec29916d3f37da42"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"b9fa9be9f74dd8c46cb6113d68fd12668a074eb4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\","},{"line_number":60,"context_line":"          unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":61,"context_line":"set -ex"},{"line_number":62,"context_line":"test $(parted -m ${journal} p 2\u003e\u00261 | egrep -c \u0027Error.*unrecognised disk label\u0027) -eq 0"},{"line_number":63,"context_line":"#ceph-disk list | egrep \u0027 *${journal}.*(other, unknown|ceph journal,)\u0027"},{"line_number":64,"context_line":"\","},{"line_number":65,"context_line":"          logoutput \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"3a461143_8f933900","line":62,"updated":"2017-02-01 13:21:59.000000000","message":"I think you might need to use \u0027-s\u0027 to enter script mode, otherwise parted will prompt stuff. You also don\u0027t need to redirect, I believe this is easier:\n\nparted -s -m ${journal} p |\u0026 grep -sq \u0027Error.*unrecognised disk label\u0027","commit_id":"9362b22dd811038649a51f1192cc7ce8ffc504a6"}],"releasenotes/notes/ceph-zap-7e39c63f83697e2f.yaml":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"90bc86d419f5859bfc8de082df3802b7ce0ca0ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"1a430d35_c59662ef","updated":"2017-02-07 18:25:28.000000000","message":"Please update, or remove the reno","commit_id":"995b50bad7eea8531c190302dc4d8d57dffb1909"}],"spec/defines/ceph_zap_spec.rb":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"4395c34b7830079203d7740e485b826313cc7965","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#   Copyright (C) 2014 Cloudwatt \u003clibre.licensing@cloudwatt.com\u003e"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"#   you may not use this file except in compliance with the License."}],"source_content_type":"text/x-ruby","patch_set":21,"id":"5a3905b3_abcf937d","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":64},"updated":"2017-01-20 19:54:39.000000000","message":"Copyright is 2017 Your company, if a lot of this was copied and is the same as a previous file, then add your copyright and leave this one.","commit_id":"722ce8e374c8c1071113d3d56ff1610724acd581"}]}