)]}'
{"manifests/rgw.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"1e6de921d3bab542d70952b71747c99fe614f982","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    fail(\"Unsupported frontend_type: ${frontend_type}\")"},{"line_number":138,"context_line":"  }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  if( $rgw_zone )"},{"line_number":141,"context_line":"  {"},{"line_number":142,"context_line":"    \"client.${name}/rgw_zone\": value \u003d\u003e $rgw_zone;"},{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  if( $rgw_region )"},{"line_number":146,"context_line":"  {"},{"line_number":147,"context_line":"    \"client.${name}/rgw_region\": value \u003d\u003e $rgw_region;"},{"line_number":148,"context_line":"  }"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  package { $pkg_radosgw:"},{"line_number":151,"context_line":"    ensure \u003d\u003e installed,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a430d35_c5758298","line":148,"range":{"start_line":140,"start_character":0,"end_line":148,"end_character":3},"updated":"2017-02-07 18:06:35.000000000","message":"the inifile provider will not add the stanza to the config if the value provided is undef. In that regard, you don\u0027t need to if them, you can simply include them @L106","commit_id":"308bcc2da97879c7e821558af39b6e4cf824d707"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"f81c960f5f5a334b3c907e61a74fc02d398be34a","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    fail(\"Unsupported frontend_type: ${frontend_type}\")"},{"line_number":138,"context_line":"  }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  if( $rgw_zone )"},{"line_number":141,"context_line":"  {"},{"line_number":142,"context_line":"    \"client.${name}/rgw_zone\": value \u003d\u003e $rgw_zone;"},{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  if( $rgw_region )"},{"line_number":146,"context_line":"  {"},{"line_number":147,"context_line":"    \"client.${name}/rgw_region\": value \u003d\u003e $rgw_region;"},{"line_number":148,"context_line":"  }"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  package { $pkg_radosgw:"},{"line_number":151,"context_line":"    ensure \u003d\u003e installed,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a430d35_856a9a7f","line":148,"range":{"start_line":140,"start_character":0,"end_line":148,"end_character":3},"in_reply_to":"1a430d35_c5758298","updated":"2017-02-07 18:09:56.000000000","message":"I forgot. That ini provider is very useful.","commit_id":"308bcc2da97879c7e821558af39b6e4cf824d707"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"9d3369aced8587e23f01e98cba293a8b39767cd9","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    \"client.${name}/keyring\":            value \u003d\u003e $keyring_path;"},{"line_number":105,"context_line":"    \"client.${name}/log_file\":           value \u003d\u003e $log_file;"},{"line_number":106,"context_line":"    \"client.${name}/user\":               value \u003d\u003e $user;"},{"line_number":107,"context_line":"    \"client.${name}/rgw_zone\": value \u003d\u003e $rgw_zone;"},{"line_number":108,"context_line":"    \"client.${name}/rgw_region\": value \u003d\u003e $rgw_region;"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a430d35_e5c0be52","line":107,"range":{"start_line":107,"start_character":31,"end_line":107,"end_character":49},"updated":"2017-02-07 18:13:24.000000000","message":"please align, will fail rspec","commit_id":"1bba54436b2bcab7b402cba33d562cb967792437"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"9d3369aced8587e23f01e98cba293a8b39767cd9","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    \"client.${name}/log_file\":           value \u003d\u003e $log_file;"},{"line_number":106,"context_line":"    \"client.${name}/user\":               value \u003d\u003e $user;"},{"line_number":107,"context_line":"    \"client.${name}/rgw_zone\": value \u003d\u003e $rgw_zone;"},{"line_number":108,"context_line":"    \"client.${name}/rgw_region\": value \u003d\u003e $rgw_region;"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  if($frontend_type \u003d\u003d \u0027civetweb\u0027)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a430d35_45d0b21f","line":108,"range":{"start_line":108,"start_character":33,"end_line":108,"end_character":53},"updated":"2017-02-07 18:13:24.000000000","message":"same","commit_id":"1bba54436b2bcab7b402cba33d562cb967792437"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"933899b92949924dcdbea739c78ad5307e8465d4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"# [*syslog*] Whether or not to log to syslog."},{"line_number":68,"context_line":"#   Optional. Default is true."},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"define ceph::rgw ("},{"line_number":72,"context_line":"  $pkg_radosgw        \u003d $::ceph::params::pkg_radosgw,"},{"line_number":73,"context_line":"  $rgw_ensure         \u003d \u0027running\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"da36d5c6_312a782d","line":70,"updated":"2017-02-21 08:26:28.000000000","message":"empty line","commit_id":"c867c970be0fb0a6abf4a9fdf8d62d9d514c5a4d"}],"manifests/rgw/replication.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"42890baaa5296784e6c6f58f71fdcc851eea76bb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  $rgw_realm             \u003d \u0027openstack\u0027,"},{"line_number":40,"context_line":"  $rgw_zone_group        \u003d \u0027overcloud\u0027,"},{"line_number":41,"context_line":"  $rgw_zone              \u003d $facts[\u0027hostname\u0027],"},{"line_number":42,"context_line":"  $rgw_system_access_key \u003d undef,"},{"line_number":43,"context_line":"  $rgw_system_secret_key \u003d undef,"},{"line_number":44,"context_line":"  $rgw_port              \u003d \u00278080\u0027,"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"da36d5c6_04797ef6","line":42,"updated":"2017-02-22 14:08:14.000000000","message":"we could remove the default undef values here I think","commit_id":"3b2ed8f8dac92e362caa1b5009de8b8fa539c37c"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0679242ba1c86825e7d8b8cd2afc364d353a2b36","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  $rgw_realm             \u003d \u0027openstack\u0027,"},{"line_number":40,"context_line":"  $rgw_zone_group        \u003d \u0027overcloud\u0027,"},{"line_number":41,"context_line":"  $rgw_zone              \u003d $facts[\u0027hostname\u0027],"},{"line_number":42,"context_line":"  $rgw_system_access_key \u003d undef,"},{"line_number":43,"context_line":"  $rgw_system_secret_key \u003d undef,"},{"line_number":44,"context_line":"  $rgw_port              \u003d \u00278080\u0027,"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"da36d5c6_2fa2dbae","line":42,"in_reply_to":"da36d5c6_04797ef6","updated":"2017-02-22 18:20:32.000000000","message":"Done","commit_id":"3b2ed8f8dac92e362caa1b5009de8b8fa539c37c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"42890baaa5296784e6c6f58f71fdcc851eea76bb","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    exec { \"rgw-zonegroup-create-${name}\":"},{"line_number":86,"context_line":"      command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":87,"context_line":"set -ex"},{"line_number":88,"context_line":"radosgw-admin zonegroup create --rgw-zonegroup\u003d${rgw_zone_group} --endpoints\u003dhttp://${::hostname}:${rgw_port} --master --default"},{"line_number":89,"context_line":"\","},{"line_number":90,"context_line":"      unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":91,"context_line":"radosgw-admin zonegroup list | grep -q \\\"${rgw_zone_group}\\\""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"da36d5c6_4461b638","line":88,"updated":"2017-02-22 14:08:14.000000000","message":"I think this should be the keystone vip not the hostname","commit_id":"3b2ed8f8dac92e362caa1b5009de8b8fa539c37c"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0679242ba1c86825e7d8b8cd2afc364d353a2b36","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    exec { \"rgw-zonegroup-create-${name}\":"},{"line_number":86,"context_line":"      command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":87,"context_line":"set -ex"},{"line_number":88,"context_line":"radosgw-admin zonegroup create --rgw-zonegroup\u003d${rgw_zone_group} --endpoints\u003dhttp://${::hostname}:${rgw_port} --master --default"},{"line_number":89,"context_line":"\","},{"line_number":90,"context_line":"      unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":91,"context_line":"radosgw-admin zonegroup list | grep -q \\\"${rgw_zone_group}\\\""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"da36d5c6_6fa05344","line":88,"in_reply_to":"da36d5c6_4461b638","updated":"2017-02-22 18:20:32.000000000","message":"Done. I made this a puppet parameter with the default being the localhost.","commit_id":"3b2ed8f8dac92e362caa1b5009de8b8fa539c37c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"42890baaa5296784e6c6f58f71fdcc851eea76bb","unresolved":false,"context_lines":[{"line_number":129,"context_line":"      tag       \u003d\u003e \u0027period-update\u0027,"},{"line_number":130,"context_line":"    }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    Ceph::Pool\u003c||\u003e -\u003e"},{"line_number":133,"context_line":"      Exec\u003c| tag \u003d\u003d \u0027realm-create\u0027 |\u003e -\u003e"},{"line_number":134,"context_line":"      Exec\u003c| tag \u003d\u003d \u0027zone-group-create\u0027 |\u003e -\u003e"},{"line_number":135,"context_line":"      Exec\u003c| tag \u003d\u003d \u0027zone-create\u0027 |\u003e -\u003e"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"da36d5c6_c455a650","line":132,"updated":"2017-02-22 14:08:14.000000000","message":"I would prefer to make this depend on Ceph::Rgw so we make sure this starts after ::rgw finished","commit_id":"3b2ed8f8dac92e362caa1b5009de8b8fa539c37c"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0679242ba1c86825e7d8b8cd2afc364d353a2b36","unresolved":false,"context_lines":[{"line_number":129,"context_line":"      tag       \u003d\u003e \u0027period-update\u0027,"},{"line_number":130,"context_line":"    }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    Ceph::Pool\u003c||\u003e -\u003e"},{"line_number":133,"context_line":"      Exec\u003c| tag \u003d\u003d \u0027realm-create\u0027 |\u003e -\u003e"},{"line_number":134,"context_line":"      Exec\u003c| tag \u003d\u003d \u0027zone-group-create\u0027 |\u003e -\u003e"},{"line_number":135,"context_line":"      Exec\u003c| tag \u003d\u003d \u0027zone-create\u0027 |\u003e -\u003e"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"da36d5c6_89de5a6b","line":132,"in_reply_to":"da36d5c6_c455a650","updated":"2017-02-22 18:20:32.000000000","message":"I have been ale to update the rgw-period-update-${name} exec to notify the RGW Service by name.","commit_id":"3b2ed8f8dac92e362caa1b5009de8b8fa539c37c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"42890baaa5296784e6c6f58f71fdcc851eea76bb","unresolved":false,"context_lines":[{"line_number":160,"context_line":"      tag       \u003d\u003e \u0027zone-create\u0027,"},{"line_number":161,"context_line":"    }"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    Ceph::Pool\u003c||\u003e -\u003e"},{"line_number":164,"context_line":"      Exec\u003c| tag \u003d\u003d \u0027realm-pull\u0027 |\u003e -\u003e"},{"line_number":165,"context_line":"      Exec\u003c| tag \u003d\u003d \u0027zone-create\u0027 |\u003e ~\u003e Service\u003c| tag \u003d\u003d \u0027ceph-radosgw\u0027 |\u003e"},{"line_number":166,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"da36d5c6_04509e5c","line":163,"updated":"2017-02-22 14:08:14.000000000","message":"here too","commit_id":"3b2ed8f8dac92e362caa1b5009de8b8fa539c37c"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0679242ba1c86825e7d8b8cd2afc364d353a2b36","unresolved":false,"context_lines":[{"line_number":160,"context_line":"      tag       \u003d\u003e \u0027zone-create\u0027,"},{"line_number":161,"context_line":"    }"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    Ceph::Pool\u003c||\u003e -\u003e"},{"line_number":164,"context_line":"      Exec\u003c| tag \u003d\u003d \u0027realm-pull\u0027 |\u003e -\u003e"},{"line_number":165,"context_line":"      Exec\u003c| tag \u003d\u003d \u0027zone-create\u0027 |\u003e ~\u003e Service\u003c| tag \u003d\u003d \u0027ceph-radosgw\u0027 |\u003e"},{"line_number":166,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"da36d5c6_c9e85213","line":163,"in_reply_to":"da36d5c6_04509e5c","updated":"2017-02-22 18:20:32.000000000","message":"same.","commit_id":"3b2ed8f8dac92e362caa1b5009de8b8fa539c37c"}],"spec/defines/ceph_rgw_replication.rb":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"933899b92949924dcdbea739c78ad5307e8465d4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      it { is_expected.to contain_exec(\u0027rgw-zone-create-myhost\u0027).with("},{"line_number":56,"context_line":"         \u0027command\u0027 \u003d\u003e \"/bin/true  # comment to satisfy puppet syntax requirements"},{"line_number":57,"context_line":"set -ex"},{"line_number":58,"context_line":"radosgw-admin zone create --rgw-zonegroup\u003dovercloud --rgw-zone\u003dus "},{"line_number":59,"context_line":"\","},{"line_number":60,"context_line":"      ) }"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"da36d5c6_b1682889","line":58,"range":{"start_line":58,"start_character":65,"end_line":58,"end_character":66},"updated":"2017-02-21 08:26:28.000000000","message":"empty space","commit_id":"c867c970be0fb0a6abf4a9fdf8d62d9d514c5a4d"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"933899b92949924dcdbea739c78ad5307e8465d4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"      it { is_expected.to contain_exec(\u0027rgw-zone-create-myhost\u0027).with("},{"line_number":115,"context_line":"         \u0027command\u0027 \u003d\u003e \"/bin/true  # comment to satisfy puppet syntax requirements"},{"line_number":116,"context_line":"set -ex"},{"line_number":117,"context_line":"radosgw-admin zone create --rgw-zonegroup\u003dmyzonegroup --rgw-zone\u003dmyzone "},{"line_number":118,"context_line":"\","},{"line_number":119,"context_line":"      ) }"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"da36d5c6_11101401","line":117,"range":{"start_line":117,"start_character":71,"end_line":117,"end_character":72},"updated":"2017-02-21 08:26:28.000000000","message":"empty space","commit_id":"c867c970be0fb0a6abf4a9fdf8d62d9d514c5a4d"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"933899b92949924dcdbea739c78ad5307e8465d4","unresolved":false,"context_lines":[{"line_number":242,"context_line":"      it { is_expected.to contain_exec(\u0027rgw-zone-create-myhost\u0027).with("},{"line_number":243,"context_line":"         \u0027command\u0027 \u003d\u003e \"/bin/true  # comment to satisfy puppet syntax requirements"},{"line_number":244,"context_line":"set -ex"},{"line_number":245,"context_line":"radosgw-admin zone create --rgw-zonegroup\u003dovercloud --rgw-zone\u003dus "},{"line_number":246,"context_line":"\","},{"line_number":247,"context_line":"      ) }"},{"line_number":248,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"da36d5c6_51fa8cbe","line":245,"range":{"start_line":245,"start_character":65,"end_line":245,"end_character":66},"updated":"2017-02-21 08:26:28.000000000","message":"empty space","commit_id":"c867c970be0fb0a6abf4a9fdf8d62d9d514c5a4d"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"933899b92949924dcdbea739c78ad5307e8465d4","unresolved":false,"context_lines":[{"line_number":301,"context_line":"      it { is_expected.to contain_exec(\u0027rgw-zone-create-myhost\u0027).with("},{"line_number":302,"context_line":"         \u0027command\u0027 \u003d\u003e \"/bin/true  # comment to satisfy puppet syntax requirements"},{"line_number":303,"context_line":"set -ex"},{"line_number":304,"context_line":"radosgw-admin zone create --rgw-zonegroup\u003dmyzonegroup --rgw-zone\u003dmyzone "},{"line_number":305,"context_line":"\","},{"line_number":306,"context_line":"      ) }"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"da36d5c6_71f5d0c9","line":304,"range":{"start_line":304,"start_character":71,"end_line":304,"end_character":72},"updated":"2017-02-21 08:26:28.000000000","message":"empty space","commit_id":"c867c970be0fb0a6abf4a9fdf8d62d9d514c5a4d"}]}