)]}'
{"manifests/profile/mon.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e97390ce1901beb45f7b1af0e7b55cb6e41fc310","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    inject_keyring \u003d\u003e \"/var/lib/ceph/mon/ceph-${::hostname}/keyring\","},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  Ceph::Keys {"},{"line_number":42,"context_line":"    defaults \u003d\u003e $defaults,"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bff0334d_87c0a552","line":41,"updated":"2017-04-05 15:38:35.000000000","message":"call for help guys, I am trying to set a default for the Ceph::Keys class here, why is it failing with \"type not found: Ceph::Keys\" ?\n\ndo I need to include the class itself here for the reference to work?\n\n1. http://logs.openstack.org/27/446227/9/check/gate-puppet-ceph-puppet-unit-4.5-centos-7/15e68fa/console.html#_2017-03-29_11_15_14_621639","commit_id":"a42694c632fbe42d7e7a7547e1414505305ac85d"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2dec67f83cb78c96c48829c0b368e957cd5f11b8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    inject_keyring \u003d\u003e \"/var/lib/ceph/mon/ceph-${::hostname}/keyring\","},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  Ceph::Keys {"},{"line_number":42,"context_line":"    defaults \u003d\u003e $defaults,"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bff0334d_1d94e443","line":41,"in_reply_to":"bff0334d_0acc9c87","updated":"2017-04-05 16:15:16.000000000","message":"I see, I am trying to solve a bug caused by use of !defined in client.pp, which also doesn\u0027t work well as it depends on parsing order and causes duplicate resource declarations when profile::client is required before profile::mon","commit_id":"a42694c632fbe42d7e7a7547e1414505305ac85d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"494087cce9d9568391f9577881b62ab1c0478deb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    inject_keyring \u003d\u003e \"/var/lib/ceph/mon/ceph-${::hostname}/keyring\","},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  Ceph::Keys {"},{"line_number":42,"context_line":"    defaults \u003d\u003e $defaults,"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bff0334d_fb9148f3","line":41,"in_reply_to":"bff0334d_1d94e443","updated":"2017-04-05 17:05:09.000000000","message":"So it seems to be a problem with the way this is defined. Since defaults are not used in client, it seems like a better idea to drop the class definition from client and only do it where it gets consumed.  I think we need a new ::ceph::profile::keys that inherits ceph::profile::params and can be included in ceph::profile::keys and we can pass defaults here.","commit_id":"a42694c632fbe42d7e7a7547e1414505305ac85d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"710d92ac1a0900dbeb2684ec44cba9a858373282","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    inject_keyring \u003d\u003e \"/var/lib/ceph/mon/ceph-${::hostname}/keyring\","},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  Ceph::Keys {"},{"line_number":42,"context_line":"    defaults \u003d\u003e $defaults,"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bff0334d_0acc9c87","line":41,"in_reply_to":"bff0334d_87c0a552","updated":"2017-04-05 15:59:11.000000000","message":"Yea there\u0027s a scope problem. This is not a good practice.  You could use a spaceship operator to do this  but it\u0027s not a good idea.  What exactly are you trying to do here?","commit_id":"a42694c632fbe42d7e7a7547e1414505305ac85d"}]}