)]}'
{"manifests/osd.pp":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"19106ce23bc9b8765707e40177add54632f16727","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":137,"context_line":"set -ex"},{"line_number":138,"context_line":"disk\u003d$(readlink -f ${data})"},{"line_number":139,"context_line":"ceph-disk list | egrep \\\" *(\\${disk}1|\\${disk}p1)? .*ceph data, (prepared|active)\\\" ||"},{"line_number":140,"context_line":"{ test -f \\$disk/fsid \u0026\u0026 test -f \\$disk/ceph_fsid \u0026\u0026 test -f \\$disk/magic ;}"},{"line_number":141,"context_line":"\","},{"line_number":142,"context_line":"        logoutput \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1f013ff3_025a0c4e","line":139,"range":{"start_line":139,"start_character":49,"end_line":139,"end_character":50},"updated":"2017-05-16 15:10:08.000000000","message":"I made a mistake here. I don\u0027t want 0 or 1 of the full expression within the parens. Revision coming.","commit_id":"a00e301701166af1fedacf1fe79188ff1a1a97c9"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"4493cb01fcf057405c5350121524fca396b6e38c","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        unless    \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":137,"context_line":"set -ex"},{"line_number":138,"context_line":"disk\u003d$(readlink -f ${data})"},{"line_number":139,"context_line":"ceph-disk list | egrep \\\" *(\\${disk}1?|\\${disk}p1?) .*ceph data, (prepared|active)\\\" ||"},{"line_number":140,"context_line":"{ test -f \\$disk/fsid \u0026\u0026 test -f \\$disk/ceph_fsid \u0026\u0026 test -f \\$disk/magic ;}"},{"line_number":141,"context_line":"\","},{"line_number":142,"context_line":"        logoutput \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f013ff3_adf34973","line":139,"updated":"2017-05-16 15:29:49.000000000","message":"Want to explain this regex and how it was changed.\n\nOriginal:\n\nceph-disk list | egrep \" *${disk}1? .*ceph data, (prepared|active)\"\n                        ^^   ^   ^^ \n\t\t\t|/   |   |/\n\t\t\t|    |   |\n\t\t\t|    |   |\n\t\t\t|    |   +--- 0 xor 1 \"1\"\n\t\t\t|    |\t \t\t\n\t\t\t|    +--- e.g. /dev/sdb\n\t\t\t|\n\t\t\t+---- 0 or more spaces\n\n\nThe bug is that /dev/nvme0n1 matches but it shouldn\u0027t count; only /dev/nvme0n1p1 should\n\nFix: \n\nceph-disk list | egrep \" *(${disk}1?|${disk}p1?) .*ceph data, (prepared|active)\"\n                        ^^    ^   ^^^   ^   ^^^\n\t\t\t|/    |   |/|   |   \\|/\n\t\t\t|     |   | |   |    |\n\t\t\t|     |   | |   |    +------ 0 xor 1 \"p1\" (to capture \"/dev/nvme0n1p1\")\n\t\t\t|     |   | |\t| \n\t\t\t|     |   | |\t+--- e.g. /dev/nvme0n1\n\t\t\t|     |   | |\n\t\t\t|     |   | +------ OR \n\t\t\t|     |   |\t\t\t\t\t\t\t\n\t\t\t|     |   +--- 0 xor 1 \"1\" (to capture \"/dev/sdb1\")\n\t\t\t|     |\t \t\t\n\t\t\t|     +--- e.g. /dev/sdb\n\t\t\t|\n\t\t\t+---- 0 or more spaces\n\nThe examples above have /dev/sdb and /dev/nvme0n1; they will be on both\nsides of the regex alternative but won\u0027t match when they shouldn\u0027t\nbecause /dev/sdbp1 won\u0027t and neither will /dev/nvme0n11.","commit_id":"13241473c144931de8e609f60f1a74c781c92d9d"}],"releasenotes/notes/support-nvme0n1-as-osd-46e4a00ec699f718.yaml":[{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"e65a3119dfbc291c725de999d7d24a49fca29a39","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Bug 1687114 puppet-ceph does not configure devices like /dev/nvme0n1 as OSDs (only as journals)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f013ff3_b57cabeb","line":3,"range":{"start_line":3,"start_character":55,"end_line":3,"end_character":80},"updated":"2017-05-16 18:07:21.000000000","message":"Do you want to add /dev/cciss/c0d0 HP disks as part of the rel note? Your patch looks like it will cover those disks too.","commit_id":"818b015c3465738bc3bc665ea70ee3a0e4a3c829"}],"spec/defines/ceph_osd_spec.rb":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"4493cb01fcf057405c5350121524fca396b6e38c","unresolved":false,"context_lines":[{"line_number":178,"context_line":"      ) }"},{"line_number":179,"context_line":"    end"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    describe \"with NVMe param\" do"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"      let :title do"},{"line_number":184,"context_line":"        \u0027/dev/nvme0n1\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1f013ff3_8db88d76","line":181,"updated":"2017-05-16 15:29:49.000000000","message":"This revised version passed my local testing: \n\n  Finished in 2 minutes 49.5 seconds (files took 14.65 seconds to load)\n  903 examples, 0 failures\n\nProvided that I ran it like this: \n\n  bundle exec rake spec_clean\n  bundle exec rake spec_prep\n  pushd spec/fixtures/modules/concat\n  git checkout 5c4a9141d08a7b23dcada029d23b82590632d0f4\n  popd\n  pushd spec/fixtures/modules/apt\n  git checkout 3f6863ac4c97f834bebc811852452b073d202682\n  popd\n  bundle exec rake spec_standalone\n\nTo workaround problems introduced by: \n\n  https://github.com/openstack/puppet-openstack-integration/commit/2b57a24d35a833ce543e139c2d04bcb229d1a0be\n  https://github.com/openstack/puppet-openstack-integration/commit/c87bea7761f3ef50fb05bf934ec5842edd989a88\n\nI am waiting for the bot to update so that gate-puppet-ceph-puppet-unit-4.5-centos-7 can pass.","commit_id":"13241473c144931de8e609f60f1a74c781c92d9d"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"e65a3119dfbc291c725de999d7d24a49fca29a39","unresolved":false,"context_lines":[{"line_number":178,"context_line":"      ) }"},{"line_number":179,"context_line":"    end"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    describe \"with NVMe param\" do"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"      let :title do"},{"line_number":184,"context_line":"        \u0027/dev/nvme0n1\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1f013ff3_955c0f7f","line":181,"range":{"start_line":181,"start_character":14,"end_line":181,"end_character":29},"updated":"2017-05-16 18:07:21.000000000","message":"Do you want to do the same with the /dev/cciss?","commit_id":"818b015c3465738bc3bc665ea70ee3a0e4a3c829"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"ce182bd381b092c953b38d25e1da67d660390009","unresolved":false,"context_lines":[{"line_number":178,"context_line":"      ) }"},{"line_number":179,"context_line":"    end"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    describe \"with NVMe param\" do"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"      let :title do"},{"line_number":184,"context_line":"        \u0027/dev/nvme0n1\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1f013ff3_cb1d5874","line":181,"range":{"start_line":181,"start_character":14,"end_line":181,"end_character":29},"in_reply_to":"1f013ff3_955c0f7f","updated":"2017-05-16 19:40:31.000000000","message":"Yes, I see it uses the same syntax as NVMe devices:\n\n http://man7.org/linux/man-pages/man4/cciss.4.html#FILES","commit_id":"818b015c3465738bc3bc665ea70ee3a0e4a3c829"}]}