)]}'
{"id":"openstack%2Fpuppet-ceph~495372","triplet_id":"openstack%2Fpuppet-ceph~master~Ic3df2af434527b40bb78d24561d5ed1d8334dd22","project":"openstack/puppet-ceph","branch":"master","hashtags":[],"change_id":"Ic3df2af434527b40bb78d24561d5ed1d8334dd22","subject":"Convert to use of well-maintained sysctl provider","status":"ABANDONED","created":"2017-08-18 16:33:58.000000000","updated":"2017-08-18 17:32:51.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b7b84fe5b630aafe755528a63f608a0d6f9ac7d5","_number":495372,"virtual_id_number":495372,"owner":{"_account_id":26695,"name":"Tom Downes","email":"tpdownes@gmail.com","username":"tpdownes"},"actions":{},"labels":{"Verified":{"all":[{"date":"2017-08-18 16:34:07.000000000","_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"date":"2017-08-18 16:38:41.000000000","_account_id":26695,"name":"Tom Downes","email":"tpdownes@gmail.com","username":"tpdownes"},{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26695,"name":"Tom Downes","email":"tpdownes@gmail.com","username":"tpdownes"},{"value":-1,"date":"2017-08-18 17:01:55.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":26695,"name":"Tom Downes","email":"tpdownes@gmail.com","username":"tpdownes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":26695,"name":"Tom Downes","email":"tpdownes@gmail.com","username":"tpdownes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-18 16:34:07.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2017-08-18 17:01:55.000000000","updated_by":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"reviewer":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"state":"REVIEWER"}],"messages":[{"id":"0b6cab6dd4fb460194bf8243120ff226da439a16","author":{"_account_id":26695,"name":"Tom Downes","email":"tpdownes@gmail.com","username":"tpdownes"},"date":"2017-08-18 16:33:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a5e1b4d4be87b9eddf889993687fc894dea75b1e","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2017-08-18 16:34:07.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"5ebbb9565f048a08a95f31918d7ebaa830be33fd","author":{"_account_id":26695,"name":"Tom Downes","email":"tpdownes@gmail.com","username":"tpdownes"},"date":"2017-08-18 16:38:41.000000000","message":"Patch Set 1:\n\nThe durtong/sysctl module you use has not been maintained in a couple years whereas herculesteam/augeasproviders_sysctl is actively developed and highly-reviewed. But the namespaces overlap.\n\nIn fact, I\u0027m switching from a sysctl module that I maintain (tpdownes/sysctl) in favor of this.\n\naugeasproviders_sysctl depends on herculesteam/augeasproviders_core so this introduces 2 new modules that must be installed while removing duritong/sysctl.\n\nI\u0027m not sure if this also requires changes in CI tests you might be performing.","accounts_in_message":[],"_revision_number":1},{"id":"87d925982cdd033e7ca9a34aa070c0c3ee4c0777","author":{"_account_id":8971,"name":"Fuel CI","username":"fuel-ci","inactive":true,"tags":["SERVICE_USER"]},"date":"2017-08-18 16:53:54.000000000","message":"Patch Set 1:\n\nBuild Failed \n\n* master.puppet-openstack.fuel-library.pkgs.ubuntu.review_in_fuel_library https://ci.fuel-infra.org/job/master.puppet-openstack.fuel-library.pkgs.ubuntu.review_in_fuel_library/8608/ : FAILURE\n\n* master.puppet-openstack.fuel.noop https://ci.fuel-infra.org/job/master.puppet-openstack.fuel.noop/10789/ : FAILURE\n\n* master.puppet-openstack.fuel-library.pkgs.ubuntu.smoke_neutron https://ci.fuel-infra.org/job/master.puppet-openstack.fuel-library.pkgs.ubuntu.smoke_neutron/10672/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"5c052f81ba8189247fe3f7540e83ee08dba02605","author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"date":"2017-08-18 17:01:55.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nWe use the current sysctl module a lot http://codesearch.openstack.org/?q\u003dsysctl%3A%3Avalue\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d \n\nSince they conflict the namespace, and other modules that use sysctl are in the integration tests, I don\u0027t see this passing CI in the current state.\n\nYou\u0027d need to either create a case in the code here to switch between the two resource providers or the replacement module would need to be a valid drop in replacement. i.e. it also uses sysctl::value\n\nIf you post another revision, please include your basis comment you provided in the review as some color in the commit message so the other reviewers, and whoever is looking at the log has some details without coming back to the review.","accounts_in_message":[],"_revision_number":1},{"id":"eee4bcdd551233bc976d9e67017fc353dbf83695","author":{"_account_id":26695,"name":"Tom Downes","email":"tpdownes@gmail.com","username":"tpdownes"},"date":"2017-08-18 17:28:24.000000000","message":"Patch Set 1:\n\nI\u0027m not terribly familiar with gerrit but I uploaded a different patch with your reasonable suggestion to continue using ensure_resources. It looks like it spawned a new request so close this one I guess.\n\n\nThe fact of the matter is probably doesn\u0027t matter that much: the default parameters won\u0027t create the resource. It also so happens that I have another program installed which increase pid_max to your rec\u0027d value anyhow. So I could probably track your master without bothering to apply the patch.\n\nBut... if I were you, I\u0027d consider using a more widely-adopted module even if it requires a number of relatively simple changes from \"sysctl::value\" to \"sysctl\".  My experience was the lack of a proper \"sysctl\" class led to many issues in Puppet 4. That\u0027s what led me to write tpdownes/sysctl in the first place.\n\nhttps://forge.puppet.com/tpdownes/sysctl","accounts_in_message":[],"_revision_number":1},{"id":"b7b84fe5b630aafe755528a63f608a0d6f9ac7d5","author":{"_account_id":26695,"name":"Tom Downes","email":"tpdownes@gmail.com","username":"tpdownes"},"date":"2017-08-18 17:32:51.000000000","message":"Abandoned\n\nAccidentally created second one.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a2e801e97a775699066c5e79e897cc2466bc3642","revisions":{"a2e801e97a775699066c5e79e897cc2466bc3642":{"kind":"REWORK","_number":1,"created":"2017-08-18 16:33:58.000000000","uploader":{"_account_id":26695,"name":"Tom Downes","email":"tpdownes@gmail.com","username":"tpdownes"},"ref":"refs/changes/72/495372/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-ceph","ref":"refs/changes/72/495372/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-ceph refs/changes/72/495372/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-ceph refs/changes/72/495372/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-ceph refs/changes/72/495372/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-ceph refs/changes/72/495372/1"}}},"commit":{"parents":[{"commit":"3cc04b6900d36b83d67b95a5190a77c14c2d3a02","subject":"Prepare 2.4.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-ceph/commit/3cc04b6900d36b83d67b95a5190a77c14c2d3a02"}]}],"author":{"name":"Tom Downes","email":"tpdownes@gmail.com","date":"2017-08-18 15:20:01.000000000","tz":-300},"committer":{"name":"Tom Downes","email":"thomas.downes@ligo.org","date":"2017-08-18 16:32:28.000000000","tz":-300},"subject":"Convert to use of well-maintained sysctl provider","message":"Convert to use of well-maintained sysctl provider\n\nChange-Id: Ic3df2af434527b40bb78d24561d5ed1d8334dd22\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-ceph/commit/a2e801e97a775699066c5e79e897cc2466bc3642"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-ceph/commit/a2e801e97a775699066c5e79e897cc2466bc3642"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}