)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0b89cf44bf3781c25498f06ef64c2d7753cb6a69","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Keith Schincke \u003ckeith.schincke@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-19 07:01:52 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Set file ACLs for Ceph keyrings"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Given a POSIX ACL list, enable puppet-ceph to set the provided"},{"line_number":10,"context_line":"Ceph keyrings to the ACLs in the list."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3f4b6375_28e63c46","line":7,"updated":"2017-10-19 11:57:02.000000000","message":"no WIP anymore?","commit_id":"9d370166d3dc3257de5d76438e0bbbd0c284be67"}],"manifests/key.pp":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"5816c16780cb5c0b4044e242c63093cdedad8981","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    #add $acls to the keyring"},{"line_number":140,"context_line":"    exec{ \"ceph-key-acl-${keyring_path}\":"},{"line_number":141,"context_line":"      command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":142,"context_line":"setfacl -m ${acls} ${keyring_path}\","},{"line_number":143,"context_line":"    }"},{"line_number":144,"context_line":"    #chain after the file is created"},{"line_number":145,"context_line":"    Exec[\"ceph-key-${name}\"] -\u003e Exec[\"ceph-key-acl-${keyring_path}\"]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7f515b1d_b548d12c","line":142,"updated":"2017-10-09 13:04:30.000000000","message":"Looks like it\u0027s not iterating through the list as it only applied the ACL for Glance, not Nova, Cinder, or Gnochi.\n\n[root@overcloud-controller-0 ~]# getfacl /etc/ceph/ceph.client.openstack.keyring\ngetfacl: Removing leading \u0027/\u0027 from absolute path names\n# file: etc/ceph/ceph.client.openstack.keyring\n# owner: root\n# group: root\nuser::rw-\nuser:glance:r--\ngroup::---\nmask::r--\nother::---\n\n[root@overcloud-controller-0 ~]# \n\n[root@overcloud-controller-0 ~]# getfacl /etc/ceph/ceph.client.manila.keyring \ngetfacl: Removing leading \u0027/\u0027 from absolute path names\n# file: etc/ceph/ceph.client.manila.keyring\n# owner: root\n# group: root\nuser::rw-\nuser:manila:r--\ngroup::---\nmask::r--\nother::---\n\n[root@overcloud-controller-0 ~]# ls -l /etc/ceph/\ntotal 20\n-rw-------. 1 root root 129 Oct  9 11:38 ceph.client.admin.keyring\n-rw-r-----+ 1 root root 254 Oct  9 11:38 ceph.client.manila.keyring\n-rw-r-----+ 1 root root 262 Oct  9 11:38 ceph.client.openstack.keyring\n-rw-r--r--. 1 root root 499 Oct  9 11:38 ceph.conf\n-rw-r--r--. 1 root root  92 Apr 11 01:53 rbdmap\n[root@overcloud-controller-0 ~]#","commit_id":"d33bb0f5cca506005edcd3676e71ff91d4a8be8e"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"13e2de80571f20c890b5ca32d3a8936067675a1c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"      group                   \u003d\u003e $group,"},{"line_number":126,"context_line":"      mode                    \u003d\u003e $mode,"},{"line_number":127,"context_line":"      selinux_ignore_defaults \u003d\u003e true,"},{"line_number":128,"context_line":"      require                 \u003d\u003e Package[$::ceph::params::packages],"},{"line_number":129,"context_line":"    }"},{"line_number":130,"context_line":"  }"},{"line_number":131,"context_line":"  if $acls {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5f4e5783_e1b9d4cb","line":128,"updated":"2017-10-16 15:44:21.000000000","message":"shall we add the package which provides set/get facl to the default list?","commit_id":"3fb2449c8929dcfcff4495d5c9e5cbee4795d900"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"13e2de80571f20c890b5ca32d3a8936067675a1c","unresolved":false,"context_lines":[{"line_number":136,"context_line":"      command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":137,"context_line":"setfacl -m ${acl_arg} ${keyring_path}\","},{"line_number":138,"context_line":"    }"},{"line_number":139,"context_line":"    exec{ \"ceph-key-get-acl-${keyring_path}\":"},{"line_number":140,"context_line":"      command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":141,"context_line":"getfacl ${keyring_path}\","},{"line_number":142,"context_line":"      logoutput \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5f4e5783_a1963c3d","line":139,"updated":"2017-10-16 15:44:21.000000000","message":"why do we need this exec?","commit_id":"3fb2449c8929dcfcff4495d5c9e5cbee4795d900"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d9817518b0cadb20955077798256ebef90af552c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"      group                   \u003d\u003e $group,"},{"line_number":126,"context_line":"      mode                    \u003d\u003e $mode,"},{"line_number":127,"context_line":"      selinux_ignore_defaults \u003d\u003e true,"},{"line_number":128,"context_line":"      require                 \u003d\u003e Package[$::ceph::params::packages],"},{"line_number":129,"context_line":"    }"},{"line_number":130,"context_line":"    if $acls {"},{"line_number":131,"context_line":"      #add $acls to the keyring"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3f4b6375_5de49bac","line":128,"updated":"2017-10-19 09:34:49.000000000","message":"can we add \"acl\" to the list of packages in params.pp given we need it for setfacl command?","commit_id":"8f371ae1052d09c67fbb3fb0c9f69b7f49c93eda"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d9817518b0cadb20955077798256ebef90af552c","unresolved":false,"context_lines":[{"line_number":136,"context_line":"setfacl -m ${acl_arg} ${keyring_path}\","},{"line_number":137,"context_line":"      }"},{"line_number":138,"context_line":"      #chain after the file is created"},{"line_number":139,"context_line":"      Exec[\"ceph-key-${name}\"] -\u003e Exec[\"ceph-key-acl-${keyring_path}\"] -\u003e Exec[\"ceph-key-get-acl-${keyring_path}\"]"},{"line_number":140,"context_line":"    }"},{"line_number":141,"context_line":"  }"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3f4b6375_7d699723","line":139,"updated":"2017-10-19 09:34:49.000000000","message":"I think there is no ceph-key-get-acl anymore?","commit_id":"8f371ae1052d09c67fbb3fb0c9f69b7f49c93eda"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7f379d62bf028f1c92c8dff3ec98f311d4b63de5","unresolved":false,"context_lines":[{"line_number":131,"context_line":"      #add $acls to the keyring"},{"line_number":132,"context_line":"      $acl_arg \u003d join($acls ,\u0027 -m \u0027 )"},{"line_number":133,"context_line":"      notify { \"acl_arg for ${name}: ${acl_arg}\": }"},{"line_number":134,"context_line":"      exec{ \"ceph-key-acl-${keyring_path}\":"},{"line_number":135,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":136,"context_line":"setfacl -m ${acl_arg} ${keyring_path}\","},{"line_number":137,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"3f4b6375_3b4f396c","line":134,"updated":"2017-10-24 13:01:04.000000000","message":"I\u0027d replace {keyring_path} with {name} and that should make the tests to pass as well","commit_id":"18e83049bd5447cea39fa52cdf0f16d1638f2414"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7f379d62bf028f1c92c8dff3ec98f311d4b63de5","unresolved":false,"context_lines":[{"line_number":136,"context_line":"setfacl -m ${acl_arg} ${keyring_path}\","},{"line_number":137,"context_line":"      }"},{"line_number":138,"context_line":"      #chain after the file is created"},{"line_number":139,"context_line":"      Exec[\"ceph-key-${name}\"] -\u003e Exec[\"ceph-key-acl-${keyring_path}\"]"},{"line_number":140,"context_line":"    }"},{"line_number":141,"context_line":"  }"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":17,"id":"3f4b6375_db594535","line":139,"updated":"2017-10-24 13:01:04.000000000","message":"same here, cause the name of the resource is different","commit_id":"18e83049bd5447cea39fa52cdf0f16d1638f2414"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4bcf799ab80349df2e5b422372067898384ca3f9","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    if $acls {"},{"line_number":141,"context_line":"      #add $acls to the keyring"},{"line_number":142,"context_line":"      $acl_arg \u003d join($acls ,\u0027 -m \u0027 )"},{"line_number":143,"context_line":"      notify { \"acl_arg for ${name}: ${acl_arg}\": }"},{"line_number":144,"context_line":"      exec{ \"ceph-key-acl-${name}\":"},{"line_number":145,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":146,"context_line":"setfacl -m ${acl_arg} ${keyring_path}\","}],"source_content_type":"text/x-puppet","patch_set":21,"id":"3f4b6375_8d4e3736","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":51},"updated":"2017-10-31 19:33:29.000000000","message":"This should be removed as it seems to be left over debugging items. This would techincally not be idempotent because of this.","commit_id":"7d776332ed488a1580a37a629de7f16b836f1204"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4bcf799ab80349df2e5b422372067898384ca3f9","unresolved":false,"context_lines":[{"line_number":142,"context_line":"      $acl_arg \u003d join($acls ,\u0027 -m \u0027 )"},{"line_number":143,"context_line":"      notify { \"acl_arg for ${name}: ${acl_arg}\": }"},{"line_number":144,"context_line":"      exec{ \"ceph-key-acl-${name}\":"},{"line_number":145,"context_line":"        command   \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements"},{"line_number":146,"context_line":"setfacl -m ${acl_arg} ${keyring_path}\","},{"line_number":147,"context_line":"      }"},{"line_number":148,"context_line":"      #chain after the file is created"},{"line_number":149,"context_line":"      Exec[\"ceph-key-${name}\"] -\u003e Exec[\"ceph-key-acl-${name}\"]"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"3f4b6375_ed492b32","line":146,"range":{"start_line":145,"start_character":0,"end_line":146,"end_character":39},"updated":"2017-10-31 19:33:29.000000000","message":"So we don\u0027t need this syntax if it\u0027s just a simple change.  Please just switch this to be...\n\n  command \u003d\u003e \"setfacl -m ${acl_arg} ${keyring_path}\"\n\n\nI think it\u0027s the default but it would be a good practice to include a path \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027]","commit_id":"7d776332ed488a1580a37a629de7f16b836f1204"}],"spec/defines/ceph_key_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5007cdfcaee9309893db87507748769c6c2e7942","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    end"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  end"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  on_supported_os({"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"3f4b6375_47f4a5cf","line":61,"updated":"2017-10-20 13:59:56.000000000","message":"no tests?","commit_id":"79bba411a3c6a6fb4c035ddfde5b26de7439eec8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"975500635cebca6ea253a8edfdbfb90e492144a6","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"      it {"},{"line_number":81,"context_line":"        is_expected.to contain_exec(\u0027ceph-key-acl-client.acl\u0027).with("},{"line_number":82,"context_line":"           \u0027command\u0027 \u003d\u003e \"/bin/true # comment to satisfy puppet syntax requirements\\nsetfacl -m u:test:rwx /etc/ceph/ceph.client.acl.keyring\""},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":"      }"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":22,"id":"3f4b6375_f8a1e796","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":140},"updated":"2017-10-31 20:30:33.000000000","message":"You\u0027ll need to update this as well","commit_id":"3d60d28e69a84ef11bedffe9a3a4d24d6bb5a8ae"}]}