)]}'
{"manifests/osd.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"262e114f916b913e4127d6dd947f0ab88eef17f0","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        creates \u003d\u003e \"${bootstrap_osd_keyring}\","},{"line_number":127,"context_line":"      }"},{"line_number":128,"context_line":"      Exec[$ceph_check_udev] -\u003e Exec[\"extract-bootstrap-osd-keyring-${name}\"]"},{"line_number":129,"context_line":"      Exec[\"extract-bootstrap-osd-keyring-${name}\"] -\u003e Exec[$ceph_prepare]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"      Exec[$ceph_check_udev] -\u003e Exec[$ceph_prepare]"},{"line_number":132,"context_line":"      # ceph-disk: prepare should be idempotent http://tracker.ceph.com/issues/7475"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5f7c97a3_b3f414d1","line":129,"updated":"2018-05-18 08:02:32.000000000","message":"you could probably just replace line 131 with this ... and for consistency move line 128 to 119","commit_id":"06f9cc52c7a3f028b0c1c73e1fbbacaf31a385fb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"626e5298af6dcb684d5f7e4ca0ab0d736a3f3e67","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          timeout   \u003d\u003e $exec_timeout,"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"      }"},{"line_number":119,"context_line":"      Exec[$ceph_check_udev] -\u003e Exec[\"extract-bootstrap-osd-keyring-${name}\"]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"      #name of the bootstrap osd keyring"},{"line_number":122,"context_line":"      $bootstrap_osd_keyring \u003d \"/var/lib/ceph/bootstrap-osd/${cluster_name}.keyring\""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5f7c97a3_529e9063","line":119,"updated":"2018-05-23 21:10:32.000000000","message":"I think this needs to be moved down to L129 because this might come up as undefined since it isn\u0027t defined until L123","commit_id":"bd3ac8928c545caa0ae4507ecd01339a87b6f6cb"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"76daf69c43d600f84ee5a2c0ad05472e5e4c08fe","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      $ceph_activate \u003d \"ceph-osd-activate-${name}\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"      Package\u003c| tag \u003d\u003d \u0027ceph\u0027 |\u003e -\u003e Exec[$ceph_check_udev]"},{"line_number":78,"context_line":"      Ceph_config\u003c||\u003e -\u003e Exec[$ceph_prepare]"},{"line_number":79,"context_line":"      Ceph::Mon\u003c||\u003e -\u003e Exec[$ceph_prepare]"},{"line_number":80,"context_line":"      Ceph::Key\u003c||\u003e -\u003e Exec[$ceph_prepare]"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3f79a3b5_186850b8","line":78,"updated":"2018-08-31 14:52:43.000000000","message":"I think these (78-80) need to be updated to make sue the Mon and the client Key are provisioned before we attempt the \u0027ceph auth get\u0027 command","commit_id":"27d63ecad121a5a7f41e7cd0ca4f6e33e8bd3578"}]}
