)]}'
{"manifests/rgw.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"da5d935740972b40cfd1dbff46488961b168dabb","unresolved":true,"context_lines":[{"line_number":86,"context_line":"  $rgw_print_continue \u003d false,"},{"line_number":87,"context_line":"  $rgw_port           \u003d undef,"},{"line_number":88,"context_line":"  $frontend_type      \u003d \u0027civetweb\u0027,"},{"line_number":89,"context_line":"  $rgw_frontends      \u003d undef,"},{"line_number":90,"context_line":"  $rgw_swift_url      \u003d \"http://${::fqdn}:7480\","},{"line_number":91,"context_line":"  $syslog             \u003d undef,"},{"line_number":92,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"abb0fc1e_bc930526","line":89,"range":{"start_line":89,"start_character":3,"end_line":89,"end_character":16},"updated":"2022-08-21 08:17:16.000000000","message":"I assume we removed this default since 7480 is the default port?","commit_id":"5e6d20e85dc1dc98a7ec5ac70bc7a03b3263690c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1927f13ea86471a0253e5987e4d7a20d7c5ecd9b","unresolved":true,"context_lines":[{"line_number":86,"context_line":"  $rgw_print_continue \u003d false,"},{"line_number":87,"context_line":"  $rgw_port           \u003d undef,"},{"line_number":88,"context_line":"  $frontend_type      \u003d \u0027civetweb\u0027,"},{"line_number":89,"context_line":"  $rgw_frontends      \u003d undef,"},{"line_number":90,"context_line":"  $rgw_swift_url      \u003d \"http://${::fqdn}:7480\","},{"line_number":91,"context_line":"  $syslog             \u003d undef,"},{"line_number":92,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"c87f4e40_807f9363","line":89,"range":{"start_line":89,"start_character":3,"end_line":89,"end_character":16},"in_reply_to":"abb0fc1e_bc930526","updated":"2022-08-21 13:30:37.000000000","message":"intention of this change is to use the default value in the underlying defined types.\n\nThis effectively defaults to \u0027civetweb pot\u003d7480\u0027 when civetweb is used, while it defaults to \u0027beast endpoint\u003d127.0.0.1\u0027 (\u003d 127.0.0.1:80) when beast is used.","commit_id":"5e6d20e85dc1dc98a7ec5ac70bc7a03b3263690c"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"da5d935740972b40cfd1dbff46488961b168dabb","unresolved":true,"context_lines":[{"line_number":130,"context_line":"      }"},{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":"    \u0027apache-proxy-fcgi\u0027: {"},{"line_number":133,"context_line":"      $rgw_fronetnds_real \u003d pick($rgw_frontends, \u0027fastcgi socket_port\u003d9000 socket_host\u003d127.0.0.1\u0027);"},{"line_number":134,"context_line":"      ceph_config {"},{"line_number":135,"context_line":"        \"client.${name}/rgw_frontends\":      value \u003d\u003e $rgw_fronetnds_real;"},{"line_number":136,"context_line":"        \"client.${name}/rgw_print_continue\": value \u003d\u003e $rgw_print_continue;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1151024b_4d54a112","line":133,"range":{"start_line":133,"start_character":7,"end_line":133,"end_character":25},"updated":"2022-08-21 08:17:16.000000000","message":"nit: spelling","commit_id":"5e6d20e85dc1dc98a7ec5ac70bc7a03b3263690c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1927f13ea86471a0253e5987e4d7a20d7c5ecd9b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"      }"},{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":"    \u0027apache-proxy-fcgi\u0027: {"},{"line_number":133,"context_line":"      $rgw_fronetnds_real \u003d pick($rgw_frontends, \u0027fastcgi socket_port\u003d9000 socket_host\u003d127.0.0.1\u0027);"},{"line_number":134,"context_line":"      ceph_config {"},{"line_number":135,"context_line":"        \"client.${name}/rgw_frontends\":      value \u003d\u003e $rgw_fronetnds_real;"},{"line_number":136,"context_line":"        \"client.${name}/rgw_print_continue\": value \u003d\u003e $rgw_print_continue;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"8b940883_cf3a2909","line":133,"range":{"start_line":133,"start_character":7,"end_line":133,"end_character":25},"in_reply_to":"1151024b_4d54a112","updated":"2022-08-21 13:30:37.000000000","message":"Done","commit_id":"5e6d20e85dc1dc98a7ec5ac70bc7a03b3263690c"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"da5d935740972b40cfd1dbff46488961b168dabb","unresolved":true,"context_lines":[{"line_number":132,"context_line":"    \u0027apache-proxy-fcgi\u0027: {"},{"line_number":133,"context_line":"      $rgw_fronetnds_real \u003d pick($rgw_frontends, \u0027fastcgi socket_port\u003d9000 socket_host\u003d127.0.0.1\u0027);"},{"line_number":134,"context_line":"      ceph_config {"},{"line_number":135,"context_line":"        \"client.${name}/rgw_frontends\":      value \u003d\u003e $rgw_fronetnds_real;"},{"line_number":136,"context_line":"        \"client.${name}/rgw_print_continue\": value \u003d\u003e $rgw_print_continue;"},{"line_number":137,"context_line":"        \"client.${name}/rgw_socket_path\":    value \u003d\u003e $rgw_socket_path;"},{"line_number":138,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bfd60692_75cfea92","line":135,"range":{"start_line":135,"start_character":55,"end_line":135,"end_character":73},"updated":"2022-08-21 08:17:16.000000000","message":"^","commit_id":"5e6d20e85dc1dc98a7ec5ac70bc7a03b3263690c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1927f13ea86471a0253e5987e4d7a20d7c5ecd9b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \u0027apache-proxy-fcgi\u0027: {"},{"line_number":133,"context_line":"      $rgw_fronetnds_real \u003d pick($rgw_frontends, \u0027fastcgi socket_port\u003d9000 socket_host\u003d127.0.0.1\u0027);"},{"line_number":134,"context_line":"      ceph_config {"},{"line_number":135,"context_line":"        \"client.${name}/rgw_frontends\":      value \u003d\u003e $rgw_fronetnds_real;"},{"line_number":136,"context_line":"        \"client.${name}/rgw_print_continue\": value \u003d\u003e $rgw_print_continue;"},{"line_number":137,"context_line":"        \"client.${name}/rgw_socket_path\":    value \u003d\u003e $rgw_socket_path;"},{"line_number":138,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"0e6a924a_cdf7e84c","line":135,"range":{"start_line":135,"start_character":55,"end_line":135,"end_character":73},"in_reply_to":"bfd60692_75cfea92","updated":"2022-08-21 13:30:37.000000000","message":"Done","commit_id":"5e6d20e85dc1dc98a7ec5ac70bc7a03b3263690c"}],"manifests/rgw/beast.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"32eedf7ba2066cdb49ba8c301b9717c0285513bd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#   Optional. Default is \u0027beast endpoint\u003d127.0.0.1\u0027"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"define ceph::rgw::beast ("},{"line_number":25,"context_line":"  $rgw_frontends \u003d \u0027beast endpoint\u003d127.0.0.1\u0027,"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  unless $name \u003d~ /^radosgw\\..+/ {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"992427af_ecfa9c1b","line":25,"range":{"start_line":25,"start_character":20,"end_line":25,"end_character":44},"updated":"2022-08-21 14:57:17.000000000","message":"seems \"beast port\u003d7480\" is the better default.\n\nhttps://docs.ceph.com/en/quincy/radosgw/config-ref/?highlight\u003drgw_swift_ur#confval-rgw_frontends","commit_id":"5e6d20e85dc1dc98a7ec5ac70bc7a03b3263690c"}]}