)]}'
{"manifests/backend/rbd.pp":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"1d09fb4897aa952c257eac5101087179e42c6df3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $rbd_secret_uuid                  \u003d false,"},{"line_number":65,"context_line":"  $volume_tmp_dir                   \u003d false,"},{"line_number":66,"context_line":"  $rbd_max_clone_depth              \u003d \u00275\u0027,"},{"line_number":67,"context_line":"  $rbd_store_chunk_size             \u003d \u00274\u0027,"},{"line_number":68,"context_line":"  $rados_connect_timeout            \u003d \u0027-1\u0027,"},{"line_number":69,"context_line":"  $extra_options                    \u003d {},"},{"line_number":70,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da9b358b_965dac7b","line":67,"updated":"2015-03-31 13:12:19.000000000","message":"These should default to undef, so that if the user doesn\u0027t set them, they remain unmanaged.  This allows them to upgrade to future releases that may change these defaults without needing changes to the puppet module.","commit_id":"9aa8f9050f3139f6957b961bef664afa543cc57a"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"acedd152c803328a3bc0ecc7f6623afb52812043","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $rbd_secret_uuid                  \u003d false,"},{"line_number":65,"context_line":"  $volume_tmp_dir                   \u003d false,"},{"line_number":66,"context_line":"  $rbd_max_clone_depth              \u003d \u00275\u0027,"},{"line_number":67,"context_line":"  $rbd_store_chunk_size             \u003d \u00274\u0027,"},{"line_number":68,"context_line":"  $rados_connect_timeout            \u003d \u0027-1\u0027,"},{"line_number":69,"context_line":"  $extra_options                    \u003d {},"},{"line_number":70,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da9b358b_29643a20","line":67,"in_reply_to":"da9b358b_965dac7b","updated":"2015-03-31 15:08:10.000000000","message":"@Clayton: We currently do not have a project wide policy regarding default value. It\u0027s a bit unfair to suggest it in a specific change without having a wider consensus/policy about it. I\u0027m not against the idea but it needs a lot more work than you suggest.","commit_id":"9aa8f9050f3139f6957b961bef664afa543cc57a"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"08bc85bba62f144f904182497040f5891d56bdc5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $rbd_secret_uuid                  \u003d false,"},{"line_number":65,"context_line":"  $volume_tmp_dir                   \u003d false,"},{"line_number":66,"context_line":"  $rbd_max_clone_depth              \u003d \u00275\u0027,"},{"line_number":67,"context_line":"  $rbd_store_chunk_size             \u003d undef,"},{"line_number":68,"context_line":"  $rados_connect_timeout            \u003d undef,"},{"line_number":69,"context_line":"  $extra_options                    \u003d {},"},{"line_number":70,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3a29b11f_e29b9664","line":67,"updated":"2015-10-21 14:44:47.000000000","message":"We should be able to set these to $::os_service_default now and get the behavior discussed.","commit_id":"cd8a748acce9f4995010c9532508ae7819071081"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8f42f646e258be3493e83b83a56340e0207094b0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $rbd_flatten_volume_from_snapshot \u003d false,"},{"line_number":71,"context_line":"  $rbd_secret_uuid                  \u003d $::os_service_default,"},{"line_number":72,"context_line":"  $volume_tmp_dir                   \u003d $::os_service_default,"},{"line_number":73,"context_line":"  $rbd_max_clone_depth              \u003d \u00275\u0027,"},{"line_number":74,"context_line":"  $rbd_store_chunk_size             \u003d \u00274\u0027,"},{"line_number":75,"context_line":"  $rados_connect_timeout            \u003d \u0027-1\u0027,"},{"line_number":76,"context_line":"  $extra_options                    \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ba8a016a_6fbecd66","line":73,"updated":"2015-11-18 11:54:32.000000000","message":"Why not switch to $::os_service_default?","commit_id":"15cda0b4f303e4580f1fd5ecc4ddbb3de6a706ee"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8f42f646e258be3493e83b83a56340e0207094b0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  $rbd_secret_uuid                  \u003d $::os_service_default,"},{"line_number":72,"context_line":"  $volume_tmp_dir                   \u003d $::os_service_default,"},{"line_number":73,"context_line":"  $rbd_max_clone_depth              \u003d \u00275\u0027,"},{"line_number":74,"context_line":"  $rbd_store_chunk_size             \u003d \u00274\u0027,"},{"line_number":75,"context_line":"  $rados_connect_timeout            \u003d \u0027-1\u0027,"},{"line_number":76,"context_line":"  $extra_options                    \u003d {},"},{"line_number":77,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ba8a016a_af74b535","line":74,"updated":"2015-11-18 11:54:32.000000000","message":"Why not switch to $::os_service_default?","commit_id":"15cda0b4f303e4580f1fd5ecc4ddbb3de6a706ee"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8f42f646e258be3493e83b83a56340e0207094b0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  $volume_tmp_dir                   \u003d $::os_service_default,"},{"line_number":73,"context_line":"  $rbd_max_clone_depth              \u003d \u00275\u0027,"},{"line_number":74,"context_line":"  $rbd_store_chunk_size             \u003d \u00274\u0027,"},{"line_number":75,"context_line":"  $rados_connect_timeout            \u003d \u0027-1\u0027,"},{"line_number":76,"context_line":"  $extra_options                    \u003d {},"},{"line_number":77,"context_line":") {"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ba8a016a_8f96913d","line":75,"updated":"2015-11-18 11:54:32.000000000","message":"same here","commit_id":"15cda0b4f303e4580f1fd5ecc4ddbb3de6a706ee"}],"manifests/volume/rbd.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ea30981177e137f169a3a698458a2f838b0e9295","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# [*rbd_store_chunk_size*]"},{"line_number":37,"context_line":"#   (optional) Volumes will be chunked into objects of this size (in"},{"line_number":38,"context_line":"#   megabytes)"},{"line_number":39,"context_line":"#   Defaults to undef"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*rados_connect_timeout*]"},{"line_number":42,"context_line":"#   (optional) Timeout value (in seconds) used when connecting to ceph"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aaa499b_6103ba10","line":39,"updated":"2015-04-12 17:51:59.000000000","message":"why not using the default value here ? (4)","commit_id":"cd8a748acce9f4995010c9532508ae7819071081"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ea30981177e137f169a3a698458a2f838b0e9295","unresolved":false,"context_lines":[{"line_number":42,"context_line":"#   (optional) Timeout value (in seconds) used when connecting to ceph"},{"line_number":43,"context_line":"#   cluster. If value \u003c 0, no timeout is set and \u0027default librados"},{"line_number":44,"context_line":"#   value is used."},{"line_number":45,"context_line":"#   Defaults to undef"},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"# [*extra_options*]"},{"line_number":48,"context_line":"#   (optional) Hash of extra options to pass to the backend stanza"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aaa499b_73ff1102","line":45,"updated":"2015-04-12 17:51:59.000000000","message":"why not using the default value here ? (-1 for no limits)","commit_id":"cd8a748acce9f4995010c9532508ae7819071081"},{"author":{"_account_id":13564,"name":"Crag Wolfe","email":"cragcw@gmail.com","username":"cwolfe"},"change_message_id":"af36454ba3184da82ebe32f88de8379a239d28b0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"#   (optional) Timeout value (in seconds) used when connecting to ceph"},{"line_number":43,"context_line":"#   cluster. If value \u003c 0, no timeout is set and \u0027default librados"},{"line_number":44,"context_line":"#   value is used."},{"line_number":45,"context_line":"#   Defaults to undef"},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"# [*extra_options*]"},{"line_number":48,"context_line":"#   (optional) Hash of extra options to pass to the backend stanza"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba8a016a_85ed2227","line":45,"in_reply_to":"7aaa499b_73ff1102","updated":"2015-11-18 04:24:47.000000000","message":"OK, I updated it. The \"why undef\" was covered in my comment from June 9, but I don\u0027t feel terribly strongly about it.","commit_id":"cd8a748acce9f4995010c9532508ae7819071081"}]}