)]}'
{"manifests/backend/dellsc_iscsi.pp":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dee77f4dd1401774fbea19764746a72985b65bbc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*dell_sc_ssn*]"},{"line_number":20,"context_line":"#   (required) he Storage Center serial number to use."},{"line_number":21,"context_line":"#   "},{"line_number":22,"context_line":"# [*volume_backend_name*]"},{"line_number":23,"context_line":"#   (optional) The storage backend name."},{"line_number":24,"context_line":"#   Defaults to the name of the backend"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3afb71cf_4da01191","line":21,"updated":"2015-06-04 20:50:30.000000000","message":"looks like some unprintable characters. Need to be fixed.","commit_id":"c812405e01a27f3b97dbfee899370e5971b4aec3"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dee77f4dd1401774fbea19764746a72985b65bbc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#   "},{"line_number":22,"context_line":"# [*volume_backend_name*]"},{"line_number":23,"context_line":"#   (optional) The storage backend name."},{"line_number":24,"context_line":"#   Defaults to the name of the backend"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*dell_sc_api_por*]"},{"line_number":27,"context_line":"#   (optional) The Enterprise Manager API port."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3afb71cf_6d898dca","line":24,"updated":"2015-06-04 20:50:30.000000000","message":"Need to make it clear that you can have multiple SC backends with single EM to manage it.","commit_id":"c812405e01a27f3b97dbfee899370e5971b4aec3"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dee77f4dd1401774fbea19764746a72985b65bbc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*dell_sc_api_por*]"},{"line_number":27,"context_line":"#   (optional) The Enterprise Manager API port."},{"line_number":28,"context_line":"#   Defaults to 3033"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*dell_sc_server_folder*]"},{"line_number":31,"context_line":"#   (optional) Server folder to place new server definitions."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3afb71cf_cd2f61f5","line":28,"updated":"2015-06-04 20:50:30.000000000","message":"to avoid confusion can we use \"em\" in the name for Enterprise manager and \"sc\" for storage center for all the names.\n\nshould end at port not por","commit_id":"c812405e01a27f3b97dbfee899370e5971b4aec3"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dee77f4dd1401774fbea19764746a72985b65bbc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#   (optional) Hash of extra options to pass to the backend stanza"},{"line_number":44,"context_line":"#   Defaults to: {}"},{"line_number":45,"context_line":"#   Example :"},{"line_number":46,"context_line":"#     { \u0027dellsc_iscsi_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }"},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"define cinder::backend::dellsc_iscsi ("},{"line_number":49,"context_line":"  $san_ip,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3afb71cf_8d5e0975","line":46,"updated":"2015-06-04 20:50:30.000000000","message":"Should we split it into EM and SC extra parameters?","commit_id":"c812405e01a27f3b97dbfee899370e5971b4aec3"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"300c54780dd41086e59f77088cfb7c6f5fd0b300","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*dell_sc_ssn*]"},{"line_number":20,"context_line":"#   (required) The Storage Center serial number to use."},{"line_number":21,"context_line":"#   "},{"line_number":22,"context_line":"# [*volume_backend_name*]"},{"line_number":23,"context_line":"#   (optional) The storage backend name."},{"line_number":24,"context_line":"#   Defaults to the name of the backend"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3afb71cf_c9d04356","line":21,"updated":"2015-06-06 01:18:22.000000000","message":"whitespace errors","commit_id":"ed6704022c19757009460e15af1695eb2ddd53ed"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"10acb98319071edabd7d3f27649efb29197c1eb6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*dell_sc_ssn*]"},{"line_number":20,"context_line":"#   (required) The Storage Center serial number to use."},{"line_number":21,"context_line":"#   "},{"line_number":22,"context_line":"# [*volume_backend_name*]"},{"line_number":23,"context_line":"#   (optional) The storage backend name."},{"line_number":24,"context_line":"#   Defaults to the name of the backend"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3afb71cf_8a2a0b2b","line":21,"in_reply_to":"3afb71cf_c9d04356","updated":"2015-06-08 17:12:48.000000000","message":"Fixed","commit_id":"ed6704022c19757009460e15af1695eb2ddd53ed"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"300c54780dd41086e59f77088cfb7c6f5fd0b300","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#   "},{"line_number":22,"context_line":"# [*volume_backend_name*]"},{"line_number":23,"context_line":"#   (optional) The storage backend name."},{"line_number":24,"context_line":"#   Defaults to the name of the backend"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*dell_sc_api_port*]"},{"line_number":27,"context_line":"#   (optional) The Enterprise Manager API port."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3afb71cf_09e89b0f","line":24,"updated":"2015-06-06 01:18:22.000000000","message":"Make it clear that it is a name for SC.","commit_id":"ed6704022c19757009460e15af1695eb2ddd53ed"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"10acb98319071edabd7d3f27649efb29197c1eb6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#   "},{"line_number":22,"context_line":"# [*volume_backend_name*]"},{"line_number":23,"context_line":"#   (optional) The storage backend name."},{"line_number":24,"context_line":"#   Defaults to the name of the backend"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*dell_sc_api_port*]"},{"line_number":27,"context_line":"#   (optional) The Enterprise Manager API port."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3afb71cf_6afb4fc2","line":24,"in_reply_to":"3afb71cf_09e89b0f","updated":"2015-06-08 17:12:48.000000000","message":"It is really not the name of the SC. It is a logical name for the administrator to identify the backend in a multi-backend cinder setup.","commit_id":"ed6704022c19757009460e15af1695eb2ddd53ed"}],"manifests/volume/dellsc_iscsi.pp":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dee77f4dd1401774fbea19764746a72985b65bbc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  $san_login,"},{"line_number":47,"context_line":"  $san_password,"},{"line_number":48,"context_line":"  $iscsi_ip_address,"},{"line_number":49,"context_line":"  $dell_sc_ssn, "},{"line_number":50,"context_line":"  $dell_sc_api_port     \u003d 3033,"},{"line_number":51,"context_line":"  $dell_sc_server_folder\u003d \u0027srv\u0027,"},{"line_number":52,"context_line":"  $dell_sc_volume_folder\u003d \u0027vol\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3afb71cf_6db06d8c","line":49,"updated":"2015-06-04 20:50:30.000000000","message":"ditto","commit_id":"c812405e01a27f3b97dbfee899370e5971b4aec3"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dee77f4dd1401774fbea19764746a72985b65bbc","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    dell_sc_api_port     \u003d\u003e $dell_sc_api_port,"},{"line_number":63,"context_line":"    dell_sc_server_folder\u003d\u003e $dell_sc_server_folder,"},{"line_number":64,"context_line":"    dell_sc_volume_folder\u003d\u003e $dell_sc_volume_folder,"},{"line_number":65,"context_line":"    iscsi_port           \u003d\u003e $iscsi_port, "},{"line_number":66,"context_line":"    extra_options        \u003d\u003e $extra_options,"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3afb71cf_4dadb130","line":65,"updated":"2015-06-04 20:50:30.000000000","message":"ditto","commit_id":"c812405e01a27f3b97dbfee899370e5971b4aec3"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dee77f4dd1401774fbea19764746a72985b65bbc","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    dell_sc_volume_folder\u003d\u003e $dell_sc_volume_folder,"},{"line_number":65,"context_line":"    iscsi_port           \u003d\u003e $iscsi_port, "},{"line_number":66,"context_line":"    extra_options        \u003d\u003e $extra_options,"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3afb71cf_ed621d16","line":67,"updated":"2015-06-04 20:50:30.000000000","message":"all the comments for dellsc_iscsi.pp are applicable here also.","commit_id":"c812405e01a27f3b97dbfee899370e5971b4aec3"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"300c54780dd41086e59f77088cfb7c6f5fd0b300","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*dell_sc_ssn*]"},{"line_number":20,"context_line":"#   (required) he Storage Center serial number to use."},{"line_number":21,"context_line":"#   "},{"line_number":22,"context_line":"# [*dell_sc_api_port*]"},{"line_number":23,"context_line":"#   (optional) The Enterprise Manager API port."},{"line_number":24,"context_line":"#   Defaults to 3033"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3afb71cf_49733381","line":21,"updated":"2015-06-06 01:18:22.000000000","message":"whitespace errors","commit_id":"ed6704022c19757009460e15af1695eb2ddd53ed"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"10acb98319071edabd7d3f27649efb29197c1eb6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*dell_sc_ssn*]"},{"line_number":20,"context_line":"#   (required) he Storage Center serial number to use."},{"line_number":21,"context_line":"#   "},{"line_number":22,"context_line":"# [*dell_sc_api_port*]"},{"line_number":23,"context_line":"#   (optional) The Enterprise Manager API port."},{"line_number":24,"context_line":"#   Defaults to 3033"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3afb71cf_aaaca7a0","line":21,"in_reply_to":"3afb71cf_49733381","updated":"2015-06-08 17:12:48.000000000","message":"Fixed","commit_id":"ed6704022c19757009460e15af1695eb2ddd53ed"}],"spec/classes/cinder_volume_dellsc_iscsi_spec.rb":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dee77f4dd1401774fbea19764746a72985b65bbc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      :san_login            \u003d\u003e \u0027Admin\u0027,"},{"line_number":8,"context_line":"      :san_password         \u003d\u003e \u002712345\u0027,"},{"line_number":9,"context_line":"      :iscsi_ip_address     \u003d\u003e \u0027192.168.0.20\u0027,"},{"line_number":10,"context_line":"      :dell_sc_ssn          \u003d\u003e \u002764720\u0027,"},{"line_number":11,"context_line":"      :dell_sc_api_port     \u003d\u003e 3033,"},{"line_number":12,"context_line":"      :dell_sc_server_folder\u003d\u003e \u0027srv\u0027,"},{"line_number":13,"context_line":"      :dell_sc_volume_folder\u003d\u003e \u0027vol\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3afb71cf_ed49fd8f","line":10,"updated":"2015-06-04 20:50:30.000000000","message":"what are legal format for it? Do we check it anywhere?","commit_id":"c812405e01a27f3b97dbfee899370e5971b4aec3"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dee77f4dd1401774fbea19764746a72985b65bbc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      :dell_sc_api_port     \u003d\u003e 3033,"},{"line_number":12,"context_line":"      :dell_sc_server_folder\u003d\u003e \u0027srv\u0027,"},{"line_number":13,"context_line":"      :dell_sc_volume_folder\u003d\u003e \u0027vol\u0027,"},{"line_number":14,"context_line":"      :iscsi_port           \u003d\u003e  3260,  "},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":"  end"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3afb71cf_8d7169e3","line":14,"updated":"2015-06-04 20:50:30.000000000","message":"another unprintable char at the end.","commit_id":"c812405e01a27f3b97dbfee899370e5971b4aec3"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"300c54780dd41086e59f77088cfb7c6f5fd0b300","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      :dell_sc_api_port     \u003d\u003e 3033,"},{"line_number":12,"context_line":"      :dell_sc_server_folder\u003d\u003e \u0027srv\u0027,"},{"line_number":13,"context_line":"      :dell_sc_volume_folder\u003d\u003e \u0027vol\u0027,"},{"line_number":14,"context_line":"      :iscsi_port           \u003d\u003e  3260,  "},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":"  end"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3afb71cf_a93187a4","line":14,"updated":"2015-06-06 01:18:22.000000000","message":"whitespace error at the end of the line","commit_id":"ed6704022c19757009460e15af1695eb2ddd53ed"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"10acb98319071edabd7d3f27649efb29197c1eb6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      :dell_sc_api_port     \u003d\u003e 3033,"},{"line_number":12,"context_line":"      :dell_sc_server_folder\u003d\u003e \u0027srv\u0027,"},{"line_number":13,"context_line":"      :dell_sc_volume_folder\u003d\u003e \u0027vol\u0027,"},{"line_number":14,"context_line":"      :iscsi_port           \u003d\u003e  3260,  "},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":"  end"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3afb71cf_8a868b11","line":14,"in_reply_to":"3afb71cf_a93187a4","updated":"2015-06-08 17:12:48.000000000","message":"Fixed. Wonder why the lint is not catching these","commit_id":"ed6704022c19757009460e15af1695eb2ddd53ed"}],"spec/defines/cinder_backend_dellsc_iscsi_spec.rb":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dee77f4dd1401774fbea19764746a72985b65bbc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      :dell_sc_api_port     \u003d\u003e 3033,"},{"line_number":16,"context_line":"      :dell_sc_server_folder\u003d\u003e \u0027srv\u0027,"},{"line_number":17,"context_line":"      :dell_sc_volume_folder\u003d\u003e \u0027vol\u0027,"},{"line_number":18,"context_line":"      :iscsi_port           \u003d\u003e  3260,     "},{"line_number":19,"context_line":"    }"},{"line_number":20,"context_line":"  end"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3afb71cf_4d2251bb","line":18,"updated":"2015-06-04 20:50:30.000000000","message":"another unprintable char at the end","commit_id":"c812405e01a27f3b97dbfee899370e5971b4aec3"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dee77f4dd1401774fbea19764746a72985b65bbc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      })"},{"line_number":43,"context_line":"    end"},{"line_number":44,"context_line":"  end"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3afb71cf_4d093131","line":45,"updated":"2015-06-04 20:50:30.000000000","message":"Do we test anywhere that we can reach EM or SC?\nor accessibility of IP and ports?","commit_id":"c812405e01a27f3b97dbfee899370e5971b4aec3"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"300c54780dd41086e59f77088cfb7c6f5fd0b300","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      :dell_sc_api_port     \u003d\u003e 3033,"},{"line_number":16,"context_line":"      :dell_sc_server_folder\u003d\u003e \u0027srv\u0027,"},{"line_number":17,"context_line":"      :dell_sc_volume_folder\u003d\u003e \u0027vol\u0027,"},{"line_number":18,"context_line":"      :iscsi_port           \u003d\u003e  3260,     "},{"line_number":19,"context_line":"    }"},{"line_number":20,"context_line":"  end"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3afb71cf_e9ee5feb","line":18,"updated":"2015-06-06 01:18:22.000000000","message":"whitespace errors","commit_id":"ed6704022c19757009460e15af1695eb2ddd53ed"}]}