)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"77d447e69a40e56e458a0561ef4c56e7eedb802a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added support for DellStorageCenter ISCSI cinder driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Dell Storage Center driver manages Storage Center arrays "},{"line_number":10,"context_line":"through Enterprise Manager. "},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added support to generate the cinder.conf for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa32b979_8f725d48","line":9,"updated":"2015-06-15 21:01:16.000000000","message":"trailing whitespace again","commit_id":"c7cd3487e9292c63073225251a83ca42a293f13a"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"77d447e69a40e56e458a0561ef4c56e7eedb802a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Added support for DellStorageCenter ISCSI cinder driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Dell Storage Center driver manages Storage Center arrays "},{"line_number":10,"context_line":"through Enterprise Manager. "},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added support to generate the cinder.conf for"},{"line_number":13,"context_line":"the Dell Storage Center iscsi volume driver based on documentation here:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa32b979_2f90f142","line":10,"updated":"2015-06-15 21:01:16.000000000","message":"trailing whitespace again","commit_id":"c7cd3487e9292c63073225251a83ca42a293f13a"}],"manifests/backend/dellsc_iscsi.pp":[{"author":{"_account_id":10644,"name":"David Paterson","email":"davpat2112@yahoo.com","username":"dpaterson"},"change_message_id":"43421599adf067fdde45a142bb2724345b4bc90c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*dell_sc_ssn*]"},{"line_number":20,"context_line":"#   (required) The Storage Center serial number to use."},{"line_number":21,"context_line":"#  "},{"line_number":22,"context_line":"# [*volume_backend_name*]"},{"line_number":23,"context_line":"#   (optional) The storage backend name."},{"line_number":24,"context_line":"#   Defaults to the name of the backend"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3afb71cf_4a7413ce","line":21,"updated":"2015-06-08 17:20:18.000000000","message":"Delete whitespace","commit_id":"2abe733acd8b2d4f28a7c21a584667692f529a4c"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dda1db4e318ab01f480ec7ca2fb28bab49a5dc97","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   (required) Enterprise Manager user name."},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"# [*san_password*]"},{"line_number":14,"context_line":"#   (required) Enterprise Manager password."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# [*iscsi_ip_address*]"},{"line_number":17,"context_line":"#   (required) The Storage Center iSCSI IP address."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_ebfdf73a","line":14,"updated":"2015-06-08 22:15:43.000000000","message":"Enterprise Manager user password.\nSorry for being pedantic, but trying to be consistent on parameter descriptions.","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"a9f3f856b5e589be6f6ddb033aa1f62646412f63","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   (required) Enterprise Manager user name."},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"# [*san_password*]"},{"line_number":14,"context_line":"#   (required) Enterprise Manager password."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# [*iscsi_ip_address*]"},{"line_number":17,"context_line":"#   (required) The Storage Center iSCSI IP address."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_fbd92123","line":14,"in_reply_to":"3afb71cf_ebfdf73a","updated":"2015-06-09 15:18:16.000000000","message":"Fixed","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dda1db4e318ab01f480ec7ca2fb28bab49a5dc97","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*dell_sc_server_folder*]"},{"line_number":31,"context_line":"#   (optional) Server folder to place new server definitions."},{"line_number":32,"context_line":"#   Defaults to \u0027srv\u0027"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*dell_sc_volume_folder*]"},{"line_number":35,"context_line":"#   (optional) Volume folder to place created volumes"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_eb94d7e2","line":32,"updated":"2015-06-08 22:15:43.000000000","message":"Add Storage Center to the description.","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"a9f3f856b5e589be6f6ddb033aa1f62646412f63","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*dell_sc_server_folder*]"},{"line_number":31,"context_line":"#   (optional) Server folder to place new server definitions."},{"line_number":32,"context_line":"#   Defaults to \u0027srv\u0027"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*dell_sc_volume_folder*]"},{"line_number":35,"context_line":"#   (optional) Volume folder to place created volumes"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_7b0ad17a","line":32,"in_reply_to":"3afb71cf_eb94d7e2","updated":"2015-06-09 15:18:16.000000000","message":"Will change it to \"Name of the server folder to use on the Storage Center\"","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dda1db4e318ab01f480ec7ca2fb28bab49a5dc97","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*dell_sc_volume_folder*]"},{"line_number":35,"context_line":"#   (optional) Volume folder to place created volumes"},{"line_number":36,"context_line":"#   Defaults to \u0027vol\u0027"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# [*iscsi_port*]"},{"line_number":39,"context_line":"#   (optional) The iSCSI IP port."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_6bb7c786","line":36,"updated":"2015-06-08 22:15:43.000000000","message":"ditto, add SC to description.","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"a9f3f856b5e589be6f6ddb033aa1f62646412f63","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*dell_sc_volume_folder*]"},{"line_number":35,"context_line":"#   (optional) Volume folder to place created volumes"},{"line_number":36,"context_line":"#   Defaults to \u0027vol\u0027"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# [*iscsi_port*]"},{"line_number":39,"context_line":"#   (optional) The iSCSI IP port."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_7b58918a","line":36,"in_reply_to":"3afb71cf_6bb7c786","updated":"2015-06-09 15:18:16.000000000","message":"Will change it to \"Name of the volume folder to use on the Storage Center\"","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dda1db4e318ab01f480ec7ca2fb28bab49a5dc97","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# [*iscsi_port*]"},{"line_number":39,"context_line":"#   (optional) The iSCSI IP port."},{"line_number":40,"context_line":"#   Defaults to 3260"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*extra_options*]"},{"line_number":43,"context_line":"#   (optional) Hash of extra options to pass to the backend stanza"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_0badf330","line":40,"updated":"2015-06-08 22:15:43.000000000","message":"ditto, add SC to description.","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"a9f3f856b5e589be6f6ddb033aa1f62646412f63","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# [*iscsi_port*]"},{"line_number":39,"context_line":"#   (optional) The iSCSI IP port."},{"line_number":40,"context_line":"#   Defaults to 3260"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*extra_options*]"},{"line_number":43,"context_line":"#   (optional) Hash of extra options to pass to the backend stanza"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_1b02bd3d","line":40,"in_reply_to":"3afb71cf_0badf330","updated":"2015-06-09 15:18:16.000000000","message":"Will Change it to \"The ISCSI IP Port of the Storage Center\"","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dda1db4e318ab01f480ec7ca2fb28bab49a5dc97","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#   Defaults to 3260"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*extra_options*]"},{"line_number":43,"context_line":"#   (optional) Hash of extra options to pass to the backend stanza"},{"line_number":44,"context_line":"#   Defaults to: {}"},{"line_number":45,"context_line":"#   Example :"},{"line_number":46,"context_line":"#     { \u0027dellsc_iscsi_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_ab649f21","line":43,"updated":"2015-06-08 22:15:43.000000000","message":"Can you add that it is for both EM and SCs.","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"a9f3f856b5e589be6f6ddb033aa1f62646412f63","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#   Defaults to 3260"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*extra_options*]"},{"line_number":43,"context_line":"#   (optional) Hash of extra options to pass to the backend stanza"},{"line_number":44,"context_line":"#   Defaults to: {}"},{"line_number":45,"context_line":"#   Example :"},{"line_number":46,"context_line":"#     { \u0027dellsc_iscsi_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_bb33a913","line":43,"in_reply_to":"3afb71cf_ab649f21","updated":"2015-06-09 15:18:16.000000000","message":"I wouldn\u0027t change this. All the drivers have this option and the description here is the same.","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*san_ip*]"},{"line_number":8,"context_line":"#   (required)IP address of Enterprise Manager."},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*san_login*]"},{"line_number":11,"context_line":"#   (required) Enterprise Manager user name."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_97f1d903","line":8,"updated":"2015-06-09 17:47:59.000000000","message":"needs a space between (required) and IP","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# [*iscsi_ip_address*]"},{"line_number":17,"context_line":"#   (required) The Storage Center iSCSI IP address."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*dell_sc_ssn*]"},{"line_number":20,"context_line":"#   (required) The Storage Center serial number to use."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*volume_backend_name*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_17e60944","line":19,"updated":"2015-06-09 17:47:59.000000000","message":"two space indentation instead of one","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"906201b66e53b26f732a8ac5a1305bfc336984a7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#   Defaults to \u0027srv\u0027"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*dell_sc_volume_folder*]"},{"line_number":35,"context_line":"#   (optional) Name of the volume folder to use on the Storage Center"},{"line_number":36,"context_line":"#   Defaults to \u0027vol\u0027"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# [*iscsi_port*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_3bbfafab","line":35,"updated":"2015-06-09 18:07:48.000000000","message":"Minor nit: Could stand to add a period at the end of the above line","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"906201b66e53b26f732a8ac5a1305bfc336984a7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#   Defaults to 3260"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*extra_options*]"},{"line_number":43,"context_line":"#   (optional) Hash of extra options to pass to the backend stanza"},{"line_number":44,"context_line":"#   Defaults to: {}"},{"line_number":45,"context_line":"#   Example :"},{"line_number":46,"context_line":"#     { \u0027dellsc_iscsi_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_1bdf530e","line":43,"updated":"2015-06-09 18:07:48.000000000","message":"Minor nit: Could stand to add a period at the end of the above line","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# [*extra_options*]"},{"line_number":43,"context_line":"#   (optional) Hash of extra options to pass to the backend stanza"},{"line_number":44,"context_line":"#   Defaults to: {}"},{"line_number":45,"context_line":"#   Example :"},{"line_number":46,"context_line":"#     { \u0027dellsc_iscsi_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }"},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"define cinder::backend::dellsc_iscsi ("}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_973f9986","line":45,"updated":"2015-06-09 17:47:59.000000000","message":"remove the space between Example and :","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  $dell_sc_ssn,"},{"line_number":54,"context_line":"  $volume_backend_name  \u003d $name,"},{"line_number":55,"context_line":"  $dell_sc_api_port     \u003d 3033,"},{"line_number":56,"context_line":"  $dell_sc_server_folder\u003d \u0027srv\u0027,"},{"line_number":57,"context_line":"  $dell_sc_volume_folder\u003d \u0027vol\u0027,"},{"line_number":58,"context_line":"  $iscsi_port           \u003d 3260,"},{"line_number":59,"context_line":"  $extra_options        \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_975679cc","line":56,"updated":"2015-06-09 17:47:59.000000000","message":"these are too tight, move all the \u003d over one","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $dell_sc_volume_folder\u003d \u0027vol\u0027,"},{"line_number":58,"context_line":"  $iscsi_port           \u003d 3260,"},{"line_number":59,"context_line":"  $extra_options        \u003d {},"},{"line_number":60,"context_line":") {"},{"line_number":61,"context_line":"  $driver \u003d \u0027dell.dell_storagecenter_iscsi.DellStorageCenterISCSIDriver\u0027"},{"line_number":62,"context_line":"  cinder_config {"},{"line_number":63,"context_line":"    \"${name}/volume_backend_name\":  value \u003d\u003e $volume_backend_name;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_17a96924","line":60,"updated":"2015-06-09 17:47:59.000000000","message":"needs a blank line inserted here before the code","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    \"${name}/iscsi_ip_address\":     value \u003d\u003e $iscsi_ip_address;"},{"line_number":69,"context_line":"    \"${name}/dell_sc_ssn\":          value \u003d\u003e $dell_sc_ssn;"},{"line_number":70,"context_line":"    \"${name}/dell_sc_api_port\":     value \u003d\u003e $dell_sc_api_port;"},{"line_number":71,"context_line":"    \"${name}/dell_sc_server_folder\":value \u003d\u003e $dell_sc_server_folder;"},{"line_number":72,"context_line":"    \"${name}/dell_sc_volume_folder\":value \u003d\u003e $dell_sc_volume_folder;"},{"line_number":73,"context_line":"    \"${name}/iscsi_port\":           value \u003d\u003e $iscsi_port;"},{"line_number":74,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_970d59ea","line":71,"updated":"2015-06-09 17:47:59.000000000","message":"same here, too tight. provide at least one space of padding between the : and value","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"}],"manifests/volume/dellsc_iscsi.pp":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dda1db4e318ab01f480ec7ca2fb28bab49a5dc97","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#   Defaults to: {}"},{"line_number":41,"context_line":"#   Example :"},{"line_number":42,"context_line":"#     { \u0027dellsc_iscsi_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"class cinder::volume::dellsc_iscsi ("},{"line_number":45,"context_line":"  $san_ip,"},{"line_number":46,"context_line":"  $san_login,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_0b74d3cc","line":43,"updated":"2015-06-08 22:15:43.000000000","message":"the same comments as for dellsc_iscsi.pp","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"a9f3f856b5e589be6f6ddb033aa1f62646412f63","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#   Defaults to: {}"},{"line_number":41,"context_line":"#   Example :"},{"line_number":42,"context_line":"#     { \u0027dellsc_iscsi_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"class cinder::volume::dellsc_iscsi ("},{"line_number":45,"context_line":"  $san_ip,"},{"line_number":46,"context_line":"  $san_login,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_7b109159","line":43,"in_reply_to":"3afb71cf_0b74d3cc","updated":"2015-06-09 15:18:16.000000000","message":"Done","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*san_ip*]"},{"line_number":8,"context_line":"#   (required)IP address of Enterprise Manager."},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*san_login*]"},{"line_number":11,"context_line":"#   (required) Enterprise Manager user name."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_17c72965","line":8,"updated":"2015-06-09 17:47:59.000000000","message":"same issues as previous file","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# [*iscsi_ip_address*]"},{"line_number":17,"context_line":"#   (required) The Storage Center iSCSI IP address."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*dell_sc_ssn*]"},{"line_number":20,"context_line":"#   (required) The Storage Center serial number to use."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*dell_sc_api_port*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_9781d9c5","line":19,"updated":"2015-06-09 17:47:59.000000000","message":"same","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"906201b66e53b26f732a8ac5a1305bfc336984a7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   Defaults to \u0027srv\u0027"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*dell_sc_volume_folder*]"},{"line_number":31,"context_line":"#   (optional) Name of the volume folder to use on the Storage Center"},{"line_number":32,"context_line":"#   Defaults to \u0027vol\u0027"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*iscsi_port*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_fbbc77bc","line":31,"updated":"2015-06-09 18:07:48.000000000","message":"Minor nit: Could stand to add a period at the end of the above line","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"906201b66e53b26f732a8ac5a1305bfc336984a7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"#   Defaults to 3260"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# [*extra_options*]"},{"line_number":39,"context_line":"#   (optional) Hash of extra options to pass to the backend stanza"},{"line_number":40,"context_line":"#   Defaults to: {}"},{"line_number":41,"context_line":"#   Example :"},{"line_number":42,"context_line":"#     { \u0027dellsc_iscsi_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_bbb27fe3","line":39,"updated":"2015-06-09 18:07:48.000000000","message":"Minor nit: Could stand to add a period at the end of the above line","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# [*extra_options*]"},{"line_number":39,"context_line":"#   (optional) Hash of extra options to pass to the backend stanza"},{"line_number":40,"context_line":"#   Defaults to: {}"},{"line_number":41,"context_line":"#   Example :"},{"line_number":42,"context_line":"#     { \u0027dellsc_iscsi_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"class cinder::volume::dellsc_iscsi ("}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_f7724d10","line":41,"updated":"2015-06-09 17:47:59.000000000","message":"same","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  $iscsi_ip_address,"},{"line_number":49,"context_line":"  $dell_sc_ssn,"},{"line_number":50,"context_line":"  $dell_sc_api_port     \u003d 3033,"},{"line_number":51,"context_line":"  $dell_sc_server_folder\u003d \u0027srv\u0027,"},{"line_number":52,"context_line":"  $dell_sc_volume_folder\u003d \u0027vol\u0027,"},{"line_number":53,"context_line":"  $iscsi_port           \u003d 3260,"},{"line_number":54,"context_line":"  $extra_options               \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_f2501bd6","line":51,"updated":"2015-06-09 17:47:59.000000000","message":"same","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  $dell_sc_server_folder\u003d \u0027srv\u0027,"},{"line_number":52,"context_line":"  $dell_sc_volume_folder\u003d \u0027vol\u0027,"},{"line_number":53,"context_line":"  $iscsi_port           \u003d 3260,"},{"line_number":54,"context_line":"  $extra_options               \u003d {},"},{"line_number":55,"context_line":") {"},{"line_number":56,"context_line":"  cinder::backend::dellsc_iscsi { \u0027DEFAULT\u0027:"},{"line_number":57,"context_line":"    san_ip                \u003d\u003e $san_ip,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_57980178","line":54,"updated":"2015-06-09 17:47:59.000000000","message":"\u003d doesn\u0027t line up","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $dell_sc_volume_folder\u003d \u0027vol\u0027,"},{"line_number":53,"context_line":"  $iscsi_port           \u003d 3260,"},{"line_number":54,"context_line":"  $extra_options               \u003d {},"},{"line_number":55,"context_line":") {"},{"line_number":56,"context_line":"  cinder::backend::dellsc_iscsi { \u0027DEFAULT\u0027:"},{"line_number":57,"context_line":"    san_ip                \u003d\u003e $san_ip,"},{"line_number":58,"context_line":"    san_login             \u003d\u003e $san_login,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3afb71cf_923fa786","line":55,"updated":"2015-06-09 17:47:59.000000000","message":"same","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"}],"spec/classes/cinder_volume_dellsc_iscsi_spec.rb":[{"author":{"_account_id":10644,"name":"David Paterson","email":"davpat2112@yahoo.com","username":"dpaterson"},"change_message_id":"43421599adf067fdde45a142bb2724345b4bc90c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      :dell_sc_api_port     \u003d\u003e 3033,"},{"line_number":12,"context_line":"      :dell_sc_server_folder\u003d\u003e \u0027srv\u0027,"},{"line_number":13,"context_line":"      :dell_sc_volume_folder\u003d\u003e \u0027vol\u0027,"},{"line_number":14,"context_line":"      :iscsi_port           \u003d\u003e  3260,  "},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":"  end"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3afb71cf_0a7e1bae","line":14,"updated":"2015-06-08 17:20:18.000000000","message":"Delete whitespace","commit_id":"2abe733acd8b2d4f28a7c21a584667692f529a4c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ed6125e4304f6c33d615532e028dfbc21c0e7c3b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      :dell_sc_api_port     \u003d\u003e 3033,"},{"line_number":12,"context_line":"      :dell_sc_server_folder\u003d\u003e \u0027srv\u0027,"},{"line_number":13,"context_line":"      :dell_sc_volume_folder\u003d\u003e \u0027vol\u0027,"},{"line_number":14,"context_line":"      :iscsi_port           \u003d\u003e  3260,  "},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":"  end"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3afb71cf_c8548122","line":14,"updated":"2015-06-08 21:48:32.000000000","message":"Missed removing trailing whitespace here.","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"a9f3f856b5e589be6f6ddb033aa1f62646412f63","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      :dell_sc_api_port     \u003d\u003e 3033,"},{"line_number":12,"context_line":"      :dell_sc_server_folder\u003d\u003e \u0027srv\u0027,"},{"line_number":13,"context_line":"      :dell_sc_volume_folder\u003d\u003e \u0027vol\u0027,"},{"line_number":14,"context_line":"      :iscsi_port           \u003d\u003e  3260,  "},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":"  end"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3afb71cf_2db8a029","line":14,"in_reply_to":"3afb71cf_c8548122","updated":"2015-06-09 15:18:16.000000000","message":"Fixed it. For some reason, git was not marking the change as modified!","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      :iscsi_ip_address     \u003d\u003e \u0027192.168.0.20\u0027,"},{"line_number":10,"context_line":"      :dell_sc_ssn          \u003d\u003e \u002764720\u0027,"},{"line_number":11,"context_line":"      :dell_sc_api_port     \u003d\u003e 3033,"},{"line_number":12,"context_line":"      :dell_sc_server_folder\u003d\u003e \u0027srv\u0027,"},{"line_number":13,"context_line":"      :dell_sc_volume_folder\u003d\u003e \u0027vol\u0027,"},{"line_number":14,"context_line":"      :iscsi_port           \u003d\u003e  3260,"},{"line_number":15,"context_line":"  }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3afb71cf_77853d05","line":12,"updated":"2015-06-09 17:47:59.000000000","message":"not enough padding, move all the \u003d\u003e rockets over one","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      :dell_sc_api_port     \u003d\u003e 3033,"},{"line_number":12,"context_line":"      :dell_sc_server_folder\u003d\u003e \u0027srv\u0027,"},{"line_number":13,"context_line":"      :dell_sc_volume_folder\u003d\u003e \u0027vol\u0027,"},{"line_number":14,"context_line":"      :iscsi_port           \u003d\u003e  3260,"},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":"  end"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3afb71cf_b8b285e3","line":14,"updated":"2015-06-09 17:47:59.000000000","message":"2 spaces after the rocket, should be 1","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"5a0687bf068f16cbbac96225e318ac13c376c779","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      :san_password          \u003d\u003e \u002712345\u0027,"},{"line_number":9,"context_line":"      :iscsi_ip_address      \u003d\u003e \u0027192.168.0.20\u0027,"},{"line_number":10,"context_line":"      :dell_sc_ssn           \u003d\u003e \u002764720\u0027,"},{"line_number":11,"context_line":"      :dell_sc_api_port      \u003d\u003e 3033,"},{"line_number":12,"context_line":"      :dell_sc_server_folder \u003d\u003e \u0027srv\u0027,"},{"line_number":13,"context_line":"      :dell_sc_volume_folder \u003d\u003e \u0027vol\u0027,"},{"line_number":14,"context_line":"      :iscsi_port            \u003d\u003e  3260,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3afb71cf_61f4f186","line":11,"updated":"2015-06-11 17:11:22.000000000","message":"Don\u0027t set params with default values, only required/optional. Other volume drivers have a separate test for default values, this one should too. See any of the other volume driver tests for ways to implement those kinds of tests. Example: https://github.com/stackforge/puppet-cinder/blob/master/spec/classes/cinder_volume_san_spec.rb","commit_id":"3bf0adfcfd6066db9df4ff423bbb09cef6df8bef"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"79e0d72100c86181c7f45ed9da5af09b00a4d7ef","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    end"},{"line_number":24,"context_line":"  end"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  describe \u0027dellsc_iscsi volume driver\u0027 do  "},{"line_number":27,"context_line":"    it \u0027marks san_password as secret\u0027 do"},{"line_number":28,"context_line":"      is_expected.to contain_cinder_config(\u0027DEFAULT/san_password\u0027).with_secret( true )"},{"line_number":29,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3afb71cf_e4cebab6","line":26,"updated":"2015-06-11 13:38:47.000000000","message":"Have some trailing whitespace","commit_id":"3bf0adfcfd6066db9df4ff423bbb09cef6df8bef"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"a66b36ad3126835acbc063cf2c9ed32c43559f8a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  let :default_params do"},{"line_number":16,"context_line":"  {"},{"line_number":17,"context_line":"      :san_login             \u003d\u003e \u0027admin\u0027,"},{"line_number":18,"context_line":"      :dell_sc_api_port      \u003d\u003e 3033,"},{"line_number":19,"context_line":"      :dell_sc_server_folder \u003d\u003e \u0027srv\u0027,"},{"line_number":20,"context_line":"      :dell_sc_volume_folder \u003d\u003e \u0027vol\u0027,"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"fa32b979_4e3490dd","line":17,"updated":"2015-06-13 19:29:30.000000000","message":"san_login is not a default value in your classes, so should not be here. You\u0027ve set it above so it is sufficient to just delete this line.","commit_id":"f6600d8dd2768ba210e8efe142cbeda00e4e8413"}],"spec/defines/cinder_backend_dellsc_iscsi_spec.rb":[{"author":{"_account_id":10644,"name":"David Paterson","email":"davpat2112@yahoo.com","username":"dpaterson"},"change_message_id":"43421599adf067fdde45a142bb2724345b4bc90c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      :dell_sc_api_port     \u003d\u003e 3033,"},{"line_number":16,"context_line":"      :dell_sc_server_folder\u003d\u003e \u0027srv\u0027,"},{"line_number":17,"context_line":"      :dell_sc_volume_folder\u003d\u003e \u0027vol\u0027,"},{"line_number":18,"context_line":"      :iscsi_port           \u003d\u003e  3260,     "},{"line_number":19,"context_line":"    }"},{"line_number":20,"context_line":"  end"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3afb71cf_aa45c770","line":18,"updated":"2015-06-08 17:20:18.000000000","message":"Delete whitespace","commit_id":"2abe733acd8b2d4f28a7c21a584667692f529a4c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ed6125e4304f6c33d615532e028dfbc21c0e7c3b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      :dell_sc_api_port     \u003d\u003e 3033,"},{"line_number":16,"context_line":"      :dell_sc_server_folder\u003d\u003e \u0027srv\u0027,"},{"line_number":17,"context_line":"      :dell_sc_volume_folder\u003d\u003e \u0027vol\u0027,"},{"line_number":18,"context_line":"      :iscsi_port           \u003d\u003e  3260,     "},{"line_number":19,"context_line":"    }"},{"line_number":20,"context_line":"  end"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3afb71cf_483f71d6","line":18,"updated":"2015-06-08 21:48:32.000000000","message":"And trailing whitespace here.","commit_id":"8d9e9d37d639f9af38282174b1fc33647e3ca63d"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"73fc8a50a2b2f46574023a0b7937e0ac6dfa8ec5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      :iscsi_ip_address     \u003d\u003e \u0027192.168.0.20\u0027,"},{"line_number":14,"context_line":"      :dell_sc_ssn          \u003d\u003e \u002764720\u0027,"},{"line_number":15,"context_line":"      :dell_sc_api_port     \u003d\u003e 3033,"},{"line_number":16,"context_line":"      :dell_sc_server_folder\u003d\u003e \u0027srv\u0027,"},{"line_number":17,"context_line":"      :dell_sc_volume_folder\u003d\u003e \u0027vol\u0027,"},{"line_number":18,"context_line":"      :iscsi_port           \u003d\u003e  3260,"},{"line_number":19,"context_line":"  }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3afb71cf_3226b315","line":16,"updated":"2015-06-09 17:47:59.000000000","message":"same","commit_id":"868c551a4c591495f4b2a939a5cd85ea1001373b"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"5a0687bf068f16cbbac96225e318ac13c376c779","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      :san_password          \u003d\u003e \u002712345\u0027,"},{"line_number":13,"context_line":"      :iscsi_ip_address      \u003d\u003e \u0027192.168.0.20\u0027,"},{"line_number":14,"context_line":"      :dell_sc_ssn           \u003d\u003e \u002764720\u0027,"},{"line_number":15,"context_line":"      :dell_sc_api_port      \u003d\u003e 3033,"},{"line_number":16,"context_line":"      :dell_sc_server_folder \u003d\u003e \u0027srv\u0027,"},{"line_number":17,"context_line":"      :dell_sc_volume_folder \u003d\u003e \u0027vol\u0027,"},{"line_number":18,"context_line":"      :iscsi_port            \u003d\u003e 3260,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3afb71cf_c18165c5","line":15,"updated":"2015-06-11 17:11:22.000000000","message":"Same. Don\u0027t set default values in params. Test they are set to the default values instead.","commit_id":"3bf0adfcfd6066db9df4ff423bbb09cef6df8bef"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"a66b36ad3126835acbc063cf2c9ed32c43559f8a","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  let :default_params do"},{"line_number":20,"context_line":"    {"},{"line_number":21,"context_line":"      :san_login             \u003d\u003e \u0027admin\u0027,"},{"line_number":22,"context_line":"      :dell_sc_api_port      \u003d\u003e 3033,"},{"line_number":23,"context_line":"      :dell_sc_server_folder \u003d\u003e \u0027srv\u0027,"},{"line_number":24,"context_line":"      :dell_sc_volume_folder \u003d\u003e \u0027vol\u0027,"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"fa32b979_0e4d2872","line":21,"updated":"2015-06-13 19:29:30.000000000","message":"Same.","commit_id":"f6600d8dd2768ba210e8efe142cbeda00e4e8413"}]}