)]}'
{"manifests/quota_set.pp":[{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"9a9eb43f89a823a52b6718173ad4209e70b76455","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*quota_snapshots*]"},{"line_number":31,"context_line":"#   (Optional) Number of volume snapshots allowed per project."},{"line_number":32,"context_line":"#   Defaults to \u002710\u0027."},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*quota_gigabytes*]"},{"line_number":35,"context_line":"#   (Optional) Number of volume gigabytes (snapshots are also included)"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"ba3cc151_94a98226","line":32,"updated":"2015-07-02 19:09:00.000000000","message":"just 10 not \u002710\u0027","commit_id":"f2cb84b91b35e2b2e7848cd5a3381754c02282c5"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"9a9eb43f89a823a52b6718173ad4209e70b76455","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  $quota_volumes \u003d 10,"},{"line_number":52,"context_line":"  $quota_snapshots \u003d 10,"},{"line_number":53,"context_line":"  $quota_gigabytes \u003d 1000,"},{"line_number":54,"context_line":"  $quota_driver \u003d \u0027cinder.quota.DbQuotaDriver\u0027,"},{"line_number":55,"context_line":") {"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  $volume_type \u003d $name"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"ba3cc151_544d3a98","line":54,"updated":"2015-07-02 19:09:00.000000000","message":"we line these up on the \u003d sign like\nfoo     \u003d bar,\nsdsds \u003d jjj,","commit_id":"f2cb84b91b35e2b2e7848cd5a3381754c02282c5"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"44c45d494801504f5ba52d357a1a0afd10100cc4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# [*os_username*]"},{"line_number":15,"context_line":"#   (Optional) The keystone user name."},{"line_number":16,"context_line":"#   Defaults to \u0027admin."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*os_auth_url*]"},{"line_number":19,"context_line":"#   (Optional) The keystone auth url."}],"source_content_type":"text/x-puppet","patch_set":22,"id":"3a50d1a3_9fbb50e5","line":16,"updated":"2015-07-21 14:05:55.000000000","message":"Missing trailing \u0027","commit_id":"5538c7cb1c39fe6d51ed23c4edacf93b770afb83"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"44c45d494801504f5ba52d357a1a0afd10100cc4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#   (Optional) Default driver to use for quota checks."},{"line_number":41,"context_line":"#   Defaults to \u0027cinder.quota.DbQuotaDriver\u0027."},{"line_number":42,"context_line":"#"},{"line_number":43,"context_line":"# Author: Craig DeLatte \u003ccraig.delatte@twcable.com\u003e"},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"define cinder::quota_set ("},{"line_number":46,"context_line":"  $os_password,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"3a50d1a3_bfbe4cd2","line":43,"updated":"2015-07-21 14:05:55.000000000","message":"Seems like this should be removed or at the top of the file","commit_id":"5538c7cb1c39fe6d51ed23c4edacf93b770afb83"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"44c45d494801504f5ba52d357a1a0afd10100cc4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    $region_env \u003d []"},{"line_number":71,"context_line":"  }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  if $volume_type{"},{"line_number":74,"context_line":"    exec {\"cinder quota-class-update default --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\":"},{"line_number":75,"context_line":"      command     \u003d\u003e \"cinder quota-class-update default --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\","},{"line_number":76,"context_line":"      onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"3a50d1a3_5fb5c8eb","line":73,"updated":"2015-07-21 14:05:55.000000000","message":"Should have whitespace between volume_type and {","commit_id":"5538c7cb1c39fe6d51ed23c4edacf93b770afb83"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"44c45d494801504f5ba52d357a1a0afd10100cc4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  if $volume_type{"},{"line_number":74,"context_line":"    exec {\"cinder quota-class-update default --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\":"},{"line_number":75,"context_line":"      command     \u003d\u003e \"cinder quota-class-update default --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\","},{"line_number":76,"context_line":"      onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"},{"line_number":77,"context_line":"      environment \u003d\u003e concat($cinder_env, $region_env),"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"3a50d1a3_7fb8c4e5","line":74,"updated":"2015-07-21 14:05:55.000000000","message":"Should the --volume-type paramter be quoted so it can have spaces or other special characters in it?  You may also want to assume this long string to a variable before the exec and reuse it instead of repeating it.","commit_id":"5538c7cb1c39fe6d51ed23c4edacf93b770afb83"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"b668bd91bcf9cfc08882df333b31b1f495ed714a","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $volume_type {"},{"line_number":72,"context_line":"    exec {\"cinder quota-class-update default --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\":"},{"line_number":73,"context_line":"      command     \u003d\u003e \"cinder quota-class-update default --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${qvolume_type}\","},{"line_number":74,"context_line":"      onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"},{"line_number":75,"context_line":"      environment \u003d\u003e concat($cinder_env, $region_env),"},{"line_number":76,"context_line":"      require     \u003d\u003e Package[\u0027python-cinderclient\u0027],"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3a50d1a3_803bdd9b","line":73,"updated":"2015-07-21 20:18:59.000000000","message":"I\u0027m guessing the q here is a typo.","commit_id":"8b8b75242ea7438a30bbe123eae0b347b7b29337"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"edcc04551691dc2875071c6c038937591f0ee27c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: cinder::quota_set"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Setup and configure Cinder quotas per volume type."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"ba15a1d1_bca7d7a5","line":1,"updated":"2015-09-17 21:47:50.000000000","message":"also this isn\u0027t a class, it\u0027s a resource since you have \u0027define cinder::quota_set\u0027","commit_id":"c14297c866764fcec265cd76cd041ea39ec036c1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1ac160be26feb95d4bdbd8399314e3940efccc40","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $volume_type {"},{"line_number":72,"context_line":"    exec {\"cinder quota-class-update default --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\":"},{"line_number":73,"context_line":"      command     \u003d\u003e \"cinder quota-class-update default --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\","},{"line_number":74,"context_line":"      onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"},{"line_number":75,"context_line":"      environment \u003d\u003e concat($cinder_env, $region_env),"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"ba15a1d1_eb990bc5","line":72,"updated":"2015-09-17 19:29:08.000000000","message":"The length is a bit much and would be hard if we wanted to do some sort of relationship matching on the name somewhere else.  Like a Exec\u003c| \u0027cinder quota-class.....\u0027 |\u003e -\u003e Class[\u0027myclass\u0027].  We really don\u0027t need all the configuration options in the exec name, just something to make it unquie.  I think the real issue is that perhaps we should be providing the class name (default) as a parameter to allow this to be used to specify multiple quotas for different classes.\n\nhttp://docs.openstack.org/cli-reference/content/cinderclient_commands.html#cinderclient_subcommand_quota-class-update\n\nThe docs seem to indicate that you could use something other than default. So it might be better to pass in the class name as a parameter and shorten this to exec { \"cinder quota-class-update ${class_name}\": ... }","commit_id":"c14297c866764fcec265cd76cd041ea39ec036c1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9dd94280d86fad22c5de51850ccb61384a1b2dd0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $volume_type {"},{"line_number":72,"context_line":"    exec {\"cinder quota-class-update default --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\":"},{"line_number":73,"context_line":"      command     \u003d\u003e \"cinder quota-class-update default --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\","},{"line_number":74,"context_line":"      onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"},{"line_number":75,"context_line":"      environment \u003d\u003e concat($cinder_env, $region_env),"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"1a4dcd0f_8f2065b2","line":72,"updated":"2015-08-13 17:35:38.000000000","message":"please use just \u0027cinder quota class update\u0027 or something similar but short as well","commit_id":"c14297c866764fcec265cd76cd041ea39ec036c1"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"629acbf97b7b312e90aab9d77c33db9a82582b26","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $volume_type {"},{"line_number":72,"context_line":"    exec {\"cinder quota-class-update default --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\":"},{"line_number":73,"context_line":"      command     \u003d\u003e \"cinder quota-class-update default --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\","},{"line_number":74,"context_line":"      onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"},{"line_number":75,"context_line":"      environment \u003d\u003e concat($cinder_env, $region_env),"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"da20952f_8c24c0af","line":72,"in_reply_to":"1a4dcd0f_8f2065b2","updated":"2015-09-02 12:28:34.000000000","message":"why wouldn\u0027t we want it to match the cinder command?","commit_id":"c14297c866764fcec265cd76cd041ea39ec036c1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9c083cfaadc9152fb24d058586e8360eb6a0291d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if $volume_type {"},{"line_number":73,"context_line":"    exec {\"cinder quota-class-update\":"},{"line_number":74,"context_line":"      command     \u003d\u003e \"cinder quota-class-update $class_name --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\","},{"line_number":75,"context_line":"      onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"},{"line_number":76,"context_line":"      environment \u003d\u003e concat($cinder_env, $region_env),"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"5a2ca52d_a3da1977","line":73,"updated":"2015-10-13 14:01:49.000000000","message":"This needs the ${volume_type} in the exec name or trying to leverage this resource twice will fail.  Should be \"cinder quota-class-update ${volume_type}\".  Also not sure why you have the if $volume_type check here...","commit_id":"8196bac6decbe3e46a200d10ad8c6724deb8ef2a"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"bc6d805fe7b02c613dcaf14dd85c16ec970231c0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if $volume_type {"},{"line_number":73,"context_line":"    exec {\"cinder quota-class-update\":"},{"line_number":74,"context_line":"      command     \u003d\u003e \"cinder quota-class-update $class_name --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\","},{"line_number":75,"context_line":"      onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"},{"line_number":76,"context_line":"      environment \u003d\u003e concat($cinder_env, $region_env),"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"5a2ca52d_7b9fbc5f","line":73,"in_reply_to":"5a2ca52d_0312edb4","updated":"2015-10-13 18:17:30.000000000","message":"so I think what I was trying to say is along the lines of your bottom statement.   \nso volume-type is an array (outside of this).   so if you decide to use this module, you would do something like if $volume-type\ncinder::type $volume-type\ncinder::quota_set $volume type. \n\nbut essentially I am only passing in the $name which is \u003d $volume-type\ndon\u0027t mind the syntax.","commit_id":"8196bac6decbe3e46a200d10ad8c6724deb8ef2a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"baece2382cd0d12b481090729439375eaf6d6f78","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if $volume_type {"},{"line_number":73,"context_line":"    exec {\"cinder quota-class-update\":"},{"line_number":74,"context_line":"      command     \u003d\u003e \"cinder quota-class-update $class_name --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\","},{"line_number":75,"context_line":"      onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"},{"line_number":76,"context_line":"      environment \u003d\u003e concat($cinder_env, $region_env),"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"5a2ca52d_0312edb4","line":73,"in_reply_to":"5a2ca52d_238da931","updated":"2015-10-13 14:10:37.000000000","message":"If i understand what you\u0027re saying correctly, I don\u0027t think puppet works that way. So if you do something like...\n\n cinder::quota_set { [\u0027default\u0027,\u0027something\u0027]:\n   ...\n }\n\nI think it calls cinder::quota_set multiple times and so $name (and ultimately $volume_type here) would not be an array but rather there would be to calls through here one with $name set to \u0027default\u0027 and one set with $name to \u0027something\u0027.","commit_id":"8196bac6decbe3e46a200d10ad8c6724deb8ef2a"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"519bc62198de1bda4413762c2caed104a3192210","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if $volume_type {"},{"line_number":73,"context_line":"    exec {\"cinder quota-class-update\":"},{"line_number":74,"context_line":"      command     \u003d\u003e \"cinder quota-class-update $class_name --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type ${volume_type}\","},{"line_number":75,"context_line":"      onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"},{"line_number":76,"context_line":"      environment \u003d\u003e concat($cinder_env, $region_env),"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"5a2ca52d_238da931","line":73,"in_reply_to":"5a2ca52d_a3da1977","updated":"2015-10-13 14:06:17.000000000","message":"so the issue this is fixing is that when a new volume-type is created the quota gets set to -1.   with volume-type being an array you can pass in so it will ensure that any infinite quotas don\u0027t exist.  \n\nI will fix the exec piece and re-post.  I have a couple other fixes to put in as well.  \n\nI really appreciate the great feed back.","commit_id":"8196bac6decbe3e46a200d10ad8c6724deb8ef2a"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"2f9529d381e8d1b1ab0f3c77068c38dec8bd1c6f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  $os_tenant_name  \u003d \u0027admin\u0027,"},{"line_number":51,"context_line":"  $os_username     \u003d \u0027admin\u0027,"},{"line_number":52,"context_line":"  $os_auth_url     \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":53,"context_line":"  $os_region_name  \u003d undef,"},{"line_number":54,"context_line":"  $quota_volumes   \u003d 10,"},{"line_number":55,"context_line":"  $quota_snapshots \u003d 10,"},{"line_number":56,"context_line":"  $quota_gigabytes \u003d 1000,"}],"source_content_type":"text/x-puppet","patch_set":36,"id":"3a29b11f_bc254cc3","line":53,"updated":"2015-10-19 09:06:37.000000000","message":"Would it make sense to convert this default to an empty array [], as you anyway use it below?","commit_id":"e508205a165cc12baed6c37e7487df1a7ff9e778"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"3d68439f8b6eaf91433f87fd5a442cd96f205ea8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $quota_volumes   \u003d 10,"},{"line_number":55,"context_line":"  $quota_snapshots \u003d 10,"},{"line_number":56,"context_line":"  $quota_gigabytes \u003d 1000,"},{"line_number":57,"context_line":"  $quota_driver    \u003d \u0027cinder.quota.DbQuotaDriver\u0027,"},{"line_number":58,"context_line":"  $class_name      \u003d \u0027default\u0027,"},{"line_number":59,"context_line":") {"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":42,"id":"fa80f949_b141e13b","line":57,"updated":"2015-11-03 20:49:07.000000000","message":"I don\u0027t see this actually used anywhere","commit_id":"fc240f994ddb35e13fb5ee611ff1f1b831489c19"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"3d68439f8b6eaf91433f87fd5a442cd96f205ea8","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    ]"},{"line_number":79,"context_line":"  }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  if $volume_type {"},{"line_number":82,"context_line":"    exec {\"cinder quota-class-update ${class_name}\":"},{"line_number":83,"context_line":"      command     \u003d\u003e \"cinder quota-class-update ${class_name} --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type \u0027${volume_type}\u0027\","},{"line_number":84,"context_line":"      onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":42,"id":"fa80f949_d609fb32","line":81,"updated":"2015-11-03 20:49:07.000000000","message":"Reasoning behind the if statement?  Won\u0027t it always return true since the variable is always set to $name which should always be set?","commit_id":"fc240f994ddb35e13fb5ee611ff1f1b831489c19"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"439c0848cd5da48ce27e7a6d02b1eb72eb7180b1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#   Defaults to \u0027default\u0027."},{"line_number":42,"context_line":"#"},{"line_number":43,"context_line":"# [*volume_type*]"},{"line_number":44,"context_line":"#   volume type that will have quota changed"},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"define cinder::quota_set ("}],"source_content_type":"text/x-puppet","patch_set":43,"id":"ba8a016a_cf9b9d71","line":44,"updated":"2015-11-20 21:05:41.000000000","message":"note that it defaults to $name","commit_id":"8ad6e547206b9c714735f588d33e4745c28c32b0"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"439c0848cd5da48ce27e7a6d02b1eb72eb7180b1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    ]"},{"line_number":76,"context_line":"  }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  if $volume_type {"},{"line_number":79,"context_line":"    exec {\"cinder quota-class-update ${class_name}\":"},{"line_number":80,"context_line":"      command     \u003d\u003e \"cinder quota-class-update ${class_name} --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type \u0027${volume_type}\u0027\","},{"line_number":81,"context_line":"      onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":43,"id":"ba8a016a_6f871113","line":78,"updated":"2015-11-20 21:05:41.000000000","message":"unneeded per discussion","commit_id":"8ad6e547206b9c714735f588d33e4745c28c32b0"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"439c0848cd5da48ce27e7a6d02b1eb72eb7180b1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      require     \u003d\u003e Package[\u0027python-cinderclient\u0027],"},{"line_number":84,"context_line":"      path        \u003d\u003e [\u0027/usr/bin\u0027, \u0027/bin\u0027],"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":43,"id":"ba8a016a_2f8109fc","line":86,"updated":"2015-11-20 21:05:41.000000000","message":"ditto","commit_id":"8ad6e547206b9c714735f588d33e4745c28c32b0"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"8fb3bdf59bb10ebcac60eee13a769da39ad6f7c3","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  if $os_region_name {"},{"line_number":62,"context_line":"    $cinder_env \u003d ["},{"line_number":63,"context_line":"      \"OS_TENANT_NAME\u003d${os_tenant_name}\","},{"line_number":64,"context_line":"      \"OS_USERNAME\u003d${os_username}\","},{"line_number":65,"context_line":"      \"OS_PASSWORD\u003d${os_password}\","},{"line_number":66,"context_line":"      \"OS_AUTH_URL\u003d${os_auth_url}\","}],"source_content_type":"text/x-puppet","patch_set":44,"id":"9a8ffd7b_fb5c2def","line":63,"updated":"2015-11-24 16:35:10.000000000","message":"Probably outside the scope of this commit given that this is the same interface presented by cinder::type but...should be be deprecating the use of OS_TENANT_NAME?","commit_id":"f541fc48ce4714fcbc141024869614ad4f38063e"}],"spec/defines/cinder_quota_set_spec.rb":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"44c45d494801504f5ba52d357a1a0afd10100cc4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \u0027OS_AUTH_URL\u003dhttp://127.127.127.1:5000/v2.0/\u0027],"},{"line_number":28,"context_line":"      :onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"},{"line_number":29,"context_line":"      :require \u003d\u003e \u0027Package[python-cinderclient]\u0027)"},{"line_number":30,"context_line":"  end"},{"line_number":31,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":22,"id":"3a50d1a3_ffedb4ef","line":30,"updated":"2015-07-21 14:05:55.000000000","message":"Should add another test for the optional region behavior.","commit_id":"5538c7cb1c39fe6d51ed23c4edacf93b770afb83"}]}