)]}'
{"manifests/db.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"161ee9c509a3229f69ff61d90e406b87755b0468","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  if $backend_package and !defined(Package[$backend_package]) {"},{"line_number":77,"context_line":"    package {\u0027cinder-backend-package\u0027:"},{"line_number":78,"context_line":"      ensure \u003d\u003e present,"},{"line_number":79,"context_line":"      name   \u003d\u003e $backend_package,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba15a1d1_03f97480","line":76,"updated":"2015-09-14 14:53:49.000000000","message":"is this code block some kind of mistake? :)","commit_id":"63f6873e39a1ed72387d76eebf3b45299e729816"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4ea01b3b139b5848fa16bb0e491d50f52b746a52","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  if $backend_package and !defined(Package[$backend_package]) {"},{"line_number":77,"context_line":"    package {\u0027cinder-backend-package\u0027:"},{"line_number":78,"context_line":"      ensure \u003d\u003e present,"},{"line_number":79,"context_line":"      name   \u003d\u003e $backend_package,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba15a1d1_a37e88e2","line":76,"in_reply_to":"ba15a1d1_03f97480","updated":"2015-09-14 14:55:27.000000000","message":"oh, sorry, wrong review.","commit_id":"63f6873e39a1ed72387d76eebf3b45299e729816"}],"manifests/init.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"483932f62e163929bbbdd3b3e45112b570303c06","unresolved":false,"context_lines":[{"line_number":284,"context_line":"  $lock_path                          \u003d $::cinder::params::lock_path,"},{"line_number":285,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":286,"context_line":"  $mysql_module                       \u003d undef,"},{"line_number":287,"context_line":"  $database_connection                \u003d undef,"},{"line_number":288,"context_line":"  $database_idle_timeout              \u003d undef,"},{"line_number":289,"context_line":"  $database_min_pool_size             \u003d undef,"},{"line_number":290,"context_line":"  $database_max_pool_size             \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba15a1d1_6f04ce7d","line":287,"updated":"2015-09-14 16:58:33.000000000","message":"just a doubt, instead of undef should not be \u003cSERVICE DEFAULT\u003e ?","commit_id":"88cd72d24ba7a54897fa9874adf3431ccc6e8e16"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"fba03b4aab0296fe0a737f30764a6be3aa16dfea","unresolved":false,"context_lines":[{"line_number":284,"context_line":"  $lock_path                          \u003d $::cinder::params::lock_path,"},{"line_number":285,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":286,"context_line":"  $mysql_module                       \u003d undef,"},{"line_number":287,"context_line":"  $database_connection                \u003d undef,"},{"line_number":288,"context_line":"  $database_idle_timeout              \u003d undef,"},{"line_number":289,"context_line":"  $database_min_pool_size             \u003d undef,"},{"line_number":290,"context_line":"  $database_max_pool_size             \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba15a1d1_b521ba4f","line":287,"in_reply_to":"ba15a1d1_6f04ce7d","updated":"2015-09-15 08:47:25.000000000","message":"@Iury: Fair question. This review aims to be fully backward compatible with what was in place before.\n\nOslo database provides defaults (even if it is None), for every parameters but $database_connection. This is why this parameter is handled in a slightly different way than the other.\n\nPreviously, the oslo/database values were defaulting to values matching upstream defaults. This has been replaced by\nthe following in db.pp\n\npick ($::cinder::database_idle_timeout, $database_idle_timeout)\n\nBy defaut now, first param is undef, and second is \u0027\u003cSERVICE DEFAULT\u003e\u0027 so if a user specifies nothing it will default to upstream value, as before.\n\nWith $database_connection not having default value, it has been defaulting to a sqlite url. If we put the default in this class here as \u0027\u003cSERVICE DEFAULT\u003e\u0027 this is what would happen\n\npick ($::cinder::database_connection, $database_connection)\n\nSince $::cinder::database_connection would have a default value of \u0027\u003cSERVICE DEFAULT\u003e\u0027 it would always pick this one and never look at the second parameter (pick will pick the next value if undef is provided) - hence breaking backward compatibility.\n\nSo by leaving this to default in init.pp, we ensure it picks the value in db.pp that is now the sqlite URL so it remains backward compatible.\n\nI hope this explanation make sense,","commit_id":"88cd72d24ba7a54897fa9874adf3431ccc6e8e16"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"b6e8e2a7c11ac027653170a7510fd2def6a195c0","unresolved":false,"context_lines":[{"line_number":232,"context_line":"#"},{"line_number":233,"context_line":"# [*database_max_overflow*]"},{"line_number":234,"context_line":"#   If set, use this value for max_overflow with sqlalchemy."},{"line_number":235,"context_line":"#   (Optional) Defaults to undef."},{"line_number":236,"context_line":"#"},{"line_number":237,"context_line":"class cinder ("},{"line_number":238,"context_line":"  $rpc_backend                        \u003d \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ba15a1d1_7f73954e","line":235,"updated":"2015-09-24 00:52:42.000000000","message":"Why are these deprecated? It\u0027s inconsistent with the puppet-neutron patch and it means that the user is required to use hiera or redeclare cinder::db somewhere else in order to use it.","commit_id":"25bf5fbe36513de8d4bfb5c8fb7ccf27c8053d1d"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"fead5462eac2511335778920321e969313f3ec5e","unresolved":false,"context_lines":[{"line_number":232,"context_line":"#"},{"line_number":233,"context_line":"# [*database_max_overflow*]"},{"line_number":234,"context_line":"#   If set, use this value for max_overflow with sqlalchemy."},{"line_number":235,"context_line":"#   (Optional) Defaults to undef."},{"line_number":236,"context_line":"#"},{"line_number":237,"context_line":"class cinder ("},{"line_number":238,"context_line":"  $rpc_backend                        \u003d \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ba15a1d1_cc08f682","line":235,"in_reply_to":"ba15a1d1_7f73954e","updated":"2015-09-24 08:03:46.000000000","message":"They shouldn\u0027t be deprecated - you re right. This is a left over for a previous review where I had put it there when I shouldn\u0027t have.\n\nThe puppet-neutron way and the other pending reviews is the way to go.","commit_id":"25bf5fbe36513de8d4bfb5c8fb7ccf27c8053d1d"}]}