)]}'
{"manifests/cron/db_purge.pp":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"de27d6a73e26116a491704de4dbf64a4f76b839d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"# under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# \u003d\u003d Class: nova::cron::archive_deleted_rows"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# Move deleted instances to another table that you don\u0027t have to backup"},{"line_number":21,"context_line":"# unless you have data retention policies."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_2ee8fce1","line":18,"updated":"2015-08-04 13:14:25.000000000","message":"Done :)","commit_id":"dd9f8cad7954ae5a045f18cf88d5f2de160ccb13"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8cfb3c5a14cfed8180685f307564721b30a31ca2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#    (optional) Defaults to \u0027*\u0027."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"#  [*user*]"},{"line_number":41,"context_line":"#    (optional) User with access to nova files."},{"line_number":42,"context_line":"#    Defaults to \u0027nova\u0027."},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"#  [*age*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_dd36f002","line":41,"updated":"2015-08-04 12:36:51.000000000","message":"wrong copy paste ;-)","commit_id":"dd9f8cad7954ae5a045f18cf88d5f2de160ccb13"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"de27d6a73e26116a491704de4dbf64a4f76b839d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#    (optional) Defaults to \u0027*\u0027."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"#  [*user*]"},{"line_number":41,"context_line":"#    (optional) User with access to nova files."},{"line_number":42,"context_line":"#    Defaults to \u0027nova\u0027."},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"#  [*age*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_2eb0fc42","line":41,"in_reply_to":"1a4dcd0f_dd36f002","updated":"2015-08-04 13:14:25.000000000","message":"Done","commit_id":"dd9f8cad7954ae5a045f18cf88d5f2de160ccb13"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8cfb3c5a14cfed8180685f307564721b30a31ca2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  $destination \u003d \u0027/var/log/cinder/cinder-rowsflush.log\u0027"},{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  cron { \u0027nova-manage db archive_deleted_rows\u0027:"},{"line_number":66,"context_line":"    command     \u003d\u003e \"cinder-manage db purge ${age} \u003e\u003e${destination} 2\u003e\u00261\","},{"line_number":67,"context_line":"    environment \u003d\u003e \u0027PATH\u003d/bin:/usr/bin:/usr/sbin SHELL\u003d/bin/sh\u0027,"},{"line_number":68,"context_line":"    user        \u003d\u003e $user,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_3d5fd442","line":65,"updated":"2015-08-04 12:36:51.000000000","message":"wrong copy paste ;-)","commit_id":"dd9f8cad7954ae5a045f18cf88d5f2de160ccb13"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"de27d6a73e26116a491704de4dbf64a4f76b839d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  $destination \u003d \u0027/var/log/cinder/cinder-rowsflush.log\u0027"},{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  cron { \u0027nova-manage db archive_deleted_rows\u0027:"},{"line_number":66,"context_line":"    command     \u003d\u003e \"cinder-manage db purge ${age} \u003e\u003e${destination} 2\u003e\u00261\","},{"line_number":67,"context_line":"    environment \u003d\u003e \u0027PATH\u003d/bin:/usr/bin:/usr/sbin SHELL\u003d/bin/sh\u0027,"},{"line_number":68,"context_line":"    user        \u003d\u003e $user,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_4ead48e8","line":65,"in_reply_to":"1a4dcd0f_3d5fd442","updated":"2015-08-04 13:14:25.000000000","message":"Done","commit_id":"dd9f8cad7954ae5a045f18cf88d5f2de160ccb13"}],"spec/acceptance/basic_cinder_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e82875fef3ab721617955e3a9d34eeb239449c9f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"      # Run it twice to test for idempotency"},{"line_number":111,"context_line":"      apply_manifest(pp, :catch_failures \u003d\u003e true)"},{"line_number":112,"context_line":"      apply_manifest(pp, :catch_changes \u003d\u003e true)"},{"line_number":113,"context_line":"    end"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    describe port(8776) do"},{"line_number":116,"context_line":"      it { is_expected.to be_listening.with(\u0027tcp\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1a4dcd0f_b90f5d87","line":113,"updated":"2015-08-04 19:15:05.000000000","message":"I don\u0027t see any test that checks the crontab is actually created.\nPlease look at puppet-keystone or nova and see how we test it.","commit_id":"ba845be0747a15dea77713983d0ebb66d5435253"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"33c24c9333cc4d9cb588fad85b42cabe7718e485","unresolved":false,"context_lines":[{"line_number":110,"context_line":"      # Run it twice to test for idempotency"},{"line_number":111,"context_line":"      apply_manifest(pp, :catch_failures \u003d\u003e true)"},{"line_number":112,"context_line":"      apply_manifest(pp, :catch_changes \u003d\u003e true)"},{"line_number":113,"context_line":"    end"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    describe port(8776) do"},{"line_number":116,"context_line":"      it { is_expected.to be_listening.with(\u0027tcp\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1a4dcd0f_bf473d76","line":113,"in_reply_to":"1a4dcd0f_b90f5d87","updated":"2015-08-04 20:03:04.000000000","message":"doh .. ok, will add it tomorrow","commit_id":"ba845be0747a15dea77713983d0ebb66d5435253"}],"spec/classes/cinder_cron_db_purge.rb":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"70fa790a5c4d5064c55cd89f07c8cfdbc524090d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  end"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  it \u0027configures a cron\u0027 do"},{"line_number":21,"context_line":"    is_expected.to contain_cron(\u0027nova-manage db archive_deleted_rows\u0027).with("},{"line_number":22,"context_line":"      :command     \u003d\u003e \"cinder-manage db purge #{params[:age]} \u003e\u003e#{params[:destination]} 2\u003e\u00261\","},{"line_number":23,"context_line":"      :environment \u003d\u003e \u0027PATH\u003d/bin:/usr/bin:/usr/sbin SHELL\u003d/bin/sh\u0027,"},{"line_number":24,"context_line":"      :user        \u003d\u003e params[:user],"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1a4dcd0f_8c74859c","line":21,"updated":"2015-08-11 09:37:58.000000000","message":"Wrong copy/paste. It states nova here.","commit_id":"d5fdbd88e4046c8c391c940d1652987aaf9d07fc"}]}