)]}'
{"manifests/backend/rbd.pp":[{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"c7247d8553ec544863b4747fb344e875258fbde5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    \"${name}/rbd_pool\":                         value \u003d\u003e $rbd_pool;"},{"line_number":67,"context_line":"    \"${name}/rbd_max_clone_depth\":              value \u003d\u003e $rbd_max_clone_depth;"},{"line_number":68,"context_line":"    \"${name}/rbd_flatten_volume_from_snapshot\": value \u003d\u003e $rbd_flatten_volume_from_snapshot;"},{"line_number":69,"context_line":"    \"${name}/host\":                             value \u003d\u003e \"rbd:${rbd_pool}\";"},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if $rbd_secret_uuid {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_aaec0dc8","line":69,"updated":"2015-08-18 08:33:31.000000000","message":"I think DEFAULT/host is part of cinder.common config options - why do we configure as part of the rbd class and not in init?","commit_id":"e58b63a0d9358ce7a4d8219208ffe681e5125080"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"3680308d7f9d1cb8447742531334405dd7b95653","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    \"${name}/rbd_pool\":                         value \u003d\u003e $rbd_pool;"},{"line_number":67,"context_line":"    \"${name}/rbd_max_clone_depth\":              value \u003d\u003e $rbd_max_clone_depth;"},{"line_number":68,"context_line":"    \"${name}/rbd_flatten_volume_from_snapshot\": value \u003d\u003e $rbd_flatten_volume_from_snapshot;"},{"line_number":69,"context_line":"    \"${name}/host\":                             value \u003d\u003e \"rbd:${rbd_pool}\";"},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if $rbd_secret_uuid {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_804e6f6d","line":69,"in_reply_to":"fa1b9901_04cd9a84","updated":"2015-08-25 17:13:02.000000000","message":"\"host\" in this context is used to set the cinder-volume ID, this allows for multiple cinder-volume nodes to control the rbd volumes, with this its possible to have fail over between the cinder-volume services and maintain access to the volumes it creates.","commit_id":"e58b63a0d9358ce7a4d8219208ffe681e5125080"},{"author":{"_account_id":14007,"name":"Maksym Yatsenko","email":"myatsenko@mirantis.com","username":"myatsenko"},"change_message_id":"60a753e861d506856af0d43ab5aaeb63385c7500","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    \"${name}/rbd_pool\":                         value \u003d\u003e $rbd_pool;"},{"line_number":67,"context_line":"    \"${name}/rbd_max_clone_depth\":              value \u003d\u003e $rbd_max_clone_depth;"},{"line_number":68,"context_line":"    \"${name}/rbd_flatten_volume_from_snapshot\": value \u003d\u003e $rbd_flatten_volume_from_snapshot;"},{"line_number":69,"context_line":"    \"${name}/host\":                             value \u003d\u003e \"rbd:${rbd_pool}\";"},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if $rbd_secret_uuid {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_c1eeff21","line":69,"in_reply_to":"fa1b9901_aaec0dc8","updated":"2015-08-18 11:12:07.000000000","message":"thanks for comments,\nthis commit sets \"host\" parameter to the same value on all\ncontrollers when rbd backend is enable, due to this reason rbd class\nis used. Do you think it should be transfered to init?\nCan we use this \"rbd:${rbd_pool}\" value for \"host\" as it can be more \nconvinient way to describe hosts than default \"host\"s value? or\ndefault value should be used?","commit_id":"e58b63a0d9358ce7a4d8219208ffe681e5125080"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"5a7048bddbc6540fb6c9060bb276707d9845966a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    \"${name}/rbd_pool\":                         value \u003d\u003e $rbd_pool;"},{"line_number":67,"context_line":"    \"${name}/rbd_max_clone_depth\":              value \u003d\u003e $rbd_max_clone_depth;"},{"line_number":68,"context_line":"    \"${name}/rbd_flatten_volume_from_snapshot\": value \u003d\u003e $rbd_flatten_volume_from_snapshot;"},{"line_number":69,"context_line":"    \"${name}/host\":                             value \u003d\u003e \"rbd:${rbd_pool}\";"},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if $rbd_secret_uuid {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_04cd9a84","line":69,"in_reply_to":"fa1b9901_c1eeff21","updated":"2015-08-25 15:19:49.000000000","message":"Context for why rbd neads special treatment for this parameter: https://bugs.launchpad.net/mos/+bug/1371328","commit_id":"e58b63a0d9358ce7a4d8219208ffe681e5125080"}]}