)]}'
{"manifests/keystone/auth.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"27d70bd87222ee2ba37269ba12e65a90ca830bd7","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  $real_service_name_v2 \u003d pick($service_name_v2, $auth_name_v2)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"  # TO-DO: chande default service names according to default_catalog in next (M) cycle"},{"line_number":222,"context_line":"  if $service_name \u003d\u003d undef {"},{"line_number":223,"context_line":"    warning(\u0027Note that service_name parameter will be changed according to default_catalog in a future release. Please update your manifest accordingly.\u0027)"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":"  if $service_name_v2 \u003d\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a2ca52d_17451416","line":222,"range":{"start_line":222,"start_character":6,"end_line":222,"end_character":27},"updated":"2015-10-14 14:06:09.000000000","message":"there is not need to compare to undef. An empty value is considered as a false boolean.","commit_id":"095e4dc2ccf39f96dbcc07079089d97f746c7aa7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"27d70bd87222ee2ba37269ba12e65a90ca830bd7","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  $real_service_name_v2 \u003d pick($service_name_v2, $auth_name_v2)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"  # TO-DO: chande default service names according to default_catalog in next (M) cycle"},{"line_number":222,"context_line":"  if $service_name \u003d\u003d undef {"},{"line_number":223,"context_line":"    warning(\u0027Note that service_name parameter will be changed according to default_catalog in a future release. Please update your manifest accordingly.\u0027)"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":"  if $service_name_v2 \u003d\u003d undef {"},{"line_number":226,"context_line":"    warning(\u0027Note that service_name_v2 parameter will be changed according to default_catalog in a future release. Please update your manifest accordingly.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a2ca52d_175c34ec","line":223,"range":{"start_line":222,"start_character":29,"end_line":223,"end_character":70},"updated":"2015-10-14 14:06:09.000000000","message":"I personally don\u0027t understand the warning and what we need to change.","commit_id":"095e4dc2ccf39f96dbcc07079089d97f746c7aa7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"56d05ae9eb233c6264020177b11118e81296001c","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  $real_service_name_v2 \u003d pick($service_name_v2, $auth_name_v2)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"  # TO-DO: chande default service names according to default_catalog in next (M) cycle"},{"line_number":222,"context_line":"  if !$service_name {"},{"line_number":223,"context_line":"    warning(\u0027Note that service_name parameter default value will be changed to \"Volume Service\" (according to Keystone default catalog) in a future release. In case you use different value, please update your manifests accordingly.\u0027)"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":"  if !$service_name_v2 {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a2ca52d_5f8cfe34","line":222,"updated":"2015-10-14 16:00:53.000000000","message":"I\u0027m not sure this is the right condition.\nIf you\u0027re going to change the default soon, why not","commit_id":"4513170371cab3b0926826e8cc63b0b08cd14d22"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3d12862949f1d983cbbe7109f1687fe04f964334","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  $real_service_name_v2 \u003d pick($service_name_v2, $auth_name_v2)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"  # TO-DO: chande default service names according to default_catalog in next (M) cycle"},{"line_number":222,"context_line":"  if !$service_name {"},{"line_number":223,"context_line":"    warning(\u0027Note that service_name parameter default value will be changed to \"Volume Service\" (according to Keystone default catalog) in a future release. In case you use different value, please update your manifests accordingly.\u0027)"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":"  if !$service_name_v2 {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a2ca52d_19c1a22e","line":222,"in_reply_to":"5a2ca52d_5f8cfe34","updated":"2015-10-15 09:57:01.000000000","message":"If user is using $service_name already, he/she won\u0027t be hit by a default value change in the future release. Only those users using undef now might be surprised in future that endpoint names are different.","commit_id":"4513170371cab3b0926826e8cc63b0b08cd14d22"},{"author":{"_account_id":7431,"name":"Jay_Clark","email":"jay.clark@gmail.com","username":"jclark"},"change_message_id":"cf21baec6e5da8a664afb7f16b98c83aee6ffb7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3a29b11f_c2d67327","updated":"2015-10-22 10:56:28.000000000","message":"Not sure if this #TO-DO comment is going to be removed, but I think this should be \u0027change\u0027 instead of \u0027chande\u0027. Otherwise, this looks good.","commit_id":"f3274cf0acb540f8a47a2d951d9c173ba6b1377b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fda155d7b8c97de2b83129b7da38a80b75af9148","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  $real_service_name_v2 \u003d pick($service_name_v2, $auth_name_v2)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"  # TO-DO: change default service names according to default_catalog in next (M) cycle"},{"line_number":222,"context_line":"  if !$service_name {"},{"line_number":223,"context_line":"    warning(\u0027Note that service_name parameter default value will be changed to \"Volume Service\" (according to Keystone default catalog) in a future release. In case you use different value, please update your manifests accordingly.\u0027)"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":"  if !$service_name_v2 {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_dfe3d9a2","line":222,"updated":"2015-11-06 11:08:43.000000000","message":"why this message raises when !$service_name? May be we need raise message when this parameter are not undef?","commit_id":"5c783650dc581ee2700b7754ee180ea7285b8cd4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"1b667a9fb5df3b157d826c79797f2bf8e486d92e","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  $real_service_name_v2 \u003d pick($service_name_v2, $auth_name_v2)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"  # TO-DO: change default service names according to default_catalog in next (M) cycle"},{"line_number":222,"context_line":"  if !$service_name {"},{"line_number":223,"context_line":"    warning(\u0027Note that service_name parameter default value will be changed to \"Volume Service\" (according to Keystone default catalog) in a future release. In case you use different value, please update your manifests accordingly.\u0027)"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":"  if !$service_name_v2 {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_2d5e7812","line":222,"in_reply_to":"fa80f949_dfe3d9a2","updated":"2015-11-06 13:04:18.000000000","message":"When user is using $service_name parameter the future change won\u0027t hit him at all. On the other hand when user is not overriding default undef the future deployment will create endpoint with different name. Hence warn user if undef is not overridden.","commit_id":"5c783650dc581ee2700b7754ee180ea7285b8cd4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fda155d7b8c97de2b83129b7da38a80b75af9148","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    warning(\u0027Note that service_name parameter default value will be changed to \"Volume Service\" (according to Keystone default catalog) in a future release. In case you use different value, please update your manifests accordingly.\u0027)"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":"  if !$service_name_v2 {"},{"line_number":226,"context_line":"    warning(\u0027Note that service_name parameter default value will be changed to \"Volume Service v2\" in a future release. In case you use different value, please update your manifests accordingly.\u0027)"},{"line_number":227,"context_line":"  }"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"  if $real_service_name \u003d\u003d $real_service_name_v2 {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_1f70810a","line":226,"updated":"2015-11-06 11:08:43.000000000","message":"service_name_v2","commit_id":"5c783650dc581ee2700b7754ee180ea7285b8cd4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"1b667a9fb5df3b157d826c79797f2bf8e486d92e","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    warning(\u0027Note that service_name parameter default value will be changed to \"Volume Service\" (according to Keystone default catalog) in a future release. In case you use different value, please update your manifests accordingly.\u0027)"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":"  if !$service_name_v2 {"},{"line_number":226,"context_line":"    warning(\u0027Note that service_name parameter default value will be changed to \"Volume Service v2\" in a future release. In case you use different value, please update your manifests accordingly.\u0027)"},{"line_number":227,"context_line":"  }"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"  if $real_service_name \u003d\u003d $real_service_name_v2 {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_eda2b0fc","line":226,"in_reply_to":"fa80f949_1f70810a","updated":"2015-11-06 13:04:18.000000000","message":"Done","commit_id":"5c783650dc581ee2700b7754ee180ea7285b8cd4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"511735e1134d991ed2989e94dabe77fa46aa48d5","unresolved":false,"context_lines":[{"line_number":239,"context_line":"  $real_service_name \u003d pick($service_name, $auth_name)"},{"line_number":240,"context_line":"  $real_service_name_v2 \u003d pick($service_name_v2, $auth_name_v2)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"  # TO-DO: change default service names according to default_catalog in next (M) cycle"},{"line_number":243,"context_line":"  if !$service_name {"},{"line_number":244,"context_line":"    warning(\u0027Note that service_name parameter default value will be changed to \"Volume Service\" (according to Keystone default catalog) in a future release. In case you use different value, please update your manifests accordingly.\u0027)"},{"line_number":245,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba8a016a_15c6479a","line":242,"updated":"2015-11-18 00:23:28.000000000","message":"Yes, this is a minor comment but still valid, this is already how OpenStack does TODOs, but we don\u0027t have pep8 equivalient jobs that detect mistakes in that.","commit_id":"93699de1c130d8922b935150628d43728bb35f3c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"234e1b6e3fae6a1f8a4319c4c71d1f819b52a224","unresolved":false,"context_lines":[{"line_number":239,"context_line":"  $real_service_name \u003d pick($service_name, $auth_name)"},{"line_number":240,"context_line":"  $real_service_name_v2 \u003d pick($service_name_v2, $auth_name_v2)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"  # TO-DO: change default service names according to default_catalog in next (M) cycle"},{"line_number":243,"context_line":"  if !$service_name {"},{"line_number":244,"context_line":"    warning(\u0027Note that service_name parameter default value will be changed to \"Volume Service\" (according to Keystone default catalog) in a future release. In case you use different value, please update your manifests accordingly.\u0027)"},{"line_number":245,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba8a016a_856a7019","line":242,"updated":"2015-11-16 11:33:04.000000000","message":"nit: please use TODO(nick)","commit_id":"93699de1c130d8922b935150628d43728bb35f3c"}]}