)]}'
{"manifests/backend/dellsc_iscsi.pp":[{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"85bc77d0d96c24defde1dc65c55882184c2bbd73","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $san_login,"},{"line_number":55,"context_line":"  $san_password,"},{"line_number":56,"context_line":"  $iscsi_ip_address,"},{"line_number":57,"context_line":"  $dell_sc_ssn,"},{"line_number":58,"context_line":"  $volume_backend_name   \u003d $name,"},{"line_number":59,"context_line":"  $dell_sc_api_port      \u003d $::os_service_default,"},{"line_number":60,"context_line":"  $dell_sc_server_folder \u003d \u0027srv\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_35e0df95","line":57,"updated":"2015-11-03 01:03:22.000000000","message":"This has a default according to http://docs.openstack.org/liberty/config-reference/content/dell-storagecenter-driver.html so should have probably have a deprecation set and changed at a later date.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1e851a951d116a6b13f44ca706d604cabd59180","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $san_login,"},{"line_number":55,"context_line":"  $san_password,"},{"line_number":56,"context_line":"  $iscsi_ip_address,"},{"line_number":57,"context_line":"  $dell_sc_ssn,"},{"line_number":58,"context_line":"  $volume_backend_name   \u003d $name,"},{"line_number":59,"context_line":"  $dell_sc_api_port      \u003d $::os_service_default,"},{"line_number":60,"context_line":"  $dell_sc_server_folder \u003d \u0027srv\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_6ed39339","line":57,"in_reply_to":"1a26ad4f_35e0df95","updated":"2015-11-03 22:11:03.000000000","message":"Currently this is a required parameter, not sure if we should switch it to optional as the variable seems to lend itself to being required (a serial number)","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"417e9d01d86d15202ebc374c20e0fadb484b09f7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $san_login,"},{"line_number":55,"context_line":"  $san_password,"},{"line_number":56,"context_line":"  $iscsi_ip_address,"},{"line_number":57,"context_line":"  $dell_sc_ssn,"},{"line_number":58,"context_line":"  $volume_backend_name   \u003d $name,"},{"line_number":59,"context_line":"  $dell_sc_api_port      \u003d $::os_service_default,"},{"line_number":60,"context_line":"  $dell_sc_server_folder \u003d \u0027srv\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_33d71225","line":57,"in_reply_to":"fa80f949_6ed39339","updated":"2015-11-04 16:59:27.000000000","message":"Yeah. By the name and description of the variable alone I would agree.  Would probably need to ask someone that has actual used this kind of Dell storage array.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"85bc77d0d96c24defde1dc65c55882184c2bbd73","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $dell_sc_ssn,"},{"line_number":58,"context_line":"  $volume_backend_name   \u003d $name,"},{"line_number":59,"context_line":"  $dell_sc_api_port      \u003d $::os_service_default,"},{"line_number":60,"context_line":"  $dell_sc_server_folder \u003d \u0027srv\u0027,"},{"line_number":61,"context_line":"  $dell_sc_verify_cert   \u003d $::os_service_default,"},{"line_number":62,"context_line":"  $dell_sc_volume_folder \u003d \u0027vol\u0027,"},{"line_number":63,"context_line":"  $iscsi_port            \u003d 3260,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_9580d3c0","line":60,"updated":"2015-11-03 01:03:22.000000000","message":"Default value that doesn\u0027t match upstream default, should have a deprecation warning added.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1e851a951d116a6b13f44ca706d604cabd59180","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $dell_sc_ssn,"},{"line_number":58,"context_line":"  $volume_backend_name   \u003d $name,"},{"line_number":59,"context_line":"  $dell_sc_api_port      \u003d $::os_service_default,"},{"line_number":60,"context_line":"  $dell_sc_server_folder \u003d \u0027srv\u0027,"},{"line_number":61,"context_line":"  $dell_sc_verify_cert   \u003d $::os_service_default,"},{"line_number":62,"context_line":"  $dell_sc_volume_folder \u003d \u0027vol\u0027,"},{"line_number":63,"context_line":"  $iscsi_port            \u003d 3260,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_8ed83755","line":60,"in_reply_to":"1a26ad4f_9580d3c0","updated":"2015-11-03 22:11:03.000000000","message":"Done","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"85bc77d0d96c24defde1dc65c55882184c2bbd73","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  $dell_sc_api_port      \u003d $::os_service_default,"},{"line_number":60,"context_line":"  $dell_sc_server_folder \u003d \u0027srv\u0027,"},{"line_number":61,"context_line":"  $dell_sc_verify_cert   \u003d $::os_service_default,"},{"line_number":62,"context_line":"  $dell_sc_volume_folder \u003d \u0027vol\u0027,"},{"line_number":63,"context_line":"  $iscsi_port            \u003d 3260,"},{"line_number":64,"context_line":"  $extra_options         \u003d {},"},{"line_number":65,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_b585cfcf","line":62,"updated":"2015-11-03 01:03:22.000000000","message":"Default value that doesn\u0027t match upstream default, should have a deprecation warning added.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1e851a951d116a6b13f44ca706d604cabd59180","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  $dell_sc_api_port      \u003d $::os_service_default,"},{"line_number":60,"context_line":"  $dell_sc_server_folder \u003d \u0027srv\u0027,"},{"line_number":61,"context_line":"  $dell_sc_verify_cert   \u003d $::os_service_default,"},{"line_number":62,"context_line":"  $dell_sc_volume_folder \u003d \u0027vol\u0027,"},{"line_number":63,"context_line":"  $iscsi_port            \u003d 3260,"},{"line_number":64,"context_line":"  $extra_options         \u003d {},"},{"line_number":65,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_2edd8b42","line":62,"in_reply_to":"1a26ad4f_b585cfcf","updated":"2015-11-03 22:11:03.000000000","message":"Done","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"85bc77d0d96c24defde1dc65c55882184c2bbd73","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  $dell_sc_server_folder \u003d \u0027srv\u0027,"},{"line_number":61,"context_line":"  $dell_sc_verify_cert   \u003d $::os_service_default,"},{"line_number":62,"context_line":"  $dell_sc_volume_folder \u003d \u0027vol\u0027,"},{"line_number":63,"context_line":"  $iscsi_port            \u003d 3260,"},{"line_number":64,"context_line":"  $extra_options         \u003d {},"},{"line_number":65,"context_line":") {"},{"line_number":66,"context_line":"  $driver \u003d \u0027dell.dell_storagecenter_iscsi.DellStorageCenterISCSIDriver\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_f566e74f","line":63,"updated":"2015-11-03 01:03:22.000000000","message":"This is the upstream default according to https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L61.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1e851a951d116a6b13f44ca706d604cabd59180","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  $dell_sc_server_folder \u003d \u0027srv\u0027,"},{"line_number":61,"context_line":"  $dell_sc_verify_cert   \u003d $::os_service_default,"},{"line_number":62,"context_line":"  $dell_sc_volume_folder \u003d \u0027vol\u0027,"},{"line_number":63,"context_line":"  $iscsi_port            \u003d 3260,"},{"line_number":64,"context_line":"  $extra_options         \u003d {},"},{"line_number":65,"context_line":") {"},{"line_number":66,"context_line":"  $driver \u003d \u0027dell.dell_storagecenter_iscsi.DellStorageCenterISCSIDriver\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_0ee52708","line":63,"in_reply_to":"1a26ad4f_f566e74f","updated":"2015-11-03 22:11:03.000000000","message":"Done","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"}],"manifests/backend/eqlx.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"09392da30de3a56defe3055c0c812a9e5ff6dfa2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*eqlx_chap_login*]"},{"line_number":37,"context_line":"#   (optional) An existing CHAP account name."},{"line_number":38,"context_line":"#   Defaults to \u0027chapadmin\u0027"},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*eqlx_chap_password*]"},{"line_number":41,"context_line":"#   (optional) The password for the specified CHAP account name."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_eebe63d3","line":38,"updated":"2015-10-30 02:57:21.000000000","message":"i\u0027ve thinked tha we will switch everything with Defaults value to $::os_service_default.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1e851a951d116a6b13f44ca706d604cabd59180","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*eqlx_chap_login*]"},{"line_number":37,"context_line":"#   (optional) An existing CHAP account name."},{"line_number":38,"context_line":"#   Defaults to \u0027chapadmin\u0027"},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*eqlx_chap_password*]"},{"line_number":41,"context_line":"#   (optional) The password for the specified CHAP account name."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_8e3117a5","line":38,"in_reply_to":"1a26ad4f_75717775","updated":"2015-11-03 22:11:03.000000000","message":"Done","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"85bc77d0d96c24defde1dc65c55882184c2bbd73","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*eqlx_chap_login*]"},{"line_number":37,"context_line":"#   (optional) An existing CHAP account name."},{"line_number":38,"context_line":"#   Defaults to \u0027chapadmin\u0027"},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*eqlx_chap_password*]"},{"line_number":41,"context_line":"#   (optional) The password for the specified CHAP account name."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_75717775","line":38,"in_reply_to":"1a26ad4f_eb73a313","updated":"2015-11-03 01:03:22.000000000","message":"We need to to go through the proper deprecation process, is all.  I\u0027d be good with throwing a warning to the user here.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"768120fc0a1fafe913ed94425abb1028267d7887","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*eqlx_chap_login*]"},{"line_number":37,"context_line":"#   (optional) An existing CHAP account name."},{"line_number":38,"context_line":"#   Defaults to \u0027chapadmin\u0027"},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*eqlx_chap_password*]"},{"line_number":41,"context_line":"#   (optional) The password for the specified CHAP account name."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_eb73a313","line":38,"in_reply_to":"1a26ad4f_eebe63d3","updated":"2015-10-30 13:35:31.000000000","message":"I would except this value is not the same as the default value. My concern for where the puppet module specified something other than the default is that we\u0027ll break people when they update if they were using the puppet value rather than their own.  We could add a warning in for these situations saying it will be switched...","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"85bc77d0d96c24defde1dc65c55882184c2bbd73","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  $san_ip,"},{"line_number":60,"context_line":"  $san_login,"},{"line_number":61,"context_line":"  $san_password,"},{"line_number":62,"context_line":"  $san_thin_provision   \u003d true,"},{"line_number":63,"context_line":"  $volume_backend_name  \u003d $name,"},{"line_number":64,"context_line":"  $eqlx_group_name      \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $eqlx_pool            \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_35a53f46","line":62,"updated":"2015-11-03 01:03:22.000000000","message":"This is the upstream default according to https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/san/san.py#L39.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1e851a951d116a6b13f44ca706d604cabd59180","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  $san_ip,"},{"line_number":60,"context_line":"  $san_login,"},{"line_number":61,"context_line":"  $san_password,"},{"line_number":62,"context_line":"  $san_thin_provision   \u003d true,"},{"line_number":63,"context_line":"  $volume_backend_name  \u003d $name,"},{"line_number":64,"context_line":"  $eqlx_group_name      \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $eqlx_pool            \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_2e26eb68","line":62,"in_reply_to":"1a26ad4f_35a53f46","updated":"2015-11-03 22:11:03.000000000","message":"Done","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"85bc77d0d96c24defde1dc65c55882184c2bbd73","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  $volume_backend_name  \u003d $name,"},{"line_number":64,"context_line":"  $eqlx_group_name      \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $eqlx_pool            \u003d $::os_service_default,"},{"line_number":66,"context_line":"  $eqlx_use_chap        \u003d false,"},{"line_number":67,"context_line":"  $eqlx_chap_login      \u003d \u0027chapadmin\u0027,"},{"line_number":68,"context_line":"  $eqlx_chap_password   \u003d \u002712345\u0027,"},{"line_number":69,"context_line":"  $eqlx_cli_timeout     \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_b55cef7d","line":66,"updated":"2015-11-03 01:03:22.000000000","message":"http://docs.openstack.org/liberty/config-reference/content/dell-equallogic-driver.html https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L183\nBoth of these indicate that \"false\" is the service default.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1e851a951d116a6b13f44ca706d604cabd59180","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  $volume_backend_name  \u003d $name,"},{"line_number":64,"context_line":"  $eqlx_group_name      \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $eqlx_pool            \u003d $::os_service_default,"},{"line_number":66,"context_line":"  $eqlx_use_chap        \u003d false,"},{"line_number":67,"context_line":"  $eqlx_chap_login      \u003d \u0027chapadmin\u0027,"},{"line_number":68,"context_line":"  $eqlx_chap_password   \u003d \u002712345\u0027,"},{"line_number":69,"context_line":"  $eqlx_cli_timeout     \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_4e2b2f31","line":66,"in_reply_to":"1a26ad4f_b55cef7d","updated":"2015-11-03 22:11:03.000000000","message":"Done","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"85bc77d0d96c24defde1dc65c55882184c2bbd73","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"${name}/eqlx_pool\":            value \u003d\u003e $eqlx_pool;"},{"line_number":85,"context_line":"  }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  if(str2bool($eqlx_use_chap)) {"},{"line_number":88,"context_line":"    cinder_config {"},{"line_number":89,"context_line":"      \"${name}/eqlx_chap_login\":      value \u003d\u003e $eqlx_chap_login;"},{"line_number":90,"context_line":"      \"${name}/eqlx_chap_password\":   value \u003d\u003e $eqlx_chap_password, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_5556bb5c","line":87,"updated":"2015-11-03 01:03:22.000000000","message":"If $eqlx_use_chap is set to $::os_service_default then this conditional will have to be changed to a string comparison. This is actually probably a good thing because if you send \"str2bool\" false is Puppet 4 it will throw an error because the function can\u0027t handle a real boolean which false now is in Puppet 4...consequently this probably means we aren\u0027t actually fully testing this define.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1e851a951d116a6b13f44ca706d604cabd59180","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"${name}/eqlx_pool\":            value \u003d\u003e $eqlx_pool;"},{"line_number":85,"context_line":"  }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  if(str2bool($eqlx_use_chap)) {"},{"line_number":88,"context_line":"    cinder_config {"},{"line_number":89,"context_line":"      \"${name}/eqlx_chap_login\":      value \u003d\u003e $eqlx_chap_login;"},{"line_number":90,"context_line":"      \"${name}/eqlx_chap_password\":   value \u003d\u003e $eqlx_chap_password, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_0e1e870c","line":87,"in_reply_to":"1a26ad4f_5556bb5c","updated":"2015-11-03 22:11:03.000000000","message":"Done","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"}],"manifests/backend/glusterfs.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7bb7fe798313d841773c7d4b9f6a0ff24bdd9f63","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \"${name}/volume_backend_name\":  value \u003d\u003e $volume_backend_name;"},{"line_number":71,"context_line":"    \"${name}/volume_driver\":        value \u003d\u003e"},{"line_number":72,"context_line":"      \u0027cinder.volume.drivers.glusterfs.GlusterfsDriver\u0027;"},{"line_number":73,"context_line":"    \"${name}/glusterfs_backup_mount_point\": value \u003d\u003e $glusterfs_backup_mount_point;"},{"line_number":74,"context_line":"    \"${name}/glusterfs_backup_share\":     value \u003d\u003e $glusterfs_backup_share;"},{"line_number":75,"context_line":"    \"${name}/glusterfs_shares_config\":    value \u003d\u003e $glusterfs_shares_config;"},{"line_number":76,"context_line":"    \"${name}/glusterfs_sparsed_volumes\":  value \u003d\u003e $glusterfs_sparsed_volumes;"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"da85f559_6a0cc994","line":73,"updated":"2015-11-09 14:26:34.000000000","message":"nit: alignment","commit_id":"32cabbee695e23af909707f532da64df4e329667"}],"manifests/backend/iscsi.pp":[{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"85bc77d0d96c24defde1dc65c55882184c2bbd73","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $volume_backend_name \u003d $name,"},{"line_number":42,"context_line":"  $volume_driver       \u003d \u0027cinder.volume.drivers.lvm.LVMVolumeDriver\u0027,"},{"line_number":43,"context_line":"  $volume_group        \u003d $::os_service_default,"},{"line_number":44,"context_line":"  $volumes_dir         \u003d \u0027/var/lib/cinder/volumes\u0027,"},{"line_number":45,"context_line":"  $iscsi_helper        \u003d $::cinder::params::iscsi_helper,"},{"line_number":46,"context_line":"  $iscsi_protocol      \u003d \u0027iscsi\u0027,"},{"line_number":47,"context_line":"  $extra_options       \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_796ad182","line":44,"updated":"2015-11-03 01:03:22.000000000","message":"This is likely the upstream default but it actually set according to what cinder\u0027s state_path is set to.  Probably the only reliable way to get this value is a state_path fact for each OpenStack service.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1e851a951d116a6b13f44ca706d604cabd59180","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $volume_backend_name \u003d $name,"},{"line_number":42,"context_line":"  $volume_driver       \u003d \u0027cinder.volume.drivers.lvm.LVMVolumeDriver\u0027,"},{"line_number":43,"context_line":"  $volume_group        \u003d $::os_service_default,"},{"line_number":44,"context_line":"  $volumes_dir         \u003d \u0027/var/lib/cinder/volumes\u0027,"},{"line_number":45,"context_line":"  $iscsi_helper        \u003d $::cinder::params::iscsi_helper,"},{"line_number":46,"context_line":"  $iscsi_protocol      \u003d \u0027iscsi\u0027,"},{"line_number":47,"context_line":"  $extra_options       \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_2e0fcbe2","line":44,"in_reply_to":"1a26ad4f_796ad182","updated":"2015-11-03 22:11:03.000000000","message":"yea i\u0027m going to leave this for now since this could break a bunch of different things without a quality solution.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"85bc77d0d96c24defde1dc65c55882184c2bbd73","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  $volume_driver       \u003d \u0027cinder.volume.drivers.lvm.LVMVolumeDriver\u0027,"},{"line_number":43,"context_line":"  $volume_group        \u003d $::os_service_default,"},{"line_number":44,"context_line":"  $volumes_dir         \u003d \u0027/var/lib/cinder/volumes\u0027,"},{"line_number":45,"context_line":"  $iscsi_helper        \u003d $::cinder::params::iscsi_helper,"},{"line_number":46,"context_line":"  $iscsi_protocol      \u003d \u0027iscsi\u0027,"},{"line_number":47,"context_line":"  $extra_options       \u003d {},"},{"line_number":48,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_3984595c","line":45,"updated":"2015-11-03 01:03:22.000000000","message":"The value set by this variable in the params class is the upstream default according to https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L93.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1e851a951d116a6b13f44ca706d604cabd59180","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  $volume_driver       \u003d \u0027cinder.volume.drivers.lvm.LVMVolumeDriver\u0027,"},{"line_number":43,"context_line":"  $volume_group        \u003d $::os_service_default,"},{"line_number":44,"context_line":"  $volumes_dir         \u003d \u0027/var/lib/cinder/volumes\u0027,"},{"line_number":45,"context_line":"  $iscsi_helper        \u003d $::cinder::params::iscsi_helper,"},{"line_number":46,"context_line":"  $iscsi_protocol      \u003d \u0027iscsi\u0027,"},{"line_number":47,"context_line":"  $extra_options       \u003d {},"},{"line_number":48,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_8e6357b1","line":45,"in_reply_to":"1a26ad4f_3984595c","updated":"2015-11-03 22:11:03.000000000","message":"The params variable has OS specific logic in it, so i\u0027m going to leave it.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"417e9d01d86d15202ebc374c20e0fadb484b09f7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  $volume_driver       \u003d \u0027cinder.volume.drivers.lvm.LVMVolumeDriver\u0027,"},{"line_number":43,"context_line":"  $volume_group        \u003d $::os_service_default,"},{"line_number":44,"context_line":"  $volumes_dir         \u003d \u0027/var/lib/cinder/volumes\u0027,"},{"line_number":45,"context_line":"  $iscsi_helper        \u003d $::cinder::params::iscsi_helper,"},{"line_number":46,"context_line":"  $iscsi_protocol      \u003d \u0027iscsi\u0027,"},{"line_number":47,"context_line":"  $extra_options       \u003d {},"},{"line_number":48,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_b378e22c","line":45,"in_reply_to":"fa80f949_8e6357b1","updated":"2015-11-04 16:59:27.000000000","message":"Done","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"85bc77d0d96c24defde1dc65c55882184c2bbd73","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  $volume_group        \u003d $::os_service_default,"},{"line_number":44,"context_line":"  $volumes_dir         \u003d \u0027/var/lib/cinder/volumes\u0027,"},{"line_number":45,"context_line":"  $iscsi_helper        \u003d $::cinder::params::iscsi_helper,"},{"line_number":46,"context_line":"  $iscsi_protocol      \u003d \u0027iscsi\u0027,"},{"line_number":47,"context_line":"  $extra_options       \u003d {},"},{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_d96765e7","line":46,"updated":"2015-11-03 01:03:22.000000000","message":"This is the upstream default according to https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L144.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1e851a951d116a6b13f44ca706d604cabd59180","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  $volume_group        \u003d $::os_service_default,"},{"line_number":44,"context_line":"  $volumes_dir         \u003d \u0027/var/lib/cinder/volumes\u0027,"},{"line_number":45,"context_line":"  $iscsi_helper        \u003d $::cinder::params::iscsi_helper,"},{"line_number":46,"context_line":"  $iscsi_protocol      \u003d \u0027iscsi\u0027,"},{"line_number":47,"context_line":"  $extra_options       \u003d {},"},{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_0ef767d4","line":46,"in_reply_to":"1a26ad4f_d96765e7","updated":"2015-11-03 22:11:03.000000000","message":"Done","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"}],"manifests/backend/nfs.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7bb7fe798313d841773c7d4b9f6a0ff24bdd9f63","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# [*nfs_mount_attempts*]"},{"line_number":14,"context_line":"#   (optional) The number of attempts to mount nfs shares before raising an"},{"line_number":15,"context_line":"#   error. At least one attempt will be made to mount an nfs share, regardless"},{"line_number":16,"context_line":"#   of the value specified."},{"line_number":17,"context_line":"#   Defaults to $::os_service_default"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*nfs_mount_options*]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"da85f559_ca65b545","line":16,"updated":"2015-11-09 14:26:34.000000000","message":"i guess, such changes as adding new parameters should be in separate patch.\nMay be we should not mix this in one patch?","commit_id":"32cabbee695e23af909707f532da64df4e329667"}],"manifests/backend/vmdk.pp":[{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"85bc77d0d96c24defde1dc65c55882184c2bbd73","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  $host_username,"},{"line_number":61,"context_line":"  $host_password,"},{"line_number":62,"context_line":"  $volume_backend_name         \u003d $name,"},{"line_number":63,"context_line":"  $volume_folder               \u003d \u0027cinder-volumes\u0027,"},{"line_number":64,"context_line":"  $api_retry_count             \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $max_object_retrieval        \u003d $::os_service_default,"},{"line_number":66,"context_line":"  $task_poll_interval          \u003d 5,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_28a3a1b3","line":63,"updated":"2015-11-03 01:03:22.000000000","message":"Should likely be deprecated as it is not he upstream default","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1e851a951d116a6b13f44ca706d604cabd59180","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  $host_username,"},{"line_number":61,"context_line":"  $host_password,"},{"line_number":62,"context_line":"  $volume_backend_name         \u003d $name,"},{"line_number":63,"context_line":"  $volume_folder               \u003d \u0027cinder-volumes\u0027,"},{"line_number":64,"context_line":"  $api_retry_count             \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $max_object_retrieval        \u003d $::os_service_default,"},{"line_number":66,"context_line":"  $task_poll_interval          \u003d 5,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_4eb00ff5","line":63,"in_reply_to":"1a26ad4f_28a3a1b3","updated":"2015-11-03 22:11:03.000000000","message":"Done","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"85bc77d0d96c24defde1dc65c55882184c2bbd73","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  $volume_folder               \u003d \u0027cinder-volumes\u0027,"},{"line_number":64,"context_line":"  $api_retry_count             \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $max_object_retrieval        \u003d $::os_service_default,"},{"line_number":66,"context_line":"  $task_poll_interval          \u003d 5,"},{"line_number":67,"context_line":"  $image_transfer_timeout_secs \u003d $::os_service_default,"},{"line_number":68,"context_line":"  $wsdl_location               \u003d undef,"},{"line_number":69,"context_line":"  $extra_options               \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_e8a8498e","line":66,"updated":"2015-11-03 01:03:22.000000000","message":"Should likely be deprecated as it is not he upstream default","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1e851a951d116a6b13f44ca706d604cabd59180","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  $volume_folder               \u003d \u0027cinder-volumes\u0027,"},{"line_number":64,"context_line":"  $api_retry_count             \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $max_object_retrieval        \u003d $::os_service_default,"},{"line_number":66,"context_line":"  $task_poll_interval          \u003d 5,"},{"line_number":67,"context_line":"  $image_transfer_timeout_secs \u003d $::os_service_default,"},{"line_number":68,"context_line":"  $wsdl_location               \u003d undef,"},{"line_number":69,"context_line":"  $extra_options               \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_8e94b737","line":66,"in_reply_to":"1a26ad4f_e8a8498e","updated":"2015-11-03 22:11:03.000000000","message":"Done","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"85bc77d0d96c24defde1dc65c55882184c2bbd73","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $max_object_retrieval        \u003d $::os_service_default,"},{"line_number":66,"context_line":"  $task_poll_interval          \u003d 5,"},{"line_number":67,"context_line":"  $image_transfer_timeout_secs \u003d $::os_service_default,"},{"line_number":68,"context_line":"  $wsdl_location               \u003d undef,"},{"line_number":69,"context_line":"  $extra_options               \u003d {},"},{"line_number":70,"context_line":"  ) {"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a26ad4f_a87ed116","line":68,"updated":"2015-11-03 01:03:22.000000000","message":"Should likely be set to $::os_service_default since line 86 shows that setting this to undef results in the setting not showing up in the config.","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1e851a951d116a6b13f44ca706d604cabd59180","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $max_object_retrieval        \u003d $::os_service_default,"},{"line_number":66,"context_line":"  $task_poll_interval          \u003d 5,"},{"line_number":67,"context_line":"  $image_transfer_timeout_secs \u003d $::os_service_default,"},{"line_number":68,"context_line":"  $wsdl_location               \u003d undef,"},{"line_number":69,"context_line":"  $extra_options               \u003d {},"},{"line_number":70,"context_line":"  ) {"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_0e6be71f","line":68,"in_reply_to":"1a26ad4f_a87ed116","updated":"2015-11-03 22:11:03.000000000","message":"It actually doesn\u0027t do anything if set to undef as it\u0027ll just leave the config in there so currently there is no way to remove this. I\u0027ll update this to use the standard os_service_default logic","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"417e9d01d86d15202ebc374c20e0fadb484b09f7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $max_object_retrieval        \u003d $::os_service_default,"},{"line_number":66,"context_line":"  $task_poll_interval          \u003d 5,"},{"line_number":67,"context_line":"  $image_transfer_timeout_secs \u003d $::os_service_default,"},{"line_number":68,"context_line":"  $wsdl_location               \u003d undef,"},{"line_number":69,"context_line":"  $extra_options               \u003d {},"},{"line_number":70,"context_line":"  ) {"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_33939251","line":68,"in_reply_to":"fa80f949_0e6be71f","updated":"2015-11-04 16:59:27.000000000","message":"Done","commit_id":"d21f9b774b6942805e76bd38533e52dc99e36b8d"}],"manifests/volume/glusterfs.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7bb7fe798313d841773c7d4b9f6a0ff24bdd9f63","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# *Deprecated*"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*glusterfs_disk_util*]"},{"line_number":33,"context_line":"#   Removed in Icehouse."},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# \u003d\u003d\u003d Examples"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"da85f559_2a8a41c0","line":32,"updated":"2015-11-09 14:26:34.000000000","message":"this i guess also separate patch :)","commit_id":"32cabbee695e23af909707f532da64df4e329667"}]}