)]}'
{"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0d57933246e695f930bd7cf38f7cc845df03fac4","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    }"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if $qpid_hosts {"},{"line_number":372,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hosts\u0027:    value \u003d\u003e join($qpid_hosts, \u0027,\u0027) }"},{"line_number":373,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hostname\u0027: ensure \u003d\u003e absent }"},{"line_number":374,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_port\u0027:     ensure \u003d\u003e absent }"},{"line_number":375,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_dce9ef1b","line":372,"updated":"2015-10-29 15:05:36.000000000","message":"Should use any2array here so that qpid_hosts could be a string or an array.  I believe that is the preferred pattern for these types of things.  For example, https://review.openstack.org/#/c/220448/2/manifests/init.pp","commit_id":"8d4ec602eff2b18fbdf2cec095606a9d715134c5"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3552d747496c28e19a4ad7ef63d58c71de4f4b5a","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    }"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if $qpid_hosts {"},{"line_number":372,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hosts\u0027:    value \u003d\u003e join($qpid_hosts, \u0027,\u0027) }"},{"line_number":373,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hostname\u0027: ensure \u003d\u003e absent }"},{"line_number":374,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_port\u0027:     ensure \u003d\u003e absent }"},{"line_number":375,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_ae9dcb5a","line":372,"in_reply_to":"1a26ad4f_dce9ef1b","updated":"2015-10-30 03:05:01.000000000","message":"Agree with Alex, +1","commit_id":"8d4ec602eff2b18fbdf2cec095606a9d715134c5"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"9fbc068e9f92e0c257c9bd6d1564c7c5264dc54d","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    }"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if $qpid_hosts {"},{"line_number":372,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hosts\u0027:    value \u003d\u003e join($qpid_hosts, \u0027,\u0027) }"},{"line_number":373,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hostname\u0027: ensure \u003d\u003e absent }"},{"line_number":374,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_port\u0027:     ensure \u003d\u003e absent }"},{"line_number":375,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_bd916c9b","line":372,"in_reply_to":"1a26ad4f_dce9ef1b","updated":"2015-10-30 15:18:07.000000000","message":"Done","commit_id":"8d4ec602eff2b18fbdf2cec095606a9d715134c5"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d714af0c890caee019decfeedbba4f8e7f8866d5","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if $qpid_hosts {"},{"line_number":372,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hosts\u0027:    value \u003d\u003e join($qpid_hosts, \u0027,\u0027) }"},{"line_number":373,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hostname\u0027: ensure \u003d\u003e absent }"},{"line_number":374,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_port\u0027:     ensure \u003d\u003e absent }"},{"line_number":375,"context_line":"    } else {"},{"line_number":376,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hosts\u0027:    value \u003d\u003e \"${qpid_hostname}:${qpid_port}\" }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_c1ea6cac","line":373,"updated":"2015-10-29 15:09:55.000000000","message":"no reason to set it implicitly to absent.","commit_id":"8d4ec602eff2b18fbdf2cec095606a9d715134c5"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"9fbc068e9f92e0c257c9bd6d1564c7c5264dc54d","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if $qpid_hosts {"},{"line_number":372,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hosts\u0027:    value \u003d\u003e join($qpid_hosts, \u0027,\u0027) }"},{"line_number":373,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hostname\u0027: ensure \u003d\u003e absent }"},{"line_number":374,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_port\u0027:     ensure \u003d\u003e absent }"},{"line_number":375,"context_line":"    } else {"},{"line_number":376,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hosts\u0027:    value \u003d\u003e \"${qpid_hostname}:${qpid_port}\" }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_dd8c6881","line":373,"in_reply_to":"1a26ad4f_c1ea6cac","updated":"2015-10-30 15:18:07.000000000","message":"Done","commit_id":"8d4ec602eff2b18fbdf2cec095606a9d715134c5"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3552d747496c28e19a4ad7ef63d58c71de4f4b5a","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if $qpid_hosts {"},{"line_number":372,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hosts\u0027:    value \u003d\u003e join($qpid_hosts, \u0027,\u0027) }"},{"line_number":373,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hostname\u0027: ensure \u003d\u003e absent }"},{"line_number":374,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_port\u0027:     ensure \u003d\u003e absent }"},{"line_number":375,"context_line":"    } else {"},{"line_number":376,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hosts\u0027:    value \u003d\u003e \"${qpid_hostname}:${qpid_port}\" }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_ce05a77a","line":373,"in_reply_to":"1a26ad4f_c1ea6cac","updated":"2015-10-30 03:05:01.000000000","message":"The only reason i see to do this is: if the value is set before with some value that will make break something. Agree with Denis.","commit_id":"8d4ec602eff2b18fbdf2cec095606a9d715134c5"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"9fbc068e9f92e0c257c9bd6d1564c7c5264dc54d","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if $qpid_hosts {"},{"line_number":372,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hosts\u0027:    value \u003d\u003e join($qpid_hosts, \u0027,\u0027) }"},{"line_number":373,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hostname\u0027: ensure \u003d\u003e absent }"},{"line_number":374,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_port\u0027:     ensure \u003d\u003e absent }"},{"line_number":375,"context_line":"    } else {"},{"line_number":376,"context_line":"      cinder_config { \u0027oslo_messaging_qpid/qpid_hosts\u0027:    value \u003d\u003e \"${qpid_hostname}:${qpid_port}\" }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_7deaf410","line":373,"in_reply_to":"1a26ad4f_ce05a77a","updated":"2015-10-30 15:18:07.000000000","message":"Done","commit_id":"8d4ec602eff2b18fbdf2cec095606a9d715134c5"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f73bba359a581a5e9a2aebc46702ad1b0fc38186","unresolved":false,"context_lines":[{"line_number":106,"context_line":"#"},{"line_number":107,"context_line":"# [*qpid_hosts*]"},{"line_number":108,"context_line":"#   Qpid HA cluster host:port pairs. (list value)"},{"line_number":109,"context_line":"#   Defaults to $qpid_hostname:$qpid_port"},{"line_number":110,"context_line":"#"},{"line_number":111,"context_line":"# [*qpid_username*]"},{"line_number":112,"context_line":"#   (Optional) Username to use when connecting to qpid."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_01ac9b8a","line":109,"updated":"2015-11-06 14:26:28.000000000","message":"please add optional, and since the defaults is $qpid_hostname:$qpid_port why is set to false on line 266?","commit_id":"f4cf3901a59c4b57b4da8136bfa990ddbc8c6e34"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"7bd0ebeb90ee2b87c8ad40f5b14a338470897faf","unresolved":false,"context_lines":[{"line_number":106,"context_line":"#"},{"line_number":107,"context_line":"# [*qpid_hosts*]"},{"line_number":108,"context_line":"#   Qpid HA cluster host:port pairs. (list value)"},{"line_number":109,"context_line":"#   Defaults to $qpid_hostname:$qpid_port"},{"line_number":110,"context_line":"#"},{"line_number":111,"context_line":"# [*qpid_username*]"},{"line_number":112,"context_line":"#   (Optional) Username to use when connecting to qpid."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_1e1f196d","line":109,"in_reply_to":"fa80f949_01ac9b8a","updated":"2015-11-06 15:02:35.000000000","message":"optional added in patch set 6,\n\n i am setting it false because $qpid_hostname:$qpid_port values are set on line 382\n\nI believe it should be done like in case with rabbit_hosts on lines 344:354","commit_id":"f4cf3901a59c4b57b4da8136bfa990ddbc8c6e34"}],"spec/classes/cinder_spec.rb":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3552d747496c28e19a4ad7ef63d58c71de4f4b5a","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        :database_connection \u003d\u003e \u0027mysql://user:password@host/database\u0027,"},{"line_number":131,"context_line":"        :qpid_password       \u003d\u003e \u0027guest\u0027,"},{"line_number":132,"context_line":"        :rpc_backend         \u003d\u003e \u0027qpid\u0027,"},{"line_number":133,"context_line":"        :qpid_hosts          \u003d\u003e [\u0027qpid1:5672\u0027]"},{"line_number":134,"context_line":"      }"},{"line_number":135,"context_line":"    end"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_8e0d6f92","line":133,"updated":"2015-10-30 03:05:01.000000000","message":"Can you add tests when the value can be a string? Or ensure that can\u0027t be a string.","commit_id":"8d4ec602eff2b18fbdf2cec095606a9d715134c5"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"9fbc068e9f92e0c257c9bd6d1564c7c5264dc54d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        :database_connection \u003d\u003e \u0027mysql://user:password@host/database\u0027,"},{"line_number":131,"context_line":"        :qpid_password       \u003d\u003e \u0027guest\u0027,"},{"line_number":132,"context_line":"        :rpc_backend         \u003d\u003e \u0027qpid\u0027,"},{"line_number":133,"context_line":"        :qpid_hosts          \u003d\u003e [\u0027qpid1:5672\u0027]"},{"line_number":134,"context_line":"      }"},{"line_number":135,"context_line":"    end"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_1d93c0a4","line":133,"in_reply_to":"1a26ad4f_8e0d6f92","updated":"2015-10-30 15:18:07.000000000","message":"i am ensuring this using any2array in the patch set 2 please check it\nthanks!","commit_id":"8d4ec602eff2b18fbdf2cec095606a9d715134c5"}]}