)]}'
{"Gemfile":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7a89e8eaca807de70947b3390d9f0307af00941b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"group :development, :test do"},{"line_number":4,"context_line":"  gem \u0027puppetlabs_spec_helper\u0027,               :require \u003d\u003e \u0027false\u0027"},{"line_number":5,"context_line":"  gem \u0027rspec-puppet\u0027, \u0027~\u003e 2.2.0\u0027,             :require \u003d\u003e \u0027false\u0027"},{"line_number":6,"context_line":"  gem \u0027rspec-puppet-facts\u0027,                   :require \u003d\u003e false"},{"line_number":7,"context_line":"  gem \u0027metadata-json-lint\u0027,                   :require \u003d\u003e \u0027false\u0027"},{"line_number":8,"context_line":"  gem \u0027puppet-lint-param-docs\u0027,               :require \u003d\u003e \u0027false\u0027"},{"line_number":9,"context_line":"  gem \u0027puppet-lint-absolute_classname-check\u0027, :require \u003d\u003e \u0027false\u0027"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da85f559_2632c2a7","line":6,"updated":"2015-11-12 15:10:40.000000000","message":"\u0027false\u0027","commit_id":"855f6d4b54c84e936859f830bbaed08589b29fe3"}],"spec/classes/cinder_db_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5721b905181109bbb0090585ed47afe6b061ab09","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  context \u0027on Redhat platforms\u0027 do"},{"line_number":97,"context_line":"    let :facts do"},{"line_number":98,"context_line":"    @default_facts.merge({"},{"line_number":99,"context_line":"        :osfamily \u003d\u003e \u0027RedHat\u0027,"},{"line_number":100,"context_line":"        :operatingsystemrelease \u003d\u003e \u00277.1\u0027,"},{"line_number":101,"context_line":"    })"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"da6ed579_d2869fda","line":98,"range":{"start_line":98,"start_character":5,"end_line":98,"end_character":18},"updated":"2016-01-13 11:33:32.000000000","message":"missing change?","commit_id":"42c8486bbb21d552f1d880b862958b7a5ea5e017"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"30dab80445d441043bb48139bcdf00dbbd034dde","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  context \u0027on Redhat platforms\u0027 do"},{"line_number":97,"context_line":"    let :facts do"},{"line_number":98,"context_line":"    @default_facts.merge({"},{"line_number":99,"context_line":"        :osfamily \u003d\u003e \u0027RedHat\u0027,"},{"line_number":100,"context_line":"        :operatingsystemrelease \u003d\u003e \u00277.1\u0027,"},{"line_number":101,"context_line":"    })"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"ba63e191_ce5df7ed","line":98,"range":{"start_line":98,"start_character":5,"end_line":98,"end_character":18},"in_reply_to":"da6ed579_d2869fda","updated":"2016-01-18 17:25:27.000000000","message":"Done","commit_id":"42c8486bbb21d552f1d880b862958b7a5ea5e017"}],"spec/classes/cinder_scheduler_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5721b905181109bbb0090585ed47afe6b061ab09","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  describe \u0027on rhel platforms\u0027 do"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    let :facts do"},{"line_number":60,"context_line":"      { :osfamily \u003d\u003e \u0027RedHat\u0027 }"},{"line_number":61,"context_line":"    end"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    describe \u0027with default parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"da6ed579_12643747","line":60,"range":{"start_line":60,"start_character":9,"end_line":60,"end_character":17},"updated":"2016-01-13 11:33:32.000000000","message":"what\u0027s about changes here?","commit_id":"42c8486bbb21d552f1d880b862958b7a5ea5e017"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"30dab80445d441043bb48139bcdf00dbbd034dde","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  describe \u0027on rhel platforms\u0027 do"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    let :facts do"},{"line_number":60,"context_line":"      { :osfamily \u003d\u003e \u0027RedHat\u0027 }"},{"line_number":61,"context_line":"    end"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    describe \u0027with default parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"ba63e191_4e4b472c","line":60,"range":{"start_line":60,"start_character":9,"end_line":60,"end_character":17},"in_reply_to":"da6ed579_12643747","updated":"2016-01-18 17:25:27.000000000","message":"since there\u0027s nothing that requires \u003cSERVICE DEFAULT\u003e here it\u0027s not really required but i\u0027ll fix it. To be honest many tests need to be updated to use rspec-puppet-facts to do better checking across the different os families.","commit_id":"42c8486bbb21d552f1d880b862958b7a5ea5e017"}],"spec/classes/cinder_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5721b905181109bbb0090585ed47afe6b061ab09","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  end"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  let :facts do"},{"line_number":12,"context_line":"    OSDefaults.get_facts({"},{"line_number":13,"context_line":"      :osfamily \u003d\u003e \u0027Debian\u0027,"},{"line_number":14,"context_line":"      :operatingsystem \u003d\u003e \u0027Debian\u0027,"},{"line_number":15,"context_line":"      :operatingsystemrelease \u003d\u003e \u0027jessie\u0027,"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"da6ed579_b2d1abcf","line":12,"range":{"start_line":12,"start_character":15,"end_line":12,"end_character":24},"updated":"2016-01-13 11:33:32.000000000","message":"can we do the same as for another files and use all supported systems?","commit_id":"42c8486bbb21d552f1d880b862958b7a5ea5e017"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"30dab80445d441043bb48139bcdf00dbbd034dde","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  end"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  let :facts do"},{"line_number":12,"context_line":"    OSDefaults.get_facts({"},{"line_number":13,"context_line":"      :osfamily \u003d\u003e \u0027Debian\u0027,"},{"line_number":14,"context_line":"      :operatingsystem \u003d\u003e \u0027Debian\u0027,"},{"line_number":15,"context_line":"      :operatingsystemrelease \u003d\u003e \u0027jessie\u0027,"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"ba63e191_6ee40b0d","line":12,"range":{"start_line":12,"start_character":15,"end_line":12,"end_character":24},"in_reply_to":"da6ed579_b2d1abcf","updated":"2016-01-18 17:25:27.000000000","message":"Eventually we should follow on with additional reviews to update all of the tests to use on_supported_os instead. But this change was to completely move from @default_facts to OSDefaults. I did a single conversion of the cinder::api class to validate that it works but that was quite the undertaking.","commit_id":"42c8486bbb21d552f1d880b862958b7a5ea5e017"}],"spec/spec_helper.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"46bd815ffc52399458db0c09ddfffbafb1745a08","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  c.alias_it_should_behave_like_to :it_raises, \u0027raises\u0027"},{"line_number":12,"context_line":"  #TODO(aschultz): remove this after all tests converted to use OSDefaults"},{"line_number":13,"context_line":"  c.before :each do"},{"line_number":14,"context_line":"    @default_facts \u003d OSDefaults.get_facts"},{"line_number":15,"context_line":"  end"},{"line_number":16,"context_line":"end"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa80f949_1d989477","line":14,"updated":"2015-11-06 07:34:35.000000000","message":"I guess, it will be placed under openstacklib module, when all projects will be converted to OSDefaults, right?","commit_id":"855f6d4b54c84e936859f830bbaed08589b29fe3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e5eed5d621112365f54d58d733db260e2c70ae91","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  c.alias_it_should_behave_like_to :it_raises, \u0027raises\u0027"},{"line_number":12,"context_line":"  #TODO(aschultz): remove this after all tests converted to use OSDefaults"},{"line_number":13,"context_line":"  c.before :each do"},{"line_number":14,"context_line":"    @default_facts \u003d OSDefaults.get_facts"},{"line_number":15,"context_line":"  end"},{"line_number":16,"context_line":"end"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa80f949_219bdf73","line":14,"in_reply_to":"fa80f949_1d989477","updated":"2015-11-06 14:54:12.000000000","message":"So that is one place for it but the problem with that is then we will be required to load the defaults.rb from the openstacklib module as part of testing as i\u0027m not sure we can do that. That seems like it might be adding extra complexity but is definitely something we can look into.  For now this is just defined on a per module basis that would","commit_id":"855f6d4b54c84e936859f830bbaed08589b29fe3"}]}