)]}'
{"manifests/keystone/auth.pp":[{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"ca0622a906675bfdc7a0f9d3a7001c80fb4175cf","unresolved":false,"context_lines":[{"line_number":267,"context_line":"  }"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"  if $configure_user_role {"},{"line_number":270,"context_line":"    Keystone_user_role[\"${auth_name}@${tenant}\"] ~\u003e Service \u003c| name \u003d\u003d \u0027cinder-api\u0027 |\u003e"},{"line_number":271,"context_line":"    Keystone_user_role[\"${auth_name}@${tenant}\"] -\u003e Cinder_type\u003c||\u003e"},{"line_number":272,"context_line":"  }"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":14,"id":"9a061dce_096da2cb","line":270,"updated":"2016-04-08 01:46:53.000000000","message":"This appears to be causing a circular dependency issue when keystone and cinder are being served as wsgi applications in apache.","commit_id":"c0f8a795a6aa17659e7d918f0a760d9566884acb"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"58601341e447b93b7d1754504af79c23a46cbc86","unresolved":false,"context_lines":[{"line_number":267,"context_line":"  }"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"  if $configure_user_role {"},{"line_number":270,"context_line":"    Keystone_user_role[\"${auth_name}@${tenant}\"] ~\u003e Service \u003c| name \u003d\u003d \u0027cinder-api\u0027 |\u003e"},{"line_number":271,"context_line":"    Keystone_user_role[\"${auth_name}@${tenant}\"] -\u003e Cinder_type \u003c| |\u003e"},{"line_number":272,"context_line":"  }"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":17,"id":"5a18252c_5fb5352f","side":"PARENT","line":270,"updated":"2016-04-13 10:42:10.000000000","message":"no need to remove this collector\nyou can also add collector for wsgi","commit_id":"12ef04fd9659069b327bb15f5b6df08ada53238e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a4ff634323ceeeb36eceedecb29e364c45714bc2","unresolved":false,"context_lines":[{"line_number":267,"context_line":"  }"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"  if $configure_user_role {"},{"line_number":270,"context_line":"    Keystone_user_role[\"${auth_name}@${tenant}\"] ~\u003e Service \u003c| name \u003d\u003d \u0027cinder-api\u0027 |\u003e"},{"line_number":271,"context_line":"    Keystone_user_role[\"${auth_name}@${tenant}\"] -\u003e Cinder_type \u003c| |\u003e"},{"line_number":272,"context_line":"  }"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":17,"id":"5a18252c_856752e8","side":"PARENT","line":270,"in_reply_to":"5a18252c_5fb5352f","updated":"2016-04-14 00:41:35.000000000","message":"no, it will create a dependency loop because Keystone_user_role depends on Apache, not the other way around.","commit_id":"12ef04fd9659069b327bb15f5b6df08ada53238e"}],"spec/classes/cinder_wsgi_apache_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"12c59fbb5447f22ea3d30c778043ff4f21385057","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    end"},{"line_number":82,"context_line":"  end"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":85,"context_line":"    let :facts do"},{"line_number":86,"context_line":"      global_facts.merge({"},{"line_number":87,"context_line":"        :osfamily               \u003d\u003e \u0027RedHat\u0027,"}],"source_content_type":"text/x-ruby","patch_set":17,"id":"5a18252c_a6c4545f","line":84,"updated":"2016-04-13 03:19:27.000000000","message":"Please use the rspec-puppet-facts pattern for this since I updated the cinder module already.","commit_id":"4784699ec6134f796569a55c526da3f86f791bbc"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9014114e6878d7caa6b0b64aa2647505aae6e6fc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    end"},{"line_number":82,"context_line":"  end"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":85,"context_line":"    let :facts do"},{"line_number":86,"context_line":"      global_facts.merge({"},{"line_number":87,"context_line":"        :osfamily               \u003d\u003e \u0027RedHat\u0027,"}],"source_content_type":"text/x-ruby","patch_set":17,"id":"5a18252c_854ab224","line":84,"in_reply_to":"5a18252c_05a222fd","updated":"2016-04-14 00:52:24.000000000","message":"so I started to re-write unit tests and, actually there is too much platform specific bits in those tests. What do you suggest? Using rspec-pupept-facts will just duplicate all tests I think.","commit_id":"4784699ec6134f796569a55c526da3f86f791bbc"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"564f6fbca61e2230aa77e7527f8d1557a439f7a7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    end"},{"line_number":82,"context_line":"  end"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":85,"context_line":"    let :facts do"},{"line_number":86,"context_line":"      global_facts.merge({"},{"line_number":87,"context_line":"        :osfamily               \u003d\u003e \u0027RedHat\u0027,"}],"source_content_type":"text/x-ruby","patch_set":17,"id":"5a18252c_4da8ab8d","line":84,"in_reply_to":"5a18252c_854ab224","updated":"2016-04-14 10:52:14.000000000","message":"So, for platform specific params i guess we can use case, like it done here: https://review.openstack.org/#/c/298528/1/spec/classes/gnocchi_api_spec.rb@165","commit_id":"4784699ec6134f796569a55c526da3f86f791bbc"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a4ff634323ceeeb36eceedecb29e364c45714bc2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    end"},{"line_number":82,"context_line":"  end"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":85,"context_line":"    let :facts do"},{"line_number":86,"context_line":"      global_facts.merge({"},{"line_number":87,"context_line":"        :osfamily               \u003d\u003e \u0027RedHat\u0027,"}],"source_content_type":"text/x-ruby","patch_set":17,"id":"5a18252c_05a222fd","line":84,"in_reply_to":"5a18252c_a6c4545f","updated":"2016-04-14 00:41:35.000000000","message":"Done","commit_id":"4784699ec6134f796569a55c526da3f86f791bbc"}]}