)]}'
{"manifests/backup.pp":[{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"e11a07b08add682cdc4db0f3d8319576d30ea76b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*manage_service*]"},{"line_number":12,"context_line":"#   (Optional) Whether to start/stop the service."},{"line_number":13,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*package_ensure*]"},{"line_number":16,"context_line":"#   (Optional) Ensure state for package."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a122d0e_797551c9","line":13,"updated":"2016-04-27 15:12:22.000000000","message":"I would mention on line 12 that the expected value is a boolean. The single quotes around true in line 13 might give the impression of using a string. You should also add a validate_bool after line 67 as setting manage_service to \u0027false\u0027 (string value) will by your conditional statement on line 81 be taken as true.","commit_id":"177da2b8a5be3d72e07b3efe01e984f9afcbf255"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"f7410cebb62bc90bdd26604de39541f3b84cb501","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*manage_service*]"},{"line_number":12,"context_line":"#   (Optional) Whether to start/stop the service."},{"line_number":13,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*package_ensure*]"},{"line_number":16,"context_line":"#   (Optional) Ensure state for package."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a122d0e_c2174e43","line":13,"in_reply_to":"1a122d0e_3fea9974","updated":"2016-04-27 16:01:11.000000000","message":"Agreed that validate_bool is required. As an addition/suggestion it can be useful to specify value type in doc. So it should look like:\n\n#   (Optional) Whether to start/stop the service. (boolean value)\n\n#   Defaults to true","commit_id":"177da2b8a5be3d72e07b3efe01e984f9afcbf255"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c7c67716febebaa9b5aec4b6ebff98658945b522","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*manage_service*]"},{"line_number":12,"context_line":"#   (Optional) Whether to start/stop the service."},{"line_number":13,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*package_ensure*]"},{"line_number":16,"context_line":"#   (Optional) Ensure state for package."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a122d0e_02530618","line":13,"in_reply_to":"1a122d0e_3fea9974","updated":"2016-04-27 16:00:50.000000000","message":"Well, we don\u0027t have it now across all our modules, i\u0027m ok with current solution.","commit_id":"177da2b8a5be3d72e07b3efe01e984f9afcbf255"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"cbaf1a7c7b105da1aba10e7d5dbbbcf5b1ae6fd8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*manage_service*]"},{"line_number":12,"context_line":"#   (Optional) Whether to start/stop the service."},{"line_number":13,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*package_ensure*]"},{"line_number":16,"context_line":"#   (Optional) Ensure state for package."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a122d0e_bc2eb789","line":13,"in_reply_to":"1a122d0e_797551c9","updated":"2016-04-27 15:17:08.000000000","message":"Not sure, that it\u0027s real problem.\n\nSo, for example enabled is also boolean value - but it has quotes around default value.\n\nAlso we have such doc defaults around some other modules.\n\nI think, you can just use as default true - and that\u0027s it.","commit_id":"177da2b8a5be3d72e07b3efe01e984f9afcbf255"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"a6e01bea07ecde5db9d56df2ec5313ec904cf20b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*manage_service*]"},{"line_number":12,"context_line":"#   (Optional) Whether to start/stop the service."},{"line_number":13,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*package_ensure*]"},{"line_number":16,"context_line":"#   (Optional) Ensure state for package."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a122d0e_3fea9974","line":13,"in_reply_to":"1a122d0e_bc2eb789","updated":"2016-04-27 15:52:35.000000000","message":"I\u0027m fine with the documentation but a validate_bool should be added after line 67 since passing a string representation of false will be true in the conditional on line 81.","commit_id":"177da2b8a5be3d72e07b3efe01e984f9afcbf255"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"879e387949369d7e3e2c4dd1d63c9e51319c9a46","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*manage_service*]"},{"line_number":12,"context_line":"#   (Optional) Whether to start/stop the service."},{"line_number":13,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*package_ensure*]"},{"line_number":16,"context_line":"#   (Optional) Ensure state for package."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a122d0e_be84d0d2","line":13,"in_reply_to":"1a122d0e_c2174e43","updated":"2016-04-28 13:55:25.000000000","message":"hi guys, thanks for checking this","commit_id":"177da2b8a5be3d72e07b3efe01e984f9afcbf255"}]}