)]}'
{"manifests/init.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bfbb7e53e9345db89260c0700b27136a71821d39","unresolved":false,"context_lines":[{"line_number":343,"context_line":"  $use_stderr                         \u003d undef,"},{"line_number":344,"context_line":"  $log_facility                       \u003d undef,"},{"line_number":345,"context_line":"  $log_dir                            \u003d \u0027/var/log/cinder\u0027,"},{"line_number":346,"context_line":"  $verbose                            \u003d undef,"},{"line_number":347,"context_line":"  $debug                              \u003d undef,"},{"line_number":348,"context_line":"  $storage_availability_zone          \u003d \u0027nova\u0027,"},{"line_number":349,"context_line":"  $default_availability_zone          \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_70e7f040","line":346,"range":{"start_line":346,"start_character":2,"end_line":346,"end_character":46},"updated":"2016-05-18 01:59:37.000000000","message":"you should move this to be the last parameter and should be after # DEPRECATED PARAMETERS\nsee https://review.openstack.org/#/c/316867/2/manifests/init.pp","commit_id":"6a7d5d58bb07ce8fb163952d1bf300dc5d0cc97b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"c7793ff75dcb232fd1e24a47b134ba3f37c56e6d","unresolved":false,"context_lines":[{"line_number":343,"context_line":"  $use_stderr                         \u003d undef,"},{"line_number":344,"context_line":"  $log_facility                       \u003d undef,"},{"line_number":345,"context_line":"  $log_dir                            \u003d \u0027/var/log/cinder\u0027,"},{"line_number":346,"context_line":"  $verbose                            \u003d undef,"},{"line_number":347,"context_line":"  $debug                              \u003d undef,"},{"line_number":348,"context_line":"  $storage_availability_zone          \u003d \u0027nova\u0027,"},{"line_number":349,"context_line":"  $default_availability_zone          \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_a479ecfe","line":346,"range":{"start_line":346,"start_character":2,"end_line":346,"end_character":46},"in_reply_to":"bab6814e_70e7f040","updated":"2016-05-18 17:48:24.000000000","message":"Done","commit_id":"6a7d5d58bb07ce8fb163952d1bf300dc5d0cc97b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bfbb7e53e9345db89260c0700b27136a71821d39","unresolved":false,"context_lines":[{"line_number":359,"context_line":""},{"line_number":360,"context_line":"  include ::cinder::db"},{"line_number":361,"context_line":"  include ::cinder::logging"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"  if $use_ssl {"},{"line_number":364,"context_line":"    if !$cert_file {"},{"line_number":365,"context_line":"      fail(\u0027The cert_file parameter is required when use_ssl is set to true\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_d0ce9cb3","line":362,"updated":"2016-05-18 01:59:37.000000000","message":"please add a warning if verbose is set.","commit_id":"6a7d5d58bb07ce8fb163952d1bf300dc5d0cc97b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"c7793ff75dcb232fd1e24a47b134ba3f37c56e6d","unresolved":false,"context_lines":[{"line_number":359,"context_line":""},{"line_number":360,"context_line":"  include ::cinder::db"},{"line_number":361,"context_line":"  include ::cinder::logging"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"  if $use_ssl {"},{"line_number":364,"context_line":"    if !$cert_file {"},{"line_number":365,"context_line":"      fail(\u0027The cert_file parameter is required when use_ssl is set to true\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_c48870ea","line":362,"in_reply_to":"bab6814e_d0ce9cb3","updated":"2016-05-18 17:48:24.000000000","message":"Done","commit_id":"6a7d5d58bb07ce8fb163952d1bf300dc5d0cc97b"}],"manifests/logging.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bfbb7e53e9345db89260c0700b27136a71821d39","unresolved":false,"context_lines":[{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"#  [*verbose*]"},{"line_number":91,"context_line":"#    (Optional) DEPRECATED. Should the daemons log verbose messages"},{"line_number":92,"context_line":"#    Defaults to $::os_service_default"},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"class cinder::logging("},{"line_number":95,"context_line":"  $use_syslog                    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_f040000a","line":92,"range":{"start_line":92,"start_character":17,"end_line":92,"end_character":38},"updated":"2016-05-18 01:59:37.000000000","message":"undef now, since is DEPRECATED,","commit_id":"6a7d5d58bb07ce8fb163952d1bf300dc5d0cc97b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"c7793ff75dcb232fd1e24a47b134ba3f37c56e6d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"#  [*verbose*]"},{"line_number":91,"context_line":"#    (Optional) DEPRECATED. Should the daemons log verbose messages"},{"line_number":92,"context_line":"#    Defaults to $::os_service_default"},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"class cinder::logging("},{"line_number":95,"context_line":"  $use_syslog                    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_046b981f","line":92,"range":{"start_line":92,"start_character":17,"end_line":92,"end_character":38},"in_reply_to":"bab6814e_f040000a","updated":"2016-05-18 17:48:24.000000000","message":"Done","commit_id":"6a7d5d58bb07ce8fb163952d1bf300dc5d0cc97b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bfbb7e53e9345db89260c0700b27136a71821d39","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  $use_stderr                    \u003d $::os_service_default,"},{"line_number":97,"context_line":"  $log_facility                  \u003d $::os_service_default,"},{"line_number":98,"context_line":"  $log_dir                       \u003d \u0027/var/log/cinder\u0027,"},{"line_number":99,"context_line":"  $debug                         \u003d $::os_service_default,"},{"line_number":100,"context_line":"  $logging_context_format_string \u003d $::os_service_default,"},{"line_number":101,"context_line":"  $logging_default_format_string \u003d $::os_service_default,"},{"line_number":102,"context_line":"  $logging_debug_format_suffix   \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_5052acde","line":99,"updated":"2016-05-18 01:59:37.000000000","message":"You can\u0027t just remove, you need to deprecate the parameter first like in init.pp","commit_id":"6a7d5d58bb07ce8fb163952d1bf300dc5d0cc97b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"c7793ff75dcb232fd1e24a47b134ba3f37c56e6d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  $use_stderr                    \u003d $::os_service_default,"},{"line_number":97,"context_line":"  $log_facility                  \u003d $::os_service_default,"},{"line_number":98,"context_line":"  $log_dir                       \u003d \u0027/var/log/cinder\u0027,"},{"line_number":99,"context_line":"  $debug                         \u003d $::os_service_default,"},{"line_number":100,"context_line":"  $logging_context_format_string \u003d $::os_service_default,"},{"line_number":101,"context_line":"  $logging_default_format_string \u003d $::os_service_default,"},{"line_number":102,"context_line":"  $logging_debug_format_suffix   \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_6478a4f3","line":99,"in_reply_to":"bab6814e_5052acde","updated":"2016-05-18 17:48:24.000000000","message":"Done","commit_id":"6a7d5d58bb07ce8fb163952d1bf300dc5d0cc97b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bfbb7e53e9345db89260c0700b27136a71821d39","unresolved":false,"context_lines":[{"line_number":109,"context_line":"  $instance_uuid_format          \u003d $::os_service_default,"},{"line_number":110,"context_line":"  $log_date_format               \u003d $::os_service_default,"},{"line_number":111,"context_line":") {"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"},{"line_number":114,"context_line":"  # to use cinder::\u003cmyparam\u003e if cinder::logging::\u003cmyparam\u003e isn\u0027t specified."},{"line_number":115,"context_line":"  $use_syslog_real \u003d pick($::cinder::use_syslog,$use_syslog)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_f05760c8","line":112,"updated":"2016-05-18 01:59:37.000000000","message":"please add a warning if verbose is set.","commit_id":"6a7d5d58bb07ce8fb163952d1bf300dc5d0cc97b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"c7793ff75dcb232fd1e24a47b134ba3f37c56e6d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"  $instance_uuid_format          \u003d $::os_service_default,"},{"line_number":110,"context_line":"  $log_date_format               \u003d $::os_service_default,"},{"line_number":111,"context_line":") {"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"},{"line_number":114,"context_line":"  # to use cinder::\u003cmyparam\u003e if cinder::logging::\u003cmyparam\u003e isn\u0027t specified."},{"line_number":115,"context_line":"  $use_syslog_real \u003d pick($::cinder::use_syslog,$use_syslog)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_8465c846","line":112,"in_reply_to":"bab6814e_f05760c8","updated":"2016-05-18 17:48:24.000000000","message":"Done","commit_id":"6a7d5d58bb07ce8fb163952d1bf300dc5d0cc97b"}]}