)]}'
{"manifests/backend/netapp.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c6fe8006d6fcfcab7db629c9595b9d01a76dae12","unresolved":false,"context_lines":[{"line_number":208,"context_line":"  $netapp_sa_password           \u003d undef,"},{"line_number":209,"context_line":"  $netapp_storage_pools         \u003d undef,"},{"line_number":210,"context_line":"  $netapp_eseries_host_type     \u003d undef,"},{"line_number":211,"context_line":"  $netapp_host_type             \u003d undef,"},{"line_number":212,"context_line":"  $netapp_webservice_path       \u003d \u0027/devmgr/v2\u0027,"},{"line_number":213,"context_line":"  $extra_options                \u003d {},"},{"line_number":214,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_1eb00743","line":211,"updated":"2016-05-18 16:56:12.000000000","message":"the deprecation is not correct here, you\u0027re just adding a new parameter.\nPlease deprecate the old one.","commit_id":"06a13aae809e32d4f2625433426ca0257e318d0c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c6fe8006d6fcfcab7db629c9595b9d01a76dae12","unresolved":false,"context_lines":[{"line_number":210,"context_line":"  $netapp_eseries_host_type     \u003d undef,"},{"line_number":211,"context_line":"  $netapp_host_type             \u003d undef,"},{"line_number":212,"context_line":"  $netapp_webservice_path       \u003d \u0027/devmgr/v2\u0027,"},{"line_number":213,"context_line":"  $extra_options                \u003d {},"},{"line_number":214,"context_line":") {"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  if $netapp_eseries_host_type {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_7e879361","line":213,"updated":"2016-05-18 16:56:12.000000000","message":"add # DEPRECATED and the deprecated param bellow","commit_id":"06a13aae809e32d4f2625433426ca0257e318d0c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c6fe8006d6fcfcab7db629c9595b9d01a76dae12","unresolved":false,"context_lines":[{"line_number":214,"context_line":") {"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  if $netapp_eseries_host_type {"},{"line_number":217,"context_line":"    warning(\u0027The \"netapp_eseries_host_type\" parameter is deprecated. Use \"netapp_host_type\" instead.\u0027) "},{"line_number":218,"context_line":"  }"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"  if $nfs_shares {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_1e976791","line":217,"updated":"2016-05-18 16:56:12.000000000","message":"trailing space","commit_id":"06a13aae809e32d4f2625433426ca0257e318d0c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"455082f96ec74b98fb93b7828362d7c63c7b0819","unresolved":false,"context_lines":[{"line_number":140,"context_line":"#   Defaults to undef"},{"line_number":141,"context_line":"#"},{"line_number":142,"context_line":"# [*netapp_eseries_host_type*]"},{"line_number":143,"context_line":"#   (deprecated by netapp_host_type) This option is used to define how the"},{"line_number":144,"context_line":"#   controllers in the E-Series storage array will work with the particular"},{"line_number":145,"context_line":"#   operating system on the hosts that are connected to it."},{"line_number":146,"context_line":"#   Defaults to \u0027linux_dm_mp\u0027"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_c11b1b7f","line":143,"range":{"start_line":143,"start_character":5,"end_line":143,"end_character":35},"updated":"2016-05-19 11:23:27.000000000","message":"optional here","commit_id":"d71fd315c6431f7a2f64aa23083161b593931191"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"455082f96ec74b98fb93b7828362d7c63c7b0819","unresolved":false,"context_lines":[{"line_number":143,"context_line":"#   (deprecated by netapp_host_type) This option is used to define how the"},{"line_number":144,"context_line":"#   controllers in the E-Series storage array will work with the particular"},{"line_number":145,"context_line":"#   operating system on the hosts that are connected to it."},{"line_number":146,"context_line":"#   Defaults to \u0027linux_dm_mp\u0027"},{"line_number":147,"context_line":"#"},{"line_number":148,"context_line":"# [*netapp_host_type*]"},{"line_number":149,"context_line":"#   (optional) This option is used to define how the controllers will work with"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_042411ad","line":146,"updated":"2016-05-19 11:23:27.000000000","message":"please move this block below under \u0027# DEPRECATED PARAMETERS\u0027 section like: https://github.com/openstack/puppet-nova/blob/master/manifests/init.pp#L309","commit_id":"d71fd315c6431f7a2f64aa23083161b593931191"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"455082f96ec74b98fb93b7828362d7c63c7b0819","unresolved":false,"context_lines":[{"line_number":207,"context_line":"  $netapp_controller_ips        \u003d undef,"},{"line_number":208,"context_line":"  $netapp_sa_password           \u003d undef,"},{"line_number":209,"context_line":"  $netapp_storage_pools         \u003d undef,"},{"line_number":210,"context_line":"  $netapp_host_type             \u003d undef,"},{"line_number":211,"context_line":"  $netapp_webservice_path       \u003d \u0027/devmgr/v2\u0027,"},{"line_number":212,"context_line":"  $extra_options                \u003d {},"},{"line_number":213,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_247dd56e","line":210,"range":{"start_line":210,"start_character":34,"end_line":210,"end_character":39},"updated":"2016-05-19 11:23:27.000000000","message":"i guess we can switch it to $::os_service_default","commit_id":"d71fd315c6431f7a2f64aa23083161b593931191"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"455082f96ec74b98fb93b7828362d7c63c7b0819","unresolved":false,"context_lines":[{"line_number":215,"context_line":") {"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"  if $netapp_eseries_host_type {"},{"line_number":218,"context_line":"    warning(\u0027The \"netapp_eseries_host_type\" parameter is deprecated. Use \"netapp_host_type\" instead.\u0027)"},{"line_number":219,"context_line":"  }"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"  if $nfs_shares {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_848c8180","line":218,"updated":"2016-05-19 11:23:27.000000000","message":"in case of use instead, probably we can use:\n\n  if $netapp_eseries_host_type {\n    warning(\u0027The \"netapp_eseries_host_type\" parameter is deprecated. Use \"netapp_host_type\" instead.\u0027)\n    $netapp_host_type_real \u003d $netapp_eseries_host_type\n  } else {\n    $netapp_host_type_real \u003d $netapp_host_type\n  }\n\n\nand then put to config $netapp_host_type_real","commit_id":"d71fd315c6431f7a2f64aa23083161b593931191"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6ffbf5b71a8b8e1c0d45f700561e3b1a9ae5e5fc","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    \"${name}/netapp_storage_pools\":         value \u003d\u003e $netapp_storage_pools;"},{"line_number":259,"context_line":"    \"${name}/netapp_host_type\":             value \u003d\u003e $netapp_host_type_real;"},{"line_number":260,"context_line":"    \"${name}/netapp_webservice_path\":       value \u003d\u003e $netapp_webservice_path;"},{"line_number":261,"context_line":"    \"${name}/netapp_eseries_host_type\":     value \u003d\u003e $netapp_eseries_host_type;"},{"line_number":262,"context_line":"  }"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"  if $netapp_storage_family \u003d\u003d \u0027eseries\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_b991d554","line":261,"range":{"start_line":261,"start_character":4,"end_line":261,"end_character":79},"updated":"2016-05-19 17:29:38.000000000","message":"now you can remove it :)","commit_id":"2a0997ba4520a66fbc033bdf25d42bf92637c17a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2ebedc6e6d11d28058c3e8aaa5e821b834e0ba73","unresolved":false,"context_lines":[{"line_number":161,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":162,"context_line":"#"},{"line_number":163,"context_line":"# [*netapp_eseries_host_type*]"},{"line_number":164,"context_line":"#   (optional) This option is used to define how the controllers in the E-Series"},{"line_number":165,"context_line":"#   storage array will work with the particular operating system on the hosts that"},{"line_number":166,"context_line":"#   are connected to it."},{"line_number":167,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_78a2a7fe","line":164,"updated":"2016-05-20 08:55:42.000000000","message":"(optional) Deprecated. This option (...)","commit_id":"0f62917c86d838d960abb63ea707aa945927d7e0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2ebedc6e6d11d28058c3e8aaa5e821b834e0ba73","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    $netapp_host_type_real \u003d $netapp_eseries_host_type"},{"line_number":222,"context_line":"  } else {"},{"line_number":223,"context_line":"    $netapp_host_type_real \u003d $netapp_host_type"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"  if $nfs_shares {"},{"line_number":227,"context_line":"    validate_array($nfs_shares)"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_d8a3d3fe","line":224,"updated":"2016-05-20 08:55:42.000000000","message":"excellent!","commit_id":"0f62917c86d838d960abb63ea707aa945927d7e0"}],"manifests/volume/netapp.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3e4ba5f5c8af6a46d5de61c4272a7a3856e321bf","unresolved":false,"context_lines":[{"line_number":206,"context_line":"  $extra_options                \u003d {},"},{"line_number":207,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":208,"context_line":"  $netapp_eseries_host_type     \u003d undef,"},{"line_number":209,"context_line":") {"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"  if $netapp_eseries_host_type {"},{"line_number":212,"context_line":"    warning(\u0027The \"netapp_eseries_host_type\" parameter is deprecated. Use \"netapp_host_type\" instead.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_a456e5cf","line":209,"updated":"2016-05-19 11:23:51.000000000","message":"same comments as for prev file","commit_id":"d71fd315c6431f7a2f64aa23083161b593931191"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6ffbf5b71a8b8e1c0d45f700561e3b1a9ae5e5fc","unresolved":false,"context_lines":[{"line_number":202,"context_line":"  $netapp_controller_ips        \u003d undef,"},{"line_number":203,"context_line":"  $netapp_sa_password           \u003d undef,"},{"line_number":204,"context_line":"  $netapp_storage_pools         \u003d undef,"},{"line_number":205,"context_line":"  $netapp_host_type             \u003d undef,"},{"line_number":206,"context_line":"  $netapp_webservice_path       \u003d \u0027/devmgr/v2\u0027,"},{"line_number":207,"context_line":"  $nfs_mount_options            \u003d undef,"},{"line_number":208,"context_line":"  $extra_options                \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_1978e129","line":205,"range":{"start_line":205,"start_character":34,"end_line":205,"end_character":39},"updated":"2016-05-19 17:29:38.000000000","message":"$::os_service_default","commit_id":"2a0997ba4520a66fbc033bdf25d42bf92637c17a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6ffbf5b71a8b8e1c0d45f700561e3b1a9ae5e5fc","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    netapp_webservice_path       \u003d\u003e $netapp_webservice_path,"},{"line_number":244,"context_line":"    nfs_mount_options            \u003d\u003e $nfs_mount_options,"},{"line_number":245,"context_line":"    extra_options                \u003d\u003e $extra_options,"},{"line_number":246,"context_line":"    netapp_eseries_host_type     \u003d\u003e $netapp_eseries_host_type,"},{"line_number":247,"context_line":"  }"},{"line_number":248,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_5989c925","line":246,"updated":"2016-05-19 17:29:38.000000000","message":"same","commit_id":"2a0997ba4520a66fbc033bdf25d42bf92637c17a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2ebedc6e6d11d28058c3e8aaa5e821b834e0ba73","unresolved":false,"context_lines":[{"line_number":156,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":157,"context_line":"#"},{"line_number":158,"context_line":"# [*netapp_eseries_host_type*]"},{"line_number":159,"context_line":"#   (optional) This option is used to define how the controllers in the E-Series"},{"line_number":160,"context_line":"#   storage array will work with the particular operating system on the hosts that"},{"line_number":161,"context_line":"#   are connected to it."},{"line_number":162,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_989dcbbe","line":159,"updated":"2016-05-20 08:55:42.000000000","message":"add deprecated","commit_id":"0f62917c86d838d960abb63ea707aa945927d7e0"}]}