)]}'
{"manifests/backend/eqlx.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c920bdadad44f3b50b99543e795150f92c872ec2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  # Deprecated"},{"line_number":88,"context_line":"  $eqlx_use_chap        \u003d undef,"},{"line_number":89,"context_line":"  $eqlx_chap_login      \u003d undef,"},{"line_number":90,"context_line":"  $eqlx_chap_password   \u003d undef,"},{"line_number":91,"context_line":") {"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_cf434712","line":90,"updated":"2016-05-25 08:20:28.000000000","message":"this is not a backward compatible, you\u0027re adding a new parameters, which are required, but old - optional.\n\nI think you should use a new variable with _real suffix here, in case of passing old parameters.","commit_id":"2b4eea879a858efae25f2954350a4763c8b64de7"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"05faae283a7a1b44d777102678de76093058534d","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    warning(\u0027eqlx_chap_login is deprecated, has no effect and will be removed after Newton cycle. Please use chap_username.\u0027)"},{"line_number":107,"context_line":"    $chap_username_real \u003d $eqlx_chap_login"},{"line_number":108,"context_line":"  } else {"},{"line_number":109,"context_line":"    $chap_username_real \u003d $chap_username"},{"line_number":110,"context_line":"  }"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  if $eqlx_chap_password {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_a7e7553f","line":109,"updated":"2016-05-27 10:58:21.000000000","message":"that will not work, until parameter is required. as solution please set it to os_service_default too, but here add check - if service_default - raise fail","commit_id":"8de61f418be523f533808f1939fa9753173df0d9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"05faae283a7a1b44d777102678de76093058534d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    warning(\u0027eqlx_chap_password is deprecated, has no effect and will be removed after Newton cycle. Please use chap_password.\u0027)"},{"line_number":114,"context_line":"    $chap_password_real \u003d $eqlx_chap_password"},{"line_number":115,"context_line":"  } else {"},{"line_number":116,"context_line":"    $chap_password_real \u003d $chap_password"},{"line_number":117,"context_line":"  }"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  if $eqlx_cli_timeout {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_87e4d13b","line":116,"updated":"2016-05-27 10:58:21.000000000","message":"same","commit_id":"8de61f418be523f533808f1939fa9753173df0d9"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"252495e6888354b90dcc53c2997a464f75bb19b0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"# [*eqlx_use_chap*]"},{"line_number":61,"context_line":"#   (optional) DEPRECATED.Boolean. Use CHAP authentification for targets. The default"},{"line_number":62,"context_line":"#   value in OpenStack is assumed to be false for this."},{"line_number":63,"context_line":"#   Defaults to $::os_service_default"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*eqlx_chap_login*]"},{"line_number":66,"context_line":"#   (optional) DEPRECATED. An existing CHAP account name."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_9c85ff5a","line":63,"updated":"2016-05-30 10:21:19.000000000","message":"to undef","commit_id":"19032252e39f626f611bacc81cefb24dce8aa0cd"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"252495e6888354b90dcc53c2997a464f75bb19b0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  $san_ip,"},{"line_number":79,"context_line":"  $san_login,"},{"line_number":80,"context_line":"  $san_password,"},{"line_number":81,"context_line":"  $chap_username        \u003d $::os_service_default,"},{"line_number":82,"context_line":"  $chap_password        \u003d $::os_service_default,"},{"line_number":83,"context_line":"  $use_chap_auth        \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $san_thin_provision   \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_7c913b99","line":81,"updated":"2016-05-30 10:21:19.000000000","message":"It\u0027s required parameter, I think it shouldn\u0027t have a default value","commit_id":"19032252e39f626f611bacc81cefb24dce8aa0cd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3276ba6564e7f632147d4471e44c2869f14364ea","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  $san_ip,"},{"line_number":79,"context_line":"  $san_login,"},{"line_number":80,"context_line":"  $san_password,"},{"line_number":81,"context_line":"  $chap_username        \u003d $::os_service_default,"},{"line_number":82,"context_line":"  $chap_password        \u003d $::os_service_default,"},{"line_number":83,"context_line":"  $use_chap_auth        \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $san_thin_provision   \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_5cc0b72a","line":81,"in_reply_to":"9abb7d3a_7c913b99","updated":"2016-05-30 10:24:08.000000000","message":"Nope, in other case we will brake backward compatibility\n\nWe have fail if this parameter is not set by user.","commit_id":"19032252e39f626f611bacc81cefb24dce8aa0cd"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"252495e6888354b90dcc53c2997a464f75bb19b0","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  $san_login,"},{"line_number":80,"context_line":"  $san_password,"},{"line_number":81,"context_line":"  $chap_username        \u003d $::os_service_default,"},{"line_number":82,"context_line":"  $chap_password        \u003d $::os_service_default,"},{"line_number":83,"context_line":"  $use_chap_auth        \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $san_thin_provision   \u003d $::os_service_default,"},{"line_number":85,"context_line":"  $volume_backend_name  \u003d $name,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_bce9e31c","line":82,"updated":"2016-05-30 10:21:19.000000000","message":"same here","commit_id":"19032252e39f626f611bacc81cefb24dce8aa0cd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3276ba6564e7f632147d4471e44c2869f14364ea","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  $san_login,"},{"line_number":80,"context_line":"  $san_password,"},{"line_number":81,"context_line":"  $chap_username        \u003d $::os_service_default,"},{"line_number":82,"context_line":"  $chap_password        \u003d $::os_service_default,"},{"line_number":83,"context_line":"  $use_chap_auth        \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $san_thin_provision   \u003d $::os_service_default,"},{"line_number":85,"context_line":"  $volume_backend_name  \u003d $name,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_bcdd6316","line":82,"in_reply_to":"9abb7d3a_bce9e31c","updated":"2016-05-30 10:24:08.000000000","message":"same","commit_id":"19032252e39f626f611bacc81cefb24dce8aa0cd"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"252495e6888354b90dcc53c2997a464f75bb19b0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  $san_password,"},{"line_number":81,"context_line":"  $chap_username        \u003d $::os_service_default,"},{"line_number":82,"context_line":"  $chap_password        \u003d $::os_service_default,"},{"line_number":83,"context_line":"  $use_chap_auth        \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $san_thin_provision   \u003d $::os_service_default,"},{"line_number":85,"context_line":"  $volume_backend_name  \u003d $name,"},{"line_number":86,"context_line":"  $eqlx_group_name      \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_3cfa13be","line":83,"updated":"2016-05-30 10:21:19.000000000","message":"nit: it would be good to keep same params sequence as in docs","commit_id":"19032252e39f626f611bacc81cefb24dce8aa0cd"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"252495e6888354b90dcc53c2997a464f75bb19b0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  $eqlx_cli_timeout     \u003d undef,"},{"line_number":96,"context_line":") {"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  if is_service_default($chap_username) {"},{"line_number":99,"context_line":"    fail(\u0027chap_username need to be set.\u0027)"},{"line_number":100,"context_line":"  } else {"},{"line_number":101,"context_line":"    if $eqlx_chap_login {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_7cc93b78","line":98,"updated":"2016-05-30 10:21:19.000000000","message":"I think it should try to use old parameters first, and fail if both are not set. In your case all deployments which are uses master branch of the module will be broken by that change.","commit_id":"19032252e39f626f611bacc81cefb24dce8aa0cd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3276ba6564e7f632147d4471e44c2869f14364ea","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  $eqlx_cli_timeout     \u003d undef,"},{"line_number":96,"context_line":") {"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  if is_service_default($chap_username) {"},{"line_number":99,"context_line":"    fail(\u0027chap_username need to be set.\u0027)"},{"line_number":100,"context_line":"  } else {"},{"line_number":101,"context_line":"    if $eqlx_chap_login {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_7cf3fb9e","line":98,"in_reply_to":"9abb7d3a_7cc93b78","updated":"2016-05-30 10:24:08.000000000","message":"\u003e I think it should try to use old parameters first, and fail if both are not set.\n\nyes, we should try to use old first, because right now - in case of passing only old parameters we will have fail.","commit_id":"19032252e39f626f611bacc81cefb24dce8aa0cd"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"252495e6888354b90dcc53c2997a464f75bb19b0","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":"  }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  if is_service_default($chap_password) {"},{"line_number":110,"context_line":"    fail(\u0027chap_password need to be set.\u0027)"},{"line_number":111,"context_line":"  } else {"},{"line_number":112,"context_line":"    if $eqlx_chap_password {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_dcae6797","line":109,"updated":"2016-05-30 10:21:19.000000000","message":"same here","commit_id":"19032252e39f626f611bacc81cefb24dce8aa0cd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3276ba6564e7f632147d4471e44c2869f14364ea","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":"  }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  if is_service_default($chap_password) {"},{"line_number":110,"context_line":"    fail(\u0027chap_password need to be set.\u0027)"},{"line_number":111,"context_line":"  } else {"},{"line_number":112,"context_line":"    if $eqlx_chap_password {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_5ceef7b4","line":109,"in_reply_to":"9abb7d3a_dcae6797","updated":"2016-05-30 10:24:08.000000000","message":"same","commit_id":"19032252e39f626f611bacc81cefb24dce8aa0cd"}],"manifests/volume/eqlx.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c920bdadad44f3b50b99543e795150f92c872ec2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  $eqlx_use_chap        \u003d undef,"},{"line_number":82,"context_line":"  $eqlx_chap_login      \u003d undef,"},{"line_number":83,"context_line":"  $eqlx_chap_password   \u003d undef,"},{"line_number":84,"context_line":") {"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  if $eqlx_use_chap {"},{"line_number":87,"context_line":"    warning(\u0027eqlx_use_chap is deprecated, has no effect and will be removed after Newton cycle.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_0f46ef20","line":84,"updated":"2016-05-25 08:20:28.000000000","message":"same here","commit_id":"2b4eea879a858efae25f2954350a4763c8b64de7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"252495e6888354b90dcc53c2997a464f75bb19b0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  $san_ip,"},{"line_number":73,"context_line":"  $san_login,"},{"line_number":74,"context_line":"  $san_password,"},{"line_number":75,"context_line":"  $chap_username        \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $chap_password        \u003d $::os_service_default,"},{"line_number":77,"context_line":"  $use_chap_auth        \u003d $::os_service_default,"},{"line_number":78,"context_line":"  $san_thin_provision   \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_1cd90f84","line":75,"range":{"start_line":75,"start_character":9,"end_line":75,"end_character":10},"updated":"2016-05-30 10:21:19.000000000","message":"same here","commit_id":"19032252e39f626f611bacc81cefb24dce8aa0cd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3276ba6564e7f632147d4471e44c2869f14364ea","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  $san_ip,"},{"line_number":73,"context_line":"  $san_login,"},{"line_number":74,"context_line":"  $san_password,"},{"line_number":75,"context_line":"  $chap_username        \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $chap_password        \u003d $::os_service_default,"},{"line_number":77,"context_line":"  $use_chap_auth        \u003d $::os_service_default,"},{"line_number":78,"context_line":"  $san_thin_provision   \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_fc352b46","line":75,"range":{"start_line":75,"start_character":9,"end_line":75,"end_character":10},"in_reply_to":"9abb7d3a_1cd90f84","updated":"2016-05-30 10:24:08.000000000","message":"same here :)","commit_id":"19032252e39f626f611bacc81cefb24dce8aa0cd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"01cf55918407217ba31b49a23d3760fcbc6162ed","unresolved":false,"context_lines":[{"line_number":50,"context_line":"#   (optional) The timeout for the Group Manager cli command execution."},{"line_number":51,"context_line":"#   Defaults to $::os_service_default"},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"# \u003d\u003d\u003d DEPREATED PARAMETERS"},{"line_number":54,"context_line":"#"},{"line_number":55,"context_line":"# [*eqlx_use_chap*]"},{"line_number":56,"context_line":"#   (optional) DEPREATED. Use CHAP authentification for targets?"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_909aae6c","line":53,"range":{"start_line":53,"start_character":6,"end_line":53,"end_character":15},"updated":"2016-05-31 19:16:06.000000000","message":"DEPRECATED","commit_id":"1d8613406e4b5b6daf96c8eb80f3ebe16fa89600"}],"spec/classes/cinder_volume_eqlx_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"05faae283a7a1b44d777102678de76093058534d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      :chap_username        \u003d\u003e \u0027chapadm\u0027,"},{"line_number":14,"context_line":"      :chap_password        \u003d\u003e \u002756789\u0027,"},{"line_number":15,"context_line":"      :ssh_conn_timeout     \u003d\u003e 31,"},{"line_number":16,"context_line":"      :eqlx_cli_max_retries \u003d\u003e 6,"},{"line_number":17,"context_line":"  }"},{"line_number":18,"context_line":"  end"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9abb7d3a_07cf41b1","line":16,"updated":"2016-05-27 10:58:21.000000000","message":"please cover in tests a new scheme of working with parameters and also check for deprecated parameters.","commit_id":"8de61f418be523f533808f1939fa9753173df0d9"}]}