)]}'
{"manifests/backend/hp3par_iscsi.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9cba7622c35125dea110483df9fe3238d64d99f2","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  $hp3par_snapshot_expiration  \u003d undef,"},{"line_number":115,"context_line":") {"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  warning(\u0027The define cinder::backend::hp3par_iscsi is deprecated and will be removed after Newton cycle, pleasse use the new define cinder::backend::hpe3par_iscsi.\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  if ($hpe3par_snapshot_expiration \u003c\u003d $hpe3par_snapshot_retention) {"},{"line_number":120,"context_line":"    fail (\u0027hp3par_snapshot_expiration must be greater than hp3par_snapshot_retention\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_21b4a7f0","line":117,"updated":"2016-05-25 08:38:27.000000000","message":"what\u0027s main purpose for adding a new class (which a same) and deprecating for old? only class name?","commit_id":"6f41e5c46c7cef591a231ae5497fb674d6fafe69"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7a98a653e6af73fabb87b690ece87ba43f32ec27","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  $hp3par_snapshot_expiration  \u003d undef,"},{"line_number":115,"context_line":") {"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  warning(\u0027The define cinder::backend::hp3par_iscsi is deprecated and will be removed after Newton cycle, pleasse use the new define cinder::backend::hpe3par_iscsi.\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  if ($hpe3par_snapshot_expiration \u003c\u003d $hpe3par_snapshot_retention) {"},{"line_number":120,"context_line":"    fail (\u0027hp3par_snapshot_expiration must be greater than hp3par_snapshot_retention\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_d97ca374","line":117,"in_reply_to":"bab6814e_21b4a7f0","updated":"2016-05-25 12:37:13.000000000","message":"Well since all parameter has change to hpe and not anymore hp (because HP is now two companies) i think it\u0027s good to change file names and deprecate the old, the drive have \"hpe\" to and not only hp.","commit_id":"6f41e5c46c7cef591a231ae5497fb674d6fafe69"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a755eced82aae3ef2df982cc0a1ffb6a9a6d9d85","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  $hp3par_snapshot_expiration  \u003d undef,"},{"line_number":115,"context_line":") {"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  warning(\u0027The define cinder::backend::hp3par_iscsi is deprecated and will be removed after Newton cycle, pleasse use the new define cinder::backend::hpe3par_iscsi.\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  if ($hpe3par_snapshot_expiration \u003c\u003d $hpe3par_snapshot_retention) {"},{"line_number":120,"context_line":"    fail (\u0027hp3par_snapshot_expiration must be greater than hp3par_snapshot_retention\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_ec2ae2e6","line":117,"in_reply_to":"bab6814e_4cda5718","updated":"2016-05-27 10:44:10.000000000","message":"well, imho, these two classes are same, so probably we can call new class from here?\n\nand we don\u0027t need to deprecate all parameters then. just deprecate whole  class.","commit_id":"6f41e5c46c7cef591a231ae5497fb674d6fafe69"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5c97a57beb7975ff0ce59ec841c3cfc41db7936e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  $hp3par_snapshot_expiration  \u003d undef,"},{"line_number":115,"context_line":") {"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  warning(\u0027The define cinder::backend::hp3par_iscsi is deprecated and will be removed after Newton cycle, pleasse use the new define cinder::backend::hpe3par_iscsi.\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  if ($hpe3par_snapshot_expiration \u003c\u003d $hpe3par_snapshot_retention) {"},{"line_number":120,"context_line":"    fail (\u0027hp3par_snapshot_expiration must be greater than hp3par_snapshot_retention\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_4cda5718","line":117,"in_reply_to":"bab6814e_d97ca374","updated":"2016-05-26 22:55:46.000000000","message":"Should I add _real for variables here too? Thanks Denis","commit_id":"6f41e5c46c7cef591a231ae5497fb674d6fafe69"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  $san_password,"},{"line_number":69,"context_line":"  $hp3par_iscsi_ips,"},{"line_number":70,"context_line":"  $volume_backend_name        \u003d $name,"},{"line_number":71,"context_line":"  $volume_driver              \u003d \u0027cinder.volume.drivers.hpe.hpe_3par_iscsi.HPE3PARISCSIDriver\u0027,"},{"line_number":72,"context_line":"  $hp3par_iscsi_chap_enabled  \u003d false,"},{"line_number":73,"context_line":"  $hp3par_snap_cpg            \u003d \u0027OpenstackCPG\u0027,"},{"line_number":74,"context_line":"  $hp3par_snapshot_retention  \u003d 48,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_b12f933d","line":71,"updated":"2016-06-02 10:59:10.000000000","message":"not sure, that we need use new defaults for deprecated class.\n\nsame below.","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"297f2995eebc2cb67598810f63aed2c6de712005","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  $san_password,"},{"line_number":69,"context_line":"  $hp3par_iscsi_ips,"},{"line_number":70,"context_line":"  $volume_backend_name        \u003d $name,"},{"line_number":71,"context_line":"  $volume_driver              \u003d \u0027cinder.volume.drivers.hpe.hpe_3par_iscsi.HPE3PARISCSIDriver\u0027,"},{"line_number":72,"context_line":"  $hp3par_iscsi_chap_enabled  \u003d false,"},{"line_number":73,"context_line":"  $hp3par_snap_cpg            \u003d \u0027OpenstackCPG\u0027,"},{"line_number":74,"context_line":"  $hp3par_snapshot_retention  \u003d 48,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_d5bddad8","line":71,"in_reply_to":"9abb7d3a_b12f933d","updated":"2016-06-02 15:57:07.000000000","message":"Ok \u003d)","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"}],"manifests/backend/hpe3par_iscsi.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#    https://10.x.x.x:8080/api/v1"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*hpe3par_username*]"},{"line_number":11,"context_line":"#    (required) Username for HP3par admin user"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"# [*hpe3par_password*]"},{"line_number":14,"context_line":"#    (required) Password for hpe3par_username"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_91c7ef63","line":11,"range":{"start_line":11,"start_character":29,"end_line":11,"end_character":35},"updated":"2016-06-02 10:59:10.000000000","message":"hpe3par","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    (required) Password for hpe3par_username"},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# [*san_ip*]"},{"line_number":17,"context_line":"#   (required) IP address of HP 3par service processor."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*san_login*]"},{"line_number":20,"context_line":"#   (required) Username for HP 3par account."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_31e3a307","line":17,"updated":"2016-06-02 10:59:10.000000000","message":"HPE","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#   (required) IP address of HP 3par service processor."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*san_login*]"},{"line_number":20,"context_line":"#   (required) Username for HP 3par account."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*san_password*]"},{"line_number":23,"context_line":"#   (required) Password for HP 3par account."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_91f08fcb","line":20,"updated":"2016-06-02 10:59:10.000000000","message":"same","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#   (required) Username for HP 3par account."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*san_password*]"},{"line_number":23,"context_line":"#   (required) Password for HP 3par account."},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*hpe3par_iscsi_ips*]"},{"line_number":26,"context_line":"#   (required) iscsi IP addresses for the HP 3par array"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_b1bdd3d9","line":23,"range":{"start_line":23,"start_character":30,"end_line":23,"end_character":31},"updated":"2016-06-02 10:59:10.000000000","message":"same","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#   (required) Password for HP 3par account."},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*hpe3par_iscsi_ips*]"},{"line_number":26,"context_line":"#   (required) iscsi IP addresses for the HP 3par array"},{"line_number":27,"context_line":"#   This is a list of IPs with ports in a string, for example:"},{"line_number":28,"context_line":"#   \u00271.2.3.4:3261, 5.6.7.8:3261\u0027"},{"line_number":29,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_11b3ff0b","line":26,"range":{"start_line":26,"start_character":42,"end_line":26,"end_character":44},"updated":"2016-06-02 10:59:10.000000000","message":"same","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#   Defaults to: $name"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*volume_driver*]"},{"line_number":35,"context_line":"#   (optional) Setup cinder-volume to use HP 3par volume driver."},{"line_number":36,"context_line":"#   Defaults to \u0027cinder.volume.drivers.hpe.hpe_3par_fc.HPE3PARFCDriver\u0027"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# [*hpe3par_iscsi_chap_enabled*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_f1b75bf3","line":35,"range":{"start_line":35,"start_character":42,"end_line":35,"end_character":44},"updated":"2016-06-02 10:59:10.000000000","message":"same","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"}],"manifests/volume/hp3par_iscsi.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  warning(\u0027The class cinder::volume::hp3par_iscsi is deprecated and will be removed after Newton cycle, pleasse use the new class cinder::volume::hpe3par_iscsi.\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  class { \u0027::cinder::volume::hpe3par_iscsi\u0027:"},{"line_number":71,"context_line":"    volume_driver               \u003d\u003e $volume_driver,"},{"line_number":72,"context_line":"    hpe3par_username            \u003d\u003e $hp3par_username,"},{"line_number":73,"context_line":"    hpe3par_password            \u003d\u003e $hp3par_password,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_d1ba1771","line":70,"updated":"2016-06-02 10:59:10.000000000","message":"just call a new backend class here","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"297f2995eebc2cb67598810f63aed2c6de712005","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  warning(\u0027The class cinder::volume::hp3par_iscsi is deprecated and will be removed after Newton cycle, pleasse use the new class cinder::volume::hpe3par_iscsi.\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  class { \u0027::cinder::volume::hpe3par_iscsi\u0027:"},{"line_number":71,"context_line":"    volume_driver               \u003d\u003e $volume_driver,"},{"line_number":72,"context_line":"    hpe3par_username            \u003d\u003e $hp3par_username,"},{"line_number":73,"context_line":"    hpe3par_password            \u003d\u003e $hp3par_password,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_f4bf375e","line":70,"in_reply_to":"9abb7d3a_d1ba1771","updated":"2016-06-02 15:57:07.000000000","message":"sure.","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"}],"manifests/volume/hpe3par_iscsi.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*volume_driver*]"},{"line_number":9,"context_line":"#   (optional) Setup cinder-volume to use HP 3par volume driver."},{"line_number":10,"context_line":"#   Defaults to \u0027cinder.volume.drivers.hpe.hpe_3par_fc.HPE3PARFCDriver\u0027"},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# [*san_ip*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_9176cf04","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":44},"updated":"2016-06-02 10:59:10.000000000","message":"HPE","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#   Defaults to \u0027cinder.volume.drivers.hpe.hpe_3par_fc.HPE3PARFCDriver\u0027"},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# [*san_ip*]"},{"line_number":13,"context_line":"#   (required) IP address of HP 3par service processor."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*san_login*]"},{"line_number":16,"context_line":"#   (required) Username for HP 3par account."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_d15e9778","line":13,"range":{"start_line":13,"start_character":29,"end_line":13,"end_character":31},"updated":"2016-06-02 10:59:10.000000000","message":"same","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#   (required) IP address of HP 3par service processor."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*san_login*]"},{"line_number":16,"context_line":"#   (required) Username for HP 3par account."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*san_password*]"},{"line_number":19,"context_line":"#   (required) Password for HP 3par account."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_5153c76c","line":16,"range":{"start_line":16,"start_character":28,"end_line":16,"end_character":30},"updated":"2016-06-02 10:59:10.000000000","message":"same","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#   (required) Username for HP 3par account."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*san_password*]"},{"line_number":19,"context_line":"#   (required) Password for HP 3par account."},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# [*hpe3par_api_url*]"},{"line_number":22,"context_line":"#   (required) url for api access to 3par - expample"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_d1c5f70a","line":19,"range":{"start_line":19,"start_character":28,"end_line":19,"end_character":30},"updated":"2016-06-02 10:59:10.000000000","message":"same","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#   https://10.x.x.x:8080/api/v1"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*hpe3par_username*]"},{"line_number":26,"context_line":"#   (required) Username for HP3par admin user"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*hpe3par_password*]"},{"line_number":29,"context_line":"#   (required) Password for hp3par_username"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_b1caf318","line":26,"range":{"start_line":26,"start_character":28,"end_line":26,"end_character":34},"updated":"2016-06-02 10:59:10.000000000","message":"same","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#   (required) Username for HP3par admin user"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*hpe3par_password*]"},{"line_number":29,"context_line":"#   (required) Password for hp3par_username"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*hpe3par_iscsi_ips*]"},{"line_number":32,"context_line":"#   (required) iscsi ip addresses for the HP 3par array"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_11d01fc9","line":29,"range":{"start_line":29,"start_character":28,"end_line":29,"end_character":43},"updated":"2016-06-02 10:59:10.000000000","message":"same","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"194f6de46430a1307324eaff083c50cbb58836a6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#   (required) Password for hp3par_username"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*hpe3par_iscsi_ips*]"},{"line_number":32,"context_line":"#   (required) iscsi ip addresses for the HP 3par array"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*hpe3par_iscsi_chap_enabled*]"},{"line_number":35,"context_line":"#   (required) setting to false by default"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_51daa7ea","line":32,"range":{"start_line":32,"start_character":42,"end_line":32,"end_character":44},"updated":"2016-06-02 10:59:10.000000000","message":"same","commit_id":"52ecac3dc466d1689d18b0a787d883577fe42d0e"}]}