)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"08d1bb1945ddd4691235174b40201e3d51d0dfb5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move SSL parameters to api.pp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Most of the other services configure their SSL options in the api.pp."},{"line_number":10,"context_line":"So for consistency, they were moved here too. The old SSL parameters"},{"line_number":11,"context_line":"have been kept for backwards compatibility, so they should still"},{"line_number":12,"context_line":"work."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_aa9ce6bf","line":9,"updated":"2016-06-16 16:43:34.000000000","message":"not sure, that this is important - where we should configure ssl options.","commit_id":"79966c76ecea3e17158c121e2e6e53f95bd8d825"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"fbc487c220007e5365cf36af0133d7aef5cf537a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move SSL parameters to api.pp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Most of the other services configure their SSL options in the api.pp."},{"line_number":10,"context_line":"So for consistency, they were moved here too. The old SSL parameters"},{"line_number":11,"context_line":"have been kept for backwards compatibility, so they should still"},{"line_number":12,"context_line":"work."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_ff05f613","line":9,"in_reply_to":"7aa08908_aa9ce6bf","updated":"2016-06-17 05:44:03.000000000","message":"Well, for once consistency is important. But second; but lets say in the case of neutron, it is pretty awkward that for several services I end up giving the same value of of certs and keys, even if it\u0027s only used in the API and it might even be that the services are in completely different nodes. So in the end what I want is to configure the SSL values where they are actually used and in an expected place.","commit_id":"79966c76ecea3e17158c121e2e6e53f95bd8d825"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4f11163a2fed106341303d356eb98ba186cd6de6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move SSL parameters to api.pp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Most of the other services configure their SSL options in the api.pp."},{"line_number":10,"context_line":"So for consistency, they were moved here too. The old SSL parameters"},{"line_number":11,"context_line":"have been kept for backwards compatibility, so they should still"},{"line_number":12,"context_line":"work."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_ee80a28d","line":9,"in_reply_to":"7aa08908_ff05f613","updated":"2016-06-17 08:20:51.000000000","message":"not sure about neutron. I thought, that ssl values used by agents too.","commit_id":"79966c76ecea3e17158c121e2e6e53f95bd8d825"}],"manifests/api.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"967591559a3247a7b91f1bd2ce72644cf1af13d3","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    cinder_config {"},{"line_number":351,"context_line":"      \u0027DEFAULT/ssl_cert_file\u0027 : value \u003d\u003e $::os_service_default;"},{"line_number":352,"context_line":"      \u0027DEFAULT/ssl_key_file\u0027 :  value \u003d\u003e $::os_service_default;"},{"line_number":353,"context_line":"      \u0027DEFAULT/ssl_ca_file\u0027 :   value \u003d\u003e $::os_service_default;"},{"line_number":354,"context_line":"    }"},{"line_number":355,"context_line":"  }"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_b7e73c45","line":353,"updated":"2016-06-16 13:42:18.000000000","message":"don\u0027t need to set them at all in this case","commit_id":"46f771d57a76dd12cc23165054066f044090865e"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"f0519fccb301b204f50516affd258e4b683abde9","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    cinder_config {"},{"line_number":351,"context_line":"      \u0027DEFAULT/ssl_cert_file\u0027 : value \u003d\u003e $::os_service_default;"},{"line_number":352,"context_line":"      \u0027DEFAULT/ssl_key_file\u0027 :  value \u003d\u003e $::os_service_default;"},{"line_number":353,"context_line":"      \u0027DEFAULT/ssl_ca_file\u0027 :   value \u003d\u003e $::os_service_default;"},{"line_number":354,"context_line":"    }"},{"line_number":355,"context_line":"  }"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_5a8a7f65","line":353,"in_reply_to":"7aa08908_179d7057","updated":"2016-06-16 13:55:41.000000000","message":"do you want to be sure that these option are not set if use_ssl\u003dfalse? If yes, so you need to use https://github.com/openstack/puppet-cinder/blob/master/manifests/init.pp#L283. So, this else isn\u0027t needed","commit_id":"46f771d57a76dd12cc23165054066f044090865e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"1de76cbe089c4c00517b8e7466110356bac30642","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    cinder_config {"},{"line_number":351,"context_line":"      \u0027DEFAULT/ssl_cert_file\u0027 : value \u003d\u003e $::os_service_default;"},{"line_number":352,"context_line":"      \u0027DEFAULT/ssl_key_file\u0027 :  value \u003d\u003e $::os_service_default;"},{"line_number":353,"context_line":"      \u0027DEFAULT/ssl_ca_file\u0027 :   value \u003d\u003e $::os_service_default;"},{"line_number":354,"context_line":"    }"},{"line_number":355,"context_line":"  }"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_179d7057","line":353,"in_reply_to":"7aa08908_371fcc0a","updated":"2016-06-16 13:46:38.000000000","message":"wait; that was inaccurate from my side. But still, if we wuold set use_ssl as false and still set ssl_cert_file and the other values; it would enable ssl and disregard the use_ssl flag. So it\u0027s needed.","commit_id":"46f771d57a76dd12cc23165054066f044090865e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"5ad3ff423095bc7e932d453104333368d4f73a32","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    cinder_config {"},{"line_number":351,"context_line":"      \u0027DEFAULT/ssl_cert_file\u0027 : value \u003d\u003e $::os_service_default;"},{"line_number":352,"context_line":"      \u0027DEFAULT/ssl_key_file\u0027 :  value \u003d\u003e $::os_service_default;"},{"line_number":353,"context_line":"      \u0027DEFAULT/ssl_ca_file\u0027 :   value \u003d\u003e $::os_service_default;"},{"line_number":354,"context_line":"    }"},{"line_number":355,"context_line":"  }"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_7d6135d3","line":353,"in_reply_to":"7aa08908_5a8a7f65","updated":"2016-06-16 14:10:12.000000000","message":"didn\u0027t know of that option. Then I\u0027ll remove the else.","commit_id":"46f771d57a76dd12cc23165054066f044090865e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"459a039b7f4aee32cfb338cd08da3f9d2219620a","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    cinder_config {"},{"line_number":351,"context_line":"      \u0027DEFAULT/ssl_cert_file\u0027 : value \u003d\u003e $::os_service_default;"},{"line_number":352,"context_line":"      \u0027DEFAULT/ssl_key_file\u0027 :  value \u003d\u003e $::os_service_default;"},{"line_number":353,"context_line":"      \u0027DEFAULT/ssl_ca_file\u0027 :   value \u003d\u003e $::os_service_default;"},{"line_number":354,"context_line":"    }"},{"line_number":355,"context_line":"  }"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_371fcc0a","line":353,"in_reply_to":"7aa08908_b7e73c45","updated":"2016-06-16 13:43:43.000000000","message":"Well, in the case where cinder would be running with SSL. And then one would run the puppet manifest with use_ssl being false. Then this is needed as it would reset the values.","commit_id":"46f771d57a76dd12cc23165054066f044090865e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4f11163a2fed106341303d356eb98ba186cd6de6","unresolved":false,"context_lines":[{"line_number":341,"context_line":""},{"line_number":342,"context_line":"  # SSL Options"},{"line_number":343,"context_line":"  if $use_ssl_real {"},{"line_number":344,"context_line":"    cinder_config {"},{"line_number":345,"context_line":"      \u0027DEFAULT/ssl_cert_file\u0027 : value \u003d\u003e $cert_file_real;"},{"line_number":346,"context_line":"      \u0027DEFAULT/ssl_key_file\u0027 :  value \u003d\u003e $key_file_real;"},{"line_number":347,"context_line":"      \u0027DEFAULT/ssl_ca_file\u0027 :   value \u003d\u003e $ca_file_real;"},{"line_number":348,"context_line":"    }"},{"line_number":349,"context_line":"  }"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"  if (!is_service_default($ratelimits)) {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_2e62aa16","line":348,"range":{"start_line":344,"start_character":0,"end_line":348,"end_character":5},"updated":"2016-06-17 08:20:51.000000000","message":"please move these parameters to ssl section\n\nhttp://docs.openstack.org/mitaka/config-reference/block-storage/block-storage-sample-configuration-files.html\n\ncinder is migrated to oslo.service.sslutils\n\nhttps://github.com/openstack/cinder/blob/9567844f0e180a7278767fdcd4378b19913933be/cinder/config/cinder-config-generator.conf#L20","commit_id":"79966c76ecea3e17158c121e2e6e53f95bd8d825"}],"spec/classes/cinder_api_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c1fa5848699e32f7ad8c1dce21608b36857d2617","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    end"},{"line_number":354,"context_line":"  end"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"  describe \u0027with SSL socket options set\u0027 do"},{"line_number":357,"context_line":"    let :params do"},{"line_number":358,"context_line":"      {"},{"line_number":359,"context_line":"        :use_ssl         \u003d\u003e true,"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5a9d85d2_6e8882e8","line":356,"updated":"2016-06-20 16:45:38.000000000","message":"Move these up to the shared example block around line 337","commit_id":"15b8631a3e0a4859cccd82a4b5eb83fa25577e0f"}]}