)]}'
{"manifests/api.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2d1af564a7087e2633d66fad170eb413b6dc4bdd","unresolved":false,"context_lines":[{"line_number":291,"context_line":"      tag    \u003d\u003e [\u0027cinder-service\u0027],"},{"line_number":292,"context_line":"    }"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    # XXX - mfisch"},{"line_number":295,"context_line":"    # we need to make sure cinder-api/eventlet is stopped before trying to start apache"},{"line_number":296,"context_line":"    Service[\u0027cinder-api\u0027] -\u003e Service[$service_name]"},{"line_number":297,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_54fec4ae","line":294,"updated":"2016-07-25 11:18:33.000000000","message":"?","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"90d9e0a8e7d71d63c71a52eab4383d3712071de9","unresolved":false,"context_lines":[{"line_number":291,"context_line":"      tag    \u003d\u003e [\u0027cinder-service\u0027],"},{"line_number":292,"context_line":"    }"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    # XXX - mfisch"},{"line_number":295,"context_line":"    # we need to make sure cinder-api/eventlet is stopped before trying to start apache"},{"line_number":296,"context_line":"    Service[\u0027cinder-api\u0027] -\u003e Service[$service_name]"},{"line_number":297,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_5e96de94","line":294,"in_reply_to":"dada55a8_54fec4ae","updated":"2016-07-25 12:35:08.000000000","message":"Done","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"988ac9b930a0096c933655c437456da9033debf7","unresolved":false,"context_lines":[{"line_number":291,"context_line":"      tag    \u003d\u003e [\u0027cinder-service\u0027],"},{"line_number":292,"context_line":"    }"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    # XXX - mfisch"},{"line_number":295,"context_line":"    # we need to make sure cinder-api/eventlet is stopped before trying to start apache"},{"line_number":296,"context_line":"    Service[\u0027cinder-api\u0027] -\u003e Service[$service_name]"},{"line_number":297,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"9ad45d7e_d815d99b","line":294,"updated":"2016-08-09 10:52:09.000000000","message":"what does it mean? :)","commit_id":"6b4c283baf43a5a6a94ea57a4f20ed2a01bba32f"}],"manifests/backend/bdd.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2d1af564a7087e2633d66fad170eb413b6dc4bdd","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    \u0027tgtadm\u0027: {"},{"line_number":92,"context_line":"      ensure_packages(\u0027tgt\u0027, {"},{"line_number":93,"context_line":"        ensure \u003d\u003e present,"},{"line_number":94,"context_line":"        name   \u003d\u003e $::cinder::params::tgt_package_name})"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"      ensure_resource(\u0027service\u0027, \u0027tgtd\u0027, {"},{"line_number":97,"context_line":"        ensure  \u003d\u003e running,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_14772c3c","line":94,"updated":"2016-07-25 11:18:33.000000000","message":"tag cinder-support-package  ?","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2d1af564a7087e2633d66fad170eb413b6dc4bdd","unresolved":false,"context_lines":[{"line_number":96,"context_line":"      ensure_resource(\u0027service\u0027, \u0027tgtd\u0027, {"},{"line_number":97,"context_line":"        ensure  \u003d\u003e running,"},{"line_number":98,"context_line":"        name    \u003d\u003e $::cinder::params::tgt_service_name,"},{"line_number":99,"context_line":"        require \u003d\u003e Package[\u0027tgt\u0027]})"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"      if($::osfamily \u003d\u003d \u0027RedHat\u0027) {"},{"line_number":102,"context_line":"        ensure_resource(\u0027file_line\u0027, \u0027cinder include\u0027, {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_14e28c01","line":99,"updated":"2016-07-25 11:18:33.000000000","message":"i guess should be removed","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2d1af564a7087e2633d66fad170eb413b6dc4bdd","unresolved":false,"context_lines":[{"line_number":103,"context_line":"          path    \u003d\u003e \u0027/etc/tgt/targets.conf\u0027,"},{"line_number":104,"context_line":"          line    \u003d\u003e \"include ${volumes_dir}/*\","},{"line_number":105,"context_line":"          match   \u003d\u003e \u0027#?include /\u0027,"},{"line_number":106,"context_line":"          require \u003d\u003e Package[\u0027tgt\u0027],"},{"line_number":107,"context_line":"          notify  \u003d\u003e Service[\u0027tgtd\u0027]})"},{"line_number":108,"context_line":"      }"},{"line_number":109,"context_line":"    }"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_14c9ec79","line":107,"range":{"start_line":106,"start_character":0,"end_line":107,"end_character":38},"updated":"2016-07-25 11:18:33.000000000","message":"i guess can be replaced with anchor on \u0027config\u0027","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2d1af564a7087e2633d66fad170eb413b6dc4bdd","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    \u0027lioadm\u0027: {"},{"line_number":112,"context_line":"      ensure_packages(\u0027targetcli\u0027, {"},{"line_number":113,"context_line":"        ensure \u003d\u003e present,"},{"line_number":114,"context_line":"        name \u003d\u003e $::cinder::params::lio_package_name})"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"      ensure_resource(\u0027service\u0027, \u0027target\u0027, {"},{"line_number":117,"context_line":"        ensure  \u003d\u003e running,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_d49bd464","line":114,"updated":"2016-07-25 11:18:33.000000000","message":"+ tag cinder-support-package","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2d1af564a7087e2633d66fad170eb413b6dc4bdd","unresolved":false,"context_lines":[{"line_number":116,"context_line":"      ensure_resource(\u0027service\u0027, \u0027target\u0027, {"},{"line_number":117,"context_line":"        ensure  \u003d\u003e running,"},{"line_number":118,"context_line":"        enable  \u003d\u003e true,"},{"line_number":119,"context_line":"        require \u003d\u003e Package[\u0027targetcli\u0027]})"},{"line_number":120,"context_line":"    }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    default: {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_94bcbcdc","line":119,"updated":"2016-07-25 11:18:33.000000000","message":"same","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"}],"manifests/backend/glusterfs.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"895d5e11d5821990b446a3493bb9ea018cdc724a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  file { $glusterfs_shares_config:"},{"line_number":73,"context_line":"    content \u003d\u003e \"${content}\\n\","},{"line_number":74,"context_line":"    require \u003d\u003e Anchor[\u0027cinder::install::end\u0027],"},{"line_number":75,"context_line":"    notify  \u003d\u003e Anchor[\u0027cinder::service::end\u0027],"},{"line_number":76,"context_line":"  }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  cinder_config {"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"1ac06dbe_ab335212","line":75,"updated":"2016-08-25 16:10:36.000000000","message":"should this be cinder::service::begin?","commit_id":"27ba9099c70ac2d7b3b3d0987b77e8eda7ccdd07"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"a179f452734aaf9095dbd169ca90886b44114169","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  file { $glusterfs_shares_config:"},{"line_number":73,"context_line":"    content \u003d\u003e \"${content}\\n\","},{"line_number":74,"context_line":"    require \u003d\u003e Anchor[\u0027cinder::install::end\u0027],"},{"line_number":75,"context_line":"    notify  \u003d\u003e Anchor[\u0027cinder::service::end\u0027],"},{"line_number":76,"context_line":"  }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  cinder_config {"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"fa7ab95a_b32bee2f","line":75,"in_reply_to":"1ac06dbe_ab335212","updated":"2016-08-26 11:41:10.000000000","message":"Yes, you are right although I dont think it matters in practice. I will change it though.","commit_id":"27ba9099c70ac2d7b3b3d0987b77e8eda7ccdd07"}],"manifests/backend/iscsi.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2d1af564a7087e2633d66fad170eb413b6dc4bdd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"          path    \u003d\u003e \u0027/etc/tgt/targets.conf\u0027,"},{"line_number":76,"context_line":"          line    \u003d\u003e \"include ${volumes_dir}/*\","},{"line_number":77,"context_line":"          match   \u003d\u003e \u0027#?include /\u0027,"},{"line_number":78,"context_line":"          require \u003d\u003e Package[\u0027tgt\u0027],"},{"line_number":79,"context_line":"          notify  \u003d\u003e Service[\u0027tgtd\u0027],"},{"line_number":80,"context_line":"        }"},{"line_number":81,"context_line":"      }"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_34951040","line":79,"range":{"start_line":78,"start_character":0,"end_line":79,"end_character":37},"updated":"2016-07-25 11:18:33.000000000","message":"why not add here anchor on \u0027config\u0027 ?","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"32717696059a56ba1c3b9d6462c6b26c5e95f053","unresolved":false,"context_lines":[{"line_number":75,"context_line":"          path    \u003d\u003e \u0027/etc/tgt/targets.conf\u0027,"},{"line_number":76,"context_line":"          line    \u003d\u003e \"include ${volumes_dir}/*\","},{"line_number":77,"context_line":"          match   \u003d\u003e \u0027#?include /\u0027,"},{"line_number":78,"context_line":"          require \u003d\u003e Package[\u0027tgt\u0027],"},{"line_number":79,"context_line":"          notify  \u003d\u003e Service[\u0027tgtd\u0027],"},{"line_number":80,"context_line":"        }"},{"line_number":81,"context_line":"      }"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"bacf61ea_8c7b957a","line":79,"range":{"start_line":78,"start_character":0,"end_line":79,"end_character":37},"in_reply_to":"dada55a8_34951040","updated":"2016-08-01 17:01:30.000000000","message":"Done","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2d1af564a7087e2633d66fad170eb413b6dc4bdd","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        ensure  \u003d\u003e running,"},{"line_number":85,"context_line":"        name    \u003d\u003e $::cinder::params::tgt_service_name,"},{"line_number":86,"context_line":"        enable  \u003d\u003e true,"},{"line_number":87,"context_line":"        require \u003d\u003e Class[\u0027cinder::volume\u0027],"},{"line_number":88,"context_line":"      }"},{"line_number":89,"context_line":"    }"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_54a88477","line":87,"updated":"2016-07-25 11:18:33.000000000","message":"this require should be removed i guess, due to possible dependency cycle","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"90d9e0a8e7d71d63c71a52eab4383d3712071de9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        ensure  \u003d\u003e running,"},{"line_number":85,"context_line":"        name    \u003d\u003e $::cinder::params::tgt_service_name,"},{"line_number":86,"context_line":"        enable  \u003d\u003e true,"},{"line_number":87,"context_line":"        require \u003d\u003e Class[\u0027cinder::volume\u0027],"},{"line_number":88,"context_line":"      }"},{"line_number":89,"context_line":"    }"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_dea00ea8","line":87,"in_reply_to":"dada55a8_54a88477","updated":"2016-07-25 12:35:08.000000000","message":"Done","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2d1af564a7087e2633d66fad170eb413b6dc4bdd","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      service { \u0027target\u0027:"},{"line_number":93,"context_line":"        ensure  \u003d\u003e running,"},{"line_number":94,"context_line":"        enable  \u003d\u003e true,"},{"line_number":95,"context_line":"        require \u003d\u003e Package[\u0027targetcli\u0027],"},{"line_number":96,"context_line":"      }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"      package { \u0027targetcli\u0027:"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_549a446f","line":95,"updated":"2016-07-25 11:18:33.000000000","message":"can be removed","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"90d9e0a8e7d71d63c71a52eab4383d3712071de9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      service { \u0027target\u0027:"},{"line_number":93,"context_line":"        ensure  \u003d\u003e running,"},{"line_number":94,"context_line":"        enable  \u003d\u003e true,"},{"line_number":95,"context_line":"        require \u003d\u003e Package[\u0027targetcli\u0027],"},{"line_number":96,"context_line":"      }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"      package { \u0027targetcli\u0027:"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_bea39ab0","line":95,"in_reply_to":"dada55a8_549a446f","updated":"2016-07-25 12:35:08.000000000","message":"Done","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"95e669cda457f9609494fa9d4c82f37fa98c260b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"      }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"      if($::osfamily \u003d\u003d \u0027RedHat\u0027) {"},{"line_number":74,"context_line":"        file_line { \u0027cinder include\u0027:"},{"line_number":75,"context_line":"          path    \u003d\u003e \u0027/etc/tgt/targets.conf\u0027,"},{"line_number":76,"context_line":"          line    \u003d\u003e \"include ${volumes_dir}/*\","},{"line_number":77,"context_line":"          match   \u003d\u003e \u0027#?include /\u0027,"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_2aa00843","line":74,"updated":"2016-08-09 16:21:38.000000000","message":"In other modules (at least neutron) there are enough file and file_line resources to have them tagged and included in the ::deps class.  Might make sense here also.","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"}],"manifests/backend/vmdk.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2d1af564a7087e2633d66fad170eb413b6dc4bdd","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    \"${name}/host\":                               value \u003d\u003e \"vmdk:${host_ip}-${volume_folder}\";"},{"line_number":95,"context_line":"  }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  # XXX - ordering?"},{"line_number":98,"context_line":"  package { \u0027python-suds\u0027:"},{"line_number":99,"context_line":"    ensure \u003d\u003e present,"},{"line_number":100,"context_line":"    tag    \u003d\u003e \u0027cinder-support-package\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_d400f468","line":97,"updated":"2016-07-25 11:18:33.000000000","message":"what\u0027s problem with ordering here?","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"90d9e0a8e7d71d63c71a52eab4383d3712071de9","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    \"${name}/host\":                               value \u003d\u003e \"vmdk:${host_ip}-${volume_folder}\";"},{"line_number":95,"context_line":"  }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  # XXX - ordering?"},{"line_number":98,"context_line":"  package { \u0027python-suds\u0027:"},{"line_number":99,"context_line":"    ensure \u003d\u003e present,"},{"line_number":100,"context_line":"    tag    \u003d\u003e \u0027cinder-support-package\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_1ee746e5","line":97,"in_reply_to":"dada55a8_d400f468","updated":"2016-07-25 12:35:08.000000000","message":"will need mfisch to weigh in here.  not sure what his thought was on this","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"}],"manifests/client.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2d1af564a7087e2633d66fad170eb413b6dc4bdd","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $package_ensure \u003d \u0027present\u0027"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  include ::cinder::config"},{"line_number":16,"context_line":"  include ::cinder::deps"},{"line_number":17,"context_line":"  include ::cinder::params"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_343fd026","line":15,"updated":"2016-07-25 11:18:33.000000000","message":"i don\u0027t think, that we need this include here","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"988ac9b930a0096c933655c437456da9033debf7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $package_ensure \u003d \u0027present\u0027"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  include ::cinder::config"},{"line_number":16,"context_line":"  include ::cinder::deps"},{"line_number":17,"context_line":"  include ::cinder::params"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":28,"id":"9ad45d7e_f8953de4","line":15,"updated":"2016-08-09 10:52:09.000000000","message":"why do we need this include here?","commit_id":"6b4c283baf43a5a6a94ea57a4f20ed2a01bba32f"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"95e669cda457f9609494fa9d4c82f37fa98c260b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  package { \u0027python-cinderclient\u0027:"},{"line_number":19,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":20,"context_line":"    name   \u003d\u003e $::cinder::params::client_package,"},{"line_number":21,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027cinder-support-package\u0027],"},{"line_number":22,"context_line":"  }"},{"line_number":23,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_2a45a86f","line":21,"updated":"2016-08-09 16:21:38.000000000","message":"This probably shouldn\u0027t have the openstack tag.  Other support packages don\u0027t.","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"a1bf2c841a002336dacd4c950173d17d8c97133a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  package { \u0027python-cinderclient\u0027:"},{"line_number":19,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":20,"context_line":"    name   \u003d\u003e $::cinder::params::client_package,"},{"line_number":21,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027cinder-support-package\u0027],"},{"line_number":22,"context_line":"  }"},{"line_number":23,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_ff0fc32b","line":21,"in_reply_to":"9ad45d7e_2a45a86f","updated":"2016-08-09 20:17:55.000000000","message":"removed","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"}],"manifests/db/mysql.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2d1af564a7087e2633d66fad170eb413b6dc4bdd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*cluster_id*]"},{"line_number":34,"context_line":"#   Unused. No effect."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class cinder::db::mysql ("},{"line_number":37,"context_line":"  $password,"},{"line_number":38,"context_line":"  $dbname        \u003d \u0027cinder\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_d40e348b","side":"PARENT","line":35,"updated":"2016-07-25 11:18:33.000000000","message":"nit: better to upload separate patch for this","commit_id":"37062fa692bde3ddf73b5ad8fbe52605f1d08023"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"e363cbe35941be133b941aeffa3b899117a2b52b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*cluster_id*]"},{"line_number":34,"context_line":"#   Unused. No effect."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class cinder::db::mysql ("},{"line_number":37,"context_line":"  $password,"},{"line_number":38,"context_line":"  $dbname        \u003d \u0027cinder\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_a1909b96","side":"PARENT","line":35,"in_reply_to":"dada55a8_1e83c6cd","updated":"2016-07-25 12:43:09.000000000","message":"pushed change for this.\nhttps://review.openstack.org/346745 Removing deprecated cluster_id db var","commit_id":"37062fa692bde3ddf73b5ad8fbe52605f1d08023"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"90d9e0a8e7d71d63c71a52eab4383d3712071de9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*cluster_id*]"},{"line_number":34,"context_line":"#   Unused. No effect."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class cinder::db::mysql ("},{"line_number":37,"context_line":"  $password,"},{"line_number":38,"context_line":"  $dbname        \u003d \u0027cinder\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_1e83c6cd","side":"PARENT","line":35,"in_reply_to":"dada55a8_d40e348b","updated":"2016-07-25 12:35:08.000000000","message":"added back in.  will do a separate patch to remove the deprecated cluster_id variable","commit_id":"37062fa692bde3ddf73b5ad8fbe52605f1d08023"}],"manifests/db/sync.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"988ac9b930a0096c933655c437456da9033debf7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      Anchor[\u0027cinder::dbsync::begin\u0027]"},{"line_number":29,"context_line":"    ],"},{"line_number":30,"context_line":"    notify      \u003d\u003e Anchor[\u0027cinder::dbsync::end\u0027],"},{"line_number":31,"context_line":"    tag         \u003d\u003e \u0027cinder-exec\u0027,"},{"line_number":32,"context_line":"  }"},{"line_number":33,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"9ad45d7e_5873a9e7","line":31,"updated":"2016-08-09 10:52:09.000000000","message":"do we need this tag? it\u0027s unused.","commit_id":"6b4c283baf43a5a6a94ea57a4f20ed2a01bba32f"}],"manifests/deps.pp":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"95e669cda457f9609494fa9d4c82f37fa98c260b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  # all cache settings should be applied and all packages should be installed"},{"line_number":28,"context_line":"  # before service startup"},{"line_number":29,"context_line":"  Oslo::Cache\u003c||\u003e -\u003e Anchor[\u0027cinder::service::begin\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # all db settings should be applied and all packages should be installed"},{"line_number":32,"context_line":"  # before dbsync starts"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_0a8704d8","line":29,"updated":"2016-08-09 16:21:38.000000000","message":"This isn\u0027t needed, it\u0027s just creating cinder_config resources that are already handled.","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"a1bf2c841a002336dacd4c950173d17d8c97133a","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  # all cache settings should be applied and all packages should be installed"},{"line_number":28,"context_line":"  # before service startup"},{"line_number":29,"context_line":"  Oslo::Cache\u003c||\u003e -\u003e Anchor[\u0027cinder::service::begin\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # all db settings should be applied and all packages should be installed"},{"line_number":32,"context_line":"  # before dbsync starts"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_7f2ab37f","line":29,"in_reply_to":"9ad45d7e_0a8704d8","updated":"2016-08-09 20:17:55.000000000","message":"removed","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"95e669cda457f9609494fa9d4c82f37fa98c260b","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # all db settings should be applied and all packages should be installed"},{"line_number":32,"context_line":"  # before dbsync starts"},{"line_number":33,"context_line":"  Oslo::Db\u003c||\u003e -\u003e Anchor[\u0027cinder::dbsync::begin\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  # paste-api.ini config should occur in the config block also."},{"line_number":36,"context_line":"  Anchor[\u0027cinder::config::begin\u0027]"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_aa7878f3","line":33,"updated":"2016-08-09 16:21:38.000000000","message":"This isn\u0027t needed, it\u0027s just creating cinder_config resources that are already handled.","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"a1bf2c841a002336dacd4c950173d17d8c97133a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # all db settings should be applied and all packages should be installed"},{"line_number":32,"context_line":"  # before dbsync starts"},{"line_number":33,"context_line":"  Oslo::Db\u003c||\u003e -\u003e Anchor[\u0027cinder::dbsync::begin\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  # paste-api.ini config should occur in the config block also."},{"line_number":36,"context_line":"  Anchor[\u0027cinder::config::begin\u0027]"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_df211fa1","line":33,"in_reply_to":"9ad45d7e_aa7878f3","updated":"2016-08-09 20:17:55.000000000","message":"removed","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"}],"manifests/policy.pp":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"95e669cda457f9609494fa9d4c82f37fa98c260b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  create_resources(\u0027openstacklib::policy::base\u0027, $policies)"},{"line_number":34,"context_line":"  oslo::policy { \u0027cinder_config\u0027: policy_file \u003d\u003e $policy_path }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_4d0f562e","line":35,"updated":"2016-08-09 16:21:38.000000000","message":"Spurious?","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"}],"manifests/quota_set.pp":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"95e669cda457f9609494fa9d4c82f37fa98c260b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    command     \u003d\u003e \"cinder quota-class-update ${class_name} --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type \u0027${volume_type}\u0027\","},{"line_number":83,"context_line":"    onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"},{"line_number":84,"context_line":"    environment \u003d\u003e $cinder_env,"},{"line_number":85,"context_line":"    require     \u003d\u003e Anchor[\u0027cinder-support-package\u0027],"},{"line_number":86,"context_line":"    path        \u003d\u003e [\u0027/usr/bin\u0027, \u0027/bin\u0027],"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_6d3b3ad2","line":85,"updated":"2016-08-09 16:21:38.000000000","message":"Does this need the db or service to be up?","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"a1bf2c841a002336dacd4c950173d17d8c97133a","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    command     \u003d\u003e \"cinder quota-class-update ${class_name} --volumes ${quota_volumes} --snapshots ${quota_snapshots} --gigabytes ${quota_gigabytes} --volume-type \u0027${volume_type}\u0027\","},{"line_number":83,"context_line":"    onlyif      \u003d\u003e \u0027cinder quota-class-show default | grep -qP -- -1\u0027,"},{"line_number":84,"context_line":"    environment \u003d\u003e $cinder_env,"},{"line_number":85,"context_line":"    require     \u003d\u003e Anchor[\u0027cinder-support-package\u0027],"},{"line_number":86,"context_line":"    path        \u003d\u003e [\u0027/usr/bin\u0027, \u0027/bin\u0027],"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_3f315bed","line":85,"in_reply_to":"9ad45d7e_6d3b3ad2","updated":"2016-08-09 20:17:55.000000000","message":"yes","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"}],"manifests/rabbitmq.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"895d5e11d5821990b446a3493bb9ea018cdc724a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      write_permission     \u003d\u003e \u0027.*\u0027,"},{"line_number":48,"context_line":"      read_permission      \u003d\u003e \u0027.*\u0027,"},{"line_number":49,"context_line":"      provider             \u003d\u003e \u0027rabbitmqctl\u0027,"},{"line_number":50,"context_line":"    } -\u003e Anchor[\u0027cinder::service::end\u0027]"},{"line_number":51,"context_line":"  }"},{"line_number":52,"context_line":"  rabbitmq_vhost { $virtual_host:"},{"line_number":53,"context_line":"    provider \u003d\u003e \u0027rabbitmqctl\u0027,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"1ac06dbe_6f632542","line":50,"updated":"2016-08-25 16:10:36.000000000","message":"This class should be skipped, because it is deprecated. But if we want add deps here, may be it\u0027s better to create user before services start (add -\u003e Anchor[\u0027cinder::service::begin\u0027] instead)?","commit_id":"27ba9099c70ac2d7b3b3d0987b77e8eda7ccdd07"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"a179f452734aaf9095dbd169ca90886b44114169","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      write_permission     \u003d\u003e \u0027.*\u0027,"},{"line_number":48,"context_line":"      read_permission      \u003d\u003e \u0027.*\u0027,"},{"line_number":49,"context_line":"      provider             \u003d\u003e \u0027rabbitmqctl\u0027,"},{"line_number":50,"context_line":"    } -\u003e Anchor[\u0027cinder::service::end\u0027]"},{"line_number":51,"context_line":"  }"},{"line_number":52,"context_line":"  rabbitmq_vhost { $virtual_host:"},{"line_number":53,"context_line":"    provider \u003d\u003e \u0027rabbitmqctl\u0027,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"fa7ab95a_13ae5a85","line":50,"in_reply_to":"1ac06dbe_6f632542","updated":"2016-08-26 11:41:10.000000000","message":"Done","commit_id":"27ba9099c70ac2d7b3b3d0987b77e8eda7ccdd07"}],"manifests/setup_test_volume.pp":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"95e669cda457f9609494fa9d4c82f37fa98c260b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    unless      \u003d\u003e \"vgdisplay | grep ${volume_name}\","},{"line_number":58,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":59,"context_line":"  }"},{"line_number":60,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_cdece62b","line":60,"updated":"2016-08-09 16:21:38.000000000","message":"Spurious?","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"}],"manifests/volume.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2d1af564a7087e2633d66fad170eb413b6dc4bdd","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if $::cinder::params::volume_package {"},{"line_number":48,"context_line":"    Package[\u0027cinder\u0027]        -\u003e Package[\u0027cinder-volume\u0027]"},{"line_number":49,"context_line":"    Package[\u0027cinder-volume\u0027] -\u003e Service[\u0027cinder-volume\u0027]"},{"line_number":50,"context_line":"    package { \u0027cinder-volume\u0027:"},{"line_number":51,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":52,"context_line":"      name   \u003d\u003e $::cinder::params::volume_package,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_54724412","line":49,"updated":"2016-07-25 11:18:33.000000000","message":"not needed","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2d1af564a7087e2633d66fad170eb413b6dc4bdd","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    name      \u003d\u003e $::cinder::params::volume_service,"},{"line_number":68,"context_line":"    enable    \u003d\u003e $enabled,"},{"line_number":69,"context_line":"    hasstatus \u003d\u003e true,"},{"line_number":70,"context_line":"    require   \u003d\u003e Package[\u0027cinder\u0027],"},{"line_number":71,"context_line":"    tag       \u003d\u003e \u0027cinder-service\u0027,"},{"line_number":72,"context_line":"  }"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_9462fc3b","line":70,"updated":"2016-07-25 11:18:33.000000000","message":"not needed","commit_id":"b6a642ce202ce31da6aacf88dabce2c7d37c4fdc"}],"manifests/volume/dellsc_iscsi.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"988ac9b930a0096c933655c437456da9033debf7","unresolved":false,"context_lines":[{"line_number":60,"context_line":") {"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  warning(\u0027Usage of cinder::volume::dellsc_iscsi is deprecated, please use"},{"line_number":63,"context_line":"cinder::backend::dellsc_iscsi instead.\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  cinder::backend::dellsc_iscsi { \u0027DEFAULT\u0027:"},{"line_number":66,"context_line":"    san_ip                \u003d\u003e $san_ip,"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"9ad45d7e_c335eeda","side":"PARENT","line":63,"updated":"2016-08-09 10:52:09.000000000","message":"do not remove please current warning","commit_id":"a6f8b43f6a3adb038a578d7c373a2e617703d211"}],"manifests/volume/emc_vnx.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"988ac9b930a0096c933655c437456da9033debf7","unresolved":false,"context_lines":[{"line_number":79,"context_line":") {"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  warning(\u0027Usage of cinder::volume::emc_vnx is deprecated, please use"},{"line_number":82,"context_line":"cinder::backend::emc_vnx instead.\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  cinder::backend::emc_vnx { \u0027DEFAULT\u0027:"},{"line_number":85,"context_line":"    default_timeout               \u003d\u003e $default_timeout,"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"9ad45d7e_6336c2e8","side":"PARENT","line":82,"updated":"2016-08-09 10:52:09.000000000","message":"do not remove please current warning","commit_id":"a6f8b43f6a3adb038a578d7c373a2e617703d211"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"95e669cda457f9609494fa9d4c82f37fa98c260b","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  include ::cinder::deps"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"   warning(\u0027Usage of cinder::volume::emc_vnx is deprecated, please use"},{"line_number":84,"context_line":" cinder::backend::emc_vnx instead.\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  cinder::backend::emc_vnx { \u0027DEFAULT\u0027:"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_ed372aae","line":83,"updated":"2016-08-09 16:21:38.000000000","message":"Extra whitespace?","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"a1bf2c841a002336dacd4c950173d17d8c97133a","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  include ::cinder::deps"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"   warning(\u0027Usage of cinder::volume::emc_vnx is deprecated, please use"},{"line_number":84,"context_line":" cinder::backend::emc_vnx instead.\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  cinder::backend::emc_vnx { \u0027DEFAULT\u0027:"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_3f8ddb7b","line":83,"in_reply_to":"9ad45d7e_ed372aae","updated":"2016-08-09 20:17:55.000000000","message":"Done","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"}],"manifests/volume/eqlx.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"988ac9b930a0096c933655c437456da9033debf7","unresolved":false,"context_lines":[{"line_number":89,"context_line":") {"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  warning(\u0027Usage of cinder::volume::eqlx is deprecated, please use"},{"line_number":92,"context_line":"cinder::backend::eqlx instead.\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  if $eqlx_chap_login {"},{"line_number":95,"context_line":"    warning(\u0027eqlx_chap_login is deprecated and will be removed after Newton cycle. Please use chap_username instead.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"9ad45d7e_4321fe9e","side":"PARENT","line":92,"updated":"2016-08-09 10:52:09.000000000","message":"do not remove please current warning","commit_id":"a6f8b43f6a3adb038a578d7c373a2e617703d211"}],"manifests/volume/glusterfs.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"988ac9b930a0096c933655c437456da9033debf7","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  warning(\u0027Usage of cinder::volume::glusterfs is deprecated, please use"},{"line_number":56,"context_line":"cinder::backend::glusterfs instead.\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  cinder::backend::glusterfs { \u0027DEFAULT\u0027:"},{"line_number":59,"context_line":"    glusterfs_shares             \u003d\u003e $glusterfs_shares,"},{"line_number":60,"context_line":"    glusterfs_backup_mount_point \u003d\u003e $glusterfs_backup_mount_point,"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"9ad45d7e_a319da7b","side":"PARENT","line":57,"updated":"2016-08-09 10:52:09.000000000","message":"do not remove please current warning","commit_id":"a6f8b43f6a3adb038a578d7c373a2e617703d211"}],"manifests/volume/gpfs.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"988ac9b930a0096c933655c437456da9033debf7","unresolved":false,"context_lines":[{"line_number":69,"context_line":") {"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  warning(\u0027Usage of cinder::volume::gpfs is deprecated, please use"},{"line_number":72,"context_line":"cinder::backend::gpfs instead.\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  cinder::backend::gpfs { \u0027DEFAULT\u0027:"},{"line_number":75,"context_line":"    gpfs_mount_point_base  \u003d\u003e $gpfs_mount_point_base,"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"9ad45d7e_c31e8e62","side":"PARENT","line":72,"updated":"2016-08-09 10:52:09.000000000","message":"do not remove please current warning","commit_id":"a6f8b43f6a3adb038a578d7c373a2e617703d211"}],"manifests/volume/hp3par_iscsi.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"988ac9b930a0096c933655c437456da9033debf7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $extra_options              \u003d {},"},{"line_number":65,"context_line":") {"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  warning(\u0027The class cinder::volume::hp3par_iscsi is deprecated and will be removed after Newton cycle, pleasse use the new class cinder::volume::hpe3par_iscsi.\u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  cinder::backend::hpe3par_iscsi { \u0027DEFAULT\u0027:"},{"line_number":70,"context_line":"    volume_driver               \u003d\u003e $volume_driver,"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"9ad45d7e_630fe22e","side":"PARENT","line":67,"updated":"2016-08-09 10:52:09.000000000","message":"do not remove please current warning","commit_id":"a6f8b43f6a3adb038a578d7c373a2e617703d211"}],"manifests/volume/hpe3par_iscsi.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"988ac9b930a0096c933655c437456da9033debf7","unresolved":false,"context_lines":[{"line_number":67,"context_line":") {"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  warning(\u0027Usage of cinder::volume::hpe3par_iscsi is deprecated, please use"},{"line_number":70,"context_line":"cinder::backend::hpe3par_iscsi instead.\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  cinder::backend::hpe3par_iscsi { \u0027DEFAULT\u0027:"},{"line_number":73,"context_line":"    volume_driver               \u003d\u003e $volume_driver,"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"9ad45d7e_230dea37","side":"PARENT","line":70,"updated":"2016-08-09 10:52:09.000000000","message":"do not remove please current warning","commit_id":"a6f8b43f6a3adb038a578d7c373a2e617703d211"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"95e669cda457f9609494fa9d4c82f37fa98c260b","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  include ::cinder::deps"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    warning(\u0027Usage of cinder::volume::hpe3par_iscsi is deprecated, please use"},{"line_number":72,"context_line":"cinder::backend::hpe3par_iscsi instead.\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  cinder::backend::hpe3par_iscsi { \u0027DEFAULT\u0027:"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_6d4cda42","line":71,"updated":"2016-08-09 16:21:38.000000000","message":"Extra whitespace?","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"},{"author":{"_account_id":13258,"name":"craig delatte","email":"delattec@gmail.com","username":"cdelatte"},"change_message_id":"a1bf2c841a002336dacd4c950173d17d8c97133a","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  include ::cinder::deps"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    warning(\u0027Usage of cinder::volume::hpe3par_iscsi is deprecated, please use"},{"line_number":72,"context_line":"cinder::backend::hpe3par_iscsi instead.\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  cinder::backend::hpe3par_iscsi { \u0027DEFAULT\u0027:"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9ad45d7e_bfceebb1","line":71,"in_reply_to":"9ad45d7e_6d4cda42","updated":"2016-08-09 20:17:55.000000000","message":"Done","commit_id":"a2198d2e7b1b2867539dabe0cec85d48cb88e300"}],"manifests/volume/pure.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"988ac9b930a0096c933655c437456da9033debf7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  $extra_options                \u003d {},"},{"line_number":45,"context_line":") {"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    warning(\u0027Usage of cinder::volume::pure is deprecated, please use"},{"line_number":48,"context_line":"cinder::backend::pure instead.\u0027)"},{"line_number":49,"context_line":"  include ::cinder::deps"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":28,"id":"9ad45d7e_c34cce72","line":47,"range":{"start_line":47,"start_character":2,"end_line":47,"end_character":4},"updated":"2016-08-09 10:52:09.000000000","message":"unneeded spaces","commit_id":"6b4c283baf43a5a6a94ea57a4f20ed2a01bba32f"}],"manifests/wsgi/apache.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"988ac9b930a0096c933655c437456da9033debf7","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    wsgi_process_group  \u003d\u003e \u0027cinder-api\u0027,"},{"line_number":121,"context_line":"    wsgi_script_dir     \u003d\u003e $::cinder::params::cinder_wsgi_script_path,"},{"line_number":122,"context_line":"    wsgi_script_file    \u003d\u003e \u0027cinder-api\u0027,"},{"line_number":123,"context_line":"    wsgi_script_source  \u003d\u003e $::cinder::params::cinder_wsgi_script_source,"},{"line_number":124,"context_line":"  }"},{"line_number":125,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"9ad45d7e_43a61e11","line":123,"updated":"2016-08-09 10:52:09.000000000","message":"do we need anchor on package::end here?","commit_id":"6b4c283baf43a5a6a94ea57a4f20ed2a01bba32f"}]}