)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"41b0f567112935d1c30e717cf78b10a8fdf1b94b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Change-Id: Ide11259e1c55366837ff32ebcc3589e0e8e5a58b"},{"line_number":13,"context_line":"Closes-Bug: #1605368"},{"line_number":14,"context_line":"Closes-Bug: #1605373"},{"line_number":15,"context_line":"backport: mitaka"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_2e681dba","line":15,"updated":"2016-07-25 10:15:52.000000000","message":"this line isn\u0027t needed","commit_id":"28524ae9de2b5d7206dfb5f35d0c8eb4c0510a53"},{"author":{"_account_id":10221,"name":"Edward Balduf","email":"ed.balduf@solidfire.com","username":"ebalduf"},"change_message_id":"ef5ac82829a0b670cdb9c5dc5451f8f8115e253d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Change-Id: Ide11259e1c55366837ff32ebcc3589e0e8e5a58b"},{"line_number":13,"context_line":"Closes-Bug: #1605368"},{"line_number":14,"context_line":"Closes-Bug: #1605373"},{"line_number":15,"context_line":"backport: mitaka"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_ed3c41c1","line":15,"in_reply_to":"dada55a8_2e681dba","updated":"2016-07-25 14:11:41.000000000","message":"OpenStack developer guide says to put it in there... but it\u0027s gone now.","commit_id":"28524ae9de2b5d7206dfb5f35d0c8eb4c0510a53"}],"manifests/backend/solidfire.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"f250cf0716a16555f5c5d13baa87eafb8707fb2b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  $sf_allow_template_caching \u003d false,"},{"line_number":90,"context_line":"  $sf_api_port               \u003d \u0027443\u0027,"},{"line_number":91,"context_line":"  $sf_volume_prefix          \u003d \u0027UUID-\u0027,"},{"line_number":92,"context_line":"  $sf_svip                   \u003d undef,"},{"line_number":93,"context_line":"  $sf_enable_volume_mapping  \u003d true,"},{"line_number":94,"context_line":"  $sf_enable_vag             \u003d false,"},{"line_number":95,"context_line":"  $extra_options             \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_2cd07bf7","line":92,"updated":"2016-07-22 07:21:08.000000000","message":"is it possible to use $::os_service_default? please don\u0027t forget to update docs and unit tests","commit_id":"a91074eae496d6662f6782c8bea984dfe937c8f3"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5083bd3845aa9d8a960579127b446df1688b4f69","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  $sf_allow_template_caching \u003d false,"},{"line_number":90,"context_line":"  $sf_api_port               \u003d \u0027443\u0027,"},{"line_number":91,"context_line":"  $sf_volume_prefix          \u003d \u0027UUID-\u0027,"},{"line_number":92,"context_line":"  $sf_svip                   \u003d undef,"},{"line_number":93,"context_line":"  $sf_enable_volume_mapping  \u003d true,"},{"line_number":94,"context_line":"  $sf_enable_vag             \u003d false,"},{"line_number":95,"context_line":"  $extra_options             \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_af48dd8b","line":92,"in_reply_to":"dada55a8_2cd07bf7","updated":"2016-07-22 07:50:13.000000000","message":"+1","commit_id":"a91074eae496d6662f6782c8bea984dfe937c8f3"},{"author":{"_account_id":10221,"name":"Edward Balduf","email":"ed.balduf@solidfire.com","username":"ebalduf"},"change_message_id":"6f86a2a882d53862e0191a9b619c4131f8ba4643","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  $sf_allow_template_caching \u003d false,"},{"line_number":90,"context_line":"  $sf_api_port               \u003d \u0027443\u0027,"},{"line_number":91,"context_line":"  $sf_volume_prefix          \u003d \u0027UUID-\u0027,"},{"line_number":92,"context_line":"  $sf_svip                   \u003d undef,"},{"line_number":93,"context_line":"  $sf_enable_volume_mapping  \u003d true,"},{"line_number":94,"context_line":"  $sf_enable_vag             \u003d false,"},{"line_number":95,"context_line":"  $extra_options             \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_8ce35133","line":92,"in_reply_to":"dada55a8_2cd07bf7","updated":"2016-07-22 14:02:20.000000000","message":"I guess I should have put some more comments in here. For this bug, I wanted to fix this issue and only this issues, so we can backport it to fix this issue in Mitaka.  For this one, the driver is coded in a way that if this option (key) is in the config file, even with no value, it will fail.  Therefore we want this one undefined as the default.  I have another patch that I am working on (under a different bug #1605373) which will set the remainder of these to $::os_service_defaults, with the intention of NOT backporting that.  \n\nI could do this as one patch and backport, or as I described above.  Let me know how you want me to handle these issues.... I will do it either way","commit_id":"a91074eae496d6662f6782c8bea984dfe937c8f3"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0d8dda202082681999aa5d9d568c1b137cde7206","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  $sf_allow_template_caching \u003d false,"},{"line_number":90,"context_line":"  $sf_api_port               \u003d \u0027443\u0027,"},{"line_number":91,"context_line":"  $sf_volume_prefix          \u003d \u0027UUID-\u0027,"},{"line_number":92,"context_line":"  $sf_svip                   \u003d undef,"},{"line_number":93,"context_line":"  $sf_enable_volume_mapping  \u003d true,"},{"line_number":94,"context_line":"  $sf_enable_vag             \u003d false,"},{"line_number":95,"context_line":"  $extra_options             \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_6056e107","line":92,"in_reply_to":"dada55a8_8ce35133","updated":"2016-07-22 14:12:28.000000000","message":"So,\n\n\u003e For this one, the driver is coded in a way that if this option (key) is in the config file, even with no value, it will fail.\n\n$::os_service_default is not going to write something to config, it\u0027s kinda of value, that puppet relies on project default, even it is not set in config.\n\n\u003e For this bug, I wanted to fix this issue and only this issues, so we can backport it to fix this issue in Mitaka. \n\nYou can simply cherry-pick this change according to Mitaka rules, in Mitaka you can use undef.","commit_id":"a91074eae496d6662f6782c8bea984dfe937c8f3"}],"releasenotes/notes/solidfire-service-defaults-765ceeb5bec4eddd.yaml":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"41b0f567112935d1c30e717cf78b10a8fdf1b94b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - Fixes `bug 1605368"},{"line_number":6,"context_line":"    \u003chttps://bugs.launchpad.net/puppet-cinder/+bug/1605368\u003e`__"},{"line_number":7,"context_line":"    such that the parameter sf_svip is not include when not set. "},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - Increase code testing coverage for SolidFire backend module."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dada55a8_6e905596","line":7,"updated":"2016-07-25 10:15:52.000000000","message":"whitespace","commit_id":"28524ae9de2b5d7206dfb5f35d0c8eb4c0510a53"},{"author":{"_account_id":10221,"name":"Edward Balduf","email":"ed.balduf@solidfire.com","username":"ebalduf"},"change_message_id":"ef5ac82829a0b670cdb9c5dc5451f8f8115e253d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - Fixes `bug 1605368"},{"line_number":6,"context_line":"    \u003chttps://bugs.launchpad.net/puppet-cinder/+bug/1605368\u003e`__"},{"line_number":7,"context_line":"    such that the parameter sf_svip is not include when not set. "},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - Increase code testing coverage for SolidFire backend module."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dada55a8_8d4dc574","line":7,"in_reply_to":"dada55a8_6e905596","updated":"2016-07-25 14:11:41.000000000","message":"Done","commit_id":"28524ae9de2b5d7206dfb5f35d0c8eb4c0510a53"}]}