)]}'
{"manifests/backend/emc_vnx.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c7ab5c4fbba1e81697875efeaa149d2499e45448","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   Defaults to: $name"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"# [*iscsi_ip_address*]"},{"line_number":14,"context_line":"#   The IP address that the iSCSI daemon is listening on"},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# [*san_ip*]"},{"line_number":17,"context_line":"#   (required) IP address of SAN controller."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa6399be_5ebb730e","line":14,"updated":"2016-10-18 15:32:51.000000000","message":"please switch this to (optional)","commit_id":"f05347641ef8ded5217313a372941efee3851225"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c7ab5c4fbba1e81697875efeaa149d2499e45448","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  include ::cinder::params"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  if $volume_driver \u003d\u003d \u0027cinder.volume.drivers.emc.emc_cli_iscsi.EMCCLIISCSIDriver\u0027 and"},{"line_number":98,"context_line":"    $iscsi_ip_address \u003d\u003d $::os_service_default {"},{"line_number":99,"context_line":"    fail(\u0027iscsi_ip_address needs to be set when using the cinder.volume.drivers.emc.emc_cli_iscsi.EMCCLIISCSIDriver volume_driver\u0027)"},{"line_number":100,"context_line":"  }"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa6399be_7e3677b5","line":98,"updated":"2016-10-18 15:32:51.000000000","message":"We have a helper function that can do this, you can just use is_service_default($iscsi_ip_address)","commit_id":"f05347641ef8ded5217313a372941efee3851225"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"397b7e2d22db63a517f620f4f7987d8f39f3f794","unresolved":false,"context_lines":[{"line_number":69,"context_line":"#   with volume_backend_name\u003d$volume_backend_name key/value."},{"line_number":70,"context_line":"#   Defaults to false."},{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"# [*iscsi_ip_address*]"},{"line_number":73,"context_line":"#   (optional) DEPRECATED The IP address that the iSCSI daemon is listening on"},{"line_number":74,"context_line":"#"},{"line_number":75,"context_line":"define cinder::backend::emc_vnx ("},{"line_number":76,"context_line":"  $san_ip,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da6895a0_95a0a192","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":78},"updated":"2016-10-21 12:48:40.000000000","message":"since you wan\u0027t to deprecate the parameter ou should not just move to be the last parameter, \n\n# \u003d\u003d Deprecated Parameters\n#\n# [*iscsi_ip_address*]\n#   (optional) DEPRECATED. \u003cinformation\u003e\n#   Defaults to undef\n#","commit_id":"8a96b6c507e57376f1f20c2c859a77dcfa9a34e1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"397b7e2d22db63a517f620f4f7987d8f39f3f794","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  $storage_vnx_security_file_dir \u003d $::os_service_default,"},{"line_number":89,"context_line":"  $naviseccli_path               \u003d $::os_service_default,"},{"line_number":90,"context_line":"  $manage_volume_type            \u003d false,"},{"line_number":91,"context_line":"  $iscsi_ip_address              \u003d undef,"},{"line_number":92,"context_line":") {"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  include ::cinder::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da6895a0_d5c13930","line":91,"range":{"start_line":91,"start_character":2,"end_line":91,"end_character":41},"updated":"2016-10-21 12:48:40.000000000","message":"Please add one line above this line with \n\n# Deprecated","commit_id":"8a96b6c507e57376f1f20c2c859a77dcfa9a34e1"}],"manifests/volume/emc_vnx.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"397b7e2d22db63a517f620f4f7987d8f39f3f794","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   Defaults to $::os_service_default"},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"class cinder::volume::emc_vnx("},{"line_number":65,"context_line":"  $iscsi_ip_address,"},{"line_number":66,"context_line":"  $san_ip,"},{"line_number":67,"context_line":"  $san_password,"},{"line_number":68,"context_line":"  $storage_vnx_pool_name,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da6895a0_75d14dfb","line":65,"range":{"start_line":65,"start_character":2,"end_line":65,"end_character":19},"updated":"2016-10-21 12:48:40.000000000","message":"you need to deprecated here too like in manifests/backend/emc_vnx.pp","commit_id":"8a96b6c507e57376f1f20c2c859a77dcfa9a34e1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4533c39db1ddea63e0b9c5b82f70bdb5c3b62d59","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   Defaults to $::os_service_default"},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"class cinder::volume::emc_vnx("},{"line_number":65,"context_line":"  $iscsi_ip_address,"},{"line_number":66,"context_line":"  $san_ip,"},{"line_number":67,"context_line":"  $san_password,"},{"line_number":68,"context_line":"  $storage_vnx_pool_name,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da6895a0_f8db9119","line":65,"range":{"start_line":65,"start_character":2,"end_line":65,"end_character":19},"in_reply_to":"da6895a0_75d14dfb","updated":"2016-10-21 13:40:04.000000000","message":"You can ignore this :D","commit_id":"8a96b6c507e57376f1f20c2c859a77dcfa9a34e1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4842faeea736b45ed93ae4d5c13ea47ced6ae5da","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  cinder::backend::emc_vnx { \u0027DEFAULT\u0027:"},{"line_number":87,"context_line":"    default_timeout               \u003d\u003e $default_timeout,"},{"line_number":88,"context_line":"    iscsi_ip_address              \u003d\u003e $iscsi_ip_address,"},{"line_number":89,"context_line":"    max_luns_per_storage_group    \u003d\u003e $max_luns_per_storage_group,"},{"line_number":90,"context_line":"    package_ensure                \u003d\u003e $package_ensure,"},{"line_number":91,"context_line":"    san_ip                        \u003d\u003e $san_ip,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"da6895a0_5b1d5772","side":"PARENT","line":88,"updated":"2016-10-21 14:21:29.000000000","message":"Leave this as it\u0027ll catch the backend deprecation notice.","commit_id":"b78e8eb173705c496fd5132f8d906a65c74845e4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4842faeea736b45ed93ae4d5c13ea47ced6ae5da","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   Defaults to $::os_service_default"},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"class cinder::volume::emc_vnx("},{"line_number":65,"context_line":"  $iscsi_ip_address,"},{"line_number":66,"context_line":"  $san_ip,"},{"line_number":67,"context_line":"  $san_password,"},{"line_number":68,"context_line":"  $storage_vnx_pool_name,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"da6895a0_3b18a384","line":65,"updated":"2016-10-21 14:21:29.000000000","message":"Just set this to undef","commit_id":"594c2b174939ff5f960d5bc5ab5e82db15cff4e9"}],"spec/defines/cinder_backend_emc_vnx_spec.rb":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"455392f8ce9a7fcf77132b8a6b5fd50b2af370ba","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  describe \u0027emc vnx volume driver with only required parameters\u0027 do"},{"line_number":25,"context_line":"    before :each do"},{"line_number":26,"context_line":"      params.merge!({"},{"line_number":27,"context_line":"        :iscsi_ip_address      \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027"},{"line_number":28,"context_line":"      })"},{"line_number":29,"context_line":"    end"},{"line_number":30,"context_line":"    it \u0027configure with required/default parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa6399be_a2f8f7c5","line":27,"updated":"2016-10-18 13:13:17.000000000","message":"please make one more test where cinder.volume.drivers.emc.emc_cli_iscsi.EMCCLIISCSIDriver is set and iscsi_ip_address is set to some ip address\nthanks","commit_id":"f05347641ef8ded5217313a372941efee3851225"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"12923aead6e06511e903814c82b702adc7c1a3ca","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      :san_ip                \u003d\u003e \u0027127.0.0.2\u0027,"},{"line_number":9,"context_line":"      :san_login             \u003d\u003e \u0027emc\u0027,"},{"line_number":10,"context_line":"      :san_password          \u003d\u003e \u0027password\u0027,"},{"line_number":11,"context_line":"      :iscsi_ip_address      \u003d\u003e \u0027127.0.0.3\u0027,"},{"line_number":12,"context_line":"      :storage_vnx_pool_name \u003d\u003e \u0027emc-storage-pool\u0027"},{"line_number":13,"context_line":"    }"},{"line_number":14,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa6399be_eb062084","line":11,"range":{"start_line":11,"start_character":7,"end_line":11,"end_character":23},"updated":"2016-10-19 11:30:27.000000000","message":"This can be removed or set to SERVICE DEFAULT probably, as it\u0027s not required anymore","commit_id":"1dd693c735b0c6f3ba76f4d9211a78e4430e0f45"}]}