)]}'
{"manifests/backend/hpelefthand_iscsi.pp":[{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"2c4210a6326a1ec7f22c7529f09b36b62150fe80","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  $hpelefthand_username,"},{"line_number":41,"context_line":"  $hpelefthand_password,"},{"line_number":42,"context_line":"  $hpelefthand_clustername,"},{"line_number":43,"context_line":"  $volume_backend_name           \u003d $name,"},{"line_number":44,"context_line":"  $volume_driver                 \u003d \u0027cinder.volume.drivers.hpe.hpe_lefthand_iscsi.HPELeftHandISCSIDriver\u0027,"},{"line_number":45,"context_line":"  $hpelefthand_iscsi_chap_enabled \u003d false,"},{"line_number":46,"context_line":"  $hpelefthand_debug              \u003d false,"},{"line_number":47,"context_line":"  $extra_options                 \u003d {},"},{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  include ::cinder::deps"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a77a97e_9bc3feec","line":47,"range":{"start_line":43,"start_character":2,"end_line":47,"end_character":38},"updated":"2016-11-17 12:40:21.000000000","message":"alignment is better :)","commit_id":"333ff72cf1f070938b7bfaaed09e33daf4d4a563"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"2c4210a6326a1ec7f22c7529f09b36b62150fe80","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  include ::cinder::deps"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  cinder_config {"},{"line_number":53,"context_line":"    \"${name}/volume_backend_name\":           value \u003d\u003e $volume_backend_name;"},{"line_number":54,"context_line":"    \"${name}/volume_driver\":                 value \u003d\u003e $volume_driver;"},{"line_number":55,"context_line":"    \"${name}/hpelefthand_username\":           value \u003d\u003e $hpelefthand_username;"},{"line_number":56,"context_line":"    \"${name}/hpelefthand_password\":           value \u003d\u003e $hpelefthand_password, secret \u003d\u003e true;"},{"line_number":57,"context_line":"    \"${name}/hpelefthand_clustername\":        value \u003d\u003e $hpelefthand_clustername;"},{"line_number":58,"context_line":"    \"${name}/hpelefthand_api_url\":            value \u003d\u003e $hpelefthand_api_url;"},{"line_number":59,"context_line":"    \"${name}/hpelefthand_iscsi_chap_enabled\": value \u003d\u003e $hpelefthand_iscsi_chap_enabled;"},{"line_number":60,"context_line":"    \"${name}/hpelefthand_debug\":              value \u003d\u003e $hpelefthand_debug;"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  create_resources(\u0027cinder_config\u0027, $extra_options)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a77a97e_dbb9f67a","line":61,"range":{"start_line":53,"start_character":5,"end_line":61,"end_character":3},"updated":"2016-11-17 12:40:21.000000000","message":"same","commit_id":"333ff72cf1f070938b7bfaaed09e33daf4d4a563"}],"manifests/backend/hplefthand_iscsi.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a732605fd0b5d493553122c83c57c08308a090c0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  $hplefthand_username,"},{"line_number":41,"context_line":"  $hplefthand_password,"},{"line_number":42,"context_line":"  $hplefthand_clustername,"},{"line_number":43,"context_line":"  $volume_backend_name \u003d $name,"},{"line_number":44,"context_line":"  $volume_driver \u003d \u0027cinder.volume.drivers.san.hp.hp_lefthand_iscsi.HPLeftHandISCSIDriver\u0027,"},{"line_number":45,"context_line":"  $hplefthand_iscsi_chap_enabled \u003d false,"},{"line_number":46,"context_line":"  $hplefthand_debug \u003d false,"},{"line_number":47,"context_line":"  $extra_options \u003d {},"},{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  cinder_config {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a77a97e_8d44b21b","line":47,"range":{"start_line":43,"start_character":0,"end_line":47,"end_character":22},"updated":"2016-11-17 05:51:48.000000000","message":"please adjust the \u003d, we try and keep them lined up.  For example, https://github.com/openstack/puppet-cinder/blob/master/manifests/backend/hpe3par_iscsi.pp#L77-L84","commit_id":"a87c16761e00e809b58adacce317584e85908329"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a732605fd0b5d493553122c83c57c08308a090c0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  $hplefthand_debug \u003d false,"},{"line_number":47,"context_line":"  $extra_options \u003d {},"},{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  cinder_config {"},{"line_number":51,"context_line":"    \"${name}/volume_backend_name\":           value \u003d\u003e $volume_backend_name;"},{"line_number":52,"context_line":"    \"${name}/volume_driver\":                 value \u003d\u003e $volume_driver;"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a77a97e_cdc30a88","line":49,"updated":"2016-11-17 05:51:48.000000000","message":"You should include ::cinder::deps in here.","commit_id":"a87c16761e00e809b58adacce317584e85908329"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"28e9747e70d8e83ad60dc806daedb8f607f3677b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  create_resources(\u0027cinder_config\u0027, $extra_options)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7a77a97e_298c637e","line":64,"updated":"2016-11-17 11:54:54.000000000","message":"can you change to match the parameters in http://docs.openstack.org/newton/config-reference/block-storage/drivers/hpe-lefthand-driver.html?\n\nvolume driver is wrong, parameters should be hpelefthand and not hplefthand","commit_id":"ec43d8edc4910c7c0119da4720b0850d57c38e85"}],"manifests/volume/hplefthand_iscsi.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a732605fd0b5d493553122c83c57c08308a090c0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#   Example :"},{"line_number":46,"context_line":"#     { \u0027hplefthand_iscsi_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }"},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"class cinder::volume::hplefthand_iscsi("},{"line_number":49,"context_line":"  $hplefthand_api_url,"},{"line_number":50,"context_line":"  $hplefthand_username,"},{"line_number":51,"context_line":"  $hplefthand_password,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a77a97e_4dd7fa4a","line":48,"updated":"2016-11-17 05:51:48.000000000","message":"we\u0027re trying to deprecate the cinder::volume::* classes. Lets skip adding this.","commit_id":"a87c16761e00e809b58adacce317584e85908329"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"875ddcaa45ade5914e1f7b18edc0600e02231484","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  warning(\u0027Usage of cinder::volume::hplefthand_iscsi is deprecated, please use"},{"line_number":50,"context_line":"cinder::backend::hplefthand_iscsi instead.\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  cinder::backend::hplefthand_iscsi { \u0027DEFAULT\u0027:"},{"line_number":53,"context_line":"    volume_driver                 \u003d\u003e $volume_driver,"},{"line_number":54,"context_line":"    hplefthand_username           \u003d\u003e $hplefthand_username,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a77a97e_544f7e6a","line":51,"updated":"2016-11-17 09:31:40.000000000","message":"as Alex said, we are deprecating volume classes, it means it should be removed from the commit, we cannot deprecate something that wasn\u0027t added yet, so is it possible just remove this class from the commit?","commit_id":"9662c0fd8a9440100116c4b97a3da4d110250432"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a79ed2d4e994c4fbc6e463536b9953be8fecde07","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  warning(\u0027Usage of cinder::volume::hplefthand_iscsi is deprecated, please use"},{"line_number":50,"context_line":"cinder::backend::hplefthand_iscsi instead.\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  cinder::backend::hplefthand_iscsi { \u0027DEFAULT\u0027:"},{"line_number":53,"context_line":"    volume_driver                 \u003d\u003e $volume_driver,"},{"line_number":54,"context_line":"    hplefthand_username           \u003d\u003e $hplefthand_username,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a77a97e_03578626","line":51,"in_reply_to":"7a77a97e_544f7e6a","updated":"2016-11-17 11:33:55.000000000","message":"Yeah, you can just remove this class and the tests related to this one.","commit_id":"9662c0fd8a9440100116c4b97a3da4d110250432"}],"spec/defines/cinder_backend_hplefthand_iscsi_spec.rb":[{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"cc441674e425fbb2e852f3263450273b90745c66","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      :hplefthand_api_url            \u003d\u003e \u0027https://10.206.219.18:8081/lhos\u0027,"},{"line_number":9,"context_line":"      :hplefthand_username           \u003d\u003e \u0027admin\u0027,"},{"line_number":10,"context_line":"      :hplefthand_password           \u003d\u003e \u0027password\u0027,"},{"line_number":11,"context_line":"      :hplefthand_clustername        \u003d\u003e \u0027nfvsys_clust_001\u0027,"},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"  end"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"7a77a97e_c3faee74","line":11,"range":{"start_line":11,"start_character":29,"end_line":11,"end_character":36},"updated":"2016-11-17 11:25:55.000000000","message":"extra spaces, should be remove","commit_id":"9662c0fd8a9440100116c4b97a3da4d110250432"}]}