)]}'
{"manifests/backend/scaleio.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c284e605cc454db6f2b040373dae6375c86a66a2","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  $sio_storage_pool_name,"},{"line_number":101,"context_line":"  $sio_storage_pools,"},{"line_number":102,"context_line":"  $volume_backend_name              \u003d $name,"},{"line_number":103,"context_line":"  $sio_server_port                  \u003d \u0027443\u0027,"},{"line_number":104,"context_line":"  $sio_verify_server_certificate    \u003d false,"},{"line_number":105,"context_line":"  $sio_server_certificate_path      \u003d \u0027\u0027,"},{"line_number":106,"context_line":"  $sio_round_volume_capacity        \u003d true,"},{"line_number":107,"context_line":"  $sio_unmap_volume_before_deletion \u003d false,"},{"line_number":108,"context_line":"  $sio_max_over_subscription_ratio  \u003d \u0027\u0027,"},{"line_number":109,"context_line":"  $sio_thin_provision               \u003d false,"},{"line_number":110,"context_line":"  $manage_volume_type               \u003d false,"},{"line_number":111,"context_line":"  $extra_options                    \u003d {},"},{"line_number":112,"context_line":") {"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  cinder_config {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a6eadb0_b69ad4c3","line":111,"range":{"start_line":103,"start_character":0,"end_line":111,"end_character":41},"updated":"2016-12-20 09:24:01.000000000","message":"i think all parameters, which are using default values should be converted to $::os_service_default value. In this case, you don\u0027t need additional checks like in lines 130,136.","commit_id":"d69d8607609fd04edc97b692cb829cfa00592f4a"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"ec147d496317bd182fcddbbb64ba8c1c4a99bd24","unresolved":false,"context_lines":[{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*sio_thin_provision*]"},{"line_number":61,"context_line":"#   (optional) (Boolean) Wheater to use thin provisioning or not."},{"line_number":62,"context_line":"#   Defaults to false."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*manage_volume_type*]"},{"line_number":65,"context_line":"#   (Optional) Whether or not manage Cinder Volume type."}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a6eadb0_c7915c48","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":21},"updated":"2016-12-20 10:18:39.000000000","message":"all doc values also should be updated","commit_id":"e5fa8efcd7f6ed1f71d15537a65a43d2b0234b91"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"37c2cc9f0a58172783241f5032d9d6e545cb9f30","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  $sio_unmap_volume_before_deletion \u003d $::os_service_default,"},{"line_number":108,"context_line":"  $sio_max_over_subscription_ratio  \u003d $::os_service_default,"},{"line_number":109,"context_line":"  $sio_thin_provision               \u003d $::os_service_default,"},{"line_number":110,"context_line":"  $manage_volume_type               \u003d $::os_service_default,"},{"line_number":111,"context_line":"  $extra_options                    \u003d {},"},{"line_number":112,"context_line":") {"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a6eadb0_e781f8fc","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":60},"updated":"2016-12-20 10:17:52.000000000","message":"this parameter was an exception, please make it boolean again :)","commit_id":"e5fa8efcd7f6ed1f71d15537a65a43d2b0234b91"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"37c2cc9f0a58172783241f5032d9d6e545cb9f30","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    \"${name}/san_ip\":                           value \u003d\u003e $sio_server_hostname;"},{"line_number":120,"context_line":"    \"${name}/sio_rest_server_port\":             value \u003d\u003e $sio_server_port;"},{"line_number":121,"context_line":"    \"${name}/sio_verify_server_certificate\":    value \u003d\u003e $sio_verify_server_certificate;"},{"line_number":122,"context_line":"    \"${name}/sio_server_certificate_path\":      value \u003d\u003e $sio_server_certificate_path;    "},{"line_number":123,"context_line":"    \"${name}/sio_protection_domain_name\":       value \u003d\u003e $sio_protection_domain_name;"},{"line_number":124,"context_line":"    \"${name}/sio_storage_pool_name\":            value \u003d\u003e $sio_storage_pool_name;"},{"line_number":125,"context_line":"    \"${name}/sio_storage_pools\":                value \u003d\u003e $sio_storage_pools;"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a6eadb0_87712447","line":122,"updated":"2016-12-20 10:17:52.000000000","message":"empty space","commit_id":"e5fa8efcd7f6ed1f71d15537a65a43d2b0234b91"}]}