)]}'
{"manifests/backend/dellsc_iscsi.pp":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"42b8ef04915b9f615743c7cce99ab66185f5d2d1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  $secondary_san_ip       \u003d $::os_service_default,"},{"line_number":87,"context_line":"  $secondary_san_login    \u003d $::os_service_default,"},{"line_number":88,"context_line":"  $secondary_san_password \u003d $::os_service_default,"},{"line_number":89,"context_line":"  $secondary_sc_api_port  \u003d 3033,  "},{"line_number":90,"context_line":"  $manage_volume_type     \u003d false,"},{"line_number":91,"context_line":"  $extra_options          \u003d {},"},{"line_number":92,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bff0334d_cf198d7a","line":89,"range":{"start_line":89,"start_character":28,"end_line":89,"end_character":33},"updated":"2017-04-10 16:39:17.000000000","message":"Is this be hardwired 3033 port or is it programmable?\n Always leery of hardwiring port #.\n\nMaybe have this programmable and 3033 as default?","commit_id":"c9205bef8f83b5be92479331ceb192d30f170c20"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"f2fd9ec0994e58ed1ac43e678a68361c7d6964f1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  $secondary_san_ip       \u003d $::os_service_default,"},{"line_number":87,"context_line":"  $secondary_san_login    \u003d $::os_service_default,"},{"line_number":88,"context_line":"  $secondary_san_password \u003d $::os_service_default,"},{"line_number":89,"context_line":"  $secondary_sc_api_port  \u003d 3033,  "},{"line_number":90,"context_line":"  $manage_volume_type     \u003d false,"},{"line_number":91,"context_line":"  $extra_options          \u003d {},"},{"line_number":92,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bff0334d_8fa265ad","line":89,"range":{"start_line":89,"start_character":28,"end_line":89,"end_character":33},"in_reply_to":"bff0334d_cf198d7a","updated":"2017-04-10 16:50:11.000000000","message":"Will fix","commit_id":"c9205bef8f83b5be92479331ceb192d30f170c20"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"f31e806f16296d522bf0b046ed026482a09646e0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  $dell_sc_verify_cert    \u003d $::os_service_default,"},{"line_number":87,"context_line":"  $dell_sc_volume_folder  \u003d \u0027vol\u0027,"},{"line_number":88,"context_line":"  $iscsi_port             \u003d $::os_service_default,"},{"line_number":89,"context_line":"  $excluded_domain_ip    \u003d $::os_service_default,"},{"line_number":90,"context_line":"  $secondary_san_ip       \u003d $::os_service_default,"},{"line_number":91,"context_line":"  $secondary_san_login    \u003d $::os_service_default,"},{"line_number":92,"context_line":"  $secondary_san_password \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bff0334d_a90cd393","line":89,"range":{"start_line":89,"start_character":23,"end_line":89,"end_character":25},"updated":"2017-04-12 00:51:02.000000000","message":"less a space.","commit_id":"59e2fc9e45c838a918e9d9c2aaaed5d5264e0890"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"f31e806f16296d522bf0b046ed026482a09646e0","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    \"${name}/dell_sc_verify_cert\":    value \u003d\u003e $dell_sc_verify_cert;"},{"line_number":122,"context_line":"    \"${name}/dell_sc_volume_folder\":  value \u003d\u003e $dell_sc_volume_folder;"},{"line_number":123,"context_line":"    \"${name}/iscsi_port\":             value \u003d\u003e $iscsi_port;"},{"line_number":124,"context_line":"    \"${name}/excluded_domain_ip\":    value \u003d\u003e $excluded_domain_ip;"},{"line_number":125,"context_line":"    \"${name}/secondary_san_ip\":       value \u003d\u003e $secondary_san_ip;"},{"line_number":126,"context_line":"    \"${name}/secondary_san_login\":    value \u003d\u003e $secondary_san_login;"},{"line_number":127,"context_line":"    \"${name}/secondary_san_password\": value \u003d\u003e $secondary_san_password;"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bff0334d_692a4bdb","line":124,"range":{"start_line":124,"start_character":35,"end_line":124,"end_character":37},"updated":"2017-04-12 00:51:02.000000000","message":"same","commit_id":"59e2fc9e45c838a918e9d9c2aaaed5d5264e0890"}],"manifests/volume/dellsc_iscsi.pp":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"42b8ef04915b9f615743c7cce99ab66185f5d2d1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $secondary_san_ip       \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $secondary_san_login    \u003d $::os_service_default,"},{"line_number":77,"context_line":"  $secondary_san_password \u003d $::os_service_default,"},{"line_number":78,"context_line":"  $secondary_sc_api_port  \u003d 3033,"},{"line_number":79,"context_line":"  $extra_options         \u003d {},"},{"line_number":80,"context_line":") {"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bff0334d_0f6bf5b6","line":78,"range":{"start_line":78,"start_character":1,"end_line":78,"end_character":33},"updated":"2017-04-10 16:39:17.000000000","message":"good for default.","commit_id":"c9205bef8f83b5be92479331ceb192d30f170c20"}],"spec/classes/cinder_volume_dellsc_iscsi_spec.rb":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"33186916c3cbb38f6d5b0e165f18c85e5cff2ca9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      :secondary_san_ip       \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":23,"context_line":"      :secondary_san_login    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":24,"context_line":"      :secondary_san_password \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":25,"context_line":"      :secondary_sc_api_port  \u003d\u003e \u00273033\u0027,"},{"line_number":26,"context_line":"  }"},{"line_number":27,"context_line":"  end"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"bff0334d_cff06d94","line":25,"range":{"start_line":25,"start_character":30,"end_line":25,"end_character":40},"updated":"2017-04-10 16:55:55.000000000","message":"Should 3033 be replaced by Service default?","commit_id":"a08895e918dcb66c5cd2876a0555d2d11ab2c2f8"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"1414759936cb55f9c584f8e8452d39cb88b47408","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      :secondary_san_ip       \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":23,"context_line":"      :secondary_san_login    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":24,"context_line":"      :secondary_san_password \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":25,"context_line":"      :secondary_sc_api_port  \u003d\u003e \u00273033\u0027,"},{"line_number":26,"context_line":"  }"},{"line_number":27,"context_line":"  end"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"bff0334d_db6a6b7f","line":25,"range":{"start_line":25,"start_character":30,"end_line":25,"end_character":40},"in_reply_to":"bff0334d_cff06d94","updated":"2017-04-10 18:45:55.000000000","message":"Done","commit_id":"a08895e918dcb66c5cd2876a0555d2d11ab2c2f8"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"f31e806f16296d522bf0b046ed026482a09646e0","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  let :default_params do"},{"line_number":16,"context_line":"  {"},{"line_number":17,"context_line":"      :dell_sc_api_port      \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":18,"context_line":"      :dell_sc_server_folder \u003d\u003e \u0027srv\u0027,"},{"line_number":19,"context_line":"      :dell_sc_verify_cert   \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":20,"context_line":"      :dell_sc_volume_folder \u003d\u003e \u0027vol\u0027,"},{"line_number":21,"context_line":"      :iscsi_port            \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":22,"context_line":"      :excluded_domain_ip    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":23,"context_line":"      :secondary_san_ip       \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":24,"context_line":"      :secondary_san_login    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":25,"context_line":"      :secondary_san_password \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":26,"context_line":"      :secondary_sc_api_port  \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":27,"context_line":"  }"},{"line_number":28,"context_line":"  end"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":7,"id":"bff0334d_a98173c5","line":26,"range":{"start_line":17,"start_character":6,"end_line":26,"end_character":53},"updated":"2017-04-12 00:51:02.000000000","message":"Should be aligned ：）","commit_id":"59e2fc9e45c838a918e9d9c2aaaed5d5264e0890"}],"spec/defines/cinder_backend_dellsc_iscsi_spec.rb":[{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"f31e806f16296d522bf0b046ed026482a09646e0","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  let :default_params do"},{"line_number":20,"context_line":"    {"},{"line_number":21,"context_line":"      :dell_sc_api_port      \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":22,"context_line":"      :dell_sc_server_folder \u003d\u003e \u0027srv\u0027,"},{"line_number":23,"context_line":"      :dell_sc_verify_cert   \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":24,"context_line":"      :dell_sc_volume_folder \u003d\u003e \u0027vol\u0027,"},{"line_number":25,"context_line":"      :iscsi_port            \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":26,"context_line":"      :excluded_domain_ip    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":27,"context_line":"      :secondary_san_ip       \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":28,"context_line":"      :secondary_san_login    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":29,"context_line":"      :secondary_san_password \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":30,"context_line":"      :secondary_sc_api_port  \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":7,"id":"bff0334d_696feb2a","line":30,"range":{"start_line":21,"start_character":6,"end_line":30,"end_character":52},"updated":"2017-04-12 00:51:02.000000000","message":"should be aligned :)","commit_id":"59e2fc9e45c838a918e9d9c2aaaed5d5264e0890"}]}
