)]}'
{"manifests/backend/vstorage.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"851d7ace597fc72aff2ce956df65f9abc34ea226","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  ensure_resources(\u0027file\u0027, {"},{"line_number":113,"context_line":"      \"/var/log/vstorage\" \u003d\u003e {},"},{"line_number":114,"context_line":"      \"/var/log/vstorage/${cluster_name}\" \u003d\u003e {}"},{"line_number":115,"context_line":"    }, { ensure  \u003d\u003e \u0027directory\u0027 })"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7ffa3b31_2da11247","line":115,"updated":"2017-04-20 16:31:41.000000000","message":"Is there a reason why we no longer need to ensure this directory prior to the start of the service?  If not, i think we should leave the require/notify","commit_id":"324e515626f31ab6ffff84568cc7ace3d12dd3e4"},{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"d62ac920afc8a3ee41cd75f56b9a0769807db484","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  ensure_resources(\u0027file\u0027, {"},{"line_number":113,"context_line":"      \"/var/log/vstorage\" \u003d\u003e {},"},{"line_number":114,"context_line":"      \"/var/log/vstorage/${cluster_name}\" \u003d\u003e {}"},{"line_number":115,"context_line":"    }, { ensure  \u003d\u003e \u0027directory\u0027 })"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7ffa3b31_e8c31888","line":115,"in_reply_to":"7ffa3b31_2da11247","updated":"2017-04-20 16:42:26.000000000","message":"This directory is already in place when vstorage rpm is installed. It\u0027s just a double check. And this directory should exist before very first Cinder volume is created using vstorage backend. So it\u0027s safe to drop require and notify.","commit_id":"324e515626f31ab6ffff84568cc7ace3d12dd3e4"},{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"9b741d88703617f1a563300e6e07797307b4039a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  ensure_resources(\u0027file\u0027, {"},{"line_number":113,"context_line":"      \"/var/log/vstorage\" \u003d\u003e {},"},{"line_number":114,"context_line":"      \"/var/log/vstorage/${cluster_name}\" \u003d\u003e {}"},{"line_number":115,"context_line":"    }, { ensure  \u003d\u003e \u0027directory\u0027 })"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7ffa3b31_839c75c0","line":115,"in_reply_to":"7ffa3b31_68a708bf","updated":"2017-04-20 17:04:03.000000000","message":"This makes sense. But if I do so I got resource conflict when ensuring log dir exists when configuring vstorage for Glance in packstack. And this template is included in packstack as well.\nSeems like puppet doesn\u0027t allow multiple ensure_resources with the same title and different hashes. I.e.\n\nensure_resource(\u0027file\u0027, \u0027/var/log\u0027, {ensure \u003d\u003e \u0027directory\u0027})\nensure_resource(\u0027file\u0027, \u0027/var/log\u0027, {ensure \u003d\u003e \u0027directory\u0027, mode \u003d\u003e \u00270777\u0027})\n\nDo you know how to deal with such conflicts in puppet?","commit_id":"324e515626f31ab6ffff84568cc7ace3d12dd3e4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1f1a31548bf247d12a2e7346d7b5cf2cffebf91a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  ensure_resources(\u0027file\u0027, {"},{"line_number":113,"context_line":"      \"/var/log/vstorage\" \u003d\u003e {},"},{"line_number":114,"context_line":"      \"/var/log/vstorage/${cluster_name}\" \u003d\u003e {}"},{"line_number":115,"context_line":"    }, { ensure  \u003d\u003e \u0027directory\u0027 })"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7ffa3b31_e3a0d992","line":115,"in_reply_to":"7ffa3b31_839c75c0","updated":"2017-04-20 17:17:31.000000000","message":"Yea so this is kinda why we shouldn\u0027t be defining these in  puppet and letting packaging deliver it. Unfortunately for puppet it\u0027s all about parse ordering. So you may want to patch packstack to remove the requirement if it\u0027s being added here or not add it here. It seems like if we\u0027re going to add it here, packstack should have it removed and you can use depends-on: this patch","commit_id":"324e515626f31ab6ffff84568cc7ace3d12dd3e4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2ba9117b642eff4ae0faefd29b2b915f595d393a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  ensure_resources(\u0027file\u0027, {"},{"line_number":113,"context_line":"      \"/var/log/vstorage\" \u003d\u003e {},"},{"line_number":114,"context_line":"      \"/var/log/vstorage/${cluster_name}\" \u003d\u003e {}"},{"line_number":115,"context_line":"    }, { ensure  \u003d\u003e \u0027directory\u0027 })"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7ffa3b31_68a708bf","line":115,"in_reply_to":"7ffa3b31_e8c31888","updated":"2017-04-20 16:46:44.000000000","message":"In order to properly check after the rpm is installed, we should at least keep the require \u003d\u003e Anchor[\u0027cinder::install::end\u0027]","commit_id":"324e515626f31ab6ffff84568cc7ace3d12dd3e4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5f94788d4cc99d3ece7a8d60d2d4b68ffe779382","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  $mount_user            \u003d \u0027cinder\u0027,"},{"line_number":70,"context_line":"  $mount_group           \u003d \u0027root\u0027,"},{"line_number":71,"context_line":"  $mount_permissions     \u003d \u00270770\u0027,"},{"line_number":72,"context_line":"  $manage_package        \u003d false,"},{"line_number":73,"context_line":") {"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  include ::cinder::deps"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7ffa3b31_20be9eb3","line":72,"updated":"2017-04-21 11:47:34.000000000","message":"because you set false by default, the pacakge won\u0027t be deployed by default like before, so this patch is not backward compatible for our users.","commit_id":"90d326ff466cdcb05512c04ccd3c8393caa44594"}]}