)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"52e4d90c2e90d7f23ddfad2c80100e336c03fc7e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     abhishek.kane \u003cabhishek.kane@veritas.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-20 20:05:38 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements:"},{"line_number":8,"context_line":"Cinder component of the veritas-hyperscale-tripleo-template BP."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Add a new backend puppet module that changes following in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_8419d089","line":7,"updated":"2017-06-20 15:33:38.000000000","message":"commit message is still not valid.\n\nLet\u0027s try this:\n\nAdd support for Veritas hyperscale backend\n\nAdding support to deploy Veritas backend in Cinder.","commit_id":"6d1d508ad6e3ea9df3aa6f1bb97efc08570b234c"}],"manifests/backend/veritas_hyperscale.pp":[{"author":{"_account_id":24286,"name":"Dnyaneshwar","email":"dnyaneshwar.pawar@veritas.com","username":"DnyaneshwarPawar"},"change_message_id":"91696fba3647df5fa34d80321bc98a2ab7c6d048","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f231b9d_3ad8c07d","updated":"2017-06-20 12:57:06.000000000","message":"tab spaces are replaced by double quote. please remove.","commit_id":"bc804c2c6e6f7e62b320973b65af11615a137d99"},{"author":{"_account_id":24290,"name":"Abhishek Kane","email":"abhishek.kane@veritas.com","username":"AbhishekKane"},"change_message_id":"285c1c4acd2bfbba426b2538156b05d8dc6e154c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f201791_fe549556","in_reply_to":"7f231b9d_3ad8c07d","updated":"2017-06-21 12:53:48.000000000","message":"Done.","commit_id":"bc804c2c6e6f7e62b320973b65af11615a137d99"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c621a9b87e28e3f02a3204a90261258dd209ae73","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# Copyright (c) 2017 Veritas Technologies LLC."},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"define cinder::backend::veritas_hyperscale("},{"line_number":29,"context_line":"  $hs_passwd      \u003d $hs_passwd,"},{"line_number":30,"context_line":"  $rabbit_ip      \u003d $rabbit_ip,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_2f88951d","line":27,"updated":"2017-06-20 15:47:47.000000000","message":"please document parameters","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":24290,"name":"Abhishek Kane","email":"abhishek.kane@veritas.com","username":"AbhishekKane"},"change_message_id":"f8fb7c4aa8a36e6bd530633e68b2d28f922a3320","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# Copyright (c) 2017 Veritas Technologies LLC."},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"define cinder::backend::veritas_hyperscale("},{"line_number":29,"context_line":"  $hs_passwd      \u003d $hs_passwd,"},{"line_number":30,"context_line":"  $rabbit_ip      \u003d $rabbit_ip,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_8d52f566","line":27,"in_reply_to":"5f201791_2f88951d","updated":"2017-06-21 12:53:20.000000000","message":"Done","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"17eb7002c3607b2b13b24bab1ce82acf5540b012","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  cinder_config {"},{"line_number":34,"context_line":"    \"Veritas_HyperScale/volume_backend_name\":  value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":35,"context_line":"    \"Veritas_HyperScale/volume_driver\":        value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027,"},{"line_number":36,"context_line":"    \"DEFAULT/enabled_backends\":                value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":37,"context_line":"    \"DEFAULT/volume_name_template\":            value \u003d\u003e \u0027{%s}\u0027,"},{"line_number":38,"context_line":"    \"DEFAULT/transport_url\":                   value \u003d\u003e \"rabbit://hyperscale:$hs_passwd@$rabbit_ip\","},{"line_number":39,"context_line":"    \"DEFAULT/rpc_backend\":                     value \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_2fd535ba","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":77},"updated":"2017-06-20 15:54:05.000000000","message":"https://github.com/openstack/puppet-cinder/blob/ea5075e0945afcdab0e22216ed455e4cc83b150f/manifests/backends.pp#L7","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":24290,"name":"Abhishek Kane","email":"abhishek.kane@veritas.com","username":"AbhishekKane"},"change_message_id":"ef8df222942c643071ba66812fba9674df628870","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  cinder_config {"},{"line_number":34,"context_line":"    \"Veritas_HyperScale/volume_backend_name\":  value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":35,"context_line":"    \"Veritas_HyperScale/volume_driver\":        value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027,"},{"line_number":36,"context_line":"    \"DEFAULT/enabled_backends\":                value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":37,"context_line":"    \"DEFAULT/volume_name_template\":            value \u003d\u003e \u0027{%s}\u0027,"},{"line_number":38,"context_line":"    \"DEFAULT/transport_url\":                   value \u003d\u003e \"rabbit://hyperscale:$hs_passwd@$rabbit_ip\","},{"line_number":39,"context_line":"    \"DEFAULT/rpc_backend\":                     value \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_cae58f3a","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":77},"in_reply_to":"5f201791_2fd535ba","updated":"2017-06-20 16:06:16.000000000","message":"We wanted to append the value there, but couldn\u0027t find a way. Do I need to change parameters to the basic cinder driver?","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":24290,"name":"Abhishek Kane","email":"abhishek.kane@veritas.com","username":"AbhishekKane"},"change_message_id":"f8fb7c4aa8a36e6bd530633e68b2d28f922a3320","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  cinder_config {"},{"line_number":34,"context_line":"    \"Veritas_HyperScale/volume_backend_name\":  value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":35,"context_line":"    \"Veritas_HyperScale/volume_driver\":        value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027,"},{"line_number":36,"context_line":"    \"DEFAULT/enabled_backends\":                value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":37,"context_line":"    \"DEFAULT/volume_name_template\":            value \u003d\u003e \u0027{%s}\u0027,"},{"line_number":38,"context_line":"    \"DEFAULT/transport_url\":                   value \u003d\u003e \"rabbit://hyperscale:$hs_passwd@$rabbit_ip\","},{"line_number":39,"context_line":"    \"DEFAULT/rpc_backend\":                     value \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_6d767909","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":77},"in_reply_to":"5f201791_5eaa6485","updated":"2017-06-21 12:53:20.000000000","message":"Done","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fd15def89bed49bf60937a54996f6a20d0c8b0df","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  cinder_config {"},{"line_number":34,"context_line":"    \"Veritas_HyperScale/volume_backend_name\":  value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":35,"context_line":"    \"Veritas_HyperScale/volume_driver\":        value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027,"},{"line_number":36,"context_line":"    \"DEFAULT/enabled_backends\":                value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":37,"context_line":"    \"DEFAULT/volume_name_template\":            value \u003d\u003e \u0027{%s}\u0027,"},{"line_number":38,"context_line":"    \"DEFAULT/transport_url\":                   value \u003d\u003e \"rabbit://hyperscale:$hs_passwd@$rabbit_ip\","},{"line_number":39,"context_line":"    \"DEFAULT/rpc_backend\":                     value \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_5eaa6485","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":77},"in_reply_to":"5f201791_cae58f3a","updated":"2017-06-20 16:37:08.000000000","message":"That would not be something done by you in puppet-cinder. That would be done in the code that is calling puppet-cinder and the operator would need to provide Veritas_HyperScale as an enabled backend to cinder::backends.","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6208b793b2d5272a52c11bb35c439f66e8c5c901","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  cinder_config {"},{"line_number":34,"context_line":"    \"Veritas_HyperScale/volume_backend_name\":  value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":35,"context_line":"    \"Veritas_HyperScale/volume_driver\":        value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027,"},{"line_number":36,"context_line":"    \"DEFAULT/enabled_backends\":                value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":37,"context_line":"    \"DEFAULT/volume_name_template\":            value \u003d\u003e \u0027{%s}\u0027,"},{"line_number":38,"context_line":"    \"DEFAULT/transport_url\":                   value \u003d\u003e \"rabbit://hyperscale:$hs_passwd@$rabbit_ip\","},{"line_number":39,"context_line":"    \"DEFAULT/rpc_backend\":                     value \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":40,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_afef05af","line":37,"range":{"start_line":36,"start_character":0,"end_line":37,"end_character":35},"updated":"2017-06-20 15:50:17.000000000","message":"these options are already managed by puppet-cinder.","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":24290,"name":"Abhishek Kane","email":"abhishek.kane@veritas.com","username":"AbhishekKane"},"change_message_id":"f8fb7c4aa8a36e6bd530633e68b2d28f922a3320","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  cinder_config {"},{"line_number":34,"context_line":"    \"Veritas_HyperScale/volume_backend_name\":  value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":35,"context_line":"    \"Veritas_HyperScale/volume_driver\":        value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027,"},{"line_number":36,"context_line":"    \"DEFAULT/enabled_backends\":                value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":37,"context_line":"    \"DEFAULT/volume_name_template\":            value \u003d\u003e \u0027{%s}\u0027,"},{"line_number":38,"context_line":"    \"DEFAULT/transport_url\":                   value \u003d\u003e \"rabbit://hyperscale:$hs_passwd@$rabbit_ip\","},{"line_number":39,"context_line":"    \"DEFAULT/rpc_backend\":                     value \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":40,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_ed5ba984","line":37,"range":{"start_line":36,"start_character":0,"end_line":37,"end_character":35},"in_reply_to":"5f201791_afef05af","updated":"2017-06-21 12:53:20.000000000","message":"Done","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6208b793b2d5272a52c11bb35c439f66e8c5c901","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"Veritas_HyperScale/volume_driver\":        value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027,"},{"line_number":36,"context_line":"    \"DEFAULT/enabled_backends\":                value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":37,"context_line":"    \"DEFAULT/volume_name_template\":            value \u003d\u003e \u0027{%s}\u0027,"},{"line_number":38,"context_line":"    \"DEFAULT/transport_url\":                   value \u003d\u003e \"rabbit://hyperscale:$hs_passwd@$rabbit_ip\","},{"line_number":39,"context_line":"    \"DEFAULT/rpc_backend\":                     value \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_8f05697d","line":38,"updated":"2017-06-20 15:50:17.000000000","message":"also, don\u0027t change this option it\u0027s already managed by the module.","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":24290,"name":"Abhishek Kane","email":"abhishek.kane@veritas.com","username":"AbhishekKane"},"change_message_id":"f8fb7c4aa8a36e6bd530633e68b2d28f922a3320","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"Veritas_HyperScale/volume_driver\":        value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027,"},{"line_number":36,"context_line":"    \"DEFAULT/enabled_backends\":                value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":37,"context_line":"    \"DEFAULT/volume_name_template\":            value \u003d\u003e \u0027{%s}\u0027,"},{"line_number":38,"context_line":"    \"DEFAULT/transport_url\":                   value \u003d\u003e \"rabbit://hyperscale:$hs_passwd@$rabbit_ip\","},{"line_number":39,"context_line":"    \"DEFAULT/rpc_backend\":                     value \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_cd60ed35","line":38,"in_reply_to":"5f201791_8f05697d","updated":"2017-06-21 12:53:20.000000000","message":"Done","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"17eb7002c3607b2b13b24bab1ce82acf5540b012","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"Veritas_HyperScale/volume_driver\":        value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027,"},{"line_number":36,"context_line":"    \"DEFAULT/enabled_backends\":                value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":37,"context_line":"    \"DEFAULT/volume_name_template\":            value \u003d\u003e \u0027{%s}\u0027,"},{"line_number":38,"context_line":"    \"DEFAULT/transport_url\":                   value \u003d\u003e \"rabbit://hyperscale:$hs_passwd@$rabbit_ip\","},{"line_number":39,"context_line":"    \"DEFAULT/rpc_backend\":                     value \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # Create cinder volume type"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_6fcb2d1e","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":97},"updated":"2017-06-20 15:54:05.000000000","message":"This is already configured in cinder elsewhere and I\u0027m not sure yould should be hijacking the default transport_url\n\nhttps://github.com/openstack/puppet-cinder/blob/77b1a690100bf18036ca5d663dac8f44e05174b2/manifests/init.pp#L15-L23","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6208b793b2d5272a52c11bb35c439f66e8c5c901","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \"DEFAULT/enabled_backends\":                value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":37,"context_line":"    \"DEFAULT/volume_name_template\":            value \u003d\u003e \u0027{%s}\u0027,"},{"line_number":38,"context_line":"    \"DEFAULT/transport_url\":                   value \u003d\u003e \"rabbit://hyperscale:$hs_passwd@$rabbit_ip\","},{"line_number":39,"context_line":"    \"DEFAULT/rpc_backend\":                     value \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # Create cinder volume type"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_6f0a0d8b","line":39,"updated":"2017-06-20 15:50:17.000000000","message":"ditto","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":24290,"name":"Abhishek Kane","email":"abhishek.kane@veritas.com","username":"AbhishekKane"},"change_message_id":"f8fb7c4aa8a36e6bd530633e68b2d28f922a3320","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"Veritas_HyperScale/volume_driver\":        value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027,"},{"line_number":36,"context_line":"    \"DEFAULT/enabled_backends\":                value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":37,"context_line":"    \"DEFAULT/volume_name_template\":            value \u003d\u003e \u0027{%s}\u0027,"},{"line_number":38,"context_line":"    \"DEFAULT/transport_url\":                   value \u003d\u003e \"rabbit://hyperscale:$hs_passwd@$rabbit_ip\","},{"line_number":39,"context_line":"    \"DEFAULT/rpc_backend\":                     value \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # Create cinder volume type"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_ad55b152","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":97},"in_reply_to":"5f201791_1ecf4c80","updated":"2017-06-21 12:53:20.000000000","message":"Done","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":24290,"name":"Abhishek Kane","email":"abhishek.kane@veritas.com","username":"AbhishekKane"},"change_message_id":"41688f6769a9a08ab21b6ba417957b3baaee5b4a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"Veritas_HyperScale/volume_driver\":        value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027,"},{"line_number":36,"context_line":"    \"DEFAULT/enabled_backends\":                value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":37,"context_line":"    \"DEFAULT/volume_name_template\":            value \u003d\u003e \u0027{%s}\u0027,"},{"line_number":38,"context_line":"    \"DEFAULT/transport_url\":                   value \u003d\u003e \"rabbit://hyperscale:$hs_passwd@$rabbit_ip\","},{"line_number":39,"context_line":"    \"DEFAULT/rpc_backend\":                     value \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # Create cinder volume type"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_8a05577d","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":97},"in_reply_to":"5f201791_6fcb2d1e","updated":"2017-06-20 16:16:28.000000000","message":"I guess by changing these values this won\u0027t be compatible for multiple backends. Is this compatibility a must have?","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fd15def89bed49bf60937a54996f6a20d0c8b0df","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"Veritas_HyperScale/volume_driver\":        value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027,"},{"line_number":36,"context_line":"    \"DEFAULT/enabled_backends\":                value \u003d\u003e \u0027Veritas_HyperScale\u0027,"},{"line_number":37,"context_line":"    \"DEFAULT/volume_name_template\":            value \u003d\u003e \u0027{%s}\u0027,"},{"line_number":38,"context_line":"    \"DEFAULT/transport_url\":                   value \u003d\u003e \"rabbit://hyperscale:$hs_passwd@$rabbit_ip\","},{"line_number":39,"context_line":"    \"DEFAULT/rpc_backend\":                     value \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # Create cinder volume type"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f201791_1ecf4c80","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":97},"in_reply_to":"5f201791_8a05577d","updated":"2017-06-20 16:37:08.000000000","message":"Yes. Multiple backends is an important compatibility. We would not support adding this code in if it\u0027s going to break that.","commit_id":"c70c2fb5634a92c642d8773b4b19ea564cc457a0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"af4da74d08a9c794d40f6b1783db0f8e3e862fbd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"define cinder::backend::veritas_hyperscale ("},{"line_number":35,"context_line":"  $hs_passwd     \u003d $hs_passwd,"},{"line_number":36,"context_line":"  $rabbit_ip     \u003d $rabbit_ip,"},{"line_number":37,"context_line":"  $extra_options \u003d {},"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":"  cinder_config {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5f201791_aec5a790","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":30},"updated":"2017-06-21 13:51:06.000000000","message":"no longer needed","commit_id":"98fdec39421b81b610287c67ba571b2ac1b9b06b"},{"author":{"_account_id":24290,"name":"Abhishek Kane","email":"abhishek.kane@veritas.com","username":"AbhishekKane"},"change_message_id":"61d465f6d92f315673eda68894123434a505c77a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"define cinder::backend::veritas_hyperscale ("},{"line_number":35,"context_line":"  $hs_passwd     \u003d $hs_passwd,"},{"line_number":36,"context_line":"  $rabbit_ip     \u003d $rabbit_ip,"},{"line_number":37,"context_line":"  $extra_options \u003d {},"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":"  cinder_config {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5f201791_8503e942","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":30},"in_reply_to":"5f201791_aec5a790","updated":"2017-06-21 14:57:38.000000000","message":"Yikes. Removed.","commit_id":"98fdec39421b81b610287c67ba571b2ac1b9b06b"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"9c27a9614bd070ca940c34e05dc918cf3e46dd4a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  $extra_options \u003d {},"},{"line_number":24,"context_line":") {"},{"line_number":25,"context_line":"  cinder_config {"},{"line_number":26,"context_line":"    \u0027Veritas_HyperScale/volume_backend_name\u0027: value \u003d\u003e \u0027Veritas_HyperScale\u0027;"},{"line_number":27,"context_line":"    \u0027Veritas_HyperScale/volume_driver\u0027:       value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027;"},{"line_number":28,"context_line":"  }"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f201791_55843fb1","line":26,"range":{"start_line":26,"start_character":5,"end_line":26,"end_character":23},"updated":"2017-06-22 15:24:12.000000000","message":"Why not use ${name} to allow configuration of multiple Veritas_Hyperscale backends?","commit_id":"c846b0dc0c362534167f1285cab785f48ed98b87"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"9c27a9614bd070ca940c34e05dc918cf3e46dd4a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  $extra_options \u003d {},"},{"line_number":24,"context_line":") {"},{"line_number":25,"context_line":"  cinder_config {"},{"line_number":26,"context_line":"    \u0027Veritas_HyperScale/volume_backend_name\u0027: value \u003d\u003e \u0027Veritas_HyperScale\u0027;"},{"line_number":27,"context_line":"    \u0027Veritas_HyperScale/volume_driver\u0027:       value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027;"},{"line_number":28,"context_line":"  }"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f201791_95177752","line":26,"range":{"start_line":26,"start_character":56,"end_line":26,"end_character":74},"updated":"2017-06-22 15:24:12.000000000","message":"ditto","commit_id":"c846b0dc0c362534167f1285cab785f48ed98b87"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"082f632193b41f245ba7b22367173b0c71e92607","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  $extra_options \u003d {},"},{"line_number":24,"context_line":") {"},{"line_number":25,"context_line":"  cinder_config {"},{"line_number":26,"context_line":"    \u0027Veritas_HyperScale/volume_backend_name\u0027: value \u003d\u003e \u0027Veritas_HyperScale\u0027;"},{"line_number":27,"context_line":"    \u0027Veritas_HyperScale/volume_driver\u0027:       value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027;"},{"line_number":28,"context_line":"  }"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f201791_cb666c2a","line":26,"range":{"start_line":26,"start_character":56,"end_line":26,"end_character":74},"in_reply_to":"5f201791_8bb514d0","updated":"2017-06-22 16:00:13.000000000","message":"So it\u0027s more about consistency with the other backends. if you look at the other cinder::backend::* resources they use name. In tripleo you may not support more than one, but this is puppet-cinder where the operator should be the one to choose that. \n\nhttps://github.com/openstack/puppet-cinder/blob/master/manifests/backend/nexenta.pp#L78\nhttps://github.com/openstack/puppet-cinder/blob/master/manifests/backend/rbd.pp#L101\nhttps://github.com/openstack/puppet-cinder/blob/master/manifests/backend/vmdk.pp#L91\n\nEffectively using the ${name} simplified the configuration items since you\u0027ll be passing in Veritas_HyperScale as the name from tripleo anyway.","commit_id":"c846b0dc0c362534167f1285cab785f48ed98b87"},{"author":{"_account_id":24290,"name":"Abhishek Kane","email":"abhishek.kane@veritas.com","username":"AbhishekKane"},"change_message_id":"6efc01ab9ba7d49b47dd0c50ef4e422f5fd9f2a1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  $extra_options \u003d {},"},{"line_number":24,"context_line":") {"},{"line_number":25,"context_line":"  cinder_config {"},{"line_number":26,"context_line":"    \u0027Veritas_HyperScale/volume_backend_name\u0027: value \u003d\u003e \u0027Veritas_HyperScale\u0027;"},{"line_number":27,"context_line":"    \u0027Veritas_HyperScale/volume_driver\u0027:       value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027;"},{"line_number":28,"context_line":"  }"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f201791_8bb514d0","line":26,"range":{"start_line":26,"start_character":56,"end_line":26,"end_character":74},"in_reply_to":"5f201791_95177752","updated":"2017-06-22 15:50:31.000000000","message":"We are not going to support multiple Veritas Hyperscale backends on the same cinder node. It\u0027s supposed to manage everything on one node. That\u0027s why I have hard coded the name here.","commit_id":"c846b0dc0c362534167f1285cab785f48ed98b87"},{"author":{"_account_id":24290,"name":"Abhishek Kane","email":"abhishek.kane@veritas.com","username":"AbhishekKane"},"change_message_id":"955107a9f6d8e555e7c1d9d070250bbf3e11a138","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  $extra_options \u003d {},"},{"line_number":24,"context_line":") {"},{"line_number":25,"context_line":"  cinder_config {"},{"line_number":26,"context_line":"    \u0027Veritas_HyperScale/volume_backend_name\u0027: value \u003d\u003e \u0027Veritas_HyperScale\u0027;"},{"line_number":27,"context_line":"    \u0027Veritas_HyperScale/volume_driver\u0027:       value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027;"},{"line_number":28,"context_line":"  }"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f201791_8b14f3a1","line":26,"range":{"start_line":26,"start_character":56,"end_line":26,"end_character":74},"in_reply_to":"5f201791_cb666c2a","updated":"2017-06-22 16:29:00.000000000","message":"Done","commit_id":"c846b0dc0c362534167f1285cab785f48ed98b87"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"9c27a9614bd070ca940c34e05dc918cf3e46dd4a","unresolved":false,"context_lines":[{"line_number":24,"context_line":") {"},{"line_number":25,"context_line":"  cinder_config {"},{"line_number":26,"context_line":"    \u0027Veritas_HyperScale/volume_backend_name\u0027: value \u003d\u003e \u0027Veritas_HyperScale\u0027;"},{"line_number":27,"context_line":"    \u0027Veritas_HyperScale/volume_driver\u0027:       value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027;"},{"line_number":28,"context_line":"  }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  # Create cinder volume type"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f201791_5509df2e","line":27,"range":{"start_line":27,"start_character":5,"end_line":27,"end_character":24},"updated":"2017-06-22 15:24:12.000000000","message":"ditto","commit_id":"c846b0dc0c362534167f1285cab785f48ed98b87"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1580ce40f369f4b2f953b1ba2a0752985e39663b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"define cinder::backend::veritas_hyperscale ("},{"line_number":27,"context_line":"  $volume_backend_name \u003d $name,"},{"line_number":28,"context_line":"  $extra_options       \u003d {},"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":"  cinder_config {"},{"line_number":31,"context_line":"    \"${name}/volume_backend_name\": value \u003d\u003e $volume_backend_name;"},{"line_number":32,"context_line":"    \"${name}/volume_driver\":       value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027;"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5f201791_c0764207","line":29,"updated":"2017-06-22 20:27:57.000000000","message":"include ::cinder::deps","commit_id":"31bc34b725fb08185d67cd4b8b4e98550aac9148"},{"author":{"_account_id":24290,"name":"Abhishek Kane","email":"abhishek.kane@veritas.com","username":"AbhishekKane"},"change_message_id":"b1404547a601b47d7c32ac1d39953eeac90fdd3d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"define cinder::backend::veritas_hyperscale ("},{"line_number":27,"context_line":"  $volume_backend_name \u003d $name,"},{"line_number":28,"context_line":"  $extra_options       \u003d {},"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":"  cinder_config {"},{"line_number":31,"context_line":"    \"${name}/volume_backend_name\": value \u003d\u003e $volume_backend_name;"},{"line_number":32,"context_line":"    \"${name}/volume_driver\":       value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027;"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5f201791_1bbc9f67","line":29,"in_reply_to":"5f201791_c0764207","updated":"2017-06-23 08:47:40.000000000","message":"Done","commit_id":"31bc34b725fb08185d67cd4b8b4e98550aac9148"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1580ce40f369f4b2f953b1ba2a0752985e39663b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"${name}/volume_driver\":       value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027;"},{"line_number":33,"context_line":"  }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  # Create cinder volume type"},{"line_number":36,"context_line":"  cinder_type { $name:"},{"line_number":37,"context_line":"    ensure     \u003d\u003e present,"},{"line_number":38,"context_line":"    properties \u003d\u003e [\"volume_backend_name\u003d${name}\"],"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5f201791_60652e45","line":35,"updated":"2017-06-22 20:27:57.000000000","message":"look at eqlnx.pp and add $manage_volume_type conditional.","commit_id":"31bc34b725fb08185d67cd4b8b4e98550aac9148"},{"author":{"_account_id":24290,"name":"Abhishek Kane","email":"abhishek.kane@veritas.com","username":"AbhishekKane"},"change_message_id":"b1404547a601b47d7c32ac1d39953eeac90fdd3d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"${name}/volume_driver\":       value \u003d\u003e \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027;"},{"line_number":33,"context_line":"  }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  # Create cinder volume type"},{"line_number":36,"context_line":"  cinder_type { $name:"},{"line_number":37,"context_line":"    ensure     \u003d\u003e present,"},{"line_number":38,"context_line":"    properties \u003d\u003e [\"volume_backend_name\u003d${name}\"],"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5f201791_fbb20394","line":35,"in_reply_to":"5f201791_60652e45","updated":"2017-06-23 08:47:40.000000000","message":"Done","commit_id":"31bc34b725fb08185d67cd4b8b4e98550aac9148"}],"spec/defines/cinder_backend_veritas_hyperscale_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1fbe994dbbae8b9f000e84652bcbce04c0139e25","unresolved":false,"context_lines":[{"line_number":3,"context_line":"describe \u0027cinder::backend::veritas_hyperscale\u0027 do"},{"line_number":4,"context_line":"  let (:title) { \u0027Veritas_HyperScale\u0027 }"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  let :params do"},{"line_number":7,"context_line":"    {"},{"line_number":8,"context_line":"\t  :manage_volume_type \u003d\u003e true,"},{"line_number":9,"context_line":"    }"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  describe \u0027veritas_hyperscale volume driver\u0027 do"},{"line_number":12,"context_line":"    it \u0027configures veritas_hyperscale volume driver\u0027 do"},{"line_number":13,"context_line":"      is_expected.to contain_cinder_config(\"#{title}/volume_driver\").with_value("},{"line_number":14,"context_line":"            \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027)"},{"line_number":15,"context_line":"      is_expected.to contain_cinder_config(\"#{title}/volume_backend_name\").with_value("},{"line_number":16,"context_line":"            \"#{title}\")"},{"line_number":17,"context_line":"    end"},{"line_number":18,"context_line":"  end"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  describe \u0027veritas_hyperscale backend with additional configuration\u0027 do"},{"line_number":21,"context_line":"    before :each do"},{"line_number":22,"context_line":"      params.merge!({:extra_options \u003d\u003e {\"#{title}/param1\" \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027value1\u0027}}})"},{"line_number":23,"context_line":"    end"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    it \u0027configure veritas_hyperscale backend with additional configuration\u0027 do"},{"line_number":26,"context_line":"      is_expected.to contain_cinder_config(\"#{title}/param1\").with({"},{"line_number":27,"context_line":"        :value \u003d\u003e \u0027value1\u0027,"},{"line_number":28,"context_line":"      })"},{"line_number":29,"context_line":"    end"},{"line_number":30,"context_line":"  end"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  describe \u0027veritas_hyperScale backend with cinder type\u0027 do"},{"line_number":34,"context_line":"    before :each do"},{"line_number":35,"context_line":"      params.merge!({:manage_volume_type \u003d\u003e true})"},{"line_number":36,"context_line":"    end"},{"line_number":37,"context_line":"    it \u0027should create type with properties\u0027 do"},{"line_number":38,"context_line":"      should contain_cinder_type(\"#{title}\").with("},{"line_number":39,"context_line":"            :ensure \u003d\u003e :present, :properties \u003d\u003e [\"volume_backend_name\u003d#{title}\"])"},{"line_number":40,"context_line":"    end"},{"line_number":41,"context_line":"  end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"end"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":11,"id":"5f201791_7e6ff391","line":41,"range":{"start_line":6,"start_character":0,"end_line":41,"end_character":5},"updated":"2017-06-23 16:34:47.000000000","message":"Please take a look at the existing ones, it should follow a similar format with shared_examples_for and on_supported_os\n\nhttps://github.com/openstack/puppet-cinder/blob/master/spec/defines/cinder_backend_bdd_spec.rb","commit_id":"077238f1097072ecfe239c4352fd96c6bbcb607c"},{"author":{"_account_id":24290,"name":"Abhishek Kane","email":"abhishek.kane@veritas.com","username":"AbhishekKane"},"change_message_id":"4e8d913bda6c3ddc7b41757e30ca933e308b064b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"describe \u0027cinder::backend::veritas_hyperscale\u0027 do"},{"line_number":4,"context_line":"  let (:title) { \u0027Veritas_HyperScale\u0027 }"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  let :params do"},{"line_number":7,"context_line":"    {"},{"line_number":8,"context_line":"\t  :manage_volume_type \u003d\u003e true,"},{"line_number":9,"context_line":"    }"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  describe \u0027veritas_hyperscale volume driver\u0027 do"},{"line_number":12,"context_line":"    it \u0027configures veritas_hyperscale volume driver\u0027 do"},{"line_number":13,"context_line":"      is_expected.to contain_cinder_config(\"#{title}/volume_driver\").with_value("},{"line_number":14,"context_line":"            \u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027)"},{"line_number":15,"context_line":"      is_expected.to contain_cinder_config(\"#{title}/volume_backend_name\").with_value("},{"line_number":16,"context_line":"            \"#{title}\")"},{"line_number":17,"context_line":"    end"},{"line_number":18,"context_line":"  end"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  describe \u0027veritas_hyperscale backend with additional configuration\u0027 do"},{"line_number":21,"context_line":"    before :each do"},{"line_number":22,"context_line":"      params.merge!({:extra_options \u003d\u003e {\"#{title}/param1\" \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027value1\u0027}}})"},{"line_number":23,"context_line":"    end"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    it \u0027configure veritas_hyperscale backend with additional configuration\u0027 do"},{"line_number":26,"context_line":"      is_expected.to contain_cinder_config(\"#{title}/param1\").with({"},{"line_number":27,"context_line":"        :value \u003d\u003e \u0027value1\u0027,"},{"line_number":28,"context_line":"      })"},{"line_number":29,"context_line":"    end"},{"line_number":30,"context_line":"  end"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  describe \u0027veritas_hyperScale backend with cinder type\u0027 do"},{"line_number":34,"context_line":"    before :each do"},{"line_number":35,"context_line":"      params.merge!({:manage_volume_type \u003d\u003e true})"},{"line_number":36,"context_line":"    end"},{"line_number":37,"context_line":"    it \u0027should create type with properties\u0027 do"},{"line_number":38,"context_line":"      should contain_cinder_type(\"#{title}\").with("},{"line_number":39,"context_line":"            :ensure \u003d\u003e :present, :properties \u003d\u003e [\"volume_backend_name\u003d#{title}\"])"},{"line_number":40,"context_line":"    end"},{"line_number":41,"context_line":"  end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"end"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":11,"id":"5f201791_6814cb44","line":41,"range":{"start_line":6,"start_character":0,"end_line":41,"end_character":5},"in_reply_to":"5f201791_7e6ff391","updated":"2017-06-24 07:29:10.000000000","message":"Thanks for the example Alex!\nI followed eqlx (doesn\u0027t have on_supported_os) and scaleio (doesn\u0027t have both) files before and I didn\u0027t know what tags were necessary.","commit_id":"077238f1097072ecfe239c4352fd96c6bbcb607c"}]}