)]}'
{"manifests/backend/dellemc_vmax_iscsi.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"56f55fd514df3d86ab5193f0fb0f71ac0f2f64ca","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":"  }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  ensure_packages( \u0027pywbem\u0027, {"},{"line_number":57,"context_line":"    ensure \u003d\u003e present,"},{"line_number":58,"context_line":"    tag    \u003d\u003e \u0027cinder-support-package\u0027})"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f485f77_7774219a","line":56,"updated":"2017-11-10 14:31:52.000000000","message":"The actual package name needs to be configurable because it may differ between \u0027Debian\u0027 and \u0027RedHat\u0027 OS families. This needs something like:\n\n  name \u003d\u003e $::cinder::param::pywbem_package_name\n\nFollow examples of similar XXX_package_name variables in manifests/params.pp. The proper value for \u0027RedHat\u0027 might be \u0027pywbem,\u0027 but for \u0027Debian\u0027 I think it\u0027s \u0027python-pywbem\u0027 (not 100% certain).","commit_id":"dcc46079e3994b0bcac6c463ee10d5ea3aa080ca"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"c91fb1267eefc8f8b9b2b0f59bc01b09e25c0f58","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":"  }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  ensure_packages( \u0027pywbem\u0027, {"},{"line_number":57,"context_line":"    ensure \u003d\u003e present,"},{"line_number":58,"context_line":"    tag    \u003d\u003e \u0027cinder-support-package\u0027})"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f485f77_8e92c34a","line":56,"in_reply_to":"1f485f77_7774219a","updated":"2017-11-13 15:10:07.000000000","message":"Done","commit_id":"dcc46079e3994b0bcac6c463ee10d5ea3aa080ca"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"38c6da3b3a4315b4fb5dc72d140843d74d2eb4d2","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  ensure_packages( \u0027pywbem\u0027, {"},{"line_number":57,"context_line":"    ensure \u003d\u003e present,"},{"line_number":58,"context_line":"    name \u003d\u003e $::cinder::param::pywbem_package_name,"},{"line_number":59,"context_line":"    tag    \u003d\u003e \u0027cinder-support-package\u0027})"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  create_resources(\u0027cinder_config\u0027, $extra_options)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1f485f77_9fc1cbe7","line":58,"updated":"2017-11-13 17:22:21.000000000","message":"nit: \"\u003d\u003e\" not aligned with surrounding lines","commit_id":"1e06d070bb62ac9faf0559c486dda7ad2f427d0c"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"e0ea226fc82521c9ed06cb9f9fe2d2b219ca1299","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  ensure_packages( \u0027pywbem\u0027, {"},{"line_number":57,"context_line":"    ensure \u003d\u003e present,"},{"line_number":58,"context_line":"    name \u003d\u003e $::cinder::param::pywbem_package_name,"},{"line_number":59,"context_line":"    tag    \u003d\u003e \u0027cinder-support-package\u0027})"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  create_resources(\u0027cinder_config\u0027, $extra_options)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1f485f77_7aabbd88","line":58,"in_reply_to":"1f485f77_9fc1cbe7","updated":"2017-11-13 17:51:51.000000000","message":"Fixed. I wonder why the gate didn\u0027t catch it. Neither did puppet lint and puppet syntax","commit_id":"1e06d070bb62ac9faf0559c486dda7ad2f427d0c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a3798ec41258a4fedd2b35788d002fabd764615c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":"  }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  ensure_packages( \u0027pywbem\u0027, {"},{"line_number":57,"context_line":"    ensure \u003d\u003e present,"},{"line_number":58,"context_line":"    name   \u003d\u003e $::cinder::param::pywbem_package_name,"},{"line_number":59,"context_line":"    tag    \u003d\u003e \u0027cinder-support-package\u0027})"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1f485f77_9e5c247f","line":56,"updated":"2017-11-13 23:55:43.000000000","message":"If i remember correctly I think the prefered solution is ensure_resouce(\u0027package\u0027, [\u0027pywbem\u0027], {...}) because it would allow for something other than present.  That being said I think for this package it\u0027s not really a problem since it needs to be there.","commit_id":"1eb43b2b9740f3f8afad1330d7749a91e9568a4c"}]}