)]}'
{"lib/puppet/provider/cinder_type/openstack.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d313f7a3a91043706bbd170ce3fdf745b43e8f76","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  def self.instances"},{"line_number":80,"context_line":"    list \u003d request(\u0027volume type\u0027, \u0027list\u0027, \u0027--long\u0027)"},{"line_number":81,"context_line":"    priv \u003d request(\u0027volume type\u0027, \u0027list\u0027, [\u0027--long\u0027, \u0027--private\u0027])"},{"line_number":82,"context_line":"    priv.each do |type|"},{"line_number":83,"context_line":"      item \u003d list.find { |x| x[:id] \u003d\u003d type[:id] }"},{"line_number":84,"context_line":"      index \u003d list.index(item)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3f79a3b5_e245bab5","line":81,"range":{"start_line":81,"start_character":54,"end_line":81,"end_character":63},"updated":"2018-09-12 19:30:07.000000000","message":"Why --private here? Won\u0027t this cause public volume types not to be loaded into instances for this provider.","commit_id":"d0dcbe989651d47e57f5377411ef0b5923698402"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"81986c51c98890f53498c82c055e06d7f317950a","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  def self.instances"},{"line_number":80,"context_line":"    list \u003d request(\u0027volume type\u0027, \u0027list\u0027, \u0027--long\u0027)"},{"line_number":81,"context_line":"    priv \u003d request(\u0027volume type\u0027, \u0027list\u0027, [\u0027--long\u0027, \u0027--private\u0027])"},{"line_number":82,"context_line":"    priv.each do |type|"},{"line_number":83,"context_line":"      item \u003d list.find { |x| x[:id] \u003d\u003d type[:id] }"},{"line_number":84,"context_line":"      index \u003d list.index(item)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3f79a3b5_3d0f41e1","line":81,"range":{"start_line":81,"start_character":54,"end_line":81,"end_character":63},"in_reply_to":"3f79a3b5_2ece312d","updated":"2018-09-13 15:39:14.000000000","message":"Ok I understand, I think it would be better to loop the \"list\" variable and check if is_public is true otherwise continue to next item, no?\n\nThat way you don\u0027t have to make to volume type list calls which and it should be faster.","commit_id":"d0dcbe989651d47e57f5377411ef0b5923698402"},{"author":{"_account_id":28627,"name":"Julien","email":"julien.cosmao@ovhcloud.com","username":"jcosmao"},"change_message_id":"67c30c4981ff496f05b5b081ee7b820732b71674","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  def self.instances"},{"line_number":80,"context_line":"    list \u003d request(\u0027volume type\u0027, \u0027list\u0027, \u0027--long\u0027)"},{"line_number":81,"context_line":"    priv \u003d request(\u0027volume type\u0027, \u0027list\u0027, [\u0027--long\u0027, \u0027--private\u0027])"},{"line_number":82,"context_line":"    priv.each do |type|"},{"line_number":83,"context_line":"      item \u003d list.find { |x| x[:id] \u003d\u003d type[:id] }"},{"line_number":84,"context_line":"      index \u003d list.index(item)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3f79a3b5_68fc190c","line":81,"range":{"start_line":81,"start_character":54,"end_line":81,"end_character":63},"in_reply_to":"3f79a3b5_3d0f41e1","updated":"2018-09-13 16:01:48.000000000","message":"If i loop on all type list, i\u0027ll have to \u0027volume type show\u0027 on each object to check if it\u0027s private and retrieve access_project_ids. If there is a lot of volume type, it will slow down puppet run. \n\nAs I don\u0027t need \u0027volume type show\u0027 on public volume, I think it\u0027s the fastest way.\n\nA better way to do it would be patching openstack client to return is_public: true/false directly in volume type list (api return the param, but cli does not display it)","commit_id":"d0dcbe989651d47e57f5377411ef0b5923698402"},{"author":{"_account_id":28627,"name":"Julien","email":"julien.cosmao@ovhcloud.com","username":"jcosmao"},"change_message_id":"d0895a9c7068fc186468d5f1b8086f6697040015","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  def self.instances"},{"line_number":80,"context_line":"    list \u003d request(\u0027volume type\u0027, \u0027list\u0027, \u0027--long\u0027)"},{"line_number":81,"context_line":"    priv \u003d request(\u0027volume type\u0027, \u0027list\u0027, [\u0027--long\u0027, \u0027--private\u0027])"},{"line_number":82,"context_line":"    priv.each do |type|"},{"line_number":83,"context_line":"      item \u003d list.find { |x| x[:id] \u003d\u003d type[:id] }"},{"line_number":84,"context_line":"      index \u003d list.index(item)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3f79a3b5_682899ed","line":81,"range":{"start_line":81,"start_character":54,"end_line":81,"end_character":63},"in_reply_to":"3f79a3b5_48ab5d87","updated":"2018-09-13 16:21:02.000000000","message":"Arf.. i don\u0027t have it in my client version. \nThx, i\u0027m fixing it.","commit_id":"d0dcbe989651d47e57f5377411ef0b5923698402"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"762a4dda3a00ba7904f22c25376f343e12ff0297","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  def self.instances"},{"line_number":80,"context_line":"    list \u003d request(\u0027volume type\u0027, \u0027list\u0027, \u0027--long\u0027)"},{"line_number":81,"context_line":"    priv \u003d request(\u0027volume type\u0027, \u0027list\u0027, [\u0027--long\u0027, \u0027--private\u0027])"},{"line_number":82,"context_line":"    priv.each do |type|"},{"line_number":83,"context_line":"      item \u003d list.find { |x| x[:id] \u003d\u003d type[:id] }"},{"line_number":84,"context_line":"      index \u003d list.index(item)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3f79a3b5_48ab5d87","line":81,"range":{"start_line":81,"start_character":54,"end_line":81,"end_character":63},"in_reply_to":"3f79a3b5_68fc190c","updated":"2018-09-13 16:14:21.000000000","message":"But it does already? This is my output from a Queens controller. [1]\n\n[1] http://paste.openstack.org/show/730040/","commit_id":"d0dcbe989651d47e57f5377411ef0b5923698402"},{"author":{"_account_id":28627,"name":"Julien","email":"julien.cosmao@ovhcloud.com","username":"jcosmao"},"change_message_id":"47f9c5d3d1d03727fe450ee03143f48eaa1e3a90","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  def self.instances"},{"line_number":80,"context_line":"    list \u003d request(\u0027volume type\u0027, \u0027list\u0027, \u0027--long\u0027)"},{"line_number":81,"context_line":"    priv \u003d request(\u0027volume type\u0027, \u0027list\u0027, [\u0027--long\u0027, \u0027--private\u0027])"},{"line_number":82,"context_line":"    priv.each do |type|"},{"line_number":83,"context_line":"      item \u003d list.find { |x| x[:id] \u003d\u003d type[:id] }"},{"line_number":84,"context_line":"      index \u003d list.index(item)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3f79a3b5_2ece312d","line":81,"range":{"start_line":81,"start_character":54,"end_line":81,"end_character":63},"in_reply_to":"3f79a3b5_e245bab5","updated":"2018-09-13 12:02:52.000000000","message":"instances are created from variable list, so all volume types are instanciated (public + private).\n\nI need --private here to iterate on each private volume type to get \u0027access_project_ids\u0027.\n\nWithout private list, i\u0027ll need to iterate over all types wether they are public/private.","commit_id":"d0dcbe989651d47e57f5377411ef0b5923698402"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"5ce6d207629101e215cc56a1f80b5b127cebfabe","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    end"},{"line_number":19,"context_line":"    properties \u003c\u003c (@resource[:is_public] \u003d\u003d :true ? \u0027--public\u0027 : \u0027--private\u0027)"},{"line_number":20,"context_line":"    properties \u003c\u003c name"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    self.class.request(\u0027volume type\u0027, \u0027create\u0027, properties)"},{"line_number":23,"context_line":"    @property_hash[:ensure] \u003d :present"},{"line_number":24,"context_line":"    @property_hash[:properties] \u003d resource[:properties]"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3f79a3b5_dbfd35b3","line":21,"updated":"2018-09-24 13:55:12.000000000","message":"nit: remove new line","commit_id":"926e4af6d5d88faa9ffd94060ed03c18d0a893b9"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"5ce6d207629101e215cc56a1f80b5b127cebfabe","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  def self.instances"},{"line_number":80,"context_line":"    list \u003d request(\u0027volume type\u0027, \u0027list\u0027, \u0027--long\u0027)"},{"line_number":81,"context_line":"    list.each do |type|"},{"line_number":82,"context_line":"      if type[:is_public] \u003d\u003d \"False\""},{"line_number":83,"context_line":"        type_details \u003d request(\u0027volume type\u0027, \u0027show\u0027, type[:id])"},{"line_number":84,"context_line":"        type[:access_project_ids] \u003d string2array(type_details[:access_project_ids])"},{"line_number":85,"context_line":"        type[:is_public] \u003d false"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3f79a3b5_bb05d9c3","line":82,"range":{"start_line":82,"start_character":29,"end_line":82,"end_character":36},"updated":"2018-09-24 13:55:12.000000000","message":"use single quotes","commit_id":"926e4af6d5d88faa9ffd94060ed03c18d0a893b9"}],"lib/puppet/type/cinder_type.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"5ce6d207629101e215cc56a1f80b5b127cebfabe","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  end"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  newparam(:is_public, :boolean \u003d\u003e true) do"},{"line_number":24,"context_line":"    desc \u0027Whether the type is public or not. Default to `true`\u0027"},{"line_number":25,"context_line":"    newvalues(:true, :false)"},{"line_number":26,"context_line":"    defaultto true"},{"line_number":27,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3f79a3b5_7bdd0140","line":24,"range":{"start_line":24,"start_character":56,"end_line":24,"end_character":57},"updated":"2018-09-24 13:55:12.000000000","message":"nit: why backticks?","commit_id":"926e4af6d5d88faa9ffd94060ed03c18d0a893b9"},{"author":{"_account_id":28627,"name":"Julien","email":"julien.cosmao@ovhcloud.com","username":"jcosmao"},"change_message_id":"d8755530b19cfb432c13fa9101c4bc6d79f674ff","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  end"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  newparam(:is_public, :boolean \u003d\u003e true) do"},{"line_number":24,"context_line":"    desc \u0027Whether the type is public or not. Default to `true`\u0027"},{"line_number":25,"context_line":"    newvalues(:true, :false)"},{"line_number":26,"context_line":"    defaultto true"},{"line_number":27,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3f79a3b5_ed7638a4","line":24,"range":{"start_line":24,"start_character":56,"end_line":24,"end_character":57},"in_reply_to":"3f79a3b5_7bdd0140","updated":"2018-09-24 14:33:41.000000000","message":"Same syntax than other puppet openstack modules.","commit_id":"926e4af6d5d88faa9ffd94060ed03c18d0a893b9"}],"spec/unit/provider/cinder_type/openstack_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"5ce6d207629101e215cc56a1f80b5b127cebfabe","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    let(:type_attributes) do"},{"line_number":16,"context_line":"      {"},{"line_number":17,"context_line":"         :name       \u003d\u003e \u0027Backend_1\u0027,"},{"line_number":18,"context_line":"         :ensure     \u003d\u003e :present,"},{"line_number":19,"context_line":"         :properties \u003d\u003e [\u0027key\u003dvalue\u0027, \u0027new_key\u003dnew_value\u0027],"},{"line_number":20,"context_line":"         :is_public  \u003d\u003e true,"},{"line_number":21,"context_line":"         :access_project_ids  \u003d\u003e [],"},{"line_number":22,"context_line":"      }"},{"line_number":23,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3f79a3b5_3b6c699c","line":20,"range":{"start_line":17,"start_character":9,"end_line":20,"end_character":29},"updated":"2018-09-24 13:55:12.000000000","message":"nit: align \u003d\u003e","commit_id":"926e4af6d5d88faa9ffd94060ed03c18d0a893b9"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"5ce6d207629101e215cc56a1f80b5b127cebfabe","unresolved":false,"context_lines":[{"line_number":18,"context_line":"         :ensure     \u003d\u003e :present,"},{"line_number":19,"context_line":"         :properties \u003d\u003e [\u0027key\u003dvalue\u0027, \u0027new_key\u003dnew_value\u0027],"},{"line_number":20,"context_line":"         :is_public  \u003d\u003e true,"},{"line_number":21,"context_line":"         :access_project_ids  \u003d\u003e [],"},{"line_number":22,"context_line":"      }"},{"line_number":23,"context_line":"    end"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3f79a3b5_5b55a5c1","line":21,"range":{"start_line":21,"start_character":28,"end_line":21,"end_character":29},"updated":"2018-09-24 13:55:12.000000000","message":"nit: double spaces","commit_id":"926e4af6d5d88faa9ffd94060ed03c18d0a893b9"}]}