)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"2915fe4953e79902f4c9787a6a63cda348ec9437","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rajinir \u003crajini.karthik@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-21 11:04:55 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell EMC Sc: Add support for excluded_domain_ips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Dell EMC SC configuration option excluded_domain_ip has been"},{"line_number":10,"context_line":"deprecated and will be removed in a future release. Deployments"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_b3dc3971","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":11},"updated":"2018-09-21 17:53:01.000000000","message":"SC - nit","commit_id":"79617ee8ec3039af844042baa6ccb08104cdfeb4"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"19cb4da2c8652bbce4452147befed2f3b524a412","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rajinir \u003crajini.karthik@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-21 11:04:55 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell EMC Sc: Add support for excluded_domain_ips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Dell EMC SC configuration option excluded_domain_ip has been"},{"line_number":10,"context_line":"deprecated and will be removed in a future release. Deployments"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_d3e5350b","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":11},"in_reply_to":"3f79a3b5_b3dc3971","updated":"2018-09-21 18:02:33.000000000","message":"Done","commit_id":"79617ee8ec3039af844042baa6ccb08104cdfeb4"}],"manifests/backend/dellsc_iscsi.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9040d1edc1d3e3a9b11f325a4ef20e3a077d91ec","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#   (optional) The ISCSI IP Port of the Storage Center."},{"line_number":44,"context_line":"#   Defaults to $::os_service_default"},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"# [*excluded_domain_ip*]"},{"line_number":47,"context_line":"#   (optional) Domain IP to be excluded from iSCSI returns of Storage Center."},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"# [*excluded_domain_ips*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_d4ac3c38","line":46,"updated":"2018-09-21 20:57:03.000000000","message":"Deprecated options need to be moved to another location within the header. Look for \"DEPRECATED PARAMETERS\" in other files such as manifests/api.pp for an example.","commit_id":"220144ab0db86c41a2531c5503e894ee1e08ef2b"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"aac2f9ee1bc639f49535e666edcb3c946441d39a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#   (optional) The ISCSI IP Port of the Storage Center."},{"line_number":44,"context_line":"#   Defaults to $::os_service_default"},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"# [*excluded_domain_ip*]"},{"line_number":47,"context_line":"#   (optional) Domain IP to be excluded from iSCSI returns of Storage Center."},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"# [*excluded_domain_ips*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_6a32f511","line":46,"in_reply_to":"3f79a3b5_d4ac3c38","updated":"2018-09-25 14:35:07.000000000","message":"Done","commit_id":"220144ab0db86c41a2531c5503e894ee1e08ef2b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9040d1edc1d3e3a9b11f325a4ef20e3a077d91ec","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# [*excluded_domain_ips*]"},{"line_number":50,"context_line":"#   (optional)Comma separated list of domain Is Pto be excluded from"},{"line_number":51,"context_line":"#   iSCSI returns of Storage Center."},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"# [*secondary_san_ip*]"},{"line_number":54,"context_line":"#   (optional) IP address of secondary DSM controller."},{"line_number":55,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_542cacb1","line":52,"updated":"2018-09-21 20:57:03.000000000","message":"Add \"Defaults to $::os_service_default\"","commit_id":"220144ab0db86c41a2531c5503e894ee1e08ef2b"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"aac2f9ee1bc639f49535e666edcb3c946441d39a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# [*excluded_domain_ips*]"},{"line_number":50,"context_line":"#   (optional)Comma separated list of domain Is Pto be excluded from"},{"line_number":51,"context_line":"#   iSCSI returns of Storage Center."},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"# [*secondary_san_ip*]"},{"line_number":54,"context_line":"#   (optional) IP address of secondary DSM controller."},{"line_number":55,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_2a3cfddf","line":52,"in_reply_to":"3f79a3b5_542cacb1","updated":"2018-09-25 14:35:07.000000000","message":"Done","commit_id":"220144ab0db86c41a2531c5503e894ee1e08ef2b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9040d1edc1d3e3a9b11f325a4ef20e3a077d91ec","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  $dell_sc_verify_cert    \u003d $::os_service_default,"},{"line_number":91,"context_line":"  $dell_sc_volume_folder  \u003d \u0027vol\u0027,"},{"line_number":92,"context_line":"  $iscsi_port             \u003d $::os_service_default,"},{"line_number":93,"context_line":"  $excluded_domain_ip     \u003d $::os_service_default,"},{"line_number":94,"context_line":"  $excluded_domain_ips    \u003d $::os_service_default,"},{"line_number":95,"context_line":"  $secondary_san_ip       \u003d $::os_service_default,"},{"line_number":96,"context_line":"  $secondary_san_login    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_343b30eb","line":93,"updated":"2018-09-21 20:57:03.000000000","message":"Likewise, deprecated parameters need to be moved down, below a section that clearly delineates \"DEPRECATED PARAMETERS\" (again, see api.pp for example).","commit_id":"220144ab0db86c41a2531c5503e894ee1e08ef2b"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"aac2f9ee1bc639f49535e666edcb3c946441d39a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  $dell_sc_verify_cert    \u003d $::os_service_default,"},{"line_number":91,"context_line":"  $dell_sc_volume_folder  \u003d \u0027vol\u0027,"},{"line_number":92,"context_line":"  $iscsi_port             \u003d $::os_service_default,"},{"line_number":93,"context_line":"  $excluded_domain_ip     \u003d $::os_service_default,"},{"line_number":94,"context_line":"  $excluded_domain_ips    \u003d $::os_service_default,"},{"line_number":95,"context_line":"  $secondary_san_ip       \u003d $::os_service_default,"},{"line_number":96,"context_line":"  $secondary_san_login    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_6d00cf01","line":93,"in_reply_to":"3f79a3b5_343b30eb","updated":"2018-09-25 14:35:07.000000000","message":"Done","commit_id":"220144ab0db86c41a2531c5503e894ee1e08ef2b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9040d1edc1d3e3a9b11f325a4ef20e3a077d91ec","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  include ::cinder::deps"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  if $excluded_domain_ip {"},{"line_number":106,"context_line":"    warning(\u0027The excluded_domain_ip is deprecated. Please use excluded_domain_ips instead.\u0027)"},{"line_number":107,"context_line":"  }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  if $dell_sc_server_folder \u003d\u003d \u0027srv\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_d45afc4f","line":106,"updated":"2018-09-21 20:57:03.000000000","message":"This warning message can be moved down, and included in the existing block starting on L140 (no need for two blocks).","commit_id":"220144ab0db86c41a2531c5503e894ee1e08ef2b"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"aac2f9ee1bc639f49535e666edcb3c946441d39a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  include ::cinder::deps"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  if $excluded_domain_ip {"},{"line_number":106,"context_line":"    warning(\u0027The excluded_domain_ip is deprecated. Please use excluded_domain_ips instead.\u0027)"},{"line_number":107,"context_line":"  }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  if $dell_sc_server_folder \u003d\u003d \u0027srv\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_4dfb9314","line":106,"in_reply_to":"3f79a3b5_d45afc4f","updated":"2018-09-25 14:35:07.000000000","message":"Done","commit_id":"220144ab0db86c41a2531c5503e894ee1e08ef2b"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"b0168065c123daffbdffce42313849bb61027fd6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#   Defaults to $::os_service_default"},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"# [*excluded_domain_ips*]"},{"line_number":47,"context_line":"#   (optional)Comma separated list of domain Is Pto be excluded from"},{"line_number":48,"context_line":"#   iSCSI returns of Storage Center."},{"line_number":49,"context_line":"#   Defaults to $::os_service_default"},{"line_number":50,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_3bdded12","line":47,"range":{"start_line":47,"start_character":45,"end_line":47,"end_character":51},"updated":"2018-09-27 22:02:04.000000000","message":"typos","commit_id":"14c213de16a5b51dd7ec6555bfb2c4bd8c399faa"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"7a15fc9580dff9da511c86a78442c937b775f1cd","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  $secondary_sc_api_port  \u003d $::os_service_default,"},{"line_number":100,"context_line":"  $manage_volume_type     \u003d false,"},{"line_number":101,"context_line":"  $extra_options          \u003d {},"},{"line_number":102,"context_line":"  $excluded_domain_ip     \u003d $::os_service_default,"},{"line_number":103,"context_line":") {"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  include ::cinder::deps"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f79a3b5_a12e99f6","line":102,"updated":"2018-09-28 18:51:05.000000000","message":"A \"  # DEPRECATED PARAMETERS\" comment line needs to be added above this line. See other examples (api.pp, glance.pp, backend/emc_vnx.pp).","commit_id":"a36747db74340579d427262ae5a11d60ecd013f6"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"5ae57dd9cbc053f046a7f1aa0b781deff2b197f7","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  $secondary_sc_api_port  \u003d $::os_service_default,"},{"line_number":100,"context_line":"  $manage_volume_type     \u003d false,"},{"line_number":101,"context_line":"  $extra_options          \u003d {},"},{"line_number":102,"context_line":"  $excluded_domain_ip     \u003d $::os_service_default,"},{"line_number":103,"context_line":") {"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  include ::cinder::deps"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f79a3b5_e4733fb3","line":102,"in_reply_to":"3f79a3b5_a12e99f6","updated":"2018-09-28 19:30:05.000000000","message":"Done","commit_id":"a36747db74340579d427262ae5a11d60ecd013f6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f423b4bed0c571c9a06cb76820b896ddae90f858","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  $manage_volume_type     \u003d false,"},{"line_number":101,"context_line":"  $extra_options          \u003d {},"},{"line_number":102,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":103,"context_line":"  $excluded_domain_ip     \u003d $::os_service_default,"},{"line_number":104,"context_line":") {"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  include ::cinder::deps"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_0ff98bc3","line":103,"range":{"start_line":103,"start_character":28,"end_line":103,"end_character":49},"updated":"2018-10-01 21:29:36.000000000","message":"Technically this should be undef as to not always trigger a warning in the default case","commit_id":"ce795cc3165a5f80ce5ebe4e193ebc44e26df896"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"c2dd007b731d82e153e22cebf560363a36ad705d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  $manage_volume_type     \u003d false,"},{"line_number":101,"context_line":"  $extra_options          \u003d {},"},{"line_number":102,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":103,"context_line":"  $excluded_domain_ip     \u003d $::os_service_default,"},{"line_number":104,"context_line":") {"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  include ::cinder::deps"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_eeaaca17","line":103,"range":{"start_line":103,"start_character":28,"end_line":103,"end_character":49},"in_reply_to":"3f79a3b5_0ff98bc3","updated":"2018-10-04 14:48:38.000000000","message":"Done","commit_id":"ce795cc3165a5f80ce5ebe4e193ebc44e26df896"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"22691638f4c45939fd7939a9ebc37f957c0eec7d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  $use_multipath_for_image_xfer \u003d true,"},{"line_number":106,"context_line":"  $extra_options                \u003d {},"},{"line_number":107,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":108,"context_line":"  $excluded_domain_ip           \u003d $::os_service_default,"},{"line_number":109,"context_line":") {"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  include ::cinder::deps"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3f79a3b5_e32939f1","line":108,"updated":"2018-10-09 00:31:17.000000000","message":"Alex previously suggested the default value be undef. You marked the comment as \"done\" but it looks like the original value is still being used.","commit_id":"49d5669d9c939bdfc19c8a8448f80de52deaf87d"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"f2aa65ebd5656c2bcb46892fd9111c92bbe30256","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  $use_multipath_for_image_xfer \u003d true,"},{"line_number":106,"context_line":"  $extra_options                \u003d {},"},{"line_number":107,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":108,"context_line":"  $excluded_domain_ip           \u003d $::os_service_default,"},{"line_number":109,"context_line":") {"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  include ::cinder::deps"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3f79a3b5_696e58c9","line":108,"in_reply_to":"3f79a3b5_e32939f1","updated":"2018-10-09 16:37:23.000000000","message":"I remember changing the code, don\u0027t know where I missed. Thanks , will fix it now","commit_id":"49d5669d9c939bdfc19c8a8448f80de52deaf87d"}],"spec/defines/cinder_backend_dellsc_iscsi_spec.rb":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9040d1edc1d3e3a9b11f325a4ef20e3a077d91ec","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      :dell_sc_volume_folder  \u003d\u003e \u0027vol\u0027,"},{"line_number":25,"context_line":"      :iscsi_port             \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":26,"context_line":"      :excluded_domain_ip     \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":27,"context_line":"      :excluded_domain_ips    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":28,"context_line":"      :secondary_san_ip       \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":29,"context_line":"      :secondary_san_login    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":30,"context_line":"      :secondary_san_password \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3f79a3b5_57234eab","line":27,"updated":"2018-09-21 20:57:03.000000000","message":"This is fine, but there\u0027s an opportunity to improve the overall test coverage by adding tests that override some of the default input values (see \"describe \u0027emc vnx backend overriding some parameters\u0027\" in cinder_backend_emc_vnx_spec.rb for an example).\n\nThis is just a suggestion for a future improvement.","commit_id":"220144ab0db86c41a2531c5503e894ee1e08ef2b"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"aac2f9ee1bc639f49535e666edcb3c946441d39a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      :dell_sc_volume_folder  \u003d\u003e \u0027vol\u0027,"},{"line_number":25,"context_line":"      :iscsi_port             \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":26,"context_line":"      :excluded_domain_ip     \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":27,"context_line":"      :excluded_domain_ips    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":28,"context_line":"      :secondary_san_ip       \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":29,"context_line":"      :secondary_san_login    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":30,"context_line":"      :secondary_san_password \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3f79a3b5_8d468b50","line":27,"in_reply_to":"3f79a3b5_57234eab","updated":"2018-09-25 14:35:07.000000000","message":"ok","commit_id":"220144ab0db86c41a2531c5503e894ee1e08ef2b"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"b0168065c123daffbdffce42313849bb61027fd6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      :secondary_san_login    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":29,"context_line":"      :secondary_san_password \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":30,"context_line":"      :secondary_sc_api_port  \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":31,"context_line":"      :excluded_domain_ip     \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":"  end"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3f79a3b5_3b064d87","line":31,"range":{"start_line":31,"start_character":2,"end_line":31,"end_character":53},"updated":"2018-09-27 22:02:04.000000000","message":"can both excluded_domain_ip and excluded_domain_ips be defaults?\u003e","commit_id":"14c213de16a5b51dd7ec6555bfb2c4bd8c399faa"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"ffe46e47df234e60b2fffe99cc720d04a455ac6a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      :secondary_san_login    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":29,"context_line":"      :secondary_san_password \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":30,"context_line":"      :secondary_sc_api_port  \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":31,"context_line":"      :excluded_domain_ip     \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":"  end"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3f79a3b5_5e3e85b9","line":31,"range":{"start_line":31,"start_character":2,"end_line":31,"end_character":53},"in_reply_to":"3f79a3b5_3b064d87","updated":"2018-09-28 15:26:29.000000000","message":"They are optional. So they default to empty list","commit_id":"14c213de16a5b51dd7ec6555bfb2c4bd8c399faa"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c6ec5f265a7b75e74295c13643361f5a03fe38db","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      :secondary_san_password       \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":30,"context_line":"      :secondary_sc_api_port        \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":31,"context_line":"      :use_multipath_for_image_xfer \u003d\u003e \u0027true\u0027,"},{"line_number":32,"context_line":"      :excluded_domain_ip           \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":33,"context_line":"    }"},{"line_number":34,"context_line":"  end"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":11,"id":"3f79a3b5_e074b639","line":32,"updated":"2018-10-09 20:33:00.000000000","message":"This is causing unit test to fail.\nhttp://logs.openstack.org/84/604384/11/check/puppet-openstack-unit-4.8-centos-7/e6a3f3e/job-output.txt.gz#_2018-10-09_18_07_21_644632","commit_id":"a355a694315240adf42956af3515f05e665dd926"}]}