)]}'
{"manifests/backend/rbd.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"94f00bd70522c1464bbaa2deed45ff6fc385bffe","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  include ::cinder::deps"},{"line_number":90,"context_line":"  include ::cinder::params"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  $rbd_ceph_conf_filename \u003d split($rbd_ceph_conf, \u0027/\u0027)[-1]"},{"line_number":93,"context_line":"  $rbd_cluster_name \u003d split($rbd_ceph_conf_filename, \u0027.conf\u0027)[0]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  cinder_config {"},{"line_number":96,"context_line":"    \"${name}/volume_backend_name\":              value \u003d\u003e $volume_backend_name;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_156e1c97","line":93,"range":{"start_line":92,"start_character":2,"end_line":93,"end_character":64},"updated":"2018-10-05 11:29:50.000000000","message":"Since we have stdlib this could be simplified to: basename($rbd_ceph_conf, \u0027.conf\u0027)\n\nNow we dont have a way to ensure that the ceph config is a valid path but basename supports both relative and absolute paths.\n\nThe other thing would be to add a validate_absolute_path() call to validate $rbd_ceph_conf, but adding that logic is probably considered a breaking change, and also that function itself is deprecated so for Puppet 4/5 which we support now the correct way would be changing $rbd_ceph_conf to Stdlib::AbsolutePath data type.\n\nI\u0027m all for this change after some cleanup.","commit_id":"b6f67dd106ceb0c73a346acb4e8e43997c2ae3e9"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"91da15acacbcf17c4c2578481c0fcc6fe105d0dd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  include ::cinder::deps"},{"line_number":90,"context_line":"  include ::cinder::params"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  $rbd_ceph_conf_filename \u003d split($rbd_ceph_conf, \u0027/\u0027)[-1]"},{"line_number":93,"context_line":"  $rbd_cluster_name \u003d split($rbd_ceph_conf_filename, \u0027.conf\u0027)[0]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  cinder_config {"},{"line_number":96,"context_line":"    \"${name}/volume_backend_name\":              value \u003d\u003e $volume_backend_name;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_d598a477","line":93,"range":{"start_line":92,"start_character":2,"end_line":93,"end_character":64},"in_reply_to":"3f79a3b5_156e1c97","updated":"2018-10-05 11:42:19.000000000","message":"great, will do thanks","commit_id":"b6f67dd106ceb0c73a346acb4e8e43997c2ae3e9"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c1fe5b6afba20263487941794e50e8be0c40c817","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  include ::cinder::deps"},{"line_number":90,"context_line":"  include ::cinder::params"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  $rbd_cluster_name \u003d basename($rbd_ceph_conf, \u0027.conf\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  cinder_config {"},{"line_number":95,"context_line":"    \"${name}/volume_backend_name\":              value \u003d\u003e $volume_backend_name;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_d7f38c6c","line":92,"updated":"2018-10-09 11:30:59.000000000","message":"do you guys think having a condition here to map \u0027ceph\u0027 to $::os_service_default would avoid service restarts for the deployments which didn\u0027t change it from \u0027ceph\u0027 ?","commit_id":"c1cca47f97569e89a960a777904b085f51f1cdc6"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"cb5e7e0cc2d187b55d88497aeb07eb03c8c69a8e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  include ::cinder::deps"},{"line_number":90,"context_line":"  include ::cinder::params"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  $rbd_cluster_name \u003d basename($rbd_ceph_conf, \u0027.conf\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  cinder_config {"},{"line_number":95,"context_line":"    \"${name}/volume_backend_name\":              value \u003d\u003e $volume_backend_name;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_c212ec55","line":92,"in_reply_to":"3f79a3b5_d7f38c6c","updated":"2018-10-09 11:43:47.000000000","message":"I have no problem with anything that avoids a restart given the fact that \u0027ceph\u0027 is well known to be the service default.\n\nOne idea that also comes to mind could look something like this:\n\nif $rbd_cluster_name \u003d\u003d \u0027ceph\u0027 {\n  # Do not pass a parameter value in order to avoid service restarts\n  $rbd_cluster_name_real \u003d undef\n} else {\n  $rbd_cluster_name_real \u003d $rbd_cluster_name\n}","commit_id":"c1cca47f97569e89a960a777904b085f51f1cdc6"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"953289ef5b3a4f6d21e2d50f8bb8d675e11ab4c4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  include ::cinder::params"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  $rbd_cluster_name \u003d basename($rbd_ceph_conf, \u0027.conf\u0027)"},{"line_number":100,"context_line":"  if $rbd_cluster_name \u003d\u003d \u0027ceph\u0027 {"},{"line_number":101,"context_line":"    # Do not pass a parameter value in order to avoid service restarts"},{"line_number":102,"context_line":"    $rbd_cluster_name_real \u003d undef"},{"line_number":103,"context_line":"  } else {"},{"line_number":104,"context_line":"    $rbd_cluster_name_real \u003d $rbd_cluster_name"},{"line_number":105,"context_line":"  }"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  cinder_config {"},{"line_number":108,"context_line":"    \"${name}/volume_backend_name\":              value \u003d\u003e $volume_backend_name;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_9544f31a","line":105,"range":{"start_line":100,"start_character":0,"end_line":105,"end_character":3},"updated":"2018-10-11 12:07:40.000000000","message":"I think we need to agree if we should just backport this change plain or introduce something like this.\n\nWe need this in master, but might want to in backports. I don\u0027t think it\u0027s a big deal to backport this and cause restarts since I\u0027ve warned on ML but it\u0027s generally a bad thing so I\u0027m all in favor of doing this in stable backports.","commit_id":"662ec3aef125f6032a9940771dad64fa4d37496d"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5b2236bc52b968268d3e591b1d22701d9676ff98","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  include ::cinder::params"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  $rbd_cluster_name \u003d basename($rbd_ceph_conf, \u0027.conf\u0027)"},{"line_number":100,"context_line":"  if $rbd_cluster_name \u003d\u003d \u0027ceph\u0027 {"},{"line_number":101,"context_line":"    # Do not pass a parameter value in order to avoid service restarts"},{"line_number":102,"context_line":"    $rbd_cluster_name_real \u003d undef"},{"line_number":103,"context_line":"  } else {"},{"line_number":104,"context_line":"    $rbd_cluster_name_real \u003d $rbd_cluster_name"},{"line_number":105,"context_line":"  }"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  cinder_config {"},{"line_number":108,"context_line":"    \"${name}/volume_backend_name\":              value \u003d\u003e $volume_backend_name;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_8cae22e2","line":105,"range":{"start_line":100,"start_character":0,"end_line":105,"end_character":3},"in_reply_to":"3f79a3b5_9544f31a","updated":"2018-10-11 22:08:10.000000000","message":"Tobias are you suggesting we add this condition only to the backports? I am not against but I think I\u0027d prefer to see same code in master as well.","commit_id":"662ec3aef125f6032a9940771dad64fa4d37496d"}]}