)]}'
{"manifests/backend/bdd.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"28d7166bf0cc534f9bbec7d5695b109d50060aac","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    warning(\u0027Cinder block device driver is deprecated. Please use LVM backend\u0027)"},{"line_number":110,"context_line":"  }"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  if $iscsi_ip_address {"},{"line_number":113,"context_line":"    warning(\u0027The iscsi_ip_address parameter is deprecated, has no effect and will be removed in the future release.\u0027)"},{"line_number":114,"context_line":"    # Note: $target_ip_address is a required parameter."},{"line_number":115,"context_line":"  }"},{"line_number":116,"context_line":"  "},{"line_number":117,"context_line":"  if $iscsi_helper {"},{"line_number":118,"context_line":"    warning(\u0027The iscsi_helper parameter is deprecated, use target_helper instead.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_be7b7df1","line":115,"range":{"start_line":112,"start_character":0,"end_line":115,"end_character":3},"updated":"2018-10-31 16:32:48.000000000","message":"still need to support iscsi_ip_address for one release","commit_id":"bdda30fc5b0e7592c1bfee3c681cb3313832acec"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1078cb5d31005a6dbc8b79abc0ee267e4d689b1a","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    warning(\u0027Cinder block device driver is deprecated. Please use LVM backend\u0027)"},{"line_number":110,"context_line":"  }"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  if $iscsi_ip_address {"},{"line_number":113,"context_line":"    warning(\u0027The iscsi_ip_address parameter is deprecated, has no effect and will be removed in the future release.\u0027)"},{"line_number":114,"context_line":"    # Note: $target_ip_address is a required parameter."},{"line_number":115,"context_line":"  }"},{"line_number":116,"context_line":"  "},{"line_number":117,"context_line":"  if $iscsi_helper {"},{"line_number":118,"context_line":"    warning(\u0027The iscsi_helper parameter is deprecated, use target_helper instead.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_d2d5081c","line":115,"range":{"start_line":112,"start_character":0,"end_line":115,"end_character":3},"in_reply_to":"3f79a3b5_7e8165a1","updated":"2018-10-31 19:17:58.000000000","message":"Done","commit_id":"bdda30fc5b0e7592c1bfee3c681cb3313832acec"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"701e01db884b027529009dfeb26526da5416c5f7","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    warning(\u0027Cinder block device driver is deprecated. Please use LVM backend\u0027)"},{"line_number":110,"context_line":"  }"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  if $iscsi_ip_address {"},{"line_number":113,"context_line":"    warning(\u0027The iscsi_ip_address parameter is deprecated, has no effect and will be removed in the future release.\u0027)"},{"line_number":114,"context_line":"    # Note: $target_ip_address is a required parameter."},{"line_number":115,"context_line":"  }"},{"line_number":116,"context_line":"  "},{"line_number":117,"context_line":"  if $iscsi_helper {"},{"line_number":118,"context_line":"    warning(\u0027The iscsi_helper parameter is deprecated, use target_helper instead.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_7e8165a1","line":115,"range":{"start_line":112,"start_character":0,"end_line":115,"end_character":3},"in_reply_to":"3f79a3b5_be7b7df1","updated":"2018-10-31 16:38:40.000000000","message":"Yeah, wasn\u0027t sure if I was taking the right approach. Would this work? Make both target_ip_address and iscsi_ip_address individually optional, but then add a check to ensure at least one of them is set?","commit_id":"bdda30fc5b0e7592c1bfee3c681cb3313832acec"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"28d7166bf0cc534f9bbec7d5695b109d50060aac","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    warning(\u0027The iscsi_ip_address parameter is deprecated, has no effect and will be removed in the future release.\u0027)"},{"line_number":114,"context_line":"    # Note: $target_ip_address is a required parameter."},{"line_number":115,"context_line":"  }"},{"line_number":116,"context_line":"  "},{"line_number":117,"context_line":"  if $iscsi_helper {"},{"line_number":118,"context_line":"    warning(\u0027The iscsi_helper parameter is deprecated, use target_helper instead.\u0027)"},{"line_number":119,"context_line":"    $target_helper_real \u003d $iscsi_helper"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_1e77110a","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":2},"updated":"2018-10-31 16:32:48.000000000","message":"nit","commit_id":"bdda30fc5b0e7592c1bfee3c681cb3313832acec"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"701e01db884b027529009dfeb26526da5416c5f7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    warning(\u0027The iscsi_ip_address parameter is deprecated, has no effect and will be removed in the future release.\u0027)"},{"line_number":114,"context_line":"    # Note: $target_ip_address is a required parameter."},{"line_number":115,"context_line":"  }"},{"line_number":116,"context_line":"  "},{"line_number":117,"context_line":"  if $iscsi_helper {"},{"line_number":118,"context_line":"    warning(\u0027The iscsi_helper parameter is deprecated, use target_helper instead.\u0027)"},{"line_number":119,"context_line":"    $target_helper_real \u003d $iscsi_helper"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_9ea7a152","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":2},"in_reply_to":"3f79a3b5_1e77110a","updated":"2018-10-31 16:38:40.000000000","message":"Ack. I spotted this, and just forgot to \"git add\" to update the patch.","commit_id":"bdda30fc5b0e7592c1bfee3c681cb3313832acec"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1078cb5d31005a6dbc8b79abc0ee267e4d689b1a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    warning(\u0027The iscsi_ip_address parameter is deprecated, has no effect and will be removed in the future release.\u0027)"},{"line_number":114,"context_line":"    # Note: $target_ip_address is a required parameter."},{"line_number":115,"context_line":"  }"},{"line_number":116,"context_line":"  "},{"line_number":117,"context_line":"  if $iscsi_helper {"},{"line_number":118,"context_line":"    warning(\u0027The iscsi_helper parameter is deprecated, use target_helper instead.\u0027)"},{"line_number":119,"context_line":"    $target_helper_real \u003d $iscsi_helper"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_f2da8448","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":2},"in_reply_to":"3f79a3b5_9ea7a152","updated":"2018-10-31 19:17:58.000000000","message":"Done","commit_id":"bdda30fc5b0e7592c1bfee3c681cb3313832acec"}],"manifests/backend/dellsc_iscsi.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"28d7166bf0cc534f9bbec7d5695b109d50060aac","unresolved":false,"context_lines":[{"line_number":138,"context_line":"default of \\\"vol\\\" and will be changed to the upstream OpenStack default in N-release.\")"},{"line_number":139,"context_line":"  }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  if $iscsi_ip_address {"},{"line_number":142,"context_line":"    warning(\u0027The iscsi_ip_address parameter is deprecated, has no effect and will be removed in the future release.\u0027)"},{"line_number":143,"context_line":"    # Note: $target_ip_address is a required parameter."},{"line_number":144,"context_line":"  }"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  if $iscsi_port {"},{"line_number":147,"context_line":"    warning(\u0027The iscsi_port parameter is deprecated, use target_port instead.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_5e6ca932","line":144,"range":{"start_line":141,"start_character":0,"end_line":144,"end_character":3},"updated":"2018-10-31 16:32:48.000000000","message":"still need to support iscsi_ip_address for one release","commit_id":"bdda30fc5b0e7592c1bfee3c681cb3313832acec"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1078cb5d31005a6dbc8b79abc0ee267e4d689b1a","unresolved":false,"context_lines":[{"line_number":138,"context_line":"default of \\\"vol\\\" and will be changed to the upstream OpenStack default in N-release.\")"},{"line_number":139,"context_line":"  }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  if $iscsi_ip_address {"},{"line_number":142,"context_line":"    warning(\u0027The iscsi_ip_address parameter is deprecated, has no effect and will be removed in the future release.\u0027)"},{"line_number":143,"context_line":"    # Note: $target_ip_address is a required parameter."},{"line_number":144,"context_line":"  }"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  if $iscsi_port {"},{"line_number":147,"context_line":"    warning(\u0027The iscsi_port parameter is deprecated, use target_port instead.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_52e9f8e1","line":144,"range":{"start_line":141,"start_character":0,"end_line":144,"end_character":3},"in_reply_to":"3f79a3b5_5e6ca932","updated":"2018-10-31 19:17:58.000000000","message":"Done","commit_id":"bdda30fc5b0e7592c1bfee3c681cb3313832acec"}],"manifests/backend/iscsi.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"28d7166bf0cc534f9bbec7d5695b109d50060aac","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  if $iscsi_ip_address {"},{"line_number":95,"context_line":"    warning(\u0027The iscsi_ip_address parameter is deprecated, has no effect and will be removed in the future release.\u0027)"},{"line_number":96,"context_line":"    # Note: $target_ip_address is a required parameter."},{"line_number":97,"context_line":"  }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  if $iscsi_helper {"},{"line_number":100,"context_line":"    warning(\u0027The iscsi_helper parameter is deprecated, use target_helper instead.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_fe5a5583","line":97,"range":{"start_line":94,"start_character":0,"end_line":97,"end_character":3},"updated":"2018-10-31 16:32:48.000000000","message":"still need to support iscsi_ip_address for one release","commit_id":"bdda30fc5b0e7592c1bfee3c681cb3313832acec"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1078cb5d31005a6dbc8b79abc0ee267e4d689b1a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  if $iscsi_ip_address {"},{"line_number":95,"context_line":"    warning(\u0027The iscsi_ip_address parameter is deprecated, has no effect and will be removed in the future release.\u0027)"},{"line_number":96,"context_line":"    # Note: $target_ip_address is a required parameter."},{"line_number":97,"context_line":"  }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  if $iscsi_helper {"},{"line_number":100,"context_line":"    warning(\u0027The iscsi_helper parameter is deprecated, use target_helper instead.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_72e67416","line":97,"range":{"start_line":94,"start_character":0,"end_line":97,"end_character":3},"in_reply_to":"3f79a3b5_fe5a5583","updated":"2018-10-31 19:17:58.000000000","message":"Done","commit_id":"bdda30fc5b0e7592c1bfee3c681cb3313832acec"}],"releasenotes/notes/deprecate-iscsi-parameters-9b091c7207694e4c.yaml":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"28d7166bf0cc534f9bbec7d5695b109d50060aac","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    * target_port"},{"line_number":19,"context_line":"    * target_helper"},{"line_number":20,"context_line":"    * target_protocol"},{"line_number":21,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_9e4b21b1","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":4},"updated":"2018-10-31 16:32:48.000000000","message":"nit","commit_id":"bdda30fc5b0e7592c1bfee3c681cb3313832acec"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1078cb5d31005a6dbc8b79abc0ee267e4d689b1a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    * target_port"},{"line_number":19,"context_line":"    * target_helper"},{"line_number":20,"context_line":"    * target_protocol"},{"line_number":21,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_d2ae68a0","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":4},"in_reply_to":"3f79a3b5_9e4b21b1","updated":"2018-10-31 19:17:58.000000000","message":"Done","commit_id":"bdda30fc5b0e7592c1bfee3c681cb3313832acec"}]}