)]}'
{"manifests/backend/dellsc_iscsi.pp":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"7182df9120c04e2078b78a3e97897d85a19b435d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  $secondary_san_password       \u003d $::os_service_default,"},{"line_number":97,"context_line":"  $secondary_sc_api_port        \u003d $::os_service_default,"},{"line_number":98,"context_line":"  $manage_volume_type           \u003d false,"},{"line_number":99,"context_line":"  $use_multipath_for_image_xfer \u003d true,"},{"line_number":100,"context_line":"  $extra_options          \u003d {},"},{"line_number":101,"context_line":") {"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_9faa386b","line":99,"range":{"start_line":99,"start_character":2,"end_line":99,"end_character":39},"updated":"2018-10-31 21:17:04.000000000","message":"do we really want to have this true for previous versions?\nI would expect we want to preserve existing behavior.","commit_id":"245c0385969b080ecd637b59ce21d2087b466e68"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"75f9987215eebae7fcdc1b255cde2054d8184ae5","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  $secondary_san_password       \u003d $::os_service_default,"},{"line_number":97,"context_line":"  $secondary_sc_api_port        \u003d $::os_service_default,"},{"line_number":98,"context_line":"  $manage_volume_type           \u003d false,"},{"line_number":99,"context_line":"  $use_multipath_for_image_xfer \u003d true,"},{"line_number":100,"context_line":"  $extra_options          \u003d {},"},{"line_number":101,"context_line":") {"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_e2f71328","line":99,"range":{"start_line":99,"start_character":2,"end_line":99,"end_character":39},"in_reply_to":"3f79a3b5_9faa386b","updated":"2018-10-31 21:50:13.000000000","message":"This is a cherry-pick, cannot change the code. This is just default. When the value is passed from the triplo templates for deployment, we can control there","commit_id":"245c0385969b080ecd637b59ce21d2087b466e68"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"19cdccfac4e8d0d3b4702e3eaef23cd3a44c722b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  $secondary_san_password       \u003d $::os_service_default,"},{"line_number":97,"context_line":"  $secondary_sc_api_port        \u003d $::os_service_default,"},{"line_number":98,"context_line":"  $manage_volume_type           \u003d false,"},{"line_number":99,"context_line":"  $use_multipath_for_image_xfer \u003d $::os_service_default,"},{"line_number":100,"context_line":"  $extra_options          \u003d {},"},{"line_number":101,"context_line":") {"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f79a3b5_5835f2a5","line":99,"range":{"start_line":99,"start_character":34,"end_line":99,"end_character":56},"updated":"2018-11-27 03:35:30.000000000","message":"should this be false as default value?","commit_id":"45ed10ff628c73577d7c7a1985baed7dae73ce6b"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"b6014cda25143e356e1a1f00552c18a37bf42f51","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  $secondary_san_password       \u003d $::os_service_default,"},{"line_number":97,"context_line":"  $secondary_sc_api_port        \u003d $::os_service_default,"},{"line_number":98,"context_line":"  $manage_volume_type           \u003d false,"},{"line_number":99,"context_line":"  $use_multipath_for_image_xfer \u003d $::os_service_default,"},{"line_number":100,"context_line":"  $extra_options          \u003d {},"},{"line_number":101,"context_line":") {"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f79a3b5_3ef49455","line":99,"range":{"start_line":99,"start_character":34,"end_line":99,"end_character":56},"in_reply_to":"3f79a3b5_5835f2a5","updated":"2018-11-27 15:11:52.000000000","message":"Tobias suggested we use os_service_default. os_service_default defaults to false if unconfigured)","commit_id":"45ed10ff628c73577d7c7a1985baed7dae73ce6b"}],"releasenotes/notes/dellsc-driver-a7cd300a24a64b01.yaml":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"7182df9120c04e2078b78a3e97897d85a19b435d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    This change implements the documented best practice to use multipath"},{"line_number":5,"context_line":"    with a Cinder deployment by setting a Cinder configuration setting"},{"line_number":6,"context_line":"    to ensure that multipath is appropriately used by the Dell EMC"},{"line_number":7,"context_line":"    SC iSCSI driver. Multipath is true by default."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_5fc4a042","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":50},"updated":"2018-10-31 21:17:04.000000000","message":"ditto","commit_id":"245c0385969b080ecd637b59ce21d2087b466e68"}],"spec/defines/cinder_backend_dellsc_iscsi_spec.rb":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"7182df9120c04e2078b78a3e97897d85a19b435d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      :secondary_san_login          \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":29,"context_line":"      :secondary_san_password       \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":30,"context_line":"      :secondary_sc_api_port        \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":31,"context_line":"      :use_multipath_for_image_xfer \u003d\u003e \u0027true\u0027,"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":"  end"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_1fbe28af","line":31,"range":{"start_line":31,"start_character":38,"end_line":31,"end_character":46},"updated":"2018-10-31 21:17:04.000000000","message":"I think it is OK for testing.","commit_id":"245c0385969b080ecd637b59ce21d2087b466e68"}]}