)]}'
{"manifests/db.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0180e993adbefc1bef8ef6dc8abe647d42e66c64","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"},{"line_number":65,"context_line":"  # to use cinder::\u003cmyparam\u003e if cinder::db::\u003cmyparam\u003e isn\u0027t specified."},{"line_number":66,"context_line":"  $database_connection_real     \u003d pick($::cinder::database_connection,$database_connection)"},{"line_number":67,"context_line":"  $database_idle_timeout_real   \u003d pick($::cinder::database_idle_timeout,$database_idle_timeout)"},{"line_number":68,"context_line":"  $database_min_pool_size_real  \u003d pick($::cinder::database_min_pool_size,$database_min_pool_size)"},{"line_number":69,"context_line":"  $database_max_pool_size_real  \u003d pick($::cinder::database_max_pool_size,$database_max_pool_size)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fce034c_2a896f74","line":66,"updated":"2019-04-12 14:06:21.000000000","message":"Ah, the cinder::database_XXX parameters appear to be a legacy. The slave_connection is a new parameters, and doesn\u0027t need to pick.\n\nTherefore, as I noted in my init.pp comment, I think the slave_connection parameter can be removed from init.pp. There is no legacy to preserve (it\u0027s a new parameter).","commit_id":"b3e3d4acb31128f57dfe0ae18c770ff31eb1d9f9"}],"manifests/init.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6c6fde9ca64469c3564ba1caa51df235e1bdea0f","unresolved":false,"context_lines":[{"line_number":245,"context_line":"#"},{"line_number":246,"context_line":"class cinder ("},{"line_number":247,"context_line":"  $database_connection                \u003d undef,"},{"line_number":248,"context_line":"  $slave_connection                   \u003d undef,"},{"line_number":249,"context_line":"  $database_idle_timeout              \u003d undef,"},{"line_number":250,"context_line":"  $database_min_pool_size             \u003d undef,"},{"line_number":251,"context_line":"  $database_max_pool_size             \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fce034c_df0d0b38","line":248,"updated":"2019-04-12 13:21:50.000000000","message":"While it seems benign, is this parameter necessary? The only one that seems relevant to me is the one in db.pp.","commit_id":"b3e3d4acb31128f57dfe0ae18c770ff31eb1d9f9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"93a5e2c408c45ef3fd85ec962b0411902a8f7a4b","unresolved":false,"context_lines":[{"line_number":245,"context_line":"#"},{"line_number":246,"context_line":"class cinder ("},{"line_number":247,"context_line":"  $database_connection                \u003d undef,"},{"line_number":248,"context_line":"  $slave_connection                   \u003d undef,"},{"line_number":249,"context_line":"  $database_idle_timeout              \u003d undef,"},{"line_number":250,"context_line":"  $database_min_pool_size             \u003d undef,"},{"line_number":251,"context_line":"  $database_max_pool_size             \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fce034c_5fa83b1e","line":248,"in_reply_to":"3fce034c_5f47db4c","updated":"2019-04-12 13:56:04.000000000","message":"Sure, I just don\u0027t see any of the $database_XXX parameters used in this module (the ones in db.pp ARE used). Maybe it\u0027s a puppet thing I\u0027m not familiar with? I\u0027m not a puppet expert.","commit_id":"b3e3d4acb31128f57dfe0ae18c770ff31eb1d9f9"},{"author":{"_account_id":27442,"name":"Quentin GROLLEAU","email":"quentin.grolleau@corp.ovh.com","username":"QG"},"change_message_id":"f874f0168c54de0237f9eb0789d2178aa4371f66","unresolved":false,"context_lines":[{"line_number":245,"context_line":"#"},{"line_number":246,"context_line":"class cinder ("},{"line_number":247,"context_line":"  $database_connection                \u003d undef,"},{"line_number":248,"context_line":"  $slave_connection                   \u003d undef,"},{"line_number":249,"context_line":"  $database_idle_timeout              \u003d undef,"},{"line_number":250,"context_line":"  $database_min_pool_size             \u003d undef,"},{"line_number":251,"context_line":"  $database_max_pool_size             \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fce034c_5f47db4c","line":248,"in_reply_to":"3fce034c_df0d0b38","updated":"2019-04-12 13:25:01.000000000","message":"It was just to configure the DB connection and the slave in the same place","commit_id":"b3e3d4acb31128f57dfe0ae18c770ff31eb1d9f9"}]}