)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a75437977bede5a3dbe2a0c668a5da361ecba5e4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Radu Pantiru \u003cradupantiru@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-30 14:29:47 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"adding description related to if not defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I94e8ee30cadcd0882fc0ef423a3a3bee12c84f99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_85acbced","line":7,"updated":"2019-07-30 13:54:14.000000000","message":"This doesn\u0027t seem sufficient. See my comment in iscsi.pp.","commit_id":"2452acad746a33f4b859e6655642500265ecf5aa"}],"manifests/backend/iscsi.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a75437977bede5a3dbe2a0c668a5da361ecba5e4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  # NOTE(mnaser): Cinder requires /usr/sbin/thin_check to create volumes which"},{"line_number":90,"context_line":"  #               does not get installed with Cinder (see LP#1615134)."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"\t# NOTE(radupantiru): If ! defined() is required for using this defined type"},{"line_number":93,"context_line":"  #\t\t\t\t\t\t\t\t\t\t more than once.\t "},{"line_number":94,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"},{"line_number":95,"context_line":"    if ! defined(Package[\u0027thin-provisioning-tools\u0027]) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7faddb67_052e8c91","line":92,"updated":"2019-07-30 13:54:14.000000000","message":"I think this comment should be part of the commit message. It should also explain _why_ the checks are being added. That is, they are necessary to avoid duplicate resource errors when using multiples instances of the iSCSI backend.","commit_id":"2452acad746a33f4b859e6655642500265ecf5aa"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a75437977bede5a3dbe2a0c668a5da361ecba5e4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  #               does not get installed with Cinder (see LP#1615134)."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"\t# NOTE(radupantiru): If ! defined() is required for using this defined type"},{"line_number":93,"context_line":"  #\t\t\t\t\t\t\t\t\t\t more than once.\t "},{"line_number":94,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"},{"line_number":95,"context_line":"    if ! defined(Package[\u0027thin-provisioning-tools\u0027]) {"},{"line_number":96,"context_line":"      package { \u0027thin-provisioning-tools\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7faddb67_c52394a6","line":93,"updated":"2019-07-30 13:54:14.000000000","message":"Remove this (looks like cruft from your editor?)","commit_id":"2452acad746a33f4b859e6655642500265ecf5aa"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a75437977bede5a3dbe2a0c668a5da361ecba5e4","unresolved":false,"context_lines":[{"line_number":172,"context_line":"      }"},{"line_number":173,"context_line":"    }"},{"line_number":174,"context_line":"    \u0027lioadm\u0027: {"},{"line_number":175,"context_line":"    if ! defined(Service[\u0027target\u0027]) {"},{"line_number":176,"context_line":"      service { \u0027target\u0027:"},{"line_number":177,"context_line":"        ensure \u003d\u003e running,"},{"line_number":178,"context_line":"        enable \u003d\u003e true,"},{"line_number":179,"context_line":"        tag    \u003d\u003e \u0027cinder-support-service\u0027,"},{"line_number":180,"context_line":"      }"},{"line_number":181,"context_line":"    }"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"      if ! defined(Package[\u0027targetcli\u0027]) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7faddb67_452fa487","line":180,"range":{"start_line":175,"start_character":0,"end_line":180,"end_character":7},"updated":"2019-07-30 13:54:14.000000000","message":"This should be indented (as you did with the others).","commit_id":"2452acad746a33f4b859e6655642500265ecf5aa"}]}