)]}'
{"manifests/backend/dellsc_iscsi.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5183d155fffa4b0fba20ece558d9e6737bf8fa38","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#   Defaults to true."},{"line_number":92,"context_line":"#"},{"line_number":93,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":94,"context_line":"# [*excluded_domain_ip*]"},{"line_number":95,"context_line":"#   (optional) Domain IP to be excluded from iSCSI returns of Storage Center."},{"line_number":96,"context_line":"#   Defaults to undef."},{"line_number":97,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7faddb67_99d8c8f0","side":"PARENT","line":94,"updated":"2019-08-28 17:22:18.000000000","message":"This one is still marked as deprecated in the cinder code, but the vendor has not yet removed the option. Also, puppet-tripleo needs a patch or else this will break puppet-tripleo.\n\nI will submit a patch to puppet-tripleo, but another option is to leave this parameter in puppet-cinder until the vendor actually removes it from cinder.","commit_id":"fa5dec5df1383d9d5bb718a1a42c59ad2bc2de44"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"db5fc01fc5c5d69c5e5c9eb7c657d235cfe892a3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#   Defaults to true."},{"line_number":92,"context_line":"#"},{"line_number":93,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":94,"context_line":"# [*excluded_domain_ip*]"},{"line_number":95,"context_line":"#   (optional) Domain IP to be excluded from iSCSI returns of Storage Center."},{"line_number":96,"context_line":"#   Defaults to undef."},{"line_number":97,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7faddb67_756aa01b","side":"PARENT","line":94,"in_reply_to":"7faddb67_268ba41e","updated":"2019-08-29 14:20:26.000000000","message":"https://review.opendev.org/679246 cleans up puppet-tripleo, and it\u0027s not dependent on this patch. If the puppet-tripleo patch lands first then \u0027excluded_domain_ip\u0027 can be removed.","commit_id":"fa5dec5df1383d9d5bb718a1a42c59ad2bc2de44"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"224eca9df9ad24a4222b4883c7ebf413d06ce21e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#   Defaults to true."},{"line_number":92,"context_line":"#"},{"line_number":93,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":94,"context_line":"# [*excluded_domain_ip*]"},{"line_number":95,"context_line":"#   (optional) Domain IP to be excluded from iSCSI returns of Storage Center."},{"line_number":96,"context_line":"#   Defaults to undef."},{"line_number":97,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7faddb67_268ba41e","side":"PARENT","line":94,"in_reply_to":"7faddb67_99d8c8f0","updated":"2019-08-29 07:59:56.000000000","message":"Good point Alan, never thought about that. I don\u0027t think we have a policy for that but personally if excluded_domain_ips is working I don\u0027t see why we couldn\u0027t remove excluded_domain_ip and be prepared for it. I\u0027m fine with leaving it as well.\n\nThanks for checking the puppet-tripleo part :)","commit_id":"fa5dec5df1383d9d5bb718a1a42c59ad2bc2de44"}]}