)]}'
{"id":"openstack%2Fpuppet-cinder~688413","triplet_id":"openstack%2Fpuppet-cinder~master~If33825a3dae0dfd53e058d1d8277cee4a0423ea1","project":"openstack/puppet-cinder","branch":"master","topic":"bug/1432387","hashtags":[],"change_id":"If33825a3dae0dfd53e058d1d8277cee4a0423ea1","subject":"Ensure to remove cinder\u0027s outdated lock files left behind by a volume deletion.","status":"ABANDONED","created":"2019-10-14 14:38:54.000000000","updated":"2020-04-22 16:33:57.000000000","total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cb232f3460f437b430d28a15af3bf33b49b1f668","_number":688413,"virtual_id_number":688413,"owner":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2019-10-15 17:33:07.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-10-15 16:04:34.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"date":"2019-10-15 17:28:41.000000000","_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"_account_id":17823,"name":"Michele Baldessari","email":"michele@redhat.com","username":"mbaldessari"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17823,"name":"Michele Baldessari","email":"michele@redhat.com","username":"mbaldessari"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"_account_id":17823,"name":"Michele Baldessari","email":"michele@redhat.com","username":"mbaldessari"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":-1,"date":"2019-10-17 09:14:14.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":17823,"name":"Michele Baldessari","email":"michele@redhat.com","username":"mbaldessari"},{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-14 14:43:38.000000000","updated_by":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"reviewer":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"state":"REVIEWER"},{"updated":"2019-10-14 14:50:03.000000000","updated_by":{"_account_id":17823,"name":"Michele Baldessari","email":"michele@redhat.com","username":"mbaldessari"},"reviewer":{"_account_id":17823,"name":"Michele Baldessari","email":"michele@redhat.com","username":"mbaldessari"},"state":"REVIEWER"},{"updated":"2019-10-14 15:02:06.000000000","updated_by":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"reviewer":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"state":"REVIEWER"},{"updated":"2019-10-14 18:00:22.000000000","updated_by":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"reviewer":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"state":"REVIEWER"},{"updated":"2019-10-15 13:06:27.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2019-10-15 13:09:31.000000000","updated_by":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"reviewer":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"state":"REVIEWER"},{"updated":"2019-10-15 14:52:10.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"},{"updated":"2019-10-15 16:04:34.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-10-15 17:28:41.000000000","updated_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"},{"updated":"2019-10-15 17:33:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4c2882b38e78eccd60acb07530c5a7e775502bd3","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-14 14:38:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c5c7a3bfb08c4b57498d0a2eecb8cd5d6073cd23","author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"date":"2019-10-14 15:02:06.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"de04fb7edf6edbafea7f0eca661b43716c495d18","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2019-10-14 15:14:44.000000000","message":"Patch Set 1: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"2d242b77955420cdeef449bc8d6f931b358a7783","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-10-14 15:35:08.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-integration-5-scenario001-tempest-fedora-28 http://logs.rdoproject.org/13/688413/1/openstack-check-rdo/puppet-openstack-integration-5-scenario001-tempest-fedora-28/adfdc3b/ : SUCCESS in 37m 35s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-fedora-28 http://logs.rdoproject.org/13/688413/1/openstack-check-rdo/puppet-openstack-integration-5-scenario002-tempest-fedora-28/7ea4a70/ : SUCCESS in 43m 30s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-fedora-28 http://logs.rdoproject.org/13/688413/1/openstack-check-rdo/puppet-openstack-integration-5-scenario003-tempest-fedora-28/a870aa3/ : SUCCESS in 54m 37s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-fedora-28 http://logs.rdoproject.org/13/688413/1/openstack-check-rdo/puppet-openstack-integration-5-scenario004-tempest-fedora-28/7b334e9/ : FAILURE in 31m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a31474a5553fb20927b9ea282e388ac178cbf59e","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-14 16:43:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5f009a4f09f03c9710daf67372ae8f080a6c950d","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-14 16:57:22.000000000","message":"Patch Set 2:\n\n\u003e 1) What if system time has not been acquired (i.e. current time is near the UNIX epoch)?\n\nGood question, I don\u0027t know, then I think in this case it\u0027s the same situation there:\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/deployment/logrotate/logrotate-crond-container-puppet.yaml#L121\n\nOr maybe I missing something.\n\nDo you think to something particular there or have you identify specific situation here?\n\nHow to prevent this case?","accounts_in_message":[],"_revision_number":2},{"id":"5cf36133e4f638c0c326403ec36ea11edcb3e3dc","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-14 17:01:25.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"7d1c4243652412b6476089ca7998f2a61b5b98a9","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-10-14 17:50:06.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-integration-5-scenario001-tempest-fedora-28 http://logs.rdoproject.org/13/688413/3/openstack-check-rdo/puppet-openstack-integration-5-scenario001-tempest-fedora-28/2b11fd9/ : SUCCESS in 39m 15s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-fedora-28 http://logs.rdoproject.org/13/688413/3/openstack-check-rdo/puppet-openstack-integration-5-scenario002-tempest-fedora-28/5f29adf/ : SUCCESS in 47m 09s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-fedora-28 http://logs.rdoproject.org/13/688413/3/openstack-check-rdo/puppet-openstack-integration-5-scenario003-tempest-fedora-28/d6343b0/ : SUCCESS in 37m 58s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-fedora-28 http://logs.rdoproject.org/13/688413/3/openstack-check-rdo/puppet-openstack-integration-5-scenario004-tempest-fedora-28/8bf9b78/ : SUCCESS in 32m 34s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"12612de31e1aa6f6d4b12d470090a0be09d4720d","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2019-10-14 18:00:22.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)\n\n\u003e \u003e 1) What if system time has not been acquired (i.e. current time\n \u003e is near the UNIX epoch)?\n \u003e \n \u003e Good question, I don\u0027t know, then I think in this case it\u0027s the\n \u003e same situation there:\n \u003e \n \u003e https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/logrotate/logrotate-crond-container-puppet.yaml#L121\n \u003e \n \u003e Or maybe I missing something.\n \u003e \n \u003e Do you think to something particular there or have you identify\n \u003e specific situation here?\n \u003e \n \u003e How to prevent this case?\n\nSorry, you can ignore my original comment. I (incorrectly) was thinking lock files would be prematurely deleted if the cron job ran when the system time was earlier than the lock file access times. That\u0027s not what would happen. Sorry for the confusion!\n\n-1, though, because I think it maxdepth should be 1 (correct me if your tests indicate zero works).","accounts_in_message":[],"_revision_number":3},{"id":"62fac42b9b74ab433c23cc83ebd790f99bc9cc51","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-14 19:28:03.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0e25a079a8bd4d118d2885d6062607ac : FAILURE in 6m 50s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/fd860817b7d24397a4f3d36f6f9dd01f : SUCCESS in 4m 46s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8683acfa9af94b51a5a6dc77d08377fb : SUCCESS in 5m 38s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/a70aa545fd33409ea80f1e72faa31ba9 : SUCCESS in 16m 27s\n- puppet-openstack-unit-6.4-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/82f37967f1a240a3912c47933d0242da : SUCCESS in 13m 06s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/638f635f62cb4996bcb08f58e9e1a8ad : SUCCESS in 13m 34s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/b9889d4c868b4c729e1b69dc9c226a5b : FAILURE in 39m 15s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/b421ff66807a47859752e3928a3c53a1 : SUCCESS in 57m 47s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/04a1579ce2534a4691d4a2e1e62d297e : SUCCESS in 1h 26m 01s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/1426b981a6f440479fc37fba7f782483 : SUCCESS in 45m 28s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/b5290807a3934c12a9636464d8e00ea4 : FAILURE in 37m 06s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/96b49cb7b1194dc685f2ce7b5e0cd9fd : FAILURE in 38m 38s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/98b1f93e1f5e4e04a611798226e06932 : FAILURE in 22m 19s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/0d78c01281a54d90b22ad8f9de1a48c0 : FAILURE in 22m 07s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/ef755e8becad4993b6dcc6fd06c3731e : SUCCESS in 18m 30s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9c7cfeff881e4007a11626d9f2a9e436 : FAILURE in 12m 27s (non-voting)\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/628374f7bc114f9ba1f25503fd376882 : SUCCESS in 2h 20m 54s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"afd42c321576229ba25c554624601b125a0558a1","author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"date":"2019-10-15 06:53:58.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"738d2a3b242c596efdf01cd00d94f2077f6286eb","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-15 07:13:53.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"c556a0c46a3f19b376efb4f32f559fdc21556789","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-15 07:16:05.000000000","message":"Patch Set 3:\n\n\u003e (1 comment)\n \u003e \n \u003e \u003e \u003e 1) What if system time has not been acquired (i.e. current time\n \u003e \u003e is near the UNIX epoch)?\n \u003e \u003e\n \u003e \u003e Good question, I don\u0027t know, then I think in this case it\u0027s the\n \u003e \u003e same situation there:\n \u003e \u003e\n \u003e \u003e https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/logrotate/logrotate-crond-container-puppet.yaml#L121\n \u003e \u003e\n \u003e \u003e Or maybe I missing something.\n \u003e \u003e\n \u003e \u003e Do you think to something particular there or have you identify\n \u003e \u003e specific situation here?\n \u003e \u003e\n \u003e \u003e How to prevent this case?\n \u003e \n \u003e Sorry, you can ignore my original comment. I (incorrectly) was\n \u003e thinking lock files would be prematurely deleted if the cron job\n \u003e ran when the system time was earlier than the lock file access\n \u003e times. That\u0027s not what would happen. Sorry for the confusion!\n \u003e \n \u003e -1, though, because I think it maxdepth should be 1 (correct me if\n \u003e your tests indicate zero works).\n\nYou are right we need to use `-maxdepth 1`. \nAlso -maxdepth is need to be specified before -iname","accounts_in_message":[],"_revision_number":3},{"id":"1e58bc0384c56b279e2505dc31850f13b644287c","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2019-10-15 07:18:12.000000000","message":"Patch Set 4: Code-Review-1\n\nI\u0027ve heard that the only safe way, unless this is solved in Cinder (or IIRC a third party library that causes this), is to stop cinder-volume, remove the locks and start it again.\n\nTherefore we\u0027ve always had this as a repetitive task, I don\u0027t think we should merge this unless we get absolute confirmation that this is a safe thing to do.","accounts_in_message":[],"_revision_number":4},{"id":"a181be4cf636c21888f8ffb8c3cc68d121071f22","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2019-10-15 07:21:56.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"48d8518cb07c325f4a76510e6d0afa23cc870f7f","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-15 07:23:49.000000000","message":"Patch Set 4:\n\n\u003e I\u0027ve heard that the only safe way, unless this is solved in Cinder\n \u003e (or IIRC a third party library that causes this), is to stop\n \u003e cinder-volume, remove the locks and start it again.\n \u003e \n \u003e Therefore we\u0027ve always had this as a repetitive task, I don\u0027t think\n \u003e we should merge this unless we get absolute confirmation that this\n \u003e is a safe thing to do.\n\nIt make sense. we need to be sure that it\u0027s safe before merging this. I asked some reviews/checks to Gorka and Eric from Cinder team to confirm that everything seems ok.Make sense, we need to be sure that it\u0027s safe before, I asked some reviews/checks to Gorka and Eric from Cinder team to confirm that everything seems ok.","accounts_in_message":[],"_revision_number":4},{"id":"ecc18e2a753c43ece94b46ddf575a1714dca47db","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-15 07:28:04.000000000","message":"Patch Set 4:\n\n\u003e I\u0027ve heard that the only safe way, unless this is solved in Cinder\n \u003e (or IIRC a third party library that causes this), is to stop\n \u003e cinder-volume, remove the locks and start it again.\n\nYeah, you are right this is a `fasteners` issue (cf. the commit message).","accounts_in_message":[],"_revision_number":4},{"id":"1ae24ebb94b652d3c99dbe7b2a186794f1ff4e8e","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-10-15 08:01:15.000000000","message":"Patch Set 4:\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-integration-5-scenario001-tempest-fedora-28 http://logs.rdoproject.org/13/688413/4/openstack-check-rdo/puppet-openstack-integration-5-scenario001-tempest-fedora-28/5c3f25e/ : SUCCESS in 39m 16s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-fedora-28 http://logs.rdoproject.org/13/688413/4/openstack-check-rdo/puppet-openstack-integration-5-scenario002-tempest-fedora-28/2f01c21/ : SUCCESS in 40m 18s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-fedora-28 http://logs.rdoproject.org/13/688413/4/openstack-check-rdo/puppet-openstack-integration-5-scenario003-tempest-fedora-28/326e967/ : SUCCESS in 45m 39s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-fedora-28 http://logs.rdoproject.org/13/688413/4/openstack-check-rdo/puppet-openstack-integration-5-scenario004-tempest-fedora-28/a285492/ : SUCCESS in 34m 49s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"dea45fb1e1296dbb92c0a9e3a4f46e941eb80d92","author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"date":"2019-10-15 08:20:15.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"fbe5dc1749aa1811915dfb3b0deab7ff8e2e39fa","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-10-15 09:08:16.000000000","message":"Patch Set 5:\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-integration-5-scenario001-tempest-fedora-28 http://logs.rdoproject.org/13/688413/5/openstack-check-rdo/puppet-openstack-integration-5-scenario001-tempest-fedora-28/51082cf/ : SUCCESS in 41m 58s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-fedora-28 http://logs.rdoproject.org/13/688413/5/openstack-check-rdo/puppet-openstack-integration-5-scenario002-tempest-fedora-28/13e60c4/ : SUCCESS in 44m 12s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-fedora-28 http://logs.rdoproject.org/13/688413/5/openstack-check-rdo/puppet-openstack-integration-5-scenario003-tempest-fedora-28/5b41e1c/ : FAILURE in 45m 45s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-fedora-28 http://logs.rdoproject.org/13/688413/5/openstack-check-rdo/puppet-openstack-integration-5-scenario004-tempest-fedora-28/a382ef1/ : SUCCESS in 34m 49s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"1e5cb7d1d13f6d5a7e05914d26df7dd5c500ea8f","author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"date":"2019-10-15 09:11:49.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"cc3aa88db758e27cdf68f026ef901be1828469a5","author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"date":"2019-10-15 09:38:56.000000000","message":"Patch Set 6:\n\nThe following tests are passing:\n1 creating files in the /var/lib/cinder with fake date (touch -t ...)\n2 creating files in that location with a non-matching patter and fake date\n3 creating files in a subdirectory in that location with matching pattern\n\n1: only files older than 7 days are removed, as expected. Newer are kept\n2: none of those files got removed\n3: non of those files are removed thanks to the -maxdepth\n\nNow we need to get Cinder Team feedback in order to ensure it doesn\u0027t break the service.","accounts_in_message":[],"_revision_number":6},{"id":"73596b16c0c5393c583cb423cd74ef694c8fe69c","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-10-15 09:54:13.000000000","message":"Patch Set 6:\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-integration-5-scenario001-tempest-fedora-28 http://logs.rdoproject.org/13/688413/6/openstack-check-rdo/puppet-openstack-integration-5-scenario001-tempest-fedora-28/d2c4f6b/ : SUCCESS in 37m 52s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-fedora-28 http://logs.rdoproject.org/13/688413/6/openstack-check-rdo/puppet-openstack-integration-5-scenario002-tempest-fedora-28/a7805d4/ : SUCCESS in 40m 15s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-fedora-28 http://logs.rdoproject.org/13/688413/6/openstack-check-rdo/puppet-openstack-integration-5-scenario003-tempest-fedora-28/85b3d16/ : SUCCESS in 39m 56s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-fedora-28 http://logs.rdoproject.org/13/688413/6/openstack-check-rdo/puppet-openstack-integration-5-scenario004-tempest-fedora-28/97b9325/ : SUCCESS in 31m 25s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"1fe8fa3457e18049d6b787012522877d5d795248","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-15 11:29:00.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/81fe9bb054d245778b07fba9f82d1904 : SUCCESS in 4m 47s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1824dbfea597482a90860cf0d8142b3f : SUCCESS in 4m 30s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c78b96a95c4641b79bc1196ba5aaf9c9 : SUCCESS in 4m 29s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/7292132f95bb4b74b905f827d393d14f : SUCCESS in 22m 41s\n- puppet-openstack-unit-6.4-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/a9abb41e50f94977b2cd05a3a58177b9 : SUCCESS in 15m 54s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1fcf9fc80a3942e3ba9dc20964f84e05 : SUCCESS in 16m 09s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/155e82d2496e47e5b4030385cee8d3e3 : SUCCESS in 55m 07s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/4408761a8ddd42e59f7ed1994c92a391 : SUCCESS in 56m 41s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/fb6da3bcb4654ff7a5551280ec5c786a : SUCCESS in 1h 07m 54s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/20b427b944704926a48d9818df47d5bf : SUCCESS in 47m 03s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/85e455b950d24203a1551900af0edf00 : FAILURE in 29m 02s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/543d038626654bd1b9c54ef9c1719df9 : FAILURE in 33m 51s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ff4d49a14a6944d0b7d24d9ec7cc1616 : FAILURE in 20m 20s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/dfd41e3c5a9849b8b9b292f12a439733 : FAILURE in 23m 12s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/2bd55e0d9ec145a8889f93feb18d207c : SUCCESS in 17m 43s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/39900b3ac3ac47aab1c73476ce5dfb1a : FAILURE in 9m 56s (non-voting)\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/33b0b78083104242b19dfdac3d7dafc4 : SUCCESS in 2h 09m 33s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"3aa4aacb504324cc44b6fc30b926b0ba032a6527","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2019-10-15 12:22:42.000000000","message":"Patch Set 6:\n\nIt\u0027s more than one lock file right? In our setup I can see there  is:\n\n* cinder-f1c670e3-6a47-45a2-8e9a-a9316f11bc0f\n* cinder-f1c670e3-6a47-45a2-8e9a-a9316f11bc0f-delete_volume\n* cinder-f1c670e3-6a47-45a2-8e9a-a9316f11bc0f-detach_volume\n\nThis only cleans up the \"delete_volume\" one.","accounts_in_message":[],"_revision_number":6},{"id":"ceb4ac19f9129cb6100b29b4d2e95d5d674188f4","author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"date":"2019-10-15 12:29:45.000000000","message":"Patch Set 6:\n\n\u003e It\u0027s more than one lock file right? In our setup I can see there \n \u003e is:\n \u003e \n \u003e * cinder-f1c670e3-6a47-45a2-8e9a-a9316f11bc0f\n \u003e * cinder-f1c670e3-6a47-45a2-8e9a-a9316f11bc0f-delete_volume\n \u003e * cinder-f1c670e3-6a47-45a2-8e9a-a9316f11bc0f-detach_volume\n \u003e \n \u003e This only cleans up the \"delete_volume\" one.\n\napparently only the volume deletion locks are creating problems. Would be good to ensure that. And also get some Cinder Dev feedback as to \"is it OK to drop locks like that\" :).","accounts_in_message":[],"_revision_number":6},{"id":"b61223de57377eca41a4bcd8449b8033ff7e403d","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-15 12:34:03.000000000","message":"Patch Set 6:\n\n\u003e It\u0027s more than one lock file right? In our setup I can see there \n \u003e is:\n \u003e \n \u003e * cinder-f1c670e3-6a47-45a2-8e9a-a9316f11bc0f\n \u003e * cinder-f1c670e3-6a47-45a2-8e9a-a9316f11bc0f-delete_volume\n \u003e * cinder-f1c670e3-6a47-45a2-8e9a-a9316f11bc0f-detach_volume\n \u003e \n \u003e This only cleans up the \"delete_volume\" one.\n\nI know that `delete-volume` is an issue but I\u0027m not sure for others files, I asked to the cinder to do some reviews there and confirm that everything is fine here.\n\nAnyway it\u0027s not an issue if we need to integrate these other files pattern in a second time.","accounts_in_message":[],"_revision_number":6},{"id":"efc68c3cb683420c148665c6a4a309456f7482e7","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2019-10-15 13:06:27.000000000","message":"Patch Set 6: Code-Review-1\n\nForgot to vote, also missing testing and release note upon the questions I\u0027ve raised already.","accounts_in_message":[],"_revision_number":6},{"id":"e05f75209af4f19bd0f970a3d702b33fec7219dc","author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"date":"2019-10-15 13:09:31.000000000","message":"Patch Set 6:\n\n\u003e Forgot to vote, also missing testing and release note upon the\n \u003e questions I\u0027ve raised already.\n\nregarding unit tests, I\u0027d rather ensure the proposed solution is OK before making them ;).","accounts_in_message":[],"_revision_number":6},{"id":"d335dfd6b8f6a2fcdfd92de22252315e9a3e9aca","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2019-10-15 14:52:10.000000000","message":"Patch Set 6: Code-Review-1\n\nI replied with a longer discussion on the mailing list, but I don\u0027t think we should do this. I don\u0027t want to encourage people to start deleting lock files while a service is running (I don\u0027t even know if the assumption that a -delete lock file is no longer needed after 7 days is valid - we need a cinder person to verify that) and deleting just one of the types of lock file used by cinder isn\u0027t going to eliminate the problem.\n\nI left some suggestions on other things we could do to mitigate this in http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010133.html","accounts_in_message":[],"_revision_number":6},{"id":"29a372959dde5cc2147abc8cf9b38eae6dbcba8a","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-15 15:03:01.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"65e2342e9f0ba142991b3f4a86a21a839b11e5d7","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-10-15 16:04:34.000000000","message":"Patch Set 7:\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-integration-5-scenario001-tempest-fedora-28 http://logs.rdoproject.org/13/688413/7/openstack-check-rdo/puppet-openstack-integration-5-scenario001-tempest-fedora-28/f247cd7/ : SUCCESS in 44m 01s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-fedora-28 http://logs.rdoproject.org/13/688413/7/openstack-check-rdo/puppet-openstack-integration-5-scenario002-tempest-fedora-28/e57291e/ : SUCCESS in 59m 01s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-fedora-28 http://logs.rdoproject.org/13/688413/7/openstack-check-rdo/puppet-openstack-integration-5-scenario003-tempest-fedora-28/b2dbf56/ : SUCCESS in 59m 04s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-fedora-28 http://logs.rdoproject.org/13/688413/7/openstack-check-rdo/puppet-openstack-integration-5-scenario004-tempest-fedora-28/e2d1423/ : SUCCESS in 37m 25s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"c261b6ef90296d9f2e7df880e096b4535870b7e7","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-10-15 17:28:41.000000000","message":"Patch Set 7:\n\nIt is not a safe assumption that *-delete_volume file locks can be removed just because they have not been used in a couple of days.  A new volume clone could come in that would use it and then we could have a race condition if the cron job was running.\n\nThe only way to be sure that it can be removed is checking in the Cinder DB and making sure that the volume has been deleted or it doesn\u0027t even exist (DB has been purged).\n\nSame thing with detach_volume, delete_snapshot, and those that are directly volume ids locks.\n\nIn my opinion the fix should be done in fasteners, or we should add code in Cinder that cleans up all locks related to a volume or snapshot when this one is deleted.","accounts_in_message":[],"_revision_number":7},{"id":"ed9aec0b4ac5246e7df8bf1153336b282068912c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-15 17:33:07.000000000","message":"Patch Set 7: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/4de1d975fd6a47f6a7bc15acff3c54c1 : FAILURE in 4m 16s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e652d56af93446eebdbf1eb33672bf5e : SUCCESS in 3m 48s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/7746581ea8624bbeb08d698a58901587 : SUCCESS in 4m 24s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/42887a6997ab4131b9f913a6206ac797 : SUCCESS in 25m 49s\n- puppet-openstack-unit-6.4-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0a483ac56a834935b0f9fcf1dfb9eb59 : SUCCESS in 16m 16s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/875ffb35d81a4bee80d34aa74e1a0f88 : SUCCESS in 19m 26s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/2daac15cf1674310b3cd6c0ab3b4495d : SUCCESS in 58m 47s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/0b2dd362cd4e40d9bb36ab338417719d : SUCCESS in 1h 11m 26s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/e91d44933f814762a81c6ce1f6647bcd : SUCCESS in 1h 30m 24s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/aa7fb3a2e2a84558948b8b36f59edc3d : SUCCESS in 45m 46s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/a5d38ce7eaee4f3292dc830588d272ab : FAILURE in 31m 48s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b5df4042b6074f87a866ecf02500b72f : FAILURE in 31m 14s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/31eb4ea3f78b430d879d2833e3dcc467 : FAILURE in 20m 31s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/4ee80e2826444c6da0efc751b0d063f4 : FAILURE in 32m 25s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/b0b826c17d9f4a78953b9b7c9f3d1868 : SUCCESS in 20m 01s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0cc1eeeb7a2c4a898541c8a5b63900d5 : FAILURE in 9m 07s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/46b8d6bfb1864c70844da1f0578611e4 : SUCCESS in 3m 00s\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/212f94c384ff42c4a9c1342b6c17bff8 : SUCCESS in 2h 20m 23s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"9e65ad7c83b32ba87458c19b185eb7bf1028cbf2","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-17 09:14:14.000000000","message":"Patch Set 7: Workflow-1\n\nThanks Gorka for your feedback, then in view of all the discussions about this topic I suppose only Cinder can really address it safely on stable branches.\n\n \u003e It is not a safe assumption that *-delete_volume file locks can be\n \u003e removed just because they have not been used in a couple of days. \n \u003e A new volume clone could come in that would use it and then we\n \u003e could have a race condition if the cron job was running.\n \u003e \n \u003e The only way to be sure that it can be removed is checking in the\n \u003e Cinder DB and making sure that the volume has been deleted or it\n \u003e doesn\u0027t even exist (DB has been purged).\n \u003e \n \u003e Same thing with detach_volume, delete_snapshot, and those that are\n \u003e directly volume ids locks.\n\nI definitely think that it can\u0027t be fixed in the underlying libraries like Eric has suggested [1], indeed, as you has explained only Cinder can know if a lock file can be removed safely.\n\n \u003e In my opinion the fix should be done in fasteners, or we should add\n \u003e code in Cinder that cleans up all locks related to a volume or\n \u003e snapshot when this one is deleted.\n\nI agree the most better solution is to fix the root cause and so to fix fasteners, but I don\u0027t think it\u0027s can be backported to stable branches because we will need to bump a requirement version on stable branche in this case and also because it\u0027ll introduce new features, so I guess Cinder need to add some code to remove these files and possibly backport it to stable branches. \n\n[1] http://lists.openstack.org/pipermail/openstack-discuss/2019-September/009563.html","accounts_in_message":[],"_revision_number":7},{"id":"27a105ac537dfa8d1ed2671bb00aebd411fdf198","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-04-22 16:33:57.000000000","message":"Abandoned\n\nThese changes are no longer needed due to previous discussions on the ML.","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"57d0d39476cdb8386802edbb7dc1dc13569b1547","revisions":{"018d9cec8638c6eb4782fb91bdc47a5016b00969":{"kind":"REWORK","_number":1,"created":"2019-10-14 14:38:54.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/13/688413/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/13/688413/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/1"}}},"commit":{"parents":[{"commit":"235fe651dd08cbd631aaa89d59c26cace1f1b057","subject":"Change default value for keymgr_backend to default","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/235fe651dd08cbd631aaa89d59c26cace1f1b057"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-10-14 13:59:40.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-10-14 14:34:00.000000000","tz":120},"subject":"Ensure to remove cinder\u0027s outdated leftover lock files","message":"Ensure to remove cinder\u0027s outdated leftover lock files\n\nCinder to manage locks use fasteners, the fasteners module have a bug\nand it doesn\u0027t remove some lock files automatically after usage [1]\n\nCustomer file system growing slowly and so customer risk to facing some\nissues to file system usage after a long period.\n\nA fix was proposed to fasteners but it\u0027s not merged yet.This fix\npropose to switch from locks management based on files to locks\nmanaged through a unique file where locks will be managed by file offset.\nIt will introduce some design changes which can\u0027t be backported to\nstable branches.\n\nThis patch propose to introduce a new cron job to remove these lock files.\nHence, we could fix this issue on stable branches too.\n\nThe added cron job will remove all the lock files last accessed after 7\ndays to avoid to remove used lock files.\n\nThe lifetime is not configurable. We want to avoid lets user to\nconfigure a lifetime to short and so possibly introduce some race\nconditions with cinder.\n\nWhen the root cause will be fixed through the fasteners patch we can\nthen remove this cron job safely.\n\n[1] https://github.com/harlowja/fasteners/issues/26\n\nChange-Id: If33825a3dae0dfd53e058d1d8277cee4a0423ea1\nCo-authored-by: Cédric Jeanneret \u003ccjeanner@redhat.com\u003e\nPartial-Bug: #1432387\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/018d9cec8638c6eb4782fb91bdc47a5016b00969"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/018d9cec8638c6eb4782fb91bdc47a5016b00969"}]},"branch":"refs/heads/master"},"59dcca15c42d6755ff88b104da03f56cfb0f2e72":{"kind":"REWORK","_number":2,"created":"2019-10-14 16:43:34.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/13/688413/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/13/688413/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/2"}}},"commit":{"parents":[{"commit":"235fe651dd08cbd631aaa89d59c26cace1f1b057","subject":"Change default value for keymgr_backend to default","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/235fe651dd08cbd631aaa89d59c26cace1f1b057"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-10-14 13:59:40.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-10-14 16:43:25.000000000","tz":120},"subject":"Ensure to remove cinder\u0027s outdated leftover lock files after a volume deletion","message":"Ensure to remove cinder\u0027s outdated leftover lock files after a volume deletion\n\nIndeed, after a volume deletion lock files are left behind. Cinder to manage\nlocks use fasteners, the fasteners module have a bug and it doesn\u0027t remove\nsome lock files automatically after usage [1]\n\nCustomer file system growing slowly and so customer risk to facing some\nissues to file system usage after a long period.\n\nA fix was proposed to fasteners but it\u0027s not merged yet.This fix\npropose to switch from locks management based on files to locks\nmanaged through a unique file where locks will be managed by file offset.\nIt will introduce some design changes which can\u0027t be backported to\nstable branches.\n\nThis patch propose to introduce a new cron job to remove these lock files.\nHence, we could fix this issue on stable branches too.\n\nThe added cron job will remove all the lock files last accessed after 7\ndays to avoid to remove used lock files.\n\nThe lifetime is configurable here, but we don\u0027t want to expose it at a higher\nlevel, indeed, we want to avoid to lets user to configure a lifetime to short\nand so possibly introduce some race conditions with cinder.\n\nWhen the root cause will be fixed through the fasteners patch we can\nthen remove this cron job safely.\n\n[1] https://github.com/harlowja/fasteners/issues/26\n\nChange-Id: If33825a3dae0dfd53e058d1d8277cee4a0423ea1\nCo-authored-by: Cédric Jeanneret \u003ccjeanner@redhat.com\u003e\nPartial-Bug: #1432387\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/59dcca15c42d6755ff88b104da03f56cfb0f2e72"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/59dcca15c42d6755ff88b104da03f56cfb0f2e72"}]},"branch":"refs/heads/master"},"32423741b068908f8e8fc3030da4b984d4149649":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2019-10-14 17:01:25.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/13/688413/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/13/688413/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/3"}}},"commit":{"parents":[{"commit":"235fe651dd08cbd631aaa89d59c26cace1f1b057","subject":"Change default value for keymgr_backend to default","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/235fe651dd08cbd631aaa89d59c26cace1f1b057"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-10-14 13:59:40.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-10-14 17:01:02.000000000","tz":120},"subject":"Ensure to remove cinder\u0027s outdated lock files left behind by a volume deletion.","message":"Ensure to remove cinder\u0027s outdated lock files left behind by a volume deletion.\n\nIndeed, after a volume deletion lock files are left behind. Cinder to manage\nlocks use fasteners, the fasteners module have a bug and it doesn\u0027t remove\nsome lock files automatically after usage [1]\n\nCustomer file system growing slowly and so customer risk to facing some\nissues to file system usage after a long period.\n\nA fix was proposed to fasteners but it\u0027s not merged yet.This fix\npropose to switch from locks management based on files to locks\nmanaged through a unique file where locks will be managed by file offset.\nIt will introduce some design changes which can\u0027t be backported to\nstable branches.\n\nThis patch propose to introduce a new cron job to remove these lock files.\nHence, we could fix this issue on stable branches too.\n\nThe added cron job will remove all the lock files last accessed after 7\ndays to avoid to remove used lock files.\n\nThe lifetime is configurable here, but we don\u0027t want to expose it at a higher\nlevel, indeed, we want to avoid to lets user to configure a lifetime to short\nand so possibly introduce some race conditions with cinder.\n\nWhen the root cause will be fixed through the fasteners patch we can\nthen remove this cron job safely.\n\n[1] https://github.com/harlowja/fasteners/issues/26\n\nChange-Id: If33825a3dae0dfd53e058d1d8277cee4a0423ea1\nCo-authored-by: Cédric Jeanneret \u003ccjeanner@redhat.com\u003e\nPartial-Bug: #1432387\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/32423741b068908f8e8fc3030da4b984d4149649"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/32423741b068908f8e8fc3030da4b984d4149649"}]},"branch":"refs/heads/master"},"6d0c35560fc11d25cc9e8232697d98604d312aab":{"kind":"REWORK","_number":4,"created":"2019-10-15 07:13:53.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/13/688413/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/13/688413/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/4"}}},"commit":{"parents":[{"commit":"235fe651dd08cbd631aaa89d59c26cace1f1b057","subject":"Change default value for keymgr_backend to default","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/235fe651dd08cbd631aaa89d59c26cace1f1b057"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-10-14 13:59:40.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-10-15 07:13:36.000000000","tz":120},"subject":"Ensure to remove cinder\u0027s outdated lock files left behind by a volume deletion.","message":"Ensure to remove cinder\u0027s outdated lock files left behind by a volume deletion.\n\nIndeed, after a volume deletion lock files are left behind. Cinder to manage\nlocks use fasteners, the fasteners module have a bug and it doesn\u0027t remove\nsome lock files automatically after usage [1]\n\nCustomer file system growing slowly and so customer risk to facing some\nissues to file system usage after a long period.\n\nA fix was proposed to fasteners but it\u0027s not merged yet.This fix\npropose to switch from locks management based on files to locks\nmanaged through a unique file where locks will be managed by file offset.\nIt will introduce some design changes which can\u0027t be backported to\nstable branches.\n\nThis patch propose to introduce a new cron job to remove these lock files.\nHence, we could fix this issue on stable branches too.\n\nThe added cron job will remove all the lock files last accessed after 7\ndays to avoid to remove used lock files.\n\nThe lifetime is configurable here, but we don\u0027t want to expose it at a higher\nlevel, indeed, we want to avoid to lets user to configure a lifetime to short\nand so possibly introduce some race conditions with cinder.\n\nWhen the root cause will be fixed through the fasteners patch we can\nthen remove this cron job safely.\n\n[1] https://github.com/harlowja/fasteners/issues/26\n\nChange-Id: If33825a3dae0dfd53e058d1d8277cee4a0423ea1\nCo-authored-by: Cédric Jeanneret \u003ccjeanner@redhat.com\u003e\nPartial-Bug: #1432387\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/6d0c35560fc11d25cc9e8232697d98604d312aab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/6d0c35560fc11d25cc9e8232697d98604d312aab"}]},"branch":"refs/heads/master"},"ca7ab1967572bf7c7e93bba4e843afedd1739250":{"kind":"REWORK","_number":5,"created":"2019-10-15 08:20:15.000000000","uploader":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"ref":"refs/changes/13/688413/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/13/688413/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/5"}}},"commit":{"parents":[{"commit":"235fe651dd08cbd631aaa89d59c26cace1f1b057","subject":"Change default value for keymgr_backend to default","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/235fe651dd08cbd631aaa89d59c26cace1f1b057"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-10-14 13:59:40.000000000","tz":120},"committer":{"name":"Cédric Jeanneret","email":"cjeanner@redhat.com","date":"2019-10-15 08:20:13.000000000","tz":120},"subject":"Ensure to remove cinder\u0027s outdated lock files left behind by a volume deletion.","message":"Ensure to remove cinder\u0027s outdated lock files left behind by a volume deletion.\n\nIndeed, after a volume deletion lock files are left behind. Cinder to manage\nlocks use fasteners, the fasteners module have a bug and it doesn\u0027t remove\nsome lock files automatically after usage [1]\n\nCustomer file system growing slowly and so customer risk to facing some\nissues to file system usage after a long period.\n\nA fix was proposed to fasteners but it\u0027s not merged yet.This fix\npropose to switch from locks management based on files to locks\nmanaged through a unique file where locks will be managed by file offset.\nIt will introduce some design changes which can\u0027t be backported to\nstable branches.\n\nThis patch propose to introduce a new cron job to remove these lock files.\nHence, we could fix this issue on stable branches too.\n\nThe added cron job will remove all the lock files last accessed after 7\ndays to avoid to remove used lock files.\n\nThe lifetime is configurable here, but we don\u0027t want to expose it at a higher\nlevel, indeed, we want to avoid to lets user to configure a lifetime to short\nand so possibly introduce some race conditions with cinder.\n\nWhen the root cause will be fixed through the fasteners patch we can\nthen remove this cron job safely.\n\n[1] https://github.com/harlowja/fasteners/issues/26\n\nChange-Id: If33825a3dae0dfd53e058d1d8277cee4a0423ea1\nCo-authored-by: Cédric Jeanneret \u003ccjeanner@redhat.com\u003e\nPartial-Bug: #1432387\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/ca7ab1967572bf7c7e93bba4e843afedd1739250"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/ca7ab1967572bf7c7e93bba4e843afedd1739250"}]},"branch":"refs/heads/master"},"5353856ede0d1e195ff306a5d9a65418d7170ba1":{"kind":"REWORK","_number":6,"created":"2019-10-15 09:11:49.000000000","uploader":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"ref":"refs/changes/13/688413/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/13/688413/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/6"}}},"commit":{"parents":[{"commit":"235fe651dd08cbd631aaa89d59c26cace1f1b057","subject":"Change default value for keymgr_backend to default","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/235fe651dd08cbd631aaa89d59c26cace1f1b057"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-10-14 13:59:40.000000000","tz":120},"committer":{"name":"Cédric Jeanneret","email":"cjeanner@redhat.com","date":"2019-10-15 09:11:38.000000000","tz":120},"subject":"Ensure to remove cinder\u0027s outdated lock files left behind by a volume deletion.","message":"Ensure to remove cinder\u0027s outdated lock files left behind by a volume deletion.\n\nIndeed, after a volume deletion lock files are left behind. Cinder to manage\nlocks use fasteners, the fasteners module have a bug and it doesn\u0027t remove\nsome lock files automatically after usage [1]\n\nCustomer file system growing slowly and so customer risk to facing some\nissues to file system usage after a long period.\n\nA fix was proposed to fasteners but it\u0027s not merged yet.This fix\npropose to switch from locks management based on files to locks\nmanaged through a unique file where locks will be managed by file offset.\nIt will introduce some design changes which can\u0027t be backported to\nstable branches.\n\nThis patch propose to introduce a new cron job to remove these lock files.\nHence, we could fix this issue on stable branches too.\n\nThe added cron job will remove all the lock files last accessed after 7\ndays to avoid to remove used lock files.\n\nThe lifetime is configurable here, but we don\u0027t want to expose it at a higher\nlevel, indeed, we want to avoid to lets user to configure a lifetime to short\nand so possibly introduce some race conditions with cinder.\n\nWhen the root cause will be fixed through the fasteners patch we can\nthen remove this cron job safely.\n\n[1] https://github.com/harlowja/fasteners/issues/26\n\nChange-Id: If33825a3dae0dfd53e058d1d8277cee4a0423ea1\nCo-authored-by: Cédric Jeanneret \u003ccjeanner@redhat.com\u003e\nPartial-Bug: #1432387\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/5353856ede0d1e195ff306a5d9a65418d7170ba1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/5353856ede0d1e195ff306a5d9a65418d7170ba1"}]},"branch":"refs/heads/master"},"57d0d39476cdb8386802edbb7dc1dc13569b1547":{"kind":"REWORK","_number":7,"created":"2019-10-15 15:03:01.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/13/688413/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/13/688413/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/13/688413/7"}}},"commit":{"parents":[{"commit":"235fe651dd08cbd631aaa89d59c26cace1f1b057","subject":"Change default value for keymgr_backend to default","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/235fe651dd08cbd631aaa89d59c26cace1f1b057"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-10-14 13:59:40.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-10-15 15:01:34.000000000","tz":120},"subject":"Ensure to remove cinder\u0027s outdated lock files left behind by a volume deletion.","message":"Ensure to remove cinder\u0027s outdated lock files left behind by a volume deletion.\n\nIndeed, after a volume deletion lock files are left behind. Cinder to manage\nlocks use fasteners, the fasteners module have a bug and it doesn\u0027t remove\nsome lock files automatically after usage [1]\n\nCustomer file system growing slowly and so customer risk to facing some\nissues to file system usage after a long period.\n\nA fix was proposed to fasteners but it\u0027s not merged yet.This fix\npropose to switch from locks management based on files to locks\nmanaged through a unique file where locks will be managed by file offset.\nIt will introduce some design changes which can\u0027t be backported to\nstable branches.\n\nThis patch propose to introduce a new cron job to remove these lock files.\nHence, we could fix this issue on stable branches too.\n\nThe added cron job will remove all the lock files last accessed after 7\ndays to avoid to remove used lock files.\n\nThe lifetime is configurable here, but we don\u0027t want to expose it at a higher\nlevel, indeed, we want to avoid to lets user to configure a lifetime to short\nand so possibly introduce some race conditions with cinder.\n\nWhen the root cause will be fixed through the fasteners patch we can\nthen remove this cron job safely.\n\n[1] https://github.com/harlowja/fasteners/issues/26\n\nChange-Id: If33825a3dae0dfd53e058d1d8277cee4a0423ea1\nCo-authored-by: Cédric Jeanneret \u003ccjeanner@redhat.com\u003e\nPartial-Bug: #1432387\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/57d0d39476cdb8386802edbb7dc1dc13569b1547"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/57d0d39476cdb8386802edbb7dc1dc13569b1547"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}